@bacnh85/pi-advisor 0.2.3 → 0.2.4

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## 0.2.4 (2026-09-12)
+
+### Removed
+
+- Dead `AdvisorState.getThinking` knob (sole impl returned `undefined`; the
+  value flowed nowhere meaningful).
+
+### Fixed
+
+- `saveModels` / `migrateLegacyAdvisorModel` no longer leave a `*.tmp-*` file
+  behind when the final rename throws (best-effort unlink, error re-thrown).
+
+### Documentation
+
+- README: added `/advisor watch-off` to the command list.
+
 ## 0.2.3 (2026-09-11)
 
 - **Fix 20–30s+ TUI freeze after every settled turn**: pi core awaits

package/README.md

@@ -14,10 +14,10 @@ consult tool. Inspired by the advisor subsystem in
     turn during the post-steer calm-down window. The severity sets the note's
     authority wording (“nit — consider” vs “concern — address this” vs
     “blocker — fix before continuing”).
-  - Post-steer cooldown: after a note steers, non-blocker notes within the
-    next `immuneTurns` settled turns are deferred (LLM-visible next turn)
-    instead of waking the agent again — bounds ping-pong. Blockers always
-    steer immediately.
+  - Post-steer cooldown: after a note steers, nit notes within the next
+    `immuneTurns` settled turns are deferred (LLM-visible next turn)
+    instead of waking the agent again — bounds ping-pong. Concerns and
+    blockers always steer immediately.
 - **Emission guard** (noise control): content-free phrases ("lgtm", "done", …)
   are dropped, identical notes are deduped (severity escalation still passes),
   and at most one note is delivered per review cycle.
@@ -47,6 +47,7 @@ npm install -g @bacnh85/pi-advisor
 /advisor models             # edit the full model chain (TUI panel; non-TUI prints it)
 /advisor status             # model chain, watch state, counters
 /advisor on                 # enable watch for this session (also clears a pause)
+/advisor watch-off          # disable background watch for this session
 /advisor off                # clear the chain (disables tool + watch)
 ```
 

package/extensions/commands/advisor.ts

@@ -19,7 +19,6 @@ export function parseChainArgument(raw: string): string[] {
 export interface AdvisorState {
   getModels(): string[];
   setModels(models: string[]): Promise<void> | void;
-  getThinking(): string | undefined;
   getRuntime(): WatcherRuntime | undefined;
   isWatchEnabled(): boolean;
   setWatchEnabled(value: boolean): void;
@@ -100,7 +99,6 @@ export function registerAdvisor(pi: ExtensionAPI, state: AdvisorState): void {
       const transcriptEvidence = buildEvidence(ctx, models, transcript.messages, SYSTEM);
       const chain = models.join(" → ");
       onUpdate?.({ content: [{ type: "text", text: `Consulting ${chain}…` }], details: { models } });
-      const reasoning = state.getThinking();
       // Progressive display resets per attempt: a candidate that dies mid-stream
       // must not leave its partial output above the next candidate's response.
       let output = "";
@@ -116,7 +114,7 @@ export function registerAdvisor(pi: ExtensionAPI, state: AdvisorState): void {
         if (forAttempt !== attempt) { attempt = forAttempt; output = ""; }
         output += delta;
         onUpdate?.({ content: [{ type: "text", text: output }], details: { models } });
-      }, signal, reasoning);
+      }, signal);
       return {
         content: [{ type: "text", text: `Advice from ${result.model}:\n${result.text}` }],
         details: { models, served: result.model },

package/extensions/index.ts

@@ -94,10 +94,6 @@ export default function piAdvisor(pi: ExtensionAPI): void {
       if (legacy) {
         models = [legacy];
         ctx.ui.notify(`Advisor model migrated from pi-plan: ${legacy}`, "info");
-        // If we migrated on top of a pi-plan that had legacyMigrated:true already,
-        // the user config may still lack migrationVersion. Backfill it idempotently
-        // so no future manual patch is needed (code writes, agent never touches
-        // the real global config directly).
       }
     }
     runtime = createRuntime(config, models);
@@ -151,7 +147,6 @@ export default function piAdvisor(pi: ExtensionAPI): void {
       await saveModels(models);
       if (runtime) runtime.models = models;
     },
-    getThinking: () => undefined,
     getRuntime: () => runtime,
     isWatchEnabled: () => watchEnabled,
     setWatchEnabled: (value) => {

package/extensions/lib/config.ts

@@ -1,4 +1,4 @@
-import { readFile, writeFile, mkdir, rename } from "node:fs/promises";
+import { readFile, writeFile, mkdir, rename, unlink } from "node:fs/promises";
 import os from "node:os";
 import path from "node:path";
 import { CONFIG_DIR_NAME, type ExtensionContext } from "@earendil-works/pi-coding-agent";
@@ -94,7 +94,12 @@ export async function saveModels(models: string[]): Promise<void> {
   const tmp = `${file}.tmp-${process.pid}`;
   await mkdir(path.dirname(file), { recursive: true });
   await writeFile(tmp, JSON.stringify(settings, null, 2) + "\n", "utf8");
-  await rename(tmp, file);
+  try {
+    await rename(tmp, file);
+  } catch (e) {
+    try { await unlink(tmp); } catch { /* best-effort cleanup */ }
+    throw e;
+  }
 }
 
 export function parseModel(value: string): { provider: string; id: string } | undefined {
@@ -130,7 +135,12 @@ export async function migrateLegacyAdvisorModel(): Promise<string | undefined> {
     const tmp = `${settingsPath}.tmp-${process.pid}`;
     await mkdir(path.dirname(settingsPath), { recursive: true });
     await writeFile(tmp, JSON.stringify({ ...settings, [KEY]: { ...block, model: legacy, migrationVersion: MIGRATION_VERSION } }, null, 2) + "\n", "utf8");
-    await rename(tmp, settingsPath);
+    try {
+      await rename(tmp, settingsPath);
+    } catch (e) {
+      try { await unlink(tmp); } catch { /* best-effort cleanup */ }
+      throw e;
+    }
     return legacy;
   } catch { return undefined; }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bacnh85/pi-advisor",
-  "version": "0.2.3",
+  "version": "0.2.4",
   "description": "Pi extension for an automatic advisor: a second model that reviews each settled turn and injects severity-routed notes, plus an on-demand consult tool.",
   "type": "module",
   "license": "MIT",