@backstage/repo-tools 0.15.2-next.1 → 0.15.2

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @backstage/repo-tools
 
+## 0.15.2
+
+### Patch Changes
+
+- 133ac7a: Fixed knip-reports command failing when workspace path contains spaces and process termination issues by replacing `execFile` with `spawn` and removing `shell` option.
+- Updated dependencies
+  - @backstage/config-loader@1.10.3
+  - @backstage/backend-plugin-api@1.4.3
+
 ## 0.15.2-next.1
 
 ### Patch Changes

package/dist/commands/knip-reports/knip-extractor.cjs.js

@@ -82,16 +82,20 @@ async function handlePackage({
   const run = util.createBinRunner(paths.paths.targetRoot, "");
   let report = await run(
     `${knipDir}/knip.js`,
-    `-W ${packageDir}`,
+    "-W",
     // Run the desired workspace
-    "--config knip.json",
+    packageDir,
+    "--config",
+    "knip.json",
     "--no-exit-code",
     // Removing this will end the process in case there are findings by knip
     "--no-progress",
     // Remove unnecessary debugging from output
     // TODO: Add more checks when dependencies start to look ok, see https://knip.dev/reference/cli#--include
-    "--include dependencies,unlisted",
-    "--reporter markdown"
+    "--include",
+    "dependencies,unlisted",
+    "--reporter",
+    "markdown"
   );
   report = report.replaceAll(`| ${packageDir}/`, "| ");
   report = report.replaceAll(

package/dist/commands/util.cjs.js

@@ -13,27 +13,39 @@ const limiter = pLimit__default.default(os__default.default.cpus().length);
 function createBinRunner(cwd, path) {
   return async (...command) => limiter(
     () => new Promise((resolve, reject) => {
-      child_process.execFile(
-        "node",
-        [path, ...command],
-        {
-          cwd,
-          shell: true,
-          timeout: 3 * 60 * 1e3,
-          maxBuffer: 1024 * 1024
-        },
-        (err, stdout, stderr) => {
-          if (err) {
-            console.log("err", err);
-            reject(new Error(`${err.message}
+      const args = path ? [path, ...command] : command;
+      const child = child_process.spawn("node", args, {
+        cwd,
+        stdio: ["ignore", "pipe", "pipe"]
+      });
+      let stdout = "";
+      let stderr = "";
+      child.stdout?.on("data", (data) => {
+        stdout += data.toString();
+      });
+      child.stderr?.on("data", (data) => {
+        stderr += data.toString();
+      });
+      child.on("error", (err) => {
+        reject(new Error(`Process error: ${err.message}`));
+      });
+      child.on("close", (code, signal) => {
+        if (signal) {
+          reject(
+            new Error(
+              `Process was killed with signal ${signal}
+${stderr}`
+            )
+          );
+        } else if (code !== 0) {
+          reject(new Error(`Process exited with code ${code}
 ${stderr}`));
-          } else if (stderr) {
-            reject(new Error(`Command printed error output: ${stderr}`));
-          } else {
-            resolve(stdout);
-          }
+        } else if (stderr.trim()) {
+          reject(new Error(`Command printed error output: ${stderr}`));
+        } else {
+          resolve(stdout);
         }
-      );
+      });
     })
   );
 }

package/dist/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "0.15.2-next.1";
+var version = "0.15.2";
 
 exports.version = version;
 //# sourceMappingURL=package.json.cjs.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@backstage/repo-tools",
-  "version": "0.15.2-next.1",
+  "version": "0.15.2",
   "description": "CLI for Backstage repo tooling ",
   "backstage": {
     "role": "cli"
@@ -43,12 +43,12 @@
   "dependencies": {
     "@apidevtools/swagger-parser": "^10.1.0",
     "@apisyouwonthate/style-guide": "^1.4.0",
-    "@backstage/backend-plugin-api": "1.4.3-next.0",
-    "@backstage/catalog-model": "1.7.5",
-    "@backstage/cli-common": "0.1.15",
-    "@backstage/cli-node": "0.2.14",
-    "@backstage/config-loader": "1.10.3-next.0",
-    "@backstage/errors": "1.2.7",
+    "@backstage/backend-plugin-api": "^1.4.3",
+    "@backstage/catalog-model": "^1.7.5",
+    "@backstage/cli-common": "^0.1.15",
+    "@backstage/cli-node": "^0.2.14",
+    "@backstage/config-loader": "^1.10.3",
+    "@backstage/errors": "^1.2.7",
     "@electric-sql/pglite": "^0.3.0",
     "@manypkg/get-packages": "^1.1.3",
     "@microsoft/api-documenter": "^7.25.7",
@@ -86,9 +86,9 @@
     "zod": "^3.22.4"
   },
   "devDependencies": {
-    "@backstage/backend-test-utils": "1.9.0-next.1",
-    "@backstage/cli": "0.34.2-next.2",
-    "@backstage/types": "1.2.1",
+    "@backstage/backend-test-utils": "^1.9.0",
+    "@backstage/cli": "^0.34.2",
+    "@backstage/types": "^1.2.2",
     "@types/is-glob": "^4.0.2",
     "@types/node": "^20.16.0",
     "@types/prettier": "^2.0.0",