@backstage/plugin-catalog-react 1.0.1-next.0 → 1.0.1-next.1

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @backstage/plugin-catalog-react
 
+## 1.0.1-next.1
+
+### Patch Changes
+
+- 0ffd88a90e: Prevent permissions with types other than `ResourcePermission<'catalog-entity'>` from being used with the `useEntityPermission` hook.
+- 4af82967f4: Decouple tags picker from backend entities
+
+  `EntityTagPicker` fetches all the tags independently and it doesn't require all the entities to be available client side.
+
+- 37b04b5a5e: Removed broken link from Labels section of entity inspector.
+- 4431873583: Update `usePermission` usage.
+- Updated dependencies
+  - @backstage/integration@1.1.0-next.1
+  - @backstage/plugin-permission-react@0.4.0-next.0
+  - @backstage/plugin-permission-common@0.6.0-next.0
+  - @backstage/plugin-catalog-common@1.0.1-next.1
+
 ## 1.0.1-next.0
 
 ### Patch Changes

package/alpha/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@backstage/plugin-catalog-react",
-  "version": "1.0.1-next.0",
+  "version": "1.0.1-next.1",
   "main": "../dist/index.esm.js",
   "types": "../dist/index.alpha.d.ts"
 }

package/dist/index.alpha.d.ts

@@ -17,10 +17,10 @@ import { IconButton } from '@material-ui/core';
 import { LinkProps } from '@backstage/core-components';
 import { Observable } from '@backstage/types';
 import { Overrides } from '@material-ui/core/styles/overrides';
-import { Permission } from '@backstage/plugin-permission-common';
 import { PropsWithChildren } from 'react';
 import { default as React_2 } from 'react';
 import { ReactNode } from 'react';
+import { ResourcePermission } from '@backstage/plugin-permission-common';
 import { RouteRef } from '@backstage/core-plugin-api';
 import { ScmIntegrationRegistry } from '@backstage/integration';
 import { StyleRules } from '@material-ui/core/styles/withStyles';
@@ -585,14 +585,14 @@ export declare function useEntityOwnership(): {
  * A thin wrapper around the
  * {@link @backstage/plugin-permission-react#usePermission} hook which uses the
  * current entity in context to make an authorization request for the given
- * permission.
+ * {@link @backstage/plugin-catalog-common#CatalogEntityPermission}.
  *
  * Note: this hook blocks the permission request until the entity has loaded in
  * context. If you have the entityRef and need concurrent requests, use the
  * `usePermission` hook directly.
  * @alpha
  */
-export declare function useEntityPermission(permission: Permission): {
+export declare function useEntityPermission(permission: ResourcePermission<'catalog-entity'>): {
     loading: boolean;
     allowed: boolean;
     error?: Error;

package/dist/index.beta.d.ts

@@ -17,10 +17,10 @@ import { IconButton } from '@material-ui/core';
 import { LinkProps } from '@backstage/core-components';
 import { Observable } from '@backstage/types';
 import { Overrides } from '@material-ui/core/styles/overrides';
-import { Permission } from '@backstage/plugin-permission-common';
 import { PropsWithChildren } from 'react';
 import { default as React_2 } from 'react';
 import { ReactNode } from 'react';
+import { ResourcePermission } from '@backstage/plugin-permission-common';
 import { RouteRef } from '@backstage/core-plugin-api';
 import { ScmIntegrationRegistry } from '@backstage/integration';
 import { StyleRules } from '@material-ui/core/styles/withStyles';

package/dist/index.d.ts

@@ -17,10 +17,10 @@ import { IconButton } from '@material-ui/core';
 import { LinkProps } from '@backstage/core-components';
 import { Observable } from '@backstage/types';
 import { Overrides } from '@material-ui/core/styles/overrides';
-import { Permission } from '@backstage/plugin-permission-common';
 import { PropsWithChildren } from 'react';
 import { default as React_2 } from 'react';
 import { ReactNode } from 'react';
+import { ResourcePermission } from '@backstage/plugin-permission-common';
 import { RouteRef } from '@backstage/core-plugin-api';
 import { ScmIntegrationRegistry } from '@backstage/integration';
 import { StyleRules } from '@material-ui/core/styles/withStyles';

package/dist/index.esm.js

@@ -649,7 +649,10 @@ function useEntityPermission(permission) {
     allowed,
     loading: loadingPermission,
     error: permissionError
-  } = usePermission(permission, entity ? stringifyEntityRef(entity) : void 0);
+  } = usePermission({
+    permission,
+    resourceRef: entity ? stringifyEntityRef(entity) : void 0
+  });
   if (loadingEntity || loadingPermission) {
     return { loading: true, allowed: false };
   }
@@ -1029,7 +1032,17 @@ const checkedIcon = /* @__PURE__ */ React.createElement(CheckBoxIcon, {
 const EntityTagPicker = () => {
   var _a, _b;
   const classes = useStyles$7();
-  const { updateFilters, backendEntities, filters, queryParameters } = useEntityList();
+  const { updateFilters, filters, queryParameters } = useEntityList();
+  const catalogApi = useApi(catalogApiRef);
+  const { value: availableTags } = useAsync(async () => {
+    var _a2;
+    const facet = "metadata.tags";
+    const { facets } = await catalogApi.getEntityFacets({
+      facets: [facet],
+      filter: (_a2 = filters.kind) == null ? void 0 : _a2.getCatalogFilters()
+    });
+    return facets[facet].map(({ value }) => value);
+  }, [filters.kind]);
   const queryParamTags = useMemo(() => [queryParameters.tags].flat().filter(Boolean), [queryParameters]);
   const [selectedTags, setSelectedTags] = useState(queryParamTags.length ? queryParamTags : (_b = (_a = filters.tags) == null ? void 0 : _a.values) != null ? _b : []);
   useEffect(() => {
@@ -1042,10 +1055,7 @@ const EntityTagPicker = () => {
       tags: selectedTags.length ? new EntityTagFilter(selectedTags) : void 0
     });
   }, [selectedTags, updateFilters]);
-  const availableTags = useMemo(() => [
-    ...new Set(backendEntities.flatMap((e) => e.metadata.tags).filter(Boolean))
-  ].sort(), [backendEntities]);
-  if (!availableTags.length)
+  if (!(availableTags == null ? void 0 : availableTags.length))
     return null;
   return /* @__PURE__ */ React.createElement(Box, {
     pb: 1,
@@ -1531,9 +1541,7 @@ function OverviewPage(props) {
     entry
   }))), !!Object.keys(metadata.labels || {}).length && /* @__PURE__ */ React.createElement(List, {
     dense: true,
-    subheader: /* @__PURE__ */ React.createElement(ListSubheader, null, "Labels", /* @__PURE__ */ React.createElement(HelpIcon, {
-      to: "https://backstage.io/docs/features/software-catalog/well-known-labels"
-    }))
+    subheader: /* @__PURE__ */ React.createElement(ListSubheader, null, "Labels")
   }, Object.entries(metadata.labels).map((entry) => /* @__PURE__ */ React.createElement(KeyValueListItem, {
     key: entry[0],
     indent: true,