@backstage/frontend-app-api 0.4.0-next.3 → 0.4.0

package/CHANGELOG.md

@@ -1,5 +1,46 @@
 # @backstage/frontend-app-api
 
+## 0.4.0
+
+### Minor Changes
+
+- e539735: Updated core extension structure to make space for the sign-in page by adding `core.router`.
+- 44735df: Removed `featureLoader` from `createApp`, `features` instead accepts both `FrontendFeature` and `CreateAppFeatureLoader`
+- af7bc3e: Switched all core extensions to instead use the namespace `'app'`.
+- ea06590: The app no longer provides the `AppContext` from `@backstage/core-plugin-api`. Components that require this context to be available should use the `compatWrapper` helper from `@backstage/core-compat-api`.
+
+### Patch Changes
+
+- 5eb6b8a: Added the nav logo extension for customization of sidebar logo
+- aeb8008: Add support for translation extensions.
+- 1f12fb7: Create a core components extension that allows adopters to override core app components such as `Progress`, `BootErrorPage`, `NotFoundErrorPage` and `ErrorBoundaryFallback`.
+- a379243: Leverage the new `FrontendFeature` type to simplify interfaces
+- 60d6eb5: Removed `@backstage/plugin-graphiql` dependency.
+- b7adf24: Use the new plugin type for error boundary components.
+- 5970928: Collect and register feature flags from plugins and extension overrides.
+- 9ad4039: Bringing over apis from core-plugin-api
+- 8f5d6c1: Updates to match the new extension input wrapping.
+- c35036b: A `configLoader` passed to `createApp` now returns an object, to make room for future expansion
+- f27ee7d: Migrate analytics route tracker component.
+- b8cb780: Added `createSpecializedApp`, which is a synchronous version of `createApp` where config and features already need to be loaded.
+- c36e0b9: Renamed `AppRouteBinder` to `CreateAppRouteBinder`
+- cb4197a: Forward ` node`` instead of  `extensionId` to resolved extension inputs.
+- 8837a96: Updates to match the introduction of `ExtensionDefinition` and new extension ID naming patterns.
+- a5a0473: Updates to provide `node` to extension factories instead of `id` and `source`.
+- 5cdf2b3: Updated usage of `Extension` and `ExtensionDefinition` as they are now opaque.
+- f9ef632: Updates to match the new `coreExtensionData` structure.
+- f1183b7: Renamed the `component` option of `createComponentExtension` to `loader`.
+- Updated dependencies
+  - @backstage/core-plugin-api@1.8.1
+  - @backstage/frontend-plugin-api@0.4.0
+  - @backstage/core-components@0.13.9
+  - @backstage/theme@0.5.0
+  - @backstage/core-app-api@1.11.2
+  - @backstage/config@1.1.1
+  - @backstage/errors@1.2.3
+  - @backstage/types@1.1.1
+  - @backstage/version-bridge@1.0.7
+
 ## 0.4.0-next.3
 
 ### Patch Changes

package/dist/index.d.ts

@@ -1,4 +1,4 @@
-import { ExternalRouteRef, RouteRef, SubRouteRef, ExtensionDataRef, BackstagePlugin, ExtensionOverrides } from '@backstage/frontend-plugin-api';
+import { ExternalRouteRef, RouteRef, SubRouteRef, ExtensionDataRef, FrontendFeature } from '@backstage/frontend-plugin-api';
 import { JSX } from 'react';
 import { Config } from '@backstage/config';
 import { ConfigApi } from '@backstage/core-plugin-api';
@@ -37,7 +37,7 @@ type TargetRouteMap<ExternalRoutes extends {
  *
  * @public
  */
-type AppRouteBinder = <TExternalRoutes extends {
+type CreateAppRouteBinder = <TExternalRoutes extends {
     [name: string]: ExternalRouteRef;
 }>(externalRoutes: TExternalRoutes, targetRoutes: PartialKeys<TargetRouteMap<TExternalRoutes>, KeysWithType<TExternalRoutes, ExternalRouteRef<any, true>>>) => void;
 
@@ -57,32 +57,51 @@ interface ExtensionTree {
 declare function createExtensionTree(options: {
     config: Config;
 }): ExtensionTree;
+/**
+ * A source of dynamically loaded frontend features.
+ *
+ * @public
+ */
+interface CreateAppFeatureLoader {
+    /**
+     * Returns name of this loader. suitable for showing to users.
+     */
+    getLoaderName(): string;
+    /**
+     * Loads a number of features dynamically.
+     */
+    load(options: {
+        config: ConfigApi;
+    }): Promise<{
+        features: FrontendFeature[];
+    }>;
+}
 /** @public */
 declare function createApp(options?: {
-    features?: (BackstagePlugin | ExtensionOverrides)[];
-    configLoader?: () => Promise<ConfigApi>;
+    features?: (FrontendFeature | CreateAppFeatureLoader)[];
+    configLoader?: () => Promise<{
+        config: ConfigApi;
+    }>;
     bindRoutes?(context: {
-        bind: AppRouteBinder;
+        bind: CreateAppRouteBinder;
     }): void;
-    featureLoader?: (ctx: {
-        config: ConfigApi;
-    }) => Promise<(BackstagePlugin | ExtensionOverrides)[]>;
 }): {
     createRoot(): JSX.Element;
 };
 /**
  * Synchronous version of {@link createApp}, expecting all features and
  * config to have been loaded already.
+ *
  * @public
  */
 declare function createSpecializedApp(options?: {
-    features?: (BackstagePlugin | ExtensionOverrides)[];
+    features?: FrontendFeature[];
     config?: ConfigApi;
     bindRoutes?(context: {
-        bind: AppRouteBinder;
+        bind: CreateAppRouteBinder;
     }): void;
 }): {
     createRoot(): JSX.Element;
 };
 
-export { AppRouteBinder, ExtensionTree, ExtensionTreeNode, createApp, createExtensionTree, createSpecializedApp };
+export { CreateAppFeatureLoader, CreateAppRouteBinder, ExtensionTree, ExtensionTreeNode, createApp, createExtensionTree, createSpecializedApp };

package/dist/index.esm.js

@@ -1,10 +1,10 @@
 import React, { useMemo, useState, useEffect, createContext, useContext } from 'react';
 import { ConfigReader } from '@backstage/config';
-import { createExtension, createExtensionInput, coreExtensionData, createTranslationExtension, useComponentRef, coreComponentRefs, useRouteRef, createThemeExtension, createComponentExtension, AnalyticsContext, useAnalytics, appTreeApiRef, componentsApiRef } from '@backstage/frontend-plugin-api';
+import { createExtension, createExtensionInput, createApiExtension, createThemeExtension, createComponentExtension, createTranslationExtension, coreExtensionData, useComponentRef, coreComponentRefs, createNavItemExtension, createNavLogoExtension, useRouteRef, AnalyticsContext, useAnalytics, createSignInPageExtension, appTreeApiRef, componentsApiRef } from '@backstage/frontend-plugin-api';
 import { useRoutes, BrowserRouter, useInRouterContext, MemoryRouter, matchRoutes, generatePath, useLocation, Route } from 'react-router-dom';
 import { SidebarPage, sidebarConfig, Sidebar, SidebarDivider, useSidebarOpenState, Link, SidebarItem, Progress, ErrorPage, ErrorPanel } from '@backstage/core-components';
 import { makeStyles, Button as Button$1 } from '@material-ui/core';
-import { useApi, appThemeApiRef, FeatureFlagState, createApiFactory, discoveryApiRef, configApiRef, alertApiRef, analyticsApiRef, errorApiRef, storageApiRef, fetchApiRef, identityApiRef, oauthRequestApiRef, googleAuthApiRef, microsoftAuthApiRef, githubAuthApiRef, oktaAuthApiRef, gitlabAuthApiRef, oneloginAuthApiRef, bitbucketAuthApiRef, bitbucketServerAuthApiRef, atlassianAuthApiRef, createApiRef, attachComponentData, featureFlagsApiRef } from '@backstage/core-plugin-api';
+import { useApi, appThemeApiRef, FeatureFlagState, createApiFactory, discoveryApiRef, configApiRef, alertApiRef, analyticsApiRef, errorApiRef, storageApiRef, fetchApiRef, identityApiRef, oauthRequestApiRef, googleAuthApiRef, microsoftAuthApiRef, githubAuthApiRef, oktaAuthApiRef, gitlabAuthApiRef, oneloginAuthApiRef, bitbucketAuthApiRef, bitbucketServerAuthApiRef, atlassianAuthApiRef, attachComponentData, featureFlagsApiRef } from '@backstage/core-plugin-api';
 import { UrlPatternDiscovery, AlertApiForwarder, NoOpAnalyticsApi, ErrorAlerter, ErrorApiForwarder, UnhandledErrorForwarder, WebStorage, createFetchApi, FetchMiddlewares, OAuthRequestManager, GoogleAuth, MicrosoftAuth, GithubAuth, OktaAuth, GitlabAuth, OneLoginAuth, BitbucketAuth, BitbucketServerAuth, AtlassianAuth, ApiFactoryRegistry, AppThemeSelector, ApiResolver, ApiProvider } from '@backstage/core-app-api';
 import useObservable from 'react-use/lib/useObservable';
 import ObservableImpl from 'zen-observable';
@@ -38,20 +38,21 @@ import LightIcon from '@material-ui/icons/WbSunny';
 import { getOrCreateGlobalSingleton, createVersionedContext, createVersionedValueMap } from '@backstage/version-bridge';
 import { appLanguageApiRef, translationApiRef } from '@backstage/core-plugin-api/alpha';
 import mapValues from 'lodash/mapValues';
+import { stringifyError } from '@backstage/errors';
 
 const Core = createExtension({
-  namespace: "core",
+  namespace: "app",
   attachTo: { id: "root", input: "default" },
   // ignored
   inputs: {
     apis: createExtensionInput({
-      api: coreExtensionData.apiFactory
+      api: createApiExtension.factoryDataRef
     }),
     themes: createExtensionInput({
-      theme: coreExtensionData.theme
+      theme: createThemeExtension.themeDataRef
     }),
     components: createExtensionInput({
-      component: coreExtensionData.component
+      component: createComponentExtension.componentDataRef
     }),
     translations: createExtensionInput({
       translation: createTranslationExtension.translationDataRef
@@ -74,9 +75,9 @@ const Core = createExtension({
 });
 
 const CoreRoutes = createExtension({
-  namespace: "core",
+  namespace: "app",
   name: "routes",
-  attachTo: { id: "core/layout", input: "content" },
+  attachTo: { id: "app/layout", input: "content" },
   inputs: {
     routes: createExtensionInput({
       path: coreExtensionData.routePath,
@@ -111,9 +112,9 @@ const CoreRoutes = createExtension({
 });
 
 const CoreLayout = createExtension({
-  namespace: "core",
+  namespace: "app",
   name: "layout",
-  attachTo: { id: "core/router", input: "children" },
+  attachTo: { id: "app/router", input: "children" },
   inputs: {
     nav: createExtensionInput(
       {
@@ -220,16 +221,16 @@ const SidebarNavItem = (props) => {
   return /* @__PURE__ */ React.createElement(SidebarItem, { to, icon: Icon, text: title });
 };
 const CoreNav = createExtension({
-  namespace: "core",
+  namespace: "app",
   name: "nav",
-  attachTo: { id: "core/layout", input: "nav" },
+  attachTo: { id: "app/layout", input: "nav" },
   inputs: {
     items: createExtensionInput({
-      target: coreExtensionData.navTarget
+      target: createNavItemExtension.targetDataRef
     }),
     logos: createExtensionInput(
       {
-        elements: coreExtensionData.logoElements
+        elements: createNavLogoExtension.logoElementsDataRef
       },
       {
         singleton: true,
@@ -1065,10 +1066,40 @@ registerDefaults_fn = function(internalRef) {
 };
 let I18nextTranslationApi = _I18nextTranslationApi;
 
+function toInternalExtensionDefinition(overrides) {
+  const internal = overrides;
+  if (internal.$$type !== "@backstage/ExtensionDefinition") {
+    throw new Error(
+      `Invalid extension definition instance, bad type '${internal.$$type}'`
+    );
+  }
+  if (internal.version !== "v1") {
+    throw new Error(
+      `Invalid extension definition instance, bad version '${internal.version}'`
+    );
+  }
+  return internal;
+}
+
+function toInternalExtension(overrides) {
+  const internal = overrides;
+  if (internal.$$type !== "@backstage/Extension") {
+    throw new Error(
+      `Invalid extension instance, bad type '${internal.$$type}'`
+    );
+  }
+  if (internal.version !== "v1") {
+    throw new Error(
+      `Invalid extension instance, bad version '${internal.version}'`
+    );
+  }
+  return internal;
+}
 function resolveExtensionDefinition(definition, context) {
   var _a;
-  const { name, kind, namespace: _, ...rest } = definition;
-  const namespace = (_a = definition.namespace) != null ? _a : context == null ? void 0 : context.namespace;
+  const internalDefinition = toInternalExtensionDefinition(definition);
+  const { name, kind, namespace: _, ...rest } = internalDefinition;
+  const namespace = (_a = internalDefinition.namespace) != null ? _a : context == null ? void 0 : context.namespace;
   const namePart = name && namespace ? `${namespace}/${name}` : namespace || name;
   if (!namePart) {
     throw new Error(
@@ -1077,8 +1108,9 @@ function resolveExtensionDefinition(definition, context) {
   }
   return {
     ...rest,
-    id: kind ? `${kind}:${namePart}` : namePart,
-    $$type: "@backstage/Extension"
+    $$type: "@backstage/Extension",
+    version: "v1",
+    id: kind ? `${kind}:${namePart}` : namePart
   };
 }
 
@@ -1988,40 +2020,47 @@ function resolveAppNodeSpecs(options) {
     );
   }
   const configuredExtensions = [
-    ...pluginExtensions.map(({ source, ...extension }) => ({
-      extension,
-      params: {
-        source,
-        attachTo: extension.attachTo,
-        disabled: extension.disabled,
-        config: void 0
-      }
-    })),
-    ...builtinExtensions.map((extension) => ({
-      extension,
-      params: {
-        source: void 0,
-        attachTo: extension.attachTo,
-        disabled: extension.disabled,
-        config: void 0
-      }
-    }))
+    ...pluginExtensions.map(({ source, ...extension }) => {
+      const internalExtension = toInternalExtension(extension);
+      return {
+        extension: internalExtension,
+        params: {
+          source,
+          attachTo: internalExtension.attachTo,
+          disabled: internalExtension.disabled,
+          config: void 0
+        }
+      };
+    }),
+    ...builtinExtensions.map((extension) => {
+      const internalExtension = toInternalExtension(extension);
+      return {
+        extension: internalExtension,
+        params: {
+          source: void 0,
+          attachTo: internalExtension.attachTo,
+          disabled: internalExtension.disabled,
+          config: void 0
+        }
+      };
+    })
   ];
   for (const extension of overrideExtensions) {
+    const internalExtension = toInternalExtension(extension);
     const index = configuredExtensions.findIndex(
       (e) => e.extension.id === extension.id
     );
     if (index !== -1) {
-      configuredExtensions[index].extension = extension;
-      configuredExtensions[index].params.attachTo = extension.attachTo;
-      configuredExtensions[index].params.disabled = extension.disabled;
+      configuredExtensions[index].extension = internalExtension;
+      configuredExtensions[index].params.attachTo = internalExtension.attachTo;
+      configuredExtensions[index].params.disabled = internalExtension.disabled;
     } else {
       configuredExtensions.push({
-        extension,
+        extension: internalExtension,
         params: {
           source: void 0,
-          attachTo: extension.attachTo,
-          disabled: extension.disabled,
+          attachTo: internalExtension.attachTo,
+          disabled: internalExtension.disabled,
           config: void 0
         }
       });
@@ -2163,13 +2202,14 @@ function createAppNodeInstance(options) {
     );
   }
   try {
-    const namedOutputs = extension.factory({
+    const internalExtension = toInternalExtension(extension);
+    const namedOutputs = internalExtension.factory({
       node,
       config: parsedConfig,
-      inputs: resolveInputs(extension.inputs, attachments)
+      inputs: resolveInputs(internalExtension.inputs, attachments)
     });
     for (const [name, output] of Object.entries(namedOutputs)) {
-      const ref = extension.output[name];
+      const ref = internalExtension.output[name];
       if (!ref) {
         throw new Error(`unknown output provided via '${name}'`);
       }
@@ -2227,12 +2267,12 @@ function instantiateAppNodeTree(rootNode) {
 
 function createAppTree(options) {
   const tree = resolveAppTree(
-    "core",
+    "app",
     resolveAppNodeSpecs({
       features: options.features,
       builtinExtensions: options.builtinExtensions,
       parameters: readAppExtensionsConfig(options.config),
-      forbidden: /* @__PURE__ */ new Set(["core"])
+      forbidden: /* @__PURE__ */ new Set(["app"])
     })
   );
   instantiateAppNodeTree(tree.root);
@@ -2241,15 +2281,15 @@ function createAppTree(options) {
 
 const DefaultProgressComponent = createComponentExtension({
   ref: coreComponentRefs.progress,
-  component: { sync: () => components.Progress }
+  loader: { sync: () => components.Progress }
 });
 const DefaultNotFoundErrorPageComponent = createComponentExtension({
   ref: coreComponentRefs.notFoundErrorPage,
-  component: { sync: () => components.NotFoundErrorPage }
+  loader: { sync: () => components.NotFoundErrorPage }
 });
 const DefaultErrorBoundaryComponent = createComponentExtension({
   ref: coreComponentRefs.errorBoundaryFallback,
-  component: {
+  loader: {
     sync: () => (props) => {
       const { plugin, error, resetError } = props;
       const title = `Error in ${plugin == null ? void 0 : plugin.id}`;
@@ -2260,38 +2300,6 @@ const DefaultErrorBoundaryComponent = createComponentExtension({
 
 const InternalAppContext = createContext(void 0);
 
-getOrCreateGlobalSingleton(
-  "core-plugin-api:analytics-tracker-events",
-  () => ({
-    mostRecentGatheredNavigation: void 0,
-    mostRecentRoutableExtensionRender: void 0,
-    beforeUnloadRegistered: false
-  })
-);
-
-createApiRef({ id: "core.app-tree" });
-
-createApiRef({
-  id: "core.components"
-});
-
-createApiRef({
-  id: "core.analytics"
-});
-
-function createExtensionDataRef(id) {
-  return {
-    id,
-    $$type: "@backstage/ExtensionDataRef",
-    config: {},
-    optional() {
-      return { ...this, config: { ...this.config, optional: true } };
-    }
-  };
-}
-
-const signInPageComponentDataRef = createExtensionDataRef("core.signInPage");
-
 const getExtensionContext = (pathname, routes) => {
   var _a, _b;
   try {
@@ -2360,13 +2368,13 @@ const RouteTracker = ({
 };
 
 const CoreRouter = createExtension({
-  namespace: "core",
+  namespace: "app",
   name: "router",
-  attachTo: { id: "core", input: "root" },
+  attachTo: { id: "app", input: "root" },
   inputs: {
     signInPage: createExtensionInput(
       {
-        component: signInPageComponentDataRef
+        component: createSignInPageExtension.componentDataRef
       },
       { singleton: true, optional: true }
     ),
@@ -2492,6 +2500,7 @@ class DefaultComponentsApi {
 }
 _components = new WeakMap();
 
+const DefaultApis = apis.map((factory) => createApiExtension({ factory }));
 const builtinExtensions = [
   Core,
   CoreRouter,
@@ -2502,7 +2511,8 @@ const builtinExtensions = [
   DefaultErrorBoundaryComponent,
   DefaultNotFoundErrorPageComponent,
   LightTheme,
-  DarkTheme
+  DarkTheme,
+  ...DefaultApis
 ].map((def) => resolveExtensionDefinition(def));
 function createExtensionTree(options) {
   const features = getAvailableFeatures(options.config);
@@ -2529,7 +2539,7 @@ function createExtensionTree(options) {
       return (_c = (_b = (_a = tree.nodes.get(id)) == null ? void 0 : _a.edges.attachments.get(inputName)) == null ? void 0 : _b.map(convertNode).filter((node) => Boolean(node))) != null ? _c : [];
     },
     getRootRoutes() {
-      return this.getExtensionAttachments("core/routes", "routes").map((node) => {
+      return this.getExtensionAttachments("app/routes", "routes").map((node) => {
         const path = node.getData(coreExtensionData.routePath);
         const element = node.getData(coreExtensionData.reactElement);
         const routeRef = node.getData(coreExtensionData.routeRef);
@@ -2548,8 +2558,8 @@ function createExtensionTree(options) {
         const location = useRouteRef(props.routeRef);
         return /* @__PURE__ */ React.createElement(SidebarItem, { icon: props.icon, to: location(), text: props.title });
       };
-      return this.getExtensionAttachments("core/nav", "items").map((node, index) => {
-        const target = node.getData(coreExtensionData.navTarget);
+      return this.getExtensionAttachments("app/nav", "items").map((node, index) => {
+        const target = node.getData(createNavItemExtension.targetDataRef);
         if (!target) {
           return null;
         }
@@ -2582,19 +2592,31 @@ function deduplicateFeatures(allFeatures) {
 }
 function createApp(options) {
   async function appLoader() {
-    var _a, _b, _c, _d, _e;
-    const config = (_b = await ((_a = options == null ? void 0 : options.configLoader) == null ? void 0 : _a.call(options))) != null ? _b : ConfigReader.fromConfigs(
+    var _a, _b, _c;
+    const config = (_b = await ((_a = options == null ? void 0 : options.configLoader) == null ? void 0 : _a.call(options).then((c) => c.config))) != null ? _b : ConfigReader.fromConfigs(
       overrideBaseUrlConfigs(defaultConfigLoaderSync())
     );
     const discoveredFeatures = getAvailableFeatures(config);
-    const loadedFeatures = (_d = await ((_c = options == null ? void 0 : options.featureLoader) == null ? void 0 : _c.call(options, { config }))) != null ? _d : [];
+    const providedFeatures = [];
+    for (const entry of (_c = options == null ? void 0 : options.features) != null ? _c : []) {
+      if ("load" in entry) {
+        try {
+          const result = await entry.load({ config });
+          providedFeatures.push(...result.features);
+        } catch (e) {
+          throw new Error(
+            `Failed to read frontend features from loader '${entry.getLoaderName()}', ${stringifyError(
+              e
+            )}`
+          );
+        }
+      } else {
+        providedFeatures.push(entry);
+      }
+    }
     const app = createSpecializedApp({
       config,
-      features: [
-        ...discoveredFeatures,
-        ...loadedFeatures,
-        ...(_e = options == null ? void 0 : options.features) != null ? _e : []
-      ],
+      features: [...discoveredFeatures, ...providedFeatures],
       bindRoutes: options == null ? void 0 : options.bindRoutes
     }).createRoot();
     return { default: () => app };
@@ -2662,11 +2684,11 @@ function createApiHolder(tree, configApi, appIdentityProxy) {
   const factoryRegistry = new ApiFactoryRegistry();
   const pluginApis = (_b = (_a = tree.root.edges.attachments.get("apis")) == null ? void 0 : _a.map((e) => {
     var _a2;
-    return (_a2 = e.instance) == null ? void 0 : _a2.getData(coreExtensionData.apiFactory);
+    return (_a2 = e.instance) == null ? void 0 : _a2.getData(createApiExtension.factoryDataRef);
   }).filter((x) => !!x)) != null ? _b : [];
   const themeExtensions = (_d = (_c = tree.root.edges.attachments.get("themes")) == null ? void 0 : _c.map((e) => {
     var _a2;
-    return (_a2 = e.instance) == null ? void 0 : _a2.getData(coreExtensionData.theme);
+    return (_a2 = e.instance) == null ? void 0 : _a2.getData(createThemeExtension.themeDataRef);
   }).filter((x) => !!x)) != null ? _d : [];
   const translationResources = (_f = (_e = tree.root.edges.attachments.get("translations")) == null ? void 0 : _e.map(
     (e) => {
@@ -2676,7 +2698,7 @@ function createApiHolder(tree, configApi, appIdentityProxy) {
   ).filter(
     (x) => !!x
   )) != null ? _f : [];
-  for (const factory of [...apis, ...pluginApis]) {
+  for (const factory of pluginApis) {
     factoryRegistry.register("default", factory);
   }
   factoryRegistry.register("default", {
@@ -2698,7 +2720,7 @@ function createApiHolder(tree, configApi, appIdentityProxy) {
   });
   const componentsExtensions = (_h = (_g = tree.root.edges.attachments.get("components")) == null ? void 0 : _g.map((e) => {
     var _a2;
-    return (_a2 = e.instance) == null ? void 0 : _a2.getData(coreExtensionData.component);
+    return (_a2 = e.instance) == null ? void 0 : _a2.getData(createComponentExtension.componentDataRef);
   }).filter((x) => !!x)) != null ? _h : [];
   const componentsMap = componentsExtensions.reduce(
     (components, component) => component ? components.set(component.ref, component == null ? void 0 : component.impl) : components,
@@ -2738,13 +2760,6 @@ function createApiHolder(tree, configApi, appIdentityProxy) {
       resources: translationResources
     })
   });
-  for (const factory of apis) {
-    if (!factoryRegistry.register("app", factory)) {
-      throw new Error(
-        `Duplicate or forbidden API factory for ${factory.api} in app`
-      );
-    }
-  }
   ApiResolver.validateFactories(factoryRegistry, factoryRegistry.getAllApis());
   return new ApiResolver(factoryRegistry);
 }