@backstage/eslint-plugin 0.2.2 → 0.2.3

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @backstage/eslint-plugin
 
+## 0.2.3
+
+### Patch Changes
+
+- df43b0e: Fixed `no-mixed-plugin-imports` rule to return `null` from non-fixable suggestion handlers and added an explicit `SuggestionReportDescriptor[]` type annotation, matching the stricter type checking in TypeScript 6.0.
+
+## 0.2.3-next.0
+
+### Patch Changes
+
+- df43b0e: Fixed `no-mixed-plugin-imports` rule to return `null` from non-fixable suggestion handlers and added an explicit `SuggestionReportDescriptor[]` type annotation, matching the stricter type checking in TypeScript 6.0.
+
 ## 0.2.2
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@backstage/eslint-plugin",
-  "version": "0.2.2",
+  "version": "0.2.3",
   "description": "Backstage ESLint plugin",
   "publishConfig": {
     "access": "public"
@@ -22,7 +22,7 @@
     "minimatch": "^10.2.1"
   },
   "devDependencies": {
-    "@backstage/cli": "^0.36.0",
+    "@backstage/cli": "^0.36.1",
     "@types/estree": "^1.0.5",
     "eslint": "^8.33.0"
   }

package/rules/no-mixed-plugin-imports.js

@@ -173,6 +173,7 @@ module.exports = {
             !ignoreTargetPackages.includes(targetName),
         )
       ) {
+        /** @type {import('eslint').Rule.SuggestionReportDescriptor[]} */
         const suggest = [];
 
         if (
@@ -187,9 +188,9 @@ module.exports = {
               sourcePackage: sourceName,
               sourceRole: sourceRole,
             },
-            /** @param {import('eslint').Rule.RuleFixer} _fixer */
-            fix(_fixer) {
+            fix() {
               // Not a fixable case, just give a suggestion to change plugin id
+              return null;
             },
           });
           suggest.push({
@@ -197,7 +198,6 @@ module.exports = {
             data: {
               targetPackage: targetName,
             },
-            /** @param {import('eslint').Rule.RuleFixer} fixer */
             fix(fixer) {
               const source = context.sourceCode;
               const nodeSource = source.getText(imp.node);
@@ -210,7 +210,6 @@ module.exports = {
             data: {
               targetPackage: targetName,
             },
-            /** @param {import('eslint').Rule.RuleFixer} fixer */
             fix(fixer) {
               const source = context.sourceCode;
               const nodeSource = source.getText(imp.node);
@@ -228,7 +227,6 @@ module.exports = {
             data: {
               targetPackage: targetName,
             },
-            /** @param {import('eslint').Rule.RuleFixer} fixer */
             fix(fixer) {
               const source = context.sourceCode;
               const nodeSource = source.getText(imp.node);
@@ -241,7 +239,6 @@ module.exports = {
             data: {
               targetPackage: targetName,
             },
-            /** @param {import('eslint').Rule.RuleFixer} fixer */
             fix(fixer) {
               const source = context.sourceCode;
               const nodeSource = source.getText(imp.node);
@@ -252,9 +249,9 @@ module.exports = {
         } else {
           suggest.push({
             messageId: 'removeImport',
-            /** @param {import('eslint').Rule.RuleFixer} _fixer */
-            fix(_fixer) {
-              // Not a fixable case, just give a suggestion to remove the import
+            fix() {
+              // Not a fixable case, just give a suggestion to change plugin id
+              return null;
             },
           });
         }