@backstage/eslint-plugin 0.1.9 → 0.1.10-next.0

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @backstage/eslint-plugin
 
+## 0.1.10-next.0
+
+### Patch Changes
+
+- 63963f6: Internal refactor to deal with `estree` upgrade
+
 ## 0.1.9
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@backstage/eslint-plugin",
-  "version": "0.1.9",
+  "version": "0.1.10-next.0",
   "description": "Backstage ESLint plugin",
   "publishConfig": {
     "access": "public"
@@ -22,7 +22,7 @@
     "minimatch": "^9.0.0"
   },
   "devDependencies": {
-    "@backstage/cli": "^0.27.1",
+    "@backstage/cli": "0.28.0-next.1",
     "@types/estree": "^1.0.5",
     "eslint": "^8.33.0"
   }

package/rules/no-top-level-material-ui-4-imports.js

@@ -80,11 +80,14 @@ const KNOWN_STYLES = [
 
 /**
  * filter function to keep only ImportSpecifier nodes
- * @param {import('estree').ImportSpecifier | import('estree').ImportDefaultSpecifier| import('estree').ImportNamespaceSpecifier} specifier
+ * @param {import('estree').ImportSpecifier | import('estree').ImportDefaultSpecifier | import('estree').ImportNamespaceSpecifier} specifier
  * @returns {specifier is import('estree').ImportSpecifier}
  */
 function importSpecifiersFilter(specifier) {
-  return specifier.type === 'ImportSpecifier';
+  return (
+    specifier.type === 'ImportSpecifier' &&
+    specifier.imported.type !== 'Literal'
+  );
 }
 
 /**
@@ -146,12 +149,16 @@ module.exports = {
 
           const specifiers = node.specifiers.filter(importSpecifiersFilter);
 
-          const specifiersMap = specifiers.map(
+          const specifiersMap = specifiers.flatMap(
             /**
              * transform ImportSpecifier to FixerValues to have a simpler object to work with
-             * @returns {FixerValues}
+             * @returns {FixerValues[]}
              */
             s => {
+              if (s.imported.type === 'Literal') {
+                return [];
+              }
+
               const value = s.imported.name;
               const alias = s.local.name === value ? undefined : s.local.name;
 
@@ -165,19 +172,24 @@ module.exports = {
               const emitComponent = !emitProp;
               const emitComponentAndProp =
                 emitProp &&
-                specifiers.find(s => s.imported.name === propsMatch[1])?.local
-                  .name;
-
-              return {
-                emitComponent: emitComponent || Boolean(emitComponentAndProp),
-                emitProp,
-                value,
-                componentValue: propsMatch ? propsMatch[1] : undefined,
-                componentAlias: emitComponentAndProp
-                  ? emitComponentAndProp
-                  : undefined,
-                alias,
-              };
+                specifiers.find(
+                  s =>
+                    s.imported.type !== 'Literal' &&
+                    s.imported.name === propsMatch[1],
+                )?.local.name;
+
+              return [
+                {
+                  emitComponent: emitComponent || Boolean(emitComponentAndProp),
+                  emitProp,
+                  value,
+                  componentValue: propsMatch ? propsMatch[1] : undefined,
+                  componentAlias: emitComponentAndProp
+                    ? emitComponentAndProp
+                    : undefined,
+                  alias,
+                },
+              ];
             },
           );