@backstage/eslint-plugin 0.1.3 → 0.1.4

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @backstage/eslint-plugin
 
+## 0.1.4
+
+### Patch Changes
+
+- 107dc46: The `no-undeclared-imports` rule will now prefer using version queries that already exist en the repo for the same dependency type when installing new packages.
+
+## 0.1.4-next.0
+
+### Patch Changes
+
+- 107dc46ab1: The `no-undeclared-imports` rule will now prefer using version queries that already exist en the repo for the same dependency type when installing new packages.
+
 ## 0.1.3
 
 ### Patch Changes

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@backstage/eslint-plugin",
   "description": "Backstage ESLint plugin",
-  "version": "0.1.3",
+  "version": "0.1.4",
   "publishConfig": {
     "access": "public"
   },
@@ -22,7 +22,7 @@
     "minimatch": "^5.1.2"
   },
   "devDependencies": {
-    "@backstage/cli": "^0.22.6",
+    "@backstage/cli": "^0.25.0",
     "eslint": "^8.33.0"
   }
 }

package/rules/no-undeclared-imports.js

@@ -121,6 +121,39 @@ function getAddFlagForDepsField(depsField) {
   }
 }
 
+/**
+ * Looks up the most common version range for a dependency if it already exists in the repo.
+ *
+ * @param {string} name
+ * @param {string} flag
+ * @param {getPackageMap.PackageMap} packages
+ * @returns {string}
+ */
+function addVersionQuery(name, flag, packages) {
+  const rangeCounts = new Map();
+
+  for (const pkg of packages.list) {
+    const deps =
+      flag === '--dev'
+        ? pkg.packageJson.devDependencies
+        : flag === '--peer'
+        ? pkg.packageJson.peerDependencies
+        : pkg.packageJson.dependencies;
+    const range = deps?.[name];
+    if (range) {
+      rangeCounts.set(range, (rangeCounts.get(range) ?? 0) + 1);
+    }
+  }
+
+  const mostCommonRange = [...rangeCounts.entries()].sort(
+    (a, b) => b[1] - a[1],
+  )[0]?.[0];
+  if (!mostCommonRange) {
+    return name;
+  }
+  return `${name}@${mostCommonRange}`;
+}
+
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
   meta: {
@@ -177,13 +210,22 @@ module.exports = {
         }
 
         for (const [flag, names] of Object.entries(byFlag)) {
+          // Look up existing version queries in the repo for the same dependency
+          const namesWithQuery = [...names].map(name =>
+            addVersionQuery(name, flag, packages),
+          );
+
           // The security implication of this is a bit interesting, as crafted add-import
           // directives could be used to install malicious packages. However, the same is true
-          // for adding malicious packages to package.json, so there's significant difference.
-          execFileSync('yarn', ['add', ...(flag ? [flag] : []), ...names], {
-            cwd: localPkg.dir,
-            stdio: 'inherit',
-          });
+          // for adding malicious packages to package.json, so there's no significant difference.
+          execFileSync(
+            'yarn',
+            ['add', ...(flag ? [flag] : []), ...namesWithQuery],
+            {
+              cwd: localPkg.dir,
+              stdio: 'inherit',
+            },
+          );
         }
 
         // This switches all import directives back to the original import.