@backstage/eslint-plugin 0.1.0 → 0.1.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @backstage/eslint-plugin
 
+## 0.1.1
+
+### Patch Changes
+
+- cbd09db1c0: Fixing a bug that we should check internal dependencies too
+
 ## 0.1.0
 
 ### Minor Changes

package/lib/visitImports.js

@@ -34,6 +34,7 @@ const getPackages = require('./getPackages');
  * @property {'value' | 'type'} kind
  * @property {string} path
  * @property {import('./getPackages').ExtendedPackage} package
+ * @property {string} packageName
  */
 
 /**
@@ -160,6 +161,7 @@ module.exports = function visitImports(context, visitor) {
       kind: info.kind,
       path: subPath,
       package: pkg,
+      packageName,
     });
   }
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@backstage/eslint-plugin",
   "description": "Backstage ESLint plugin",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "publishConfig": {
     "access": "public"
   },
@@ -22,7 +22,7 @@
     "minimatch": "^5.1.2"
   },
   "devDependencies": {
-    "@backstage/cli": "^0.22.2",
+    "@backstage/cli": "^0.22.3",
     "eslint": "^8.33.0"
   }
 }

package/rules/no-undeclared-imports.js

@@ -151,11 +151,18 @@ module.exports = {
     }
 
     return visitImports(context, (node, imp) => {
-      if (imp.type !== 'external') {
+      // We leave checking of type imports to the repo-tools check,
+      // and we skip builtins and local imports
+      if (
+        imp.kind === 'type' ||
+        imp.type === 'builtin' ||
+        imp.type === 'local'
+      ) {
         return;
       }
-      // We leave checking of type imports to the repo-tools check
-      if (imp.kind === 'type') {
+
+      // We skip imports for the package itself
+      if (imp.packageName === localPkg.packageJson.name) {
         return;
       }
 

package/src/no-undeclared-imports.test.ts

@@ -236,5 +236,16 @@ ruleTester.run(RULE, rule, {
         ),
       ],
     },
+    {
+      code: `import '@internal/foo'`,
+      filename: joinPath(FIXTURE, 'packages/bar/src/index.ts'),
+      errors: [
+        ERR_UNDECLARED(
+          '@internal/foo',
+          'dependencies',
+          joinPath('packages', 'bar'),
+        ),
+      ],
+    },
   ],
 });