@backstage/core-app-api 1.10.1-next.1 → 1.11.0

package/CHANGELOG.md

@@ -1,5 +1,40 @@
 # @backstage/core-app-api
 
+## 1.11.0
+
+### Minor Changes
+
+- c9d9bfeca2: URL encode some well known unsafe characters in `RouteResolver` (and therefore `useRouteRef`)
+
+### Patch Changes
+
+- 29e4d8b76b: Fixed bug in `AppRouter` to determine the correct `signOutTargetUrl` if `app.baseUrl` contains a `basePath`
+- acca17e91a: Wrap entire app in `<Suspense>`, enabling support for using translations outside plugins.
+- 1a0616fa10: Add missing resource and template app icons
+- 9a1fce352e: Updated dependency `@testing-library/jest-dom` to `^6.0.0`.
+- f95af4e540: Updated dependency `@testing-library/dom` to `^9.0.0`.
+- f1b349cfba: Fixed a bug in `TranslationApi` implementation where in some cases it wouldn't notify subscribers of language changes.
+- Updated dependencies
+  - @backstage/core-plugin-api@1.7.0
+  - @backstage/version-bridge@1.0.6
+  - @backstage/config@1.1.1
+  - @backstage/types@1.1.1
+
+## 1.11.0-next.2
+
+### Minor Changes
+
+- c9d9bfeca2: URL encode some well known unsafe characters in `RouteResolver` (and therefore `useRouteRef`)
+
+### Patch Changes
+
+- acca17e91a: Wrap entire app in `<Suspense>`, enabling support for using translations outside plugins.
+- Updated dependencies
+  - @backstage/core-plugin-api@1.7.0-next.1
+  - @backstage/config@1.1.1-next.0
+  - @backstage/types@1.1.1
+  - @backstage/version-bridge@1.0.5
+
 ## 1.10.1-next.1
 
 ### Patch Changes

package/dist/index.esm.js

@@ -1,4 +1,4 @@
-import React, { useContext, createContext, useEffect, useState, Children, isValidElement, useMemo, useRef } from 'react';
+import React, { useContext, createContext, useEffect, useState, Children, isValidElement, useMemo, useRef, Suspense } from 'react';
 import PropTypes from 'prop-types';
 import { createVersionedContext, createVersionedValueMap, getOrCreateGlobalSingleton } from '@backstage/version-bridge';
 import ObservableImpl from 'zen-observable';
@@ -9,6 +9,7 @@ export { ConfigReader } from '@backstage/config';
 import { createRoutesFromChildren, Route, useLocation, matchRoutes, Routes, generatePath, useRoutes } from 'react-router-dom';
 import useAsync from 'react-use/lib/useAsync';
 import { appLanguageApiRef, translationApiRef } from '@backstage/core-plugin-api/alpha';
+import mapValues from 'lodash/mapValues';
 import useObservable from 'react-use/lib/useObservable';
 import { createInstance } from 'i18next';
 
@@ -2294,7 +2295,7 @@ function SignInPageWrapper({
 }) {
   const [identityApi, setIdentityApi] = useState();
   const configApi = useApi(configApiRef);
-  const basePath = getBasePath(configApi);
+  const basePath = readBasePath(configApi);
   if (!identityApi) {
     return /* @__PURE__ */ React.createElement(Component, { onSignInSuccess: setIdentityApi });
   }
@@ -2834,7 +2835,13 @@ class RouteResolver {
       this.routeObjects
     );
     const routeFunc = (...[params]) => {
-      return joinPaths(basePath, generatePath(targetPath, params));
+      const encodedParams = params && mapValues(params, (value) => {
+        if (typeof value === "string") {
+          return value.replaceAll(/[&?#;\/]/g, (c) => encodeURIComponent(c));
+        }
+        return value;
+      });
+      return joinPaths(basePath, generatePath(targetPath, encodedParams));
     };
     return routeFunc;
   }
@@ -3493,7 +3500,6 @@ const _I18nextTranslationApi = class _I18nextTranslationApi {
     __privateMethod(this, _registerDefaults, registerDefaults_fn).call(this, internalRef);
     return new ObservableImpl((subscriber) => {
       let loadTicket = {};
-      let lastSnapshotWasReady = false;
       const loadResource = () => {
         loadTicket = {};
         const ticket = loadTicket;
@@ -3501,8 +3507,7 @@ const _I18nextTranslationApi = class _I18nextTranslationApi {
           () => {
             if (ticket === loadTicket) {
               const snapshot = __privateMethod(this, _createSnapshot, createSnapshot_fn).call(this, internalRef);
-              if (snapshot.ready || lastSnapshotWasReady) {
-                lastSnapshotWasReady = snapshot.ready;
+              if (snapshot.ready) {
                 subscriber.next(snapshot);
               }
             }
@@ -3516,11 +3521,9 @@ const _I18nextTranslationApi = class _I18nextTranslationApi {
       };
       const onChange = () => {
         const snapshot = __privateMethod(this, _createSnapshot, createSnapshot_fn).call(this, internalRef);
-        if (lastSnapshotWasReady && !snapshot.ready) {
-          lastSnapshotWasReady = snapshot.ready;
+        if (snapshot.ready) {
           subscriber.next(snapshot);
-        }
-        if (!snapshot.ready) {
+        } else {
           loadResource();
         }
       };
@@ -3841,7 +3844,7 @@ class AppManager {
           }
         }
       }
-      const { ThemeProvider = AppThemeProvider } = this.components;
+      const { ThemeProvider = AppThemeProvider, Progress } = this.components;
       return /* @__PURE__ */ React.createElement(ApiProvider, { apis: this.getApiHolder() }, /* @__PURE__ */ React.createElement(AppContextProvider, { appContext }, /* @__PURE__ */ React.createElement(ThemeProvider, null, /* @__PURE__ */ React.createElement(
         RoutingProvider,
         {
@@ -3859,7 +3862,7 @@ class AppManager {
               appIdentityProxy: this.appIdentityProxy
             }
           },
-          children
+          /* @__PURE__ */ React.createElement(Suspense, { fallback: /* @__PURE__ */ React.createElement(Progress, null) }, children)
         )
       ))));
     };