@backstage/cli 0.30.1-next.0 → 0.31.0

package/CHANGELOG.md

@@ -1,5 +1,60 @@
 # @backstage/cli
 
+## 0.31.0
+
+### Minor Changes
+
+- 5b70679: **BREAKING**: ESLint warnings no longer trigger system exit codes like errors do.
+
+  Set the max number of warnings to `-1` during linting to enable the gradual adoption of new ESLint rules. To restore the previous behavior, include the `--max-warnings 0` flag in the `backstage-cli <repo|package> lint` command.
+
+### Patch Changes
+
+- 0586d4c: Internal change to move the `migrate` and `version:*` commands into a new migrate module.
+- e0b226b: build(deps): bump `esbuild` from 0.24.2 to 0.25.0
+- 4d45498: Fixed the package prepack command so that it no longer produces unnecessary `index` entries in the `typesVersions` map, which could cause `/index` to be added when automatically adding imports.
+- 485b3ba: Internal update to move `test` commands to a separate module.
+- a76c482: Internal change to migrate `lint` to the new module system.
+- 8df78bf: Internal update to move build commands to a CLI module.
+- d0fc357: Internal update to move `info` commands to a separate module.
+- f8bd342: Fix a bug in the translation of the deprecated `--scope` option for the `new` command that could cause plugins to have `backstage-backstage-plugin` in their name.
+- Updated dependencies
+  - @backstage/config-loader@1.10.0
+  - @backstage/integration@1.16.2
+  - @backstage/catalog-model@1.7.3
+  - @backstage/cli-common@0.1.15
+  - @backstage/cli-node@0.2.13
+  - @backstage/config@1.3.2
+  - @backstage/errors@1.2.7
+  - @backstage/eslint-plugin@0.1.10
+  - @backstage/release-manifests@0.0.12
+  - @backstage/types@1.2.1
+
+## 0.31.0-next.1
+
+### Minor Changes
+
+- 5b70679: **BREAKING**: ESLint warnings no longer trigger system exit codes like errors do.
+
+  Set the max number of warnings to `-1` during linting to enable the gradual adoption of new ESLint rules. To restore the previous behavior, include the `--max-warnings 0` flag in the `backstage-cli <repo|package> lint` command.
+
+### Patch Changes
+
+- e0b226b: build(deps): bump `esbuild` from 0.24.2 to 0.25.0
+- 4d45498: Fixed the package prepack command so that it no longer produces unnecessary `index` entries in the `typesVersions` map, which could cause `/index` to be added when automatically adding imports.
+- f8bd342: Fix a bug in the translation of the deprecated `--scope` option for the `new` command that could cause plugins to have `backstage-backstage-plugin` in their name.
+- Updated dependencies
+  - @backstage/config-loader@1.10.0-next.0
+  - @backstage/integration@1.16.2-next.0
+  - @backstage/catalog-model@1.7.3
+  - @backstage/cli-common@0.1.15
+  - @backstage/cli-node@0.2.13
+  - @backstage/config@1.3.2
+  - @backstage/errors@1.2.7
+  - @backstage/eslint-plugin@0.1.10
+  - @backstage/release-manifests@0.0.12
+  - @backstage/types@1.2.1
+
 ## 0.30.1-next.0
 
 ### Patch Changes

package/config/eslint-factory.js

@@ -95,7 +95,7 @@ function createConfig(dir, extraConfig = {}) {
       '@typescript-eslint/no-unused-expressions': 'error',
       '@typescript-eslint/consistent-type-assertions': 'error',
       '@typescript-eslint/no-unused-vars': [
-        'warn',
+        'error',
         {
           vars: 'all',
           args: 'after-used',
@@ -173,7 +173,7 @@ function createConfig(dir, extraConfig = {}) {
           'no-unused-vars': 'off',
           'unused-imports/no-unused-imports': 'error',
           'unused-imports/no-unused-vars': [
-            'warn',
+            'error',
             {
               vars: 'all',
               varsIgnorePattern: '^_',

package/dist/commands/index.cjs.js

@@ -6,28 +6,13 @@ var index$2 = require('../modules/build/index.cjs.js');
 var index$3 = require('../modules/info/index.cjs.js');
 var index$1 = require('../modules/migrate/index.cjs.js');
 var index$4 = require('../modules/test/index.cjs.js');
+var index$5 = require('../modules/lint/index.cjs.js');
 
 function registerRepoCommand(program) {
   const command = program.command("repo [command]").description("Command that run across an entire Backstage project");
   index$2.registerRepoCommands(command);
   index$4.registerRepoCommands(command);
-  command.command("lint").description("Lint all packages in the project").option(
-    "--format <format>",
-    "Lint report output format",
-    "eslint-formatter-friendly"
-  ).option(
-    "--output-file <path>",
-    "Write the lint report to a file instead of stdout"
-  ).option(
-    "--since <ref>",
-    "Only lint packages that changed since the specified ref"
-  ).option(
-    "--successCache",
-    "Enable success caching, which skips running tests for unchanged packages that were successful in the previous run"
-  ).option(
-    "--successCacheDir <path>",
-    "Set the success cache location, (default: node_modules/.cache/backstage-cli)"
-  ).option("--fix", "Attempt to automatically fix violations").action(lazy.lazy(() => import('./repo/lint.cjs.js'), "command"));
+  index$5.registerRepoCommands(command);
   command.command("fix").description("Automatically fix packages in the project").option(
     "--publish",
     "Enable additional fixes that only apply when publishing packages"
@@ -46,17 +31,7 @@ function registerScriptCommand(program) {
   ).option("--require <path>", "Add a --require argument to the node process").option("--link <path>", "Link an external workspace for module resolution").action(lazy.lazy(() => import('./start/index.cjs.js'), "command"));
   index$2.registerPackageCommands(command);
   index$4.registerPackageCommands(command);
-  command.command("lint [directories...]").option(
-    "--format <format>",
-    "Lint report output format",
-    "eslint-formatter-friendly"
-  ).option(
-    "--output-file <path>",
-    "Write the lint report to a file instead of stdout"
-  ).option("--fix", "Attempt to automatically fix violations").option(
-    "--max-warnings <number>",
-    "Fail if more than this number of warnings. -1 allows warnings. (default: 0)"
-  ).description("Lint a package").action(lazy.lazy(() => import('./lint.cjs.js'), "default"));
+  index$5.registerPackageCommands(command);
   command.command("clean").description("Delete cache directories").action(lazy.lazy(() => import('./clean/clean.cjs.js'), "default"));
   command.command("prepack").description("Prepares a package for packaging before publishing").action(lazy.lazy(() => import('./pack.cjs.js'), "pre"));
   command.command("postpack").description("Restores the changes made by the prepack command").action(lazy.lazy(() => import('./pack.cjs.js'), "post"));

package/dist/commands/new/new.cjs.js

@@ -17,8 +17,7 @@ var _new = async (opts) => {
   let pluginInfix = void 0;
   let packagePrefix = void 0;
   if (scope) {
-    const backstagePrefix = scope.startsWith("backstage") ? "" : "backstage-";
-    packagePrefix = scope.includes("/") ? `@${scope}${backstagePrefix}` : `@${scope}/${backstagePrefix}`;
+    packagePrefix = scope.includes("/") ? `@${scope}` : `@${scope}/`;
     pluginInfix = scope.includes("backstage") ? "plugin-" : "backstage-plugin-";
   }
   if (isPrivate === false || // set to false with --no-private flag

package/dist/modules/build/lib/packager/productionPack.cjs.js

@@ -88,7 +88,7 @@ async function rewriteEntryPoints(pkg, packageDir, featureDetectionProject) {
   const outputExports = {};
   const entryPoints$1 = entryPoints.readEntryPoints(pkg);
   if (pkg.typesVersions) {
-    pkg.typesVersions = { "*": {} };
+    pkg.typesVersions = void 0;
   }
   for (const entryPoint of entryPoints$1) {
     if (!SCRIPT_EXTS.includes(entryPoint.ext)) {
@@ -106,9 +106,8 @@ async function rewriteEntryPoints(pkg, packageDir, featureDetectionProject) {
       if (!pkg.typesVersions) {
         pkg.typesVersions = { "*": {} };
       }
-      pkg.typesVersions["*"][entryPoint.name] = [
-        `dist/${entryPoint.name}.d.ts`
-      ];
+      const mount = entryPoint.name === "index" ? "*" : entryPoint.name;
+      pkg.typesVersions["*"][mount] = [`dist/${entryPoint.name}.d.ts`];
     }
     exp.default = exp.require ?? exp.import;
     if (exp.types && featureDetectionProject) {
@@ -140,6 +139,12 @@ async function rewriteEntryPoints(pkg, packageDir, featureDetectionProject) {
       outputExports[entryPoint.mount] = exp;
     }
   }
+  if (pkg.typesVersions?.["*"]) {
+    const keys = Object.keys(pkg.typesVersions["*"]);
+    if (keys.length === 1 && keys[0] === "*") {
+      delete pkg.typesVersions;
+    }
+  }
   if (pkg.exports) {
     pkg.exports = outputExports;
     pkg.exports["./package.json"] = "./package.json";

package/dist/{commands → modules/lint/commands/package}/lint.cjs.js

@@ -3,7 +3,7 @@
 Object.defineProperty(exports, '__esModule', { value: true });
 
 var fs = require('fs-extra');
-var paths = require('../lib/paths.cjs.js');
+var paths = require('../../../../lib/paths.cjs.js');
 var eslint = require('eslint');
 
 function _interopDefaultCompat (e) { return e && typeof e === 'object' && 'default' in e ? e : { default: e }; }
@@ -19,7 +19,7 @@ var lint = async (directories, opts) => {
   const results = await eslint$1.lintFiles(
     directories.length ? directories : ["."]
   );
-  const maxWarnings = opts.maxWarnings ?? 0;
+  const maxWarnings = opts.maxWarnings ?? -1;
   const ignoreWarnings = +maxWarnings === -1;
   const failed = results.some((r) => r.errorCount > 0) || !ignoreWarnings && results.reduce((current, next) => current + next.warningCount, 0) > maxWarnings;
   if (opts.fix) {

package/dist/{commands → modules/lint/commands}/repo/lint.cjs.js

@@ -5,10 +5,10 @@ var fs = require('fs-extra');
 var crypto = require('crypto');
 var path = require('path');
 var cliNode = require('@backstage/cli-node');
-var paths = require('../../lib/paths.cjs.js');
-var parallel = require('../../lib/parallel.cjs.js');
-var optionsParser = require('./optionsParser.cjs.js');
-var SuccessCache = require('../../lib/cache/SuccessCache.cjs.js');
+var paths = require('../../../../lib/paths.cjs.js');
+var parallel = require('../../../../lib/parallel.cjs.js');
+var optionsParser = require('../../../../commands/repo/optionsParser.cjs.js');
+var SuccessCache = require('../../../../lib/cache/SuccessCache.cjs.js');
 
 function _interopDefaultCompat (e) { return e && typeof e === 'object' && 'default' in e ? e : { default: e }; }
 

package/dist/modules/lint/index.cjs.js

@@ -0,0 +1,40 @@
+'use strict';
+
+var lazy = require('../../lib/lazy.cjs.js');
+
+function registerPackageCommands(command) {
+  command.command("lint [directories...]").option(
+    "--format <format>",
+    "Lint report output format",
+    "eslint-formatter-friendly"
+  ).option(
+    "--output-file <path>",
+    "Write the lint report to a file instead of stdout"
+  ).option("--fix", "Attempt to automatically fix violations").option(
+    "--max-warnings <number>",
+    "Fail if more than this number of warnings. -1 allows warnings. (default: 0)"
+  ).description("Lint a package").action(lazy.lazy(() => import('./commands/package/lint.cjs.js'), "default"));
+}
+function registerRepoCommands(command) {
+  command.command("lint").description("Lint all packages in the project").option(
+    "--format <format>",
+    "Lint report output format",
+    "eslint-formatter-friendly"
+  ).option(
+    "--output-file <path>",
+    "Write the lint report to a file instead of stdout"
+  ).option(
+    "--since <ref>",
+    "Only lint packages that changed since the specified ref"
+  ).option(
+    "--successCache",
+    "Enable success caching, which skips running tests for unchanged packages that were successful in the previous run"
+  ).option(
+    "--successCacheDir <path>",
+    "Set the success cache location, (default: node_modules/.cache/backstage-cli)"
+  ).option("--fix", "Attempt to automatically fix violations").action(lazy.lazy(() => import('./commands/repo/lint.cjs.js'), "command"));
+}
+
+exports.registerPackageCommands = registerPackageCommands;
+exports.registerRepoCommands = registerRepoCommands;
+//# sourceMappingURL=index.cjs.js.map

package/dist/packages/backend-defaults/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "0.8.2-next.1";
+var version = "0.8.2";
 
 exports.version = version;
 //# sourceMappingURL=package.json.cjs.js.map

package/dist/packages/backend-plugin-api/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "1.2.1-next.1";
+var version = "1.2.1";
 
 exports.version = version;
 //# sourceMappingURL=package.json.cjs.js.map

package/dist/packages/backend-test-utils/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "1.3.1-next.1";
+var version = "1.3.1";
 
 exports.version = version;
 //# sourceMappingURL=package.json.cjs.js.map

package/dist/packages/cli/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "0.30.1-next.0";
+var version = "0.31.0";
 var dependencies = {
 	"@backstage/catalog-model": "workspace:^",
 	"@backstage/cli-common": "workspace:^",
@@ -50,7 +50,7 @@ var dependencies = {
 	"cross-spawn": "^7.0.3",
 	"css-loader": "^6.5.1",
 	"ctrlc-windows": "^2.1.0",
-	esbuild: "^0.24.0",
+	esbuild: "^0.25.0",
 	"esbuild-loader": "^4.0.0",
 	eslint: "^8.6.0",
 	"eslint-config-prettier": "^9.0.0",

package/dist/packages/core-app-api/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "1.15.5";
+var version = "1.16.0";
 
 exports.version = version;
 //# sourceMappingURL=package.json.cjs.js.map

package/dist/packages/core-components/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "0.16.5-next.0";
+var version = "0.17.0";
 
 exports.version = version;
 //# sourceMappingURL=package.json.cjs.js.map

package/dist/packages/core-plugin-api/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "1.10.4";
+var version = "1.10.5";
 
 exports.version = version;
 //# sourceMappingURL=package.json.cjs.js.map

package/dist/packages/dev-utils/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "1.1.8-next.1";
+var version = "1.1.8";
 
 exports.version = version;
 //# sourceMappingURL=package.json.cjs.js.map

package/dist/packages/test-utils/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "1.7.5";
+var version = "1.7.6";
 
 exports.version = version;
 //# sourceMappingURL=package.json.cjs.js.map

package/dist/plugins/auth-backend/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "0.24.4-next.1";
+var version = "0.24.4";
 
 exports.version = version;
 //# sourceMappingURL=package.json.cjs.js.map

package/dist/plugins/auth-backend-module-guest-provider/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "0.2.6-next.1";
+var version = "0.2.6";
 
 exports.version = version;
 //# sourceMappingURL=package.json.cjs.js.map

package/dist/plugins/catalog-node/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "1.16.1-next.1";
+var version = "1.16.1";
 
 exports.version = version;
 //# sourceMappingURL=package.json.cjs.js.map

package/dist/plugins/scaffolder-node/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "0.7.1-next.1";
+var version = "0.8.0";
 
 exports.version = version;
 //# sourceMappingURL=package.json.cjs.js.map

package/dist/plugins/scaffolder-node-test-utils/package.json.cjs.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var version = "0.1.20-next.1";
+var version = "0.2.0";
 
 exports.version = version;
 //# sourceMappingURL=package.json.cjs.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@backstage/cli",
-  "version": "0.30.1-next.0",
+  "version": "0.31.0",
   "description": "CLI for developing Backstage plugins and apps",
   "backstage": {
     "role": "cli"
@@ -47,16 +47,16 @@
     ]
   },
   "dependencies": {
-    "@backstage/catalog-model": "1.7.3",
-    "@backstage/cli-common": "0.1.15",
-    "@backstage/cli-node": "0.2.13",
-    "@backstage/config": "1.3.2",
-    "@backstage/config-loader": "1.9.6",
-    "@backstage/errors": "1.2.7",
-    "@backstage/eslint-plugin": "0.1.10",
-    "@backstage/integration": "1.16.1",
-    "@backstage/release-manifests": "0.0.12",
-    "@backstage/types": "1.2.1",
+    "@backstage/catalog-model": "^1.7.3",
+    "@backstage/cli-common": "^0.1.15",
+    "@backstage/cli-node": "^0.2.13",
+    "@backstage/config": "^1.3.2",
+    "@backstage/config-loader": "^1.10.0",
+    "@backstage/errors": "^1.2.7",
+    "@backstage/eslint-plugin": "^0.1.10",
+    "@backstage/integration": "^1.16.2",
+    "@backstage/release-manifests": "^0.0.12",
+    "@backstage/types": "^1.2.1",
     "@manypkg/get-packages": "^1.1.3",
     "@module-federation/enhanced": "^0.8.0",
     "@octokit/graphql": "^5.0.0",
@@ -95,7 +95,7 @@
     "cross-spawn": "^7.0.3",
     "css-loader": "^6.5.1",
     "ctrlc-windows": "^2.1.0",
-    "esbuild": "^0.24.0",
+    "esbuild": "^0.25.0",
     "esbuild-loader": "^4.0.0",
     "eslint": "^8.6.0",
     "eslint-config-prettier": "^9.0.0",
@@ -163,22 +163,22 @@
     "zod-validation-error": "^3.4.0"
   },
   "devDependencies": {
-    "@backstage/backend-plugin-api": "1.2.1-next.1",
-    "@backstage/backend-test-utils": "1.3.1-next.1",
-    "@backstage/catalog-client": "1.9.1",
-    "@backstage/config": "1.3.2",
-    "@backstage/core-app-api": "1.15.5",
-    "@backstage/core-components": "0.16.5-next.0",
-    "@backstage/core-plugin-api": "1.10.4",
-    "@backstage/dev-utils": "1.1.8-next.1",
-    "@backstage/errors": "1.2.7",
-    "@backstage/plugin-auth-backend": "0.24.4-next.1",
-    "@backstage/plugin-auth-backend-module-guest-provider": "0.2.6-next.1",
-    "@backstage/plugin-catalog-node": "1.16.1-next.1",
-    "@backstage/plugin-scaffolder-node": "0.7.1-next.1",
-    "@backstage/plugin-scaffolder-node-test-utils": "0.1.20-next.1",
-    "@backstage/test-utils": "1.7.5",
-    "@backstage/theme": "0.6.4",
+    "@backstage/backend-plugin-api": "^1.2.1",
+    "@backstage/backend-test-utils": "^1.3.1",
+    "@backstage/catalog-client": "^1.9.1",
+    "@backstage/config": "^1.3.2",
+    "@backstage/core-app-api": "^1.16.0",
+    "@backstage/core-components": "^0.17.0",
+    "@backstage/core-plugin-api": "^1.10.5",
+    "@backstage/dev-utils": "^1.1.8",
+    "@backstage/errors": "^1.2.7",
+    "@backstage/plugin-auth-backend": "^0.24.4",
+    "@backstage/plugin-auth-backend-module-guest-provider": "^0.2.6",
+    "@backstage/plugin-catalog-node": "^1.16.1",
+    "@backstage/plugin-scaffolder-node": "^0.8.0",
+    "@backstage/plugin-scaffolder-node-test-utils": "^0.2.0",
+    "@backstage/test-utils": "^1.7.6",
+    "@backstage/theme": "^0.6.4",
     "@rspack/core": "^1.0.10",
     "@rspack/dev-server": "^1.0.9",
     "@rspack/plugin-react-refresh": "^1.0.0",

package/templates/frontend-plugin/src/components/ExampleFetchComponent/ExampleFetchComponent.test.tsx.hbs

@@ -1,19 +1,20 @@
 import React from 'react';
-import { render, screen } from '@testing-library/react';
+import { renderInTestApp } from '@backstage/test-utils';
 import { ExampleFetchComponent } from './ExampleFetchComponent';
 
 describe('ExampleFetchComponent', () => {
   it('renders the user table', async () => {
-    render(<ExampleFetchComponent />);
+    const { getAllByText, getByAltText, getByText, findByRole } =
+      await renderInTestApp(<ExampleFetchComponent />);
 
     // Wait for the table to render
-    const table = await screen.findByRole('table');
-    const nationality = screen.getAllByText('GB');
+    const table = await findByRole('table');
+    const nationality = getAllByText('GB');
     // Assert that the table contains the expected user data
     expect(table).toBeInTheDocument();
-    expect(screen.getByAltText('Carolyn')).toBeInTheDocument();
-    expect(screen.getByText('Carolyn Moore')).toBeInTheDocument();
-    expect(screen.getByText('carolyn.moore@example.com')).toBeInTheDocument();
+    expect(getByAltText('Carolyn')).toBeInTheDocument();
+    expect(getByText('Carolyn Moore')).toBeInTheDocument();
+    expect(getByText('carolyn.moore@example.com')).toBeInTheDocument();
     expect(nationality[0]).toBeInTheDocument();
   });
 });