@babylonjs/core 7.15.2 → 7.16.1

package/Engines/nativeEngine.d.ts

@@ -81,6 +81,7 @@ export declare class NativeEngine extends Engine {
     private _zOffset;
     private _zOffsetUnits;
     private _depthWrite;
+    private _fillModeWarningDisplayed;
     setHardwareScalingLevel(level: number): void;
     constructor(options?: NativeEngineOptions);
     dispose(): void;
@@ -122,6 +123,12 @@ export declare class NativeEngine extends Engine {
     bindVertexArrayObject(vertexArray: WebGLVertexArrayObject): void;
     releaseVertexArrayObject(vertexArray: WebGLVertexArrayObject): void;
     getAttributes(pipelineContext: IPipelineContext, attributesNames: string[]): number[];
+    /**
+     * Triangle Fan and Line Loop are not supported by modern rendering API
+     * @param fillMode  defines the primitive to use
+     * @returns true if supported
+     */
+    private _checkSupportedFillMode;
     /**
      * Draw a list of indexed primitives
      * @param fillMode defines the primitive to use

package/Engines/nativeEngine.js

@@ -144,6 +144,8 @@ export class NativeEngine extends Engine {
         this._zOffset = 0;
         this._zOffsetUnits = 0;
         this._depthWrite = true;
+        // warning for non supported fill mode has already been displayed
+        this._fillModeWarningDisplayed = false;
         if (_native.Engine.PROTOCOL_VERSION !== NativeEngine.PROTOCOL_VERSION) {
             throw new Error(`Protocol version mismatch: ${_native.Engine.PROTOCOL_VERSION} (Native) !== ${NativeEngine.PROTOCOL_VERSION} (JS)`);
         }
@@ -470,6 +472,21 @@ export class NativeEngine extends Engine {
         }
         return this._engine.getAttributes(nativePipelineContext.program, remappedAttributesNames);
     }
+    /**
+     * Triangle Fan and Line Loop are not supported by modern rendering API
+     * @param fillMode  defines the primitive to use
+     * @returns true if supported
+     */
+    _checkSupportedFillMode(fillMode) {
+        if (fillMode == 5 || fillMode == 8) {
+            if (!this._fillModeWarningDisplayed) {
+                Logger.Warn("Line Loop and Triangle Fan are not supported fill modes with Babylon Native. Elements with these fill mode will not be visible.");
+                this._fillModeWarningDisplayed = true;
+            }
+            return false;
+        }
+        return true;
+    }
     /**
      * Draw a list of indexed primitives
      * @param fillMode defines the primitive to use
@@ -478,6 +495,9 @@ export class NativeEngine extends Engine {
      * @param instancesCount defines the number of instances to draw (if instantiation is enabled)
      */
     drawElementsType(fillMode, indexStart, indexCount, instancesCount) {
+        if (!this._checkSupportedFillMode(fillMode)) {
+            return;
+        }
         // Apply states
         this._drawCalls.addCount(1, false);
         if (instancesCount && _native.Engine.COMMAND_DRAWINDEXEDINSTANCED) {
@@ -504,6 +524,9 @@ export class NativeEngine extends Engine {
      * @param instancesCount defines the number of instances to draw (if instantiation is enabled)
      */
     drawArraysType(fillMode, verticesStart, verticesCount, instancesCount) {
+        if (!this._checkSupportedFillMode(fillMode)) {
+            return;
+        }
         // Apply states
         this._drawCalls.addCount(1, false);
         if (instancesCount && _native.Engine.COMMAND_DRAWINSTANCED) {
@@ -701,7 +724,7 @@ export class NativeEngine extends Engine {
         this._commandBufferEncoder.encodeCommandArgAsUInt32(culling ? 1 : 0);
         this._commandBufferEncoder.encodeCommandArgAsFloat32(zOffset);
         this._commandBufferEncoder.encodeCommandArgAsFloat32(zOffsetUnits);
-        this._commandBufferEncoder.encodeCommandArgAsUInt32(this.cullBackFaces ?? cullBackFaces ?? true ? 1 : 0);
+        this._commandBufferEncoder.encodeCommandArgAsUInt32((this.cullBackFaces ?? cullBackFaces ?? true) ? 1 : 0);
         this._commandBufferEncoder.encodeCommandArgAsUInt32(reverseSide ? 1 : 0);
         this._commandBufferEncoder.finishEncodingCommand();
     }