@babylonjs/core 6.34.1 → 6.34.2

package/Engines/webgpuEngine.js

@@ -433,7 +433,7 @@ export class WebGPUEngine extends Engine {
             if (this.dbgVerboseLogsForFirstFrames) {
                 if (this._count === undefined) {
                     this._count = 0;
-                    console.log("%c frame #" + this._count + " - begin", "background: #ffff00");
+                    Logger.Log(["%c frame #" + this._count + " - begin", "background: #ffff00"]);
                 }
             }
             this._uploadEncoder = this._device.createCommandEncoder(this._uploadEncoderDescriptor);
@@ -458,11 +458,11 @@ export class WebGPUEngine extends Engine {
             this.resize();
         })
             .catch((e) => {
+            var _a;
             Logger.Error("Can not create WebGPU Device and/or context.");
             Logger.Error(e);
-            if (console.trace) {
-                console.trace();
-            }
+            // eslint-disable-next-line no-console
+            (_a = console === null || console === void 0 ? void 0 : console.trace) === null || _a === void 0 ? void 0 : _a.call(console);
         });
     }
     _initGlslang(glslangOptions) {
@@ -692,7 +692,7 @@ export class WebGPUEngine extends Engine {
                 this._count = 0;
             }
             if (!this._count || this._count < this.dbgVerboseLogsNumFrames) {
-                console.log("frame #" + this._count + " - setSize -", width, height);
+                Logger.Log(["frame #" + this._count + " - setSize -", width, height]);
             }
         }
         this._initializeMainAttachments();
@@ -817,7 +817,14 @@ export class WebGPUEngine extends Engine {
                 this._count = 0;
             }
             if (!this._count || this._count < this.dbgVerboseLogsNumFrames) {
-                console.log("frame #" + this._count + " - viewport applied - (", this._viewportCached.x, this._viewportCached.y, this._viewportCached.z, this._viewportCached.w, ") current pass is main pass=" + this._currentPassIsMainPass());
+                Logger.Log([
+                    "frame #" + this._count + " - viewport applied - (",
+                    this._viewportCached.x,
+                    this._viewportCached.y,
+                    this._viewportCached.z,
+                    this._viewportCached.w,
+                    ") current pass is main pass=" + this._currentPassIsMainPass(),
+                ]);
             }
         }
     }
@@ -854,7 +861,14 @@ export class WebGPUEngine extends Engine {
                 this._count = 0;
             }
             if (!this._count || this._count < this.dbgVerboseLogsNumFrames) {
-                console.log("frame #" + this._count + " - scissor applied - (", this._scissorCached.x, this._scissorCached.y, this._scissorCached.z, this._scissorCached.w, ") current pass is main pass=" + this._currentPassIsMainPass());
+                Logger.Log([
+                    "frame #" + this._count + " - scissor applied - (",
+                    this._scissorCached.x,
+                    this._scissorCached.y,
+                    this._scissorCached.z,
+                    this._scissorCached.w,
+                    ") current pass is main pass=" + this._currentPassIsMainPass(),
+                ]);
             }
         }
     }
@@ -933,7 +947,7 @@ export class WebGPUEngine extends Engine {
                 this._count = 0;
             }
             if (!this._count || this._count < this.dbgVerboseLogsNumFrames) {
-                console.log("frame #" + this._count + " - clear - backBuffer=", backBuffer, " depth=", depth, " stencil=", stencil, " scissor is active=", hasScissor);
+                Logger.Log(["frame #" + this._count + " - clear - backBuffer=", backBuffer, " depth=", depth, " stencil=", stencil, " scissor is active=", hasScissor]);
             }
         }
         // We need to recreate the render pass so that the new parameters for clear color / depth / stencil are taken into account
@@ -1257,10 +1271,10 @@ export class WebGPUEngine extends Engine {
         const webGpuContext = pipelineContext;
         const shaderLanguage = webGpuContext.shaderProcessingContext.shaderLanguage;
         if (this.dbgShowShaderCode) {
-            console.log(defines);
-            console.log(vertexSourceCode);
-            console.log(fragmentSourceCode);
-            console.log("***********************************************");
+            Logger.Log(["defines", defines]);
+            Logger.Log(vertexSourceCode);
+            Logger.Log(fragmentSourceCode);
+            Logger.Log("***********************************************");
         }
         webGpuContext.sources = {
             fragment: fragmentSourceCode,
@@ -1319,7 +1333,7 @@ export class WebGPUEngine extends Engine {
                 effect.drawContext === this._currentDrawContext &&
                 !this._forceEnableEffect)) {
             if (!effect.effect && this.dbgShowEmptyEnableEffectCalls) {
-                console.error("drawWrapper=", effect);
+                Logger.Log(["drawWrapper=", effect]);
                 throw "Invalid call to enableEffect: the effect property is empty!";
             }
             return;
@@ -1331,7 +1345,7 @@ export class WebGPUEngine extends Engine {
             this._currentDrawContext = effect.drawContext;
             this._counters.numEnableDrawWrapper++;
             if (!this._currentMaterialContext) {
-                console.error("drawWrapper=", effect);
+                Logger.Log(["drawWrapper=", effect]);
                 throw `Invalid call to enableEffect: the materialContext property is empty!`;
             }
         }
@@ -1708,7 +1722,7 @@ export class WebGPUEngine extends Engine {
                     this._count = 0;
                 }
                 if (!this._count || this._count < this.dbgVerboseLogsNumFrames) {
-                    console.log("frame #" + this._count + " - _setTexture called with a null _currentEffect! texture=", texture);
+                    Logger.Log(["frame #" + this._count + " - _setTexture called with a null _currentEffect! texture=", texture]);
                 }
             }
         }
@@ -1758,7 +1772,7 @@ export class WebGPUEngine extends Engine {
                 this._count = 0;
             }
             if (!this._count || this._count < this.dbgVerboseLogsNumFrames) {
-                console.log("frame #" +
+                Logger.Log("frame #" +
                     this._count +
                     " - generate mipmaps - width=" +
                     texture.width +
@@ -1911,7 +1925,7 @@ export class WebGPUEngine extends Engine {
                     for (const name in UniformBuffer._UpdatedUbosInFrame) {
                         list.push(name + ":" + UniformBuffer._UpdatedUbosInFrame[name]);
                     }
-                    console.log("frame #" + this._count + " - updated ubos -", list.join(", "));
+                    Logger.Log(["frame #" + this._count + " - updated ubos -", list.join(", ")]);
                 }
             }
             UniformBuffer._UpdatedUbosInFrame = {};
@@ -1933,12 +1947,12 @@ export class WebGPUEngine extends Engine {
                 this._count = 0;
             }
             if (this._count < this.dbgVerboseLogsNumFrames) {
-                console.log("%c frame #" + this._count + " - end", "background: #ffff00");
+                Logger.Log(["%c frame #" + this._count + " - end", "background: #ffff00"]);
             }
             if (this._count < this.dbgVerboseLogsNumFrames) {
                 this._count++;
                 if (this._count !== this.dbgVerboseLogsNumFrames) {
-                    console.log("%c frame #" + this._count + " - begin", "background: #ffff00");
+                    Logger.Log(["%c frame #" + this._count + " - begin", "background: #ffff00"]);
                 }
             }
         }
@@ -1952,10 +1966,6 @@ export class WebGPUEngine extends Engine {
         this._commandBuffers[0] = this._uploadEncoder.finish();
         this._commandBuffers[1] = this._renderEncoder.finish();
         this._device.queue.submit(this._commandBuffers);
-        // Now that the command buffers have been submitted, we can reset the ubo as we can reuse the same GPU buffer(s)
-        for (let i = 0; i < this._uniformBuffers.length; ++i) {
-            this._uniformBuffers[i]._checkNewFrame(true);
-        }
         this._uploadEncoder = this._device.createCommandEncoder(this._uploadEncoderDescriptor);
         this._renderEncoder = this._device.createCommandEncoder(this._renderEncoderDescriptor);
         this._timestampQuery.startFrame(this._uploadEncoder);
@@ -2075,18 +2085,22 @@ export class WebGPUEngine extends Engine {
             }
             if (!this._count || this._count < this.dbgVerboseLogsNumFrames) {
                 const internalTexture = rtWrapper.texture;
-                console.log("frame #" +
-                    this._count +
-                    " - render target begin pass - rtt name=" +
-                    renderTargetWrapper.label +
-                    ", internalTexture.uniqueId=" +
-                    internalTexture.uniqueId +
-                    ", width=" +
-                    internalTexture.width +
-                    ", height=" +
-                    internalTexture.height +
-                    ", setClearStates=" +
-                    setClearStates, "renderPassDescriptor=", this._rttRenderPassWrapper.renderPassDescriptor);
+                Logger.Log([
+                    "frame #" +
+                        this._count +
+                        " - render target begin pass - rtt name=" +
+                        renderTargetWrapper.label +
+                        ", internalTexture.uniqueId=" +
+                        internalTexture.uniqueId +
+                        ", width=" +
+                        internalTexture.width +
+                        ", height=" +
+                        internalTexture.height +
+                        ", setClearStates=" +
+                        setClearStates,
+                    "renderPassDescriptor=",
+                    this._rttRenderPassWrapper.renderPassDescriptor,
+                ]);
             }
         }
         (_h = this._debugFlushPendingCommands) === null || _h === void 0 ? void 0 : _h.call(this);
@@ -2135,7 +2149,12 @@ export class WebGPUEngine extends Engine {
                 this._count = 0;
             }
             if (!this._count || this._count < this.dbgVerboseLogsNumFrames) {
-                console.log("frame #" + this._count + " - main begin pass - texture width=" + this._mainTextureExtends.width, " height=" + this._mainTextureExtends.height + ", setClearStates=" + setClearStates, "renderPassDescriptor=", this._mainRenderPassWrapper.renderPassDescriptor);
+                Logger.Log([
+                    "frame #" + this._count + " - main begin pass - texture width=" + this._mainTextureExtends.width,
+                    " height=" + this._mainTextureExtends.height + ", setClearStates=" + setClearStates,
+                    "renderPassDescriptor=",
+                    this._mainRenderPassWrapper.renderPassDescriptor,
+                ]);
             }
         }
         (_b = this._debugPushGroup) === null || _b === void 0 ? void 0 : _b.call(this, "main pass", 0);
@@ -2165,7 +2184,7 @@ export class WebGPUEngine extends Engine {
                 this._count = 0;
             }
             if (!this._count || this._count < this.dbgVerboseLogsNumFrames) {
-                console.log("frame #" +
+                Logger.Log("frame #" +
                     this._count +
                     " - " +
                     (currentPassIndex === 2 ? "main" : "render target") +
@@ -2226,18 +2245,24 @@ export class WebGPUEngine extends Engine {
                 this._count = 0;
             }
             if (!this._count || this._count < this.dbgVerboseLogsNumFrames) {
-                console.log("frame #" +
-                    this._count +
-                    " - bindFramebuffer - rtt name=" +
-                    texture.label +
-                    ", internalTexture.uniqueId=" +
-                    ((_b = texture.texture) === null || _b === void 0 ? void 0 : _b.uniqueId) +
-                    ", face=" +
-                    faceIndex +
-                    ", lodLevel=" +
-                    lodLevel +
-                    ", layer=" +
-                    layer, "colorAttachmentViewDescriptor=", this._rttRenderPassWrapper.colorAttachmentViewDescriptor, "depthAttachmentViewDescriptor=", this._rttRenderPassWrapper.depthAttachmentViewDescriptor);
+                Logger.Log([
+                    "frame #" +
+                        this._count +
+                        " - bindFramebuffer - rtt name=" +
+                        texture.label +
+                        ", internalTexture.uniqueId=" +
+                        ((_b = texture.texture) === null || _b === void 0 ? void 0 : _b.uniqueId) +
+                        ", face=" +
+                        faceIndex +
+                        ", lodLevel=" +
+                        lodLevel +
+                        ", layer=" +
+                        layer,
+                    "colorAttachmentViewDescriptor=",
+                    this._rttRenderPassWrapper.colorAttachmentViewDescriptor,
+                    "depthAttachmentViewDescriptor=",
+                    this._rttRenderPassWrapper.depthAttachmentViewDescriptor,
+                ]);
             }
         }
         // We don't create the render pass just now, we do a lazy creation of the render pass, hoping the render pass will be created by a call to clear()...
@@ -2285,7 +2310,7 @@ export class WebGPUEngine extends Engine {
                 this._count = 0;
             }
             if (!this._count || this._count < this.dbgVerboseLogsNumFrames) {
-                console.log("frame #" + this._count + " - unBindFramebuffer - rtt name=" + texture.label + ", internalTexture.uniqueId=", (_b = texture.texture) === null || _b === void 0 ? void 0 : _b.uniqueId);
+                Logger.Log("frame #" + this._count + " - unBindFramebuffer - rtt name=" + texture.label + ", internalTexture.uniqueId=", (_b = texture.texture) === null || _b === void 0 ? void 0 : _b.uniqueId);
             }
         }
         this._mrtAttachments = [];