@babylonjs/core 5.47.0 → 5.48.0

package/Engines/engine.d.ts

@@ -428,10 +428,8 @@ export declare class Engine extends ThinEngine {
     /**
      * Shared initialization across engines types.
      * @param canvas The canvas associated with this instance of the engine.
-     * @param doNotHandleTouchAction Defines that engine should ignore modifying touch action attribute and style
-     * @param audioEngine Defines if an audio engine should be created by default
      */
-    protected _sharedInit(canvas: HTMLCanvasElement, doNotHandleTouchAction: boolean, audioEngine: boolean): void;
+    protected _sharedInit(canvas: HTMLCanvasElement): void;
     /**
      * Gets current aspect ratio
      * @param viewportOwner defines the camera to use to get the aspect ratio

package/Engines/engine.js

@@ -258,34 +258,8 @@ export class Engine extends ThinEngine {
         options = this._creationOptions;
         if (canvasOrContext.getContext) {
             const canvas = canvasOrContext;
-            this._sharedInit(canvas, !!options.doNotHandleTouchAction, options.audioEngine);
-            if (IsDocumentAvailable()) {
-                // Fullscreen
-                this._onFullscreenChange = () => {
-                    this.isFullscreen = !!document.fullscreenElement;
-                    // Pointer lock
-                    if (this.isFullscreen && this._pointerLockRequested && canvas) {
-                        Engine._RequestPointerlock(canvas);
-                    }
-                };
-                document.addEventListener("fullscreenchange", this._onFullscreenChange, false);
-                document.addEventListener("webkitfullscreenchange", this._onFullscreenChange, false);
-                // Pointer lock
-                this._onPointerLockChange = () => {
-                    this.isPointerLock = document.pointerLockElement === canvas;
-                };
-                document.addEventListener("pointerlockchange", this._onPointerLockChange, false);
-                document.addEventListener("webkitpointerlockchange", this._onPointerLockChange, false);
-                // Create Audio Engine if needed.
-                if (!Engine.audioEngine && options.audioEngine && Engine.AudioEngineFactory) {
-                    Engine.audioEngine = Engine.AudioEngineFactory(this.getRenderingCanvas(), this.getAudioContext(), this.getAudioDestination());
-                }
-            }
+            this._sharedInit(canvas);
             this._connectVREvents();
-            this.enableOfflineSupport = Engine.OfflineProviderFactory !== undefined;
-            this._deterministicLockstep = !!options.deterministicLockstep;
-            this._lockstepMaxSteps = options.lockstepMaxSteps || 0;
-            this._timeStep = options.timeStep || 1 / 60;
         }
         // Load WebVR Devices
         this._prepareVRComponent();
@@ -300,11 +274,9 @@ export class Engine extends ThinEngine {
     /**
      * Shared initialization across engines types.
      * @param canvas The canvas associated with this instance of the engine.
-     * @param doNotHandleTouchAction Defines that engine should ignore modifying touch action attribute and style
-     * @param audioEngine Defines if an audio engine should be created by default
      */
-    _sharedInit(canvas, doNotHandleTouchAction, audioEngine) {
-        super._sharedInit(canvas, doNotHandleTouchAction, audioEngine);
+    _sharedInit(canvas) {
+        super._sharedInit(canvas);
         this._onCanvasFocus = () => {
             this.onCanvasFocusObservable.notifyObservers(this);
         };
@@ -344,13 +316,35 @@ export class Engine extends ThinEngine {
             hostWindow.addEventListener("focus", this._onFocus);
         }
         canvas.addEventListener("pointerout", this._onCanvasPointerOut);
-        if (!doNotHandleTouchAction) {
+        if (!this._creationOptions.doNotHandleTouchAction) {
             this._disableTouchAction();
         }
         // Create Audio Engine if needed.
-        if (!Engine.audioEngine && audioEngine && Engine.AudioEngineFactory) {
+        if (!Engine.audioEngine && this._creationOptions.audioEngine && Engine.AudioEngineFactory) {
             Engine.audioEngine = Engine.AudioEngineFactory(this.getRenderingCanvas(), this.getAudioContext(), this.getAudioDestination());
         }
+        if (IsDocumentAvailable()) {
+            // Fullscreen
+            this._onFullscreenChange = () => {
+                this.isFullscreen = !!document.fullscreenElement;
+                // Pointer lock
+                if (this.isFullscreen && this._pointerLockRequested && canvas) {
+                    Engine._RequestPointerlock(canvas);
+                }
+            };
+            document.addEventListener("fullscreenchange", this._onFullscreenChange, false);
+            document.addEventListener("webkitfullscreenchange", this._onFullscreenChange, false);
+            // Pointer lock
+            this._onPointerLockChange = () => {
+                this.isPointerLock = document.pointerLockElement === canvas;
+            };
+            document.addEventListener("pointerlockchange", this._onPointerLockChange, false);
+            document.addEventListener("webkitpointerlockchange", this._onPointerLockChange, false);
+        }
+        this.enableOfflineSupport = Engine.OfflineProviderFactory !== undefined;
+        this._deterministicLockstep = !!this._creationOptions.deterministicLockstep;
+        this._lockstepMaxSteps = this._creationOptions.lockstepMaxSteps || 0;
+        this._timeStep = this._creationOptions.timeStep || 1 / 60;
     }
     /**
      * Gets current aspect ratio