@babylonjs/core 5.23.0 → 5.24.0

package/Engines/WebGL/webGLPipelineContext.d.ts

@@ -19,6 +19,7 @@ export declare class WebGLPipelineContext implements IPipelineContext {
     fragmentCompilationError: Nullable<string>;
     programLinkError: Nullable<string>;
     programValidationError: Nullable<string>;
+    constructor();
     get isAsync(): boolean;
     get isReady(): boolean;
     _handlesSpectorRebuildCallback(onCompiled: (program: WebGLProgram) => void): void;
@@ -39,6 +40,15 @@ export declare class WebGLPipelineContext implements IPipelineContext {
      * @hidden
      */
     _cacheMatrix(uniformName: string, matrix: IMatrixLike): boolean;
+    /**
+     * @param _uniformName
+     * @param _x
+     * @param _y
+     * @param _z
+     * @param _w
+     * @hidden
+     */
+    _cacheFloatN(_uniformName: string, _x: number, _y?: number, _z?: number, _w?: number): boolean;
     /**
      * @param uniformName
      * @param x
@@ -68,14 +78,14 @@ export declare class WebGLPipelineContext implements IPipelineContext {
      * @param uniformName Name of the variable.
      * @param value Value to be set.
      */
-    setInt(uniformName: string, value: number): void;
+    setInt: (uniformName: string, value: number) => void;
     /**
      * Sets a int2 on a uniform variable.
      * @param uniformName Name of the variable.
      * @param x First int in int2.
      * @param y Second int in int2.
      */
-    setInt2(uniformName: string, x: number, y: number): void;
+    setInt2: (uniformName: string, x: number, y: number) => void;
     /**
      * Sets a int3 on a uniform variable.
      * @param uniformName Name of the variable.
@@ -83,7 +93,7 @@ export declare class WebGLPipelineContext implements IPipelineContext {
      * @param y Second int in int3.
      * @param z Third int in int3.
      */
-    setInt3(uniformName: string, x: number, y: number, z: number): void;
+    setInt3: (uniformName: string, x: number, y: number, z: number) => void;
     /**
      * Sets a int4 on a uniform variable.
      * @param uniformName Name of the variable.
@@ -92,62 +102,62 @@ export declare class WebGLPipelineContext implements IPipelineContext {
      * @param z Third int in int4.
      * @param w Fourth int in int4.
      */
-    setInt4(uniformName: string, x: number, y: number, z: number, w: number): void;
+    setInt4: (uniformName: string, x: number, y: number, z: number, w: number) => void;
     /**
      * Sets an int array on a uniform variable.
      * @param uniformName Name of the variable.
      * @param array array to be set.
      */
-    setIntArray(uniformName: string, array: Int32Array): void;
+    setIntArray: (uniformName: string, array: Int32Array) => void;
     /**
      * Sets an int array 2 on a uniform variable. (Array is specified as single array eg. [1,2,3,4] will result in [[1,2],[3,4]] in the shader)
      * @param uniformName Name of the variable.
      * @param array array to be set.
      */
-    setIntArray2(uniformName: string, array: Int32Array): void;
+    setIntArray2: (uniformName: string, array: Int32Array) => void;
     /**
      * Sets an int array 3 on a uniform variable. (Array is specified as single array eg. [1,2,3,4,5,6] will result in [[1,2,3],[4,5,6]] in the shader)
      * @param uniformName Name of the variable.
      * @param array array to be set.
      */
-    setIntArray3(uniformName: string, array: Int32Array): void;
+    setIntArray3: (uniformName: string, array: Int32Array) => void;
     /**
      * Sets an int array 4 on a uniform variable. (Array is specified as single array eg. [1,2,3,4,5,6,7,8] will result in [[1,2,3,4],[5,6,7,8]] in the shader)
      * @param uniformName Name of the variable.
      * @param array array to be set.
      */
-    setIntArray4(uniformName: string, array: Int32Array): void;
+    setIntArray4: (uniformName: string, array: Int32Array) => void;
     /**
      * Sets an array on a uniform variable.
      * @param uniformName Name of the variable.
      * @param array array to be set.
      */
-    setArray(uniformName: string, array: number[]): void;
+    setArray: (uniformName: string, array: number[]) => void;
     /**
      * Sets an array 2 on a uniform variable. (Array is specified as single array eg. [1,2,3,4] will result in [[1,2],[3,4]] in the shader)
      * @param uniformName Name of the variable.
      * @param array array to be set.
      */
-    setArray2(uniformName: string, array: number[]): void;
+    setArray2: (uniformName: string, array: number[]) => void;
     /**
      * Sets an array 3 on a uniform variable. (Array is specified as single array eg. [1,2,3,4,5,6] will result in [[1,2,3],[4,5,6]] in the shader)
      * @param uniformName Name of the variable.
      * @param array array to be set.
      * @returns this effect.
      */
-    setArray3(uniformName: string, array: number[]): void;
+    setArray3: (uniformName: string, array: number[]) => void;
     /**
      * Sets an array 4 on a uniform variable. (Array is specified as single array eg. [1,2,3,4,5,6,7,8] will result in [[1,2,3,4],[5,6,7,8]] in the shader)
      * @param uniformName Name of the variable.
      * @param array array to be set.
      */
-    setArray4(uniformName: string, array: number[]): void;
+    setArray4: (uniformName: string, array: number[]) => void;
     /**
      * Sets matrices on a uniform variable.
      * @param uniformName Name of the variable.
      * @param matrices matrices to be set.
      */
-    setMatrices(uniformName: string, matrices: Float32Array): void;
+    setMatrices: (uniformName: string, matrices: Float32Array) => void;
     /**
      * Sets matrix on a uniform variable.
      * @param uniformName Name of the variable.
@@ -159,20 +169,20 @@ export declare class WebGLPipelineContext implements IPipelineContext {
      * @param uniformName Name of the variable.
      * @param matrix matrix to be set.
      */
-    setMatrix3x3(uniformName: string, matrix: Float32Array): void;
+    setMatrix3x3: (uniformName: string, matrix: Float32Array) => void;
     /**
      * Sets a 2x2 matrix on a uniform variable. (Specified as [1,2,3,4] will result in [1,2][3,4] matrix)
      * @param uniformName Name of the variable.
      * @param matrix matrix to be set.
      */
-    setMatrix2x2(uniformName: string, matrix: Float32Array): void;
+    setMatrix2x2: (uniformName: string, matrix: Float32Array) => void;
     /**
      * Sets a float on a uniform variable.
      * @param uniformName Name of the variable.
      * @param value value to be set.
      * @returns this effect.
      */
-    setFloat(uniformName: string, value: number): void;
+    setFloat: (uniformName: string, value: number) => void;
     /**
      * Sets a Vector2 on a uniform variable.
      * @param uniformName Name of the variable.
@@ -185,7 +195,7 @@ export declare class WebGLPipelineContext implements IPipelineContext {
      * @param x First float in float2.
      * @param y Second float in float2.
      */
-    setFloat2(uniformName: string, x: number, y: number): void;
+    setFloat2: (uniformName: string, x: number, y: number) => void;
     /**
      * Sets a Vector3 on a uniform variable.
      * @param uniformName Name of the variable.
@@ -199,7 +209,7 @@ export declare class WebGLPipelineContext implements IPipelineContext {
      * @param y Second float in float3.
      * @param z Third float in float3.
      */
-    setFloat3(uniformName: string, x: number, y: number, z: number): void;
+    setFloat3: (uniformName: string, x: number, y: number, z: number) => void;
     /**
      * Sets a Vector4 on a uniform variable.
      * @param uniformName Name of the variable.
@@ -221,7 +231,7 @@ export declare class WebGLPipelineContext implements IPipelineContext {
      * @param w Fourth float in float4.
      * @returns this effect.
      */
-    setFloat4(uniformName: string, x: number, y: number, z: number, w: number): void;
+    setFloat4: (uniformName: string, x: number, y: number, z: number, w: number) => void;
     /**
      * Sets a Color3 on a uniform variable.
      * @param uniformName Name of the variable.

package/Engines/WebGL/webGLPipelineContext.js

@@ -1,3 +1,20 @@
+const floatNCache = [
+    "Int2",
+    "Int",
+    "Int3",
+    "Int4",
+    "Vector2",
+    "Vector3",
+    "Vector4",
+    "Float2",
+    "Float",
+    "Float3",
+    "Float4",
+    "Quaternion",
+    "Color3",
+    "Color4",
+    "DirectColor4",
+];
 /** @hidden */
 export class WebGLPipelineContext {
     constructor() {
@@ -6,6 +23,51 @@ export class WebGLPipelineContext {
         this.fragmentCompilationError = null;
         this.programLinkError = null;
         this.programValidationError = null;
+        const args = [];
+        const prepareArray = function () {
+            args.length = 0;
+            Array.prototype.push.apply(args, arguments);
+            args[0] = this._uniforms[args[0]];
+        };
+        const proxyFunction = (functionName) => {
+            const cacheFunction = floatNCache.includes(functionName.substring(3)) && "FloatN";
+            if (cacheFunction) {
+                const cacheFunc = this[`_cache${cacheFunction}`];
+                return function () {
+                    const func = this.engine[functionName];
+                    prepareArray.apply(this, arguments);
+                    if (cacheFunc.apply(this, arguments)) {
+                        if (!func.apply(this.engine, args)) {
+                            this._valueCache[arguments[0]] = null;
+                        }
+                    }
+                };
+            }
+            else {
+                return function () {
+                    const func = this.engine[functionName];
+                    prepareArray.apply(this, arguments);
+                    if (arguments[1] !== undefined) {
+                        this._valueCache[arguments[0]] = null;
+                        func.apply(this.engine, args);
+                    }
+                };
+            }
+        };
+        ["Int?", "IntArray?", "Array?", "Float?", "Matrices", "Matrix3x3", "Matrix2x2"].forEach((functionName) => {
+            const name = `set${functionName}`;
+            if (this[name]) {
+                return;
+            }
+            if (name.endsWith("?")) {
+                ["", 2, 3, 4].forEach((n) => {
+                    this[(name.slice(0, -1) + n)] = this[(name.slice(0, -1) + n)] || proxyFunction(name.slice(0, -1) + n).bind(this);
+                });
+            }
+            else {
+                this[name] = this[name] || proxyFunction(name).bind(this);
+            }
+        });
     }
     get isAsync() {
         return this.isParallelCompiled;
@@ -72,29 +134,42 @@ export class WebGLPipelineContext {
         return true;
     }
     /**
-     * @param uniformName
-     * @param x
-     * @param y
+     * @param _uniformName
+     * @param _x
+     * @param _y
+     * @param _z
+     * @param _w
      * @hidden
      */
-    _cacheFloat2(uniformName, x, y) {
-        let cache = this._valueCache[uniformName];
-        if (!cache || cache.length !== 2) {
-            cache = [x, y];
-            this._valueCache[uniformName] = cache;
+    _cacheFloatN(_uniformName, _x, _y, _z, _w) {
+        /**
+         * arguments will be used to abstract the cache function.
+         * arguments[0] is the uniform name. the rest are numbers.
+         */
+        let cache = this._valueCache[arguments[0]];
+        if (!cache || cache.length !== arguments.length - 1) {
+            cache = Array.prototype.slice.call(arguments, 1);
+            this._valueCache[arguments[0]] = cache;
             return true;
         }
         let changed = false;
-        if (cache[0] !== x) {
-            cache[0] = x;
-            changed = true;
-        }
-        if (cache[1] !== y) {
-            cache[1] = y;
-            changed = true;
+        for (let i = 0; i < cache.length; ++i) {
+            if (cache[i] !== arguments[i + 1]) {
+                cache[i] = arguments[i + 1];
+                changed = true;
+            }
         }
         return changed;
     }
+    /**
+     * @param uniformName
+     * @param x
+     * @param y
+     * @hidden
+     */
+    _cacheFloat2(uniformName, x, y) {
+        return this._cacheFloatN(uniformName, x, y);
+    }
     /**
      * @param uniformName
      * @param x
@@ -103,26 +178,7 @@ export class WebGLPipelineContext {
      * @hidden
      */
     _cacheFloat3(uniformName, x, y, z) {
-        let cache = this._valueCache[uniformName];
-        if (!cache || cache.length !== 3) {
-            cache = [x, y, z];
-            this._valueCache[uniformName] = cache;
-            return true;
-        }
-        let changed = false;
-        if (cache[0] !== x) {
-            cache[0] = x;
-            changed = true;
-        }
-        if (cache[1] !== y) {
-            cache[1] = y;
-            changed = true;
-        }
-        if (cache[2] !== z) {
-            cache[2] = z;
-            changed = true;
-        }
-        return changed;
+        return this._cacheFloatN(uniformName, x, y, z);
     }
     /**
      * @param uniformName
@@ -133,171 +189,7 @@ export class WebGLPipelineContext {
      * @hidden
      */
     _cacheFloat4(uniformName, x, y, z, w) {
-        let cache = this._valueCache[uniformName];
-        if (!cache || cache.length !== 4) {
-            cache = [x, y, z, w];
-            this._valueCache[uniformName] = cache;
-            return true;
-        }
-        let changed = false;
-        if (cache[0] !== x) {
-            cache[0] = x;
-            changed = true;
-        }
-        if (cache[1] !== y) {
-            cache[1] = y;
-            changed = true;
-        }
-        if (cache[2] !== z) {
-            cache[2] = z;
-            changed = true;
-        }
-        if (cache[3] !== w) {
-            cache[3] = w;
-            changed = true;
-        }
-        return changed;
-    }
-    /**
-     * Sets an integer value on a uniform variable.
-     * @param uniformName Name of the variable.
-     * @param value Value to be set.
-     */
-    setInt(uniformName, value) {
-        const cache = this._valueCache[uniformName];
-        if (cache !== undefined && cache === value) {
-            return;
-        }
-        if (this.engine.setInt(this._uniforms[uniformName], value)) {
-            this._valueCache[uniformName] = value;
-        }
-    }
-    /**
-     * Sets a int2 on a uniform variable.
-     * @param uniformName Name of the variable.
-     * @param x First int in int2.
-     * @param y Second int in int2.
-     */
-    setInt2(uniformName, x, y) {
-        if (this._cacheFloat2(uniformName, x, y)) {
-            if (!this.engine.setInt2(this._uniforms[uniformName], x, y)) {
-                this._valueCache[uniformName] = null;
-            }
-        }
-    }
-    /**
-     * Sets a int3 on a uniform variable.
-     * @param uniformName Name of the variable.
-     * @param x First int in int3.
-     * @param y Second int in int3.
-     * @param z Third int in int3.
-     */
-    setInt3(uniformName, x, y, z) {
-        if (this._cacheFloat3(uniformName, x, y, z)) {
-            if (!this.engine.setInt3(this._uniforms[uniformName], x, y, z)) {
-                this._valueCache[uniformName] = null;
-            }
-        }
-    }
-    /**
-     * Sets a int4 on a uniform variable.
-     * @param uniformName Name of the variable.
-     * @param x First int in int4.
-     * @param y Second int in int4.
-     * @param z Third int in int4.
-     * @param w Fourth int in int4.
-     */
-    setInt4(uniformName, x, y, z, w) {
-        if (this._cacheFloat4(uniformName, x, y, z, w)) {
-            if (!this.engine.setInt4(this._uniforms[uniformName], x, y, z, w)) {
-                this._valueCache[uniformName] = null;
-            }
-        }
-    }
-    /**
-     * Sets an int array on a uniform variable.
-     * @param uniformName Name of the variable.
-     * @param array array to be set.
-     */
-    setIntArray(uniformName, array) {
-        this._valueCache[uniformName] = null;
-        this.engine.setIntArray(this._uniforms[uniformName], array);
-    }
-    /**
-     * Sets an int array 2 on a uniform variable. (Array is specified as single array eg. [1,2,3,4] will result in [[1,2],[3,4]] in the shader)
-     * @param uniformName Name of the variable.
-     * @param array array to be set.
-     */
-    setIntArray2(uniformName, array) {
-        this._valueCache[uniformName] = null;
-        this.engine.setIntArray2(this._uniforms[uniformName], array);
-    }
-    /**
-     * Sets an int array 3 on a uniform variable. (Array is specified as single array eg. [1,2,3,4,5,6] will result in [[1,2,3],[4,5,6]] in the shader)
-     * @param uniformName Name of the variable.
-     * @param array array to be set.
-     */
-    setIntArray3(uniformName, array) {
-        this._valueCache[uniformName] = null;
-        this.engine.setIntArray3(this._uniforms[uniformName], array);
-    }
-    /**
-     * Sets an int array 4 on a uniform variable. (Array is specified as single array eg. [1,2,3,4,5,6,7,8] will result in [[1,2,3,4],[5,6,7,8]] in the shader)
-     * @param uniformName Name of the variable.
-     * @param array array to be set.
-     */
-    setIntArray4(uniformName, array) {
-        this._valueCache[uniformName] = null;
-        this.engine.setIntArray4(this._uniforms[uniformName], array);
-    }
-    /**
-     * Sets an array on a uniform variable.
-     * @param uniformName Name of the variable.
-     * @param array array to be set.
-     */
-    setArray(uniformName, array) {
-        this._valueCache[uniformName] = null;
-        this.engine.setArray(this._uniforms[uniformName], array);
-    }
-    /**
-     * Sets an array 2 on a uniform variable. (Array is specified as single array eg. [1,2,3,4] will result in [[1,2],[3,4]] in the shader)
-     * @param uniformName Name of the variable.
-     * @param array array to be set.
-     */
-    setArray2(uniformName, array) {
-        this._valueCache[uniformName] = null;
-        this.engine.setArray2(this._uniforms[uniformName], array);
-    }
-    /**
-     * Sets an array 3 on a uniform variable. (Array is specified as single array eg. [1,2,3,4,5,6] will result in [[1,2,3],[4,5,6]] in the shader)
-     * @param uniformName Name of the variable.
-     * @param array array to be set.
-     * @returns this effect.
-     */
-    setArray3(uniformName, array) {
-        this._valueCache[uniformName] = null;
-        this.engine.setArray3(this._uniforms[uniformName], array);
-    }
-    /**
-     * Sets an array 4 on a uniform variable. (Array is specified as single array eg. [1,2,3,4,5,6,7,8] will result in [[1,2,3,4],[5,6,7,8]] in the shader)
-     * @param uniformName Name of the variable.
-     * @param array array to be set.
-     */
-    setArray4(uniformName, array) {
-        this._valueCache[uniformName] = null;
-        this.engine.setArray4(this._uniforms[uniformName], array);
-    }
-    /**
-     * Sets matrices on a uniform variable.
-     * @param uniformName Name of the variable.
-     * @param matrices matrices to be set.
-     */
-    setMatrices(uniformName, matrices) {
-        if (!matrices) {
-            return;
-        }
-        this._valueCache[uniformName] = null;
-        this.engine.setMatrices(this._uniforms[uniformName], matrices);
+        return this._cacheFloatN(uniformName, x, y, z, w);
     }
     /**
      * Sets matrix on a uniform variable.
@@ -311,63 +203,13 @@ export class WebGLPipelineContext {
             }
         }
     }
-    /**
-     * Sets a 3x3 matrix on a uniform variable. (Specified as [1,2,3,4,5,6,7,8,9] will result in [1,2,3][4,5,6][7,8,9] matrix)
-     * @param uniformName Name of the variable.
-     * @param matrix matrix to be set.
-     */
-    setMatrix3x3(uniformName, matrix) {
-        this._valueCache[uniformName] = null;
-        this.engine.setMatrix3x3(this._uniforms[uniformName], matrix);
-    }
-    /**
-     * Sets a 2x2 matrix on a uniform variable. (Specified as [1,2,3,4] will result in [1,2][3,4] matrix)
-     * @param uniformName Name of the variable.
-     * @param matrix matrix to be set.
-     */
-    setMatrix2x2(uniformName, matrix) {
-        this._valueCache[uniformName] = null;
-        this.engine.setMatrix2x2(this._uniforms[uniformName], matrix);
-    }
-    /**
-     * Sets a float on a uniform variable.
-     * @param uniformName Name of the variable.
-     * @param value value to be set.
-     * @returns this effect.
-     */
-    setFloat(uniformName, value) {
-        const cache = this._valueCache[uniformName];
-        if (cache !== undefined && cache === value) {
-            return;
-        }
-        if (this.engine.setFloat(this._uniforms[uniformName], value)) {
-            this._valueCache[uniformName] = value;
-        }
-    }
     /**
      * Sets a Vector2 on a uniform variable.
      * @param uniformName Name of the variable.
      * @param vector2 vector2 to be set.
      */
     setVector2(uniformName, vector2) {
-        if (this._cacheFloat2(uniformName, vector2.x, vector2.y)) {
-            if (!this.engine.setFloat2(this._uniforms[uniformName], vector2.x, vector2.y)) {
-                this._valueCache[uniformName] = null;
-            }
-        }
-    }
-    /**
-     * Sets a float2 on a uniform variable.
-     * @param uniformName Name of the variable.
-     * @param x First float in float2.
-     * @param y Second float in float2.
-     */
-    setFloat2(uniformName, x, y) {
-        if (this._cacheFloat2(uniformName, x, y)) {
-            if (!this.engine.setFloat2(this._uniforms[uniformName], x, y)) {
-                this._valueCache[uniformName] = null;
-            }
-        }
+        this.setFloat2(uniformName, vector2.x, vector2.y);
     }
     /**
      * Sets a Vector3 on a uniform variable.
@@ -375,25 +217,7 @@ export class WebGLPipelineContext {
      * @param vector3 Value to be set.
      */
     setVector3(uniformName, vector3) {
-        if (this._cacheFloat3(uniformName, vector3.x, vector3.y, vector3.z)) {
-            if (!this.engine.setFloat3(this._uniforms[uniformName], vector3.x, vector3.y, vector3.z)) {
-                this._valueCache[uniformName] = null;
-            }
-        }
-    }
-    /**
-     * Sets a float3 on a uniform variable.
-     * @param uniformName Name of the variable.
-     * @param x First float in float3.
-     * @param y Second float in float3.
-     * @param z Third float in float3.
-     */
-    setFloat3(uniformName, x, y, z) {
-        if (this._cacheFloat3(uniformName, x, y, z)) {
-            if (!this.engine.setFloat3(this._uniforms[uniformName], x, y, z)) {
-                this._valueCache[uniformName] = null;
-            }
-        }
+        this.setFloat3(uniformName, vector3.x, vector3.y, vector3.z);
     }
     /**
      * Sets a Vector4 on a uniform variable.
@@ -401,11 +225,7 @@ export class WebGLPipelineContext {
      * @param vector4 Value to be set.
      */
     setVector4(uniformName, vector4) {
-        if (this._cacheFloat4(uniformName, vector4.x, vector4.y, vector4.z, vector4.w)) {
-            if (!this.engine.setFloat4(this._uniforms[uniformName], vector4.x, vector4.y, vector4.z, vector4.w)) {
-                this._valueCache[uniformName] = null;
-            }
-        }
+        this.setFloat4(uniformName, vector4.x, vector4.y, vector4.z, vector4.w);
     }
     /**
      * Sets a Quaternion on a uniform variable.
@@ -413,27 +233,7 @@ export class WebGLPipelineContext {
      * @param quaternion Value to be set.
      */
     setQuaternion(uniformName, quaternion) {
-        if (this._cacheFloat4(uniformName, quaternion.x, quaternion.y, quaternion.z, quaternion.w)) {
-            if (!this.engine.setFloat4(this._uniforms[uniformName], quaternion.x, quaternion.y, quaternion.z, quaternion.w)) {
-                this._valueCache[uniformName] = null;
-            }
-        }
-    }
-    /**
-     * Sets a float4 on a uniform variable.
-     * @param uniformName Name of the variable.
-     * @param x First float in float4.
-     * @param y Second float in float4.
-     * @param z Third float in float4.
-     * @param w Fourth float in float4.
-     * @returns this effect.
-     */
-    setFloat4(uniformName, x, y, z, w) {
-        if (this._cacheFloat4(uniformName, x, y, z, w)) {
-            if (!this.engine.setFloat4(this._uniforms[uniformName], x, y, z, w)) {
-                this._valueCache[uniformName] = null;
-            }
-        }
+        this.setFloat4(uniformName, quaternion.x, quaternion.y, quaternion.z, quaternion.w);
     }
     /**
      * Sets a Color3 on a uniform variable.
@@ -441,11 +241,7 @@ export class WebGLPipelineContext {
      * @param color3 Value to be set.
      */
     setColor3(uniformName, color3) {
-        if (this._cacheFloat3(uniformName, color3.r, color3.g, color3.b)) {
-            if (!this.engine.setFloat3(this._uniforms[uniformName], color3.r, color3.g, color3.b)) {
-                this._valueCache[uniformName] = null;
-            }
-        }
+        this.setFloat3(uniformName, color3.r, color3.g, color3.b);
     }
     /**
      * Sets a Color4 on a uniform variable.
@@ -454,11 +250,7 @@ export class WebGLPipelineContext {
      * @param alpha Alpha value to be set.
      */
     setColor4(uniformName, color3, alpha) {
-        if (this._cacheFloat4(uniformName, color3.r, color3.g, color3.b, alpha)) {
-            if (!this.engine.setFloat4(this._uniforms[uniformName], color3.r, color3.g, color3.b, alpha)) {
-                this._valueCache[uniformName] = null;
-            }
-        }
+        this.setFloat4(uniformName, color3.r, color3.g, color3.b, alpha);
     }
     /**
      * Sets a Color4 on a uniform variable
@@ -466,11 +258,7 @@ export class WebGLPipelineContext {
      * @param color4 defines the value to be set
      */
     setDirectColor4(uniformName, color4) {
-        if (this._cacheFloat4(uniformName, color4.r, color4.g, color4.b, color4.a)) {
-            if (!this.engine.setFloat4(this._uniforms[uniformName], color4.r, color4.g, color4.b, color4.a)) {
-                this._valueCache[uniformName] = null;
-            }
-        }
+        this.setFloat4(uniformName, color4.r, color4.g, color4.b, color4.a);
     }
     _getVertexShaderCode() {
         return this.vertexShader ? this.engine._getShaderSource(this.vertexShader) : null;