@babelize/engine 0.1.2 → 0.1.3

package/dist/modules/translator/translate.js

@@ -34,9 +34,18 @@ const TRANSLATE_CONCURRENCY = 3; // Max concurrent locales/batches
  * many sentences (the translator service's batch limit).
  */
 const BRANCH_BATCH_SIZE = 50;
-/** A plain source whose stored translation is ICU only fits a project whose runtime formats ICU. */
-function reusableTranslation(source, translated, targetPlurals) {
-    return targetPlurals || (0, icu_message_1.isIcuMessage)(source) || !(0, icu_message_1.isIcuMessage)(translated);
+/**
+ * A plain source whose stored translation is ICU only fits a project whose
+ * runtime formats ICU. A stored ICU translation stored before a check it now
+ * fails (e.g. Czech without its `few` branch) is translated again.
+ */
+function reusableTranslation(source, translated, targetPlurals, targetLocale) {
+    if (!targetPlurals && !(0, icu_message_1.isIcuMessage)(source) && (0, icu_message_1.isIcuMessage)(translated))
+        return false;
+    if (!(0, icu_message_1.isIcuMessage)(translated))
+        return true;
+    const pluralizable = (0, icu_message_1.isIcuMessage)(source) ? [] : (0, icu_message_1.countArguments)(source);
+    return !(0, icu_message_1.compareIcuMessages)(source, translated, targetLocale, { pluralizable }).some((i) => i.severity === 'error');
 }
 /** Per-entry instruction: pluralize a count argument if the target language needs it. */
 function pluralHint(args, targetLocale) {
@@ -419,7 +428,7 @@ async function translateEntries(entries, sourceLang, targetLang, projectId, onPr
         const cacheProblem = cached.hit && cached.data !== null ? reuseProblem(text, cached.data) : null;
         if (cacheProblem)
             logger_1.engineLogger.info('Cached translation breaks the glossary; translating again', { key, targetLocale, problem: cacheProblem });
-        if (cached.hit && cached.data !== null && !cacheProblem && reusableTranslation(text, cached.data, !!options.targetPlurals) && !(0, untranslated_1.isUntranslatedInto)(text, cached.data, targetLocale)) {
+        if (cached.hit && cached.data !== null && !cacheProblem && reusableTranslation(text, cached.data, !!options.targetPlurals, targetLocale) && !(0, untranslated_1.isUntranslatedInto)(text, cached.data, targetLocale)) {
             result[key] = cached.data;
             cacheHits++;
             // Reused, not translated this run (billing counts only fresh output).
@@ -497,7 +506,7 @@ async function translateEntries(entries, sourceLang, targetLang, projectId, onPr
                 const tmProblem = lookup.hit && lookup.translatedText ? reuseProblem(entry.value, lookup.translatedText) : null;
                 if (tmProblem)
                     logger_1.engineLogger.info('TM translation breaks the glossary; translating again', { key: entry.key, targetLocale, problem: tmProblem });
-                if (lookup.hit && lookup.translatedText && !tmProblem && reusableTranslation(entry.value, lookup.translatedText, !!options.targetPlurals) && !(0, untranslated_1.isUntranslatedInto)(entry.value, lookup.translatedText, targetLocale)) {
+                if (lookup.hit && lookup.translatedText && !tmProblem && reusableTranslation(entry.value, lookup.translatedText, !!options.targetPlurals, targetLocale) && !(0, untranslated_1.isUntranslatedInto)(entry.value, lookup.translatedText, targetLocale)) {
                     result[entry.key] = lookup.translatedText;
                     tmHits++;
                     metadata[entry.key] = { fromMemory: true, inTm: true };

package/dist/utils/icu-message.d.ts

@@ -38,8 +38,8 @@ export interface IcuIssue {
 /**
  * Compare a translated ICU message to its source. Errors mean the message is
  * broken at runtime (unparseable, arguments renamed, select branches changed,
- * no `other`). Missing target plural categories are only a warning: ICU
- * falls back to `other` for them.
+ * no `other`, a target plural category whole numbers use). A missing category
+ * only fractions use is a warning: ICU falls back to `other` for it.
  */
 export declare function compareIcuMessages(source: string, translated: string, targetLocale: string, options?: {
     /**

package/dist/utils/icu-message.js

@@ -190,11 +190,29 @@ function pluralCategories(locale, type) {
         return [...CLDR_ORDER];
     }
 }
+/**
+ * Whole numbers (0–999) a plural category is used for, e.g. Czech few → 2, 3, 4,
+ * Czech many → none (only fractions like 1.5). CLDR integer rules repeat
+ * within every hundred, so this range covers them.
+ */
+function integersOf(locale, type, category) {
+    try {
+        const rules = new Intl.PluralRules(locale, { type });
+        const out = [];
+        for (let n = 0; n < 1000; n++)
+            if (rules.select(n) === category)
+                out.push(n);
+        return out;
+    }
+    catch {
+        return [];
+    }
+}
 /**
  * Compare a translated ICU message to its source. Errors mean the message is
  * broken at runtime (unparseable, arguments renamed, select branches changed,
- * no `other`). Missing target plural categories are only a warning: ICU
- * falls back to `other` for them.
+ * no `other`, a target plural category whole numbers use). A missing category
+ * only fractions use is a warning: ICU falls back to `other` for it.
  */
 function compareIcuMessages(source, translated, targetLocale, options = {}) {
     let sourceAst;
@@ -291,11 +309,29 @@ function compareIcuMessages(source, translated, targetLocale, options = {}) {
         }
         const missing = allowed.filter((c) => !target.keys.includes(c));
         if (missing.length) {
-            issues.push({
-                severity: 'warning',
-                code: 'icu_plural_category_missing',
-                message: `{${target.name}, ${target.kind}} has no [${missing.join(', ')}] branch for ${targetLocale}; "other" will be used`,
-            });
+            // A missing category whole numbers reach (Czech few: 2–4) shows the
+            // wrong form for common counts ("2 souborů"): an error. One only
+            // fractions reach (Czech many: 1.5), or whose numbers all have `=n`
+            // branches, falls back to `other` rarely: a warning.
+            const type = target.kind === 'selectordinal' ? 'ordinal' : 'cardinal';
+            const reached = missing
+                .map((c) => ({ c, ns: integersOf(targetLocale, type, c).filter((n) => !target.keys.includes(`=${n}`)) }))
+                .filter((m) => m.ns.length > 0);
+            if (reached.length) {
+                const examples = (ns) => `${ns.slice(0, 3).join(', ')}${ns.length > 3 ? ', …' : ''}`;
+                issues.push({
+                    severity: 'error',
+                    code: 'icu_plural_category_missing',
+                    message: `{${target.name}, ${target.kind}} has no ${reached.map((m) => `${m.c} branch (${examples(m.ns)})`).join(', ')} for ${targetLocale}; those counts would get the "other" form`,
+                });
+            }
+            else {
+                issues.push({
+                    severity: 'warning',
+                    code: 'icu_plural_category_missing',
+                    message: `{${target.name}, ${target.kind}} has no [${missing.join(', ')}] branch for ${targetLocale}; "other" will be used`,
+                });
+            }
         }
     }
     return issues;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@babelize/engine",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "description": "Babelize translation pipeline (extract, keygen, translate, inject). Infrastructure is injected through provider/store interfaces.",
   "keywords": [
     "babelize",
@@ -11,10 +11,6 @@
   ],
   "license": "Apache-2.0",
   "homepage": "https://babelize.co",
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/babelize/babelize-dashboard.git"
-  },
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "files": [