@babel/plugin-proposal-decorators 7.17.0 → 7.17.2

package/lib/transformer-2021-12.js

@@ -270,16 +270,29 @@ function transformClass(path, state, constantSuper) {
   let constructorPath;
   let requiresProtoInit = false;
   let requiresStaticInit = false;
-  let hasComputedProps = false;
   const decoratedPrivateMethods = new Set();
   let protoInitLocal, staticInitLocal, classInitLocal, classLocal;
+  const assignments = [];
+  const scopeParent = path.scope.parent;
+
+  const memoiseExpression = (expression, hint) => {
+    const localEvaluatedId = scopeParent.generateDeclaredUidIdentifier(hint);
+    assignments.push(_core.types.assignmentExpression("=", localEvaluatedId, expression));
+    return _core.types.cloneNode(localEvaluatedId);
+  };
 
   if (classDecorators) {
-    classInitLocal = path.scope.parent.generateDeclaredUidIdentifier("initClass");
+    classInitLocal = scopeParent.generateDeclaredUidIdentifier("initClass");
     const [localId, classPath] = replaceClassWithVar(path);
     path = classPath;
     classLocal = localId;
     path.node.decorators = null;
+
+    for (const classDecorator of classDecorators) {
+      if (!scopeParent.isStatic(classDecorator.expression)) {
+        classDecorator.expression = memoiseExpression(classDecorator.expression, "dec");
+      }
+    }
   } else {
     if (!path.node.id) {
       path.node.id = path.scope.generateUidIdentifier("Class");
@@ -294,19 +307,39 @@ function transformClass(path, state, constantSuper) {
         continue;
       }
 
-      let {
-        key
-      } = element.node;
-      const kind = getElementKind(element);
+      const {
+        node
+      } = element;
       const decorators = element.get("decorators");
-      const isPrivate = key.type === "PrivateName";
+      const hasDecorators = Array.isArray(decorators) && decorators.length > 0;
+
+      if (hasDecorators) {
+        for (const decoratorPath of decorators) {
+          if (!scopeParent.isStatic(decoratorPath.node.expression)) {
+            decoratorPath.node.expression = memoiseExpression(decoratorPath.node.expression, "dec");
+          }
+        }
+      }
+
       const isComputed = "computed" in element.node && element.node.computed === true;
+
+      if (isComputed) {
+        if (!scopeParent.isStatic(node.key)) {
+          node.key = memoiseExpression(node.key, "computedKey");
+        }
+      }
+
+      const kind = getElementKind(element);
+      const {
+        key
+      } = node;
+      const isPrivate = key.type === "PrivateName";
       const isStatic = !!element.node.static;
       let name = "computedKey";
 
       if (isPrivate) {
         name = key.id.name;
-      } else if (key.type === "Identifier") {
+      } else if (!isComputed && key.type === "Identifier") {
         name = key.name;
       }
 
@@ -316,19 +349,7 @@ function transformClass(path, state, constantSuper) {
         constructorPath = element;
       }
 
-      if (isComputed) {
-        const keyPath = element.get("key");
-        const localComputedNameId = keyPath.scope.parent.generateDeclaredUidIdentifier(name);
-        keyPath.replaceWith(localComputedNameId);
-        elementDecoratorInfo.push({
-          localComputedNameId: _core.types.cloneNode(localComputedNameId),
-          keyNode: _core.types.cloneNode(key)
-        });
-        key = localComputedNameId;
-        hasComputedProps = true;
-      }
-
-      if (Array.isArray(decorators) && decorators.length > 0) {
+      if (hasDecorators) {
         let locals;
         let privateMethods;
 
@@ -437,43 +458,14 @@ function transformClass(path, state, constantSuper) {
     }
   }
 
-  if (hasComputedProps) {
-    const assignments = [];
-
-    for (const info of elementDecoratorInfo) {
-      if (isDecoratorInfo(info)) {
-        const {
-          decorators
-        } = info;
-        const newDecorators = [];
-
-        for (const decorator of decorators) {
-          const localComputedNameId = path.scope.parent.generateDeclaredUidIdentifier("dec");
-          assignments.push(_core.types.assignmentExpression("=", localComputedNameId, decorator));
-          newDecorators.push(_core.types.cloneNode(localComputedNameId));
-        }
-
-        info.decorators = newDecorators;
-      } else {
-        assignments.push(_core.types.assignmentExpression("=", info.localComputedNameId, info.keyNode));
-      }
-    }
-
-    path.insertBefore(assignments);
-  }
-
   const elementDecorations = generateDecorationExprs(elementDecoratorInfo);
 
   const classDecorations = _core.types.arrayExpression((classDecorators || []).map(d => d.expression));
 
   const locals = extractElementLocalAssignments(elementDecoratorInfo);
 
-  if (classDecorators) {
-    locals.push(classLocal, classInitLocal);
-  }
-
   if (requiresProtoInit) {
-    protoInitLocal = path.scope.parent.generateDeclaredUidIdentifier("initProto");
+    protoInitLocal = scopeParent.generateDeclaredUidIdentifier("initProto");
     locals.push(protoInitLocal);
 
     const protoInitCall = _core.types.callExpression(_core.types.cloneNode(protoInitLocal), [_core.types.thisExpression()]);
@@ -514,7 +506,7 @@ function transformClass(path, state, constantSuper) {
   }
 
   if (requiresStaticInit) {
-    staticInitLocal = path.scope.parent.generateDeclaredUidIdentifier("initStatic");
+    staticInitLocal = scopeParent.generateDeclaredUidIdentifier("initStatic");
     locals.push(staticInitLocal);
   }
 
@@ -540,6 +532,7 @@ function transformClass(path, state, constantSuper) {
   const originalClass = path.node;
 
   if (classDecorators) {
+    locals.push(classLocal, classInitLocal);
     const statics = [];
     let staticBlocks = [];
     path.get("body.body").forEach(element => {
@@ -599,6 +592,7 @@ function transformClass(path, state, constantSuper) {
   }
 
   originalClass.body.body.unshift(_core.types.staticBlock([_core.types.expressionStatement(_core.types.assignmentExpression("=", _core.types.arrayPattern(locals), _core.types.callExpression(state.addHelper("applyDecs"), [_core.types.thisExpression(), elementDecorations, classDecorations]))), requiresStaticInit && _core.types.expressionStatement(_core.types.callExpression(_core.types.cloneNode(staticInitLocal), [_core.types.thisExpression()]))].filter(Boolean)));
+  path.insertBefore(assignments);
   path.scope.crawl();
   return path;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@babel/plugin-proposal-decorators",
-  "version": "7.17.0",
+  "version": "7.17.2",
   "author": "The Babel Team (https://babel.dev/team)",
   "license": "MIT",
   "publishConfig": {
@@ -20,7 +20,7 @@
     "decorators"
   ],
   "dependencies": {
-    "@babel/helper-create-class-features-plugin": "^7.17.0",
+    "@babel/helper-create-class-features-plugin": "^7.17.1",
     "@babel/helper-plugin-utils": "^7.16.7",
     "@babel/helper-replace-supers": "^7.16.7",
     "@babel/plugin-syntax-decorators": "^7.17.0",
@@ -30,7 +30,7 @@
     "@babel/core": "^7.0.0-0"
   },
   "devDependencies": {
-    "@babel/core": "^7.17.0",
+    "@babel/core": "^7.17.2",
     "@babel/helper-plugin-test-runner": "^7.16.7",
     "@babel/traverse": "^7.17.0",
     "babel-plugin-polyfill-es-shims": "^0.6.0",