@babblevoice/projectrtp 2.5.29 → 2.5.31

package/lib/node.js

@@ -15,7 +15,12 @@ const channelmap = {
     }
   },
   "unmix": ( chan ) => chan.unmix(),
-  "dtmf": ( chan, msg ) => chan.dtmf( msg.digits ),
+  "dtmf": ( chan, msg ) => {
+    if( !msg.digits ) return
+    if( "string" !== typeof msg.digits ) return
+    if( 10 < msg.digits.length ) return
+    chan.dtmf( msg.digits )
+  },
   "echo": ( chan ) => chan.echo(),
   "play": ( chan, msg ) => chan.play( msg.soup ),
   "record": ( chan, msg ) => chan.record( msg.options ),

package/lib/server.js

@@ -229,6 +229,8 @@ class channel {
 
     channels.set( newchannel.id, newchannel )
 
+    newchannel.channels = [ newchannel ]
+
     return newchannel
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@babblevoice/projectrtp",
-  "version": "2.5.29",
+  "version": "2.5.31",
   "description": "A scalable Node addon RTP server",
   "main": "index.js",
   "directories": {

package/test/interface/projectrtprecord.js

@@ -312,8 +312,8 @@ describe( "record", function() {
 
       expect( channel.record( {
         "file": "/tmp/ourpowerrecording.wav",
-        "startabovepower": 250,
-        "finishbelowpower": 200,
+        "startabovepower": 40,
+        "finishbelowpower": 80,
         "minduration": 2000,
         "maxduration": 15000,
         "poweraveragepackets": 20
@@ -382,8 +382,8 @@ describe( "record", function() {
 
       expect( channel.record( {
         "file": "/tmp/ourtimeoutpowerrecording.wav",
-        "startabovepower": 250,
-        "finishbelowpower": 200,
+        "startabovepower": 40,
+        "finishbelowpower": 80,
         "minduration": 200,
         "maxduration": 500,
         "poweraveragepackets": 50
@@ -449,8 +449,8 @@ describe( "record", function() {
 
       expect( channel.record( {
         "file": "/tmp/dualrecordingpower.wav",
-        "startabovepower": 200,
-        "finishbelowpower": 180,
+        "startabovepower": 40,
+        "finishbelowpower": 200,
         "minduration": 200,
         "maxduration": 3500,
         "poweraveragepackets": 10 /* faster response */
@@ -470,7 +470,7 @@ describe( "record", function() {
     server.close()
 
     let stats = fs.statSync( "/tmp/dualrecordingpower.wav" )
-    expect( stats.size ).to.be.within( 40000, 52000 )
+    expect( stats.size ).to.be.within( 30000 , 40000 )
 
     stats = fs.statSync( "/tmp/dualrecording.wav" )
     expect( stats.size ).to.be.within( 110000, 190000 )

package/test/interface/projectrtptonegen.js

@@ -4,9 +4,76 @@
 const expect = require( "chai" ).expect
 const projectrtp = require( "../../index.js" ).projectrtp
 
+const fs = require( "node:fs" ).promises
+const dgram = require( "dgram" )
+const rtp = require( "../util/rtp" )
+
 describe( "tonegen", function() {
+
+  const silentfilename = "/tmp/silent.wav"
+
+  this.afterEach( async () => {
+    try{
+      await fs.unlink( silentfilename )
+    } catch( e ) { /* silent */ }
+    
+  } )
+
   it( "tone.generate exists", async function() {
     expect( projectrtp.tone.generate ).to.be.an( "function" )
   } )
+
+  it( "generate silence and ensure looped is silent", async function() {
+
+    this.timeout( 4000 )
+    this.slow( 3000 )
+
+    /* Trying to replicate a bug where we use the silence in a tone file to send silence */
+    projectrtp.tone.generate( "350+440*0.5:1000", silentfilename )
+    projectrtp.tone.generate( "400+450*0.5/0/400+450*0.5/0:400/200/400/2000", silentfilename )
+    projectrtp.tone.generate( "697+1209*0.5/0/697+1336*0.5/0/697+1477*0.5/0/697+1633*0.5/0:400/100", silentfilename )
+
+    const server = dgram.createSocket( "udp4" )
+
+    let done
+    const complete = new Promise( resolve => done = resolve )
+    let recvcount = 0
+    let allaregood = true
+    server.on( "message", function( dgm ) {
+      // check
+      const parsed = rtp.parsepk( dgm )
+
+      recvcount++
+
+      allaregood &&= Array.from( parsed.payload ).every( val => 255 === val )
+
+      if( 100 < recvcount ) channel.close()
+    } )
+
+    server.bind()
+    await new Promise( resolve => server.on( "listening", resolve() ) )
+
+    const ourport = server.address().port
+
+    const chandef = { "remote": { "address": "localhost", "port": ourport, "codec": 0 } }
+    const channel = await projectrtp.openchannel( chandef, function( d ) {
+      if( "close" === d.action ) {
+        server.close()
+        done()
+      }
+    } )
+
+    const prompt = { "wav": silentfilename, "start": 2100, "stop": 3100, "loop": 3 } //silent
+    const soup = { 
+      "files": [ prompt ], "interupt": true 
+    }
+
+    channel.play( soup )
+
+    await complete
+
+    expect( allaregood ).to.be.true
+
+  } )
 } )