@babblevoice/babble-drachtio-callmanager 2.3.24 → 2.3.26

package/lib/call.js

@@ -1854,7 +1854,7 @@ class call {
     const media = sdp.getmedia()
 
     let ip
-    if( sdp && sdp && sdp.sdp.connection && sdp.sdp.connection.ip ) {
+    if( sdp && sdp.sdp && sdp.sdp.connection && sdp.sdp.connection.ip ) {
       ip = sdp.sdp.connection.ip
     }
 
@@ -1869,7 +1869,7 @@ class call {
    */
   #handlehold( direction, res ) {
 
-    if(  "inactive" !== direction && "sendonly" !== direction ) return false
+    if( "inactive" !== direction && "sendonly" !== direction ) return false
 
     if( "sendonly" === direction ) this._hold( "recvonly" )
     else this._hold( direction )
@@ -1888,13 +1888,13 @@ class call {
   }
 
   /**
-   * We erceive a request to unhold.
-   * @param { string } direction 
+   * We receive a request to unhold.
+   * @param { string | undefined } direction undefined is the same as "sendrecv"
    * @param { object } res 
    * @returns { boolean }
    */
   #handleoffhold( direction, res ) {
-    if( "sendrecv" !== direction ) return false
+    if( direction && "sendrecv" !== direction ) return false
 
     this._unhold()
     res.send( 200, {
@@ -2993,6 +2993,7 @@ class call {
 
     newcall.options.headers[ "Allow-Events" ] = "talk, hold, presence, as-feature-event, dialog, call-info, sla, include-session-description, message-summary, refer"
     newcall.options.headers[ "Allow" ] = "INVITE, ACK, BYE, CANCEL, OPTIONS, MESSAGE, INFO, UPDATE, REGISTER, REFER, NOTIFY, PUBLISH, SUBSCRIBE"
+    newcall.options.headers[ "Supported" ] = "timer, path, replaces"
     
     newcall.#confignetwork( options )
     await newcall.#openchannelsfornewuac()

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@babblevoice/babble-drachtio-callmanager",
-  "version": "2.3.24",
+  "version": "2.3.26",
   "description": "Call processing to create a PBX",
   "main": "index.js",
   "scripts": {

package/test/interface/sdp.js

@@ -836,4 +836,66 @@ a=sendrecv
     expect( sdpilbc.selected ).to.deep.equal( { name: "ilbc", pt: 97, dpt: 110 } )
 
   } )
+
+  it( "Poly E220 hold", async () => {
+
+    const polysdp = `v=0
+o=- 1699364340 1699364341 IN IP4 82.19.206.102
+s=Polycom IP Phone
+c=IN IP4 82.19.206.102
+t=0 0
+a=sendonly
+m=audio 63558 RTP/AVP 9 127
+a=rtpmap:9 G722/8000
+a=rtpmap:127 telephone-event/8000
+a=sendonly
+`.replace( /\r\n/g, "\n" ).replace( /\n/g, "\r\n" )
+
+    const sdpobj = sdp.create( polysdp )
+
+    /* ref call.#getsdpformodify */
+    const media = sdpobj.getmedia()
+
+    let ip
+    if( sdpobj && sdpobj.sdp && sdpobj.sdp.connection && sdpobj.sdp.connection.ip ) {
+      ip = sdpobj.sdp.connection.ip
+    }
+
+    expect( ip ).to.equal( "82.19.206.102" )
+    expect( media.direction ).to.equal( "sendonly" )
+    
+  } )
+
+  it( "Poly E220 unhold", async () => {
+
+    const polysdp = `v=0
+o=- 1699364340 1699364342 IN IP4 82.19.206.102
+s=Polycom IP Phone
+c=IN IP4 82.19.206.102
+t=0 0
+a=sendrecv
+m=audio 63558 RTP/AVP 110 9 0 8 127
+a=rtpmap:110 iLBC/8000
+a=fmtp:110 mode=20
+a=rtpmap:9 G722/8000
+a=rtpmap:0 PCMU/8000
+a=rtpmap:8 PCMA/8000
+a=rtpmap:127 telephone-event/8000
+`.replace( /\r\n/g, "\n" ).replace( /\n/g, "\r\n" )
+
+    const sdpobj = sdp.create( polysdp )
+
+    /* ref call.#getsdpformodify */
+    const media = sdpobj.getmedia()
+
+    let ip
+    if( sdpobj && sdpobj.sdp && sdpobj.sdp.connection && sdpobj.sdp.connection.ip ) {
+      ip = sdpobj.sdp.connection.ip
+    }
+
+    expect( ip ).to.equal( "82.19.206.102" )
+    /* somewhere in the library - default is sendrecv so it is left undefined */
+    expect( media.direction ).to.be.undefined
+  } )
+
 } )