@b9g/shovel 0.2.0-beta.3 → 0.2.0-beta.4

package/bin/cli.js

@@ -23,7 +23,6 @@ import * as Platform from "@b9g/platform";
 
 // src/esbuild/watcher.ts
 import * as ESBuild from "esbuild";
-import { watch } from "fs";
 import { resolve, dirname as dirname2, join } from "path";
 import { readFileSync } from "fs";
 import { mkdir } from "fs/promises";
@@ -36,8 +35,8 @@ import { pathToFileURL } from "url";
 function importMetaPlugin() {
   return {
     name: "import-meta-transform",
-    setup(build3) {
-      build3.onLoad({ filter: /\.[jt]sx?$/, namespace: "file" }, async (args) => {
+    setup(build2) {
+      build2.onLoad({ filter: /\.[jt]sx?$/, namespace: "file" }, async (args) => {
         if (args.path.includes("node_modules")) {
           return null;
         }
@@ -82,115 +81,102 @@ function importMetaPlugin() {
 import { getLogger } from "@logtape/logtape";
 var logger = getLogger(["watcher"]);
 var Watcher = class {
-  #watcher;
-  #building;
   #options;
+  #ctx;
+  #initialBuildComplete = false;
+  #initialBuildSuccess = false;
+  #initialBuildResolve;
   constructor(options) {
-    this.#building = false;
     this.#options = options;
   }
   /**
    * Start watching and building
+   * @returns true if initial build succeeded, false if it failed
    */
   async start() {
     const entryPath = resolve(this.#options.entrypoint);
-    await this.#build();
-    const watchDir = dirname2(entryPath);
-    logger.info("Watching for changes", { watchDir });
-    this.#watcher = watch(
-      watchDir,
-      { recursive: true },
-      (_eventType, filename) => {
-        if (filename && (filename.endsWith(".js") || filename.endsWith(".ts") || filename.endsWith(".tsx"))) {
-          const outDir = this.#options.outDir || "dist";
-          if (filename.startsWith(outDir + "/") || filename.startsWith(outDir + "\\")) {
-            return;
+    const outputDir = resolve(this.#options.outDir);
+    const workspaceRoot = this.#findWorkspaceRoot();
+    await mkdir(join(outputDir, "server"), { recursive: true });
+    await mkdir(join(outputDir, "static"), { recursive: true });
+    const initialBuildPromise = new Promise((resolve3) => {
+      this.#initialBuildResolve = resolve3;
+    });
+    this.#ctx = await ESBuild.context({
+      entryPoints: [entryPath],
+      bundle: true,
+      format: "esm",
+      target: "es2022",
+      platform: "node",
+      outfile: `${outputDir}/server/app.js`,
+      // No packages: "external" - bundle everything for dev/prod parity
+      absWorkingDir: workspaceRoot,
+      plugins: [
+        importMetaPlugin(),
+        assetsPlugin({
+          outDir: outputDir
+        }),
+        // Plugin to detect build completion (works with watch mode)
+        {
+          name: "build-notify",
+          setup: (build2) => {
+            build2.onStart(() => {
+              logger.info("Building", {
+                entrypoint: this.#options.entrypoint
+              });
+            });
+            build2.onEnd((result) => {
+              const version = Date.now();
+              const success = result.errors.length === 0;
+              if (success) {
+                logger.info("Build complete", { version });
+              } else {
+                logger.error("Build errors", { errors: result.errors });
+              }
+              if (!this.#initialBuildComplete) {
+                this.#initialBuildComplete = true;
+                this.#initialBuildSuccess = success;
+                this.#initialBuildResolve?.(success);
+              } else {
+                this.#options.onBuild?.(success, version);
+              }
+            });
           }
-          this.#debouncedBuild();
         }
-      }
-    );
+      ],
+      sourcemap: "inline",
+      minify: false,
+      treeShaking: true
+    });
+    logger.info("Starting esbuild watch mode");
+    await this.#ctx.watch();
+    return initialBuildPromise;
   }
   /**
-   * Stop watching
+   * Stop watching and dispose of esbuild context
    */
   async stop() {
-    if (this.#watcher) {
-      this.#watcher.close();
-      this.#watcher = void 0;
+    if (this.#ctx) {
+      await this.#ctx.dispose();
+      this.#ctx = void 0;
     }
   }
-  #timeout;
-  #debouncedBuild() {
-    if (this.#timeout) {
-      clearTimeout(this.#timeout);
-    }
-    this.#timeout = setTimeout(() => {
-      this.#build();
-    }, 100);
-  }
-  async #build() {
-    if (this.#building)
-      return;
-    this.#building = true;
-    try {
-      const entryPath = resolve(this.#options.entrypoint);
-      const outputDir = resolve(this.#options.outDir);
-      const version = Date.now();
-      const initialCwd = process.cwd();
-      let workspaceRoot = initialCwd;
-      while (workspaceRoot !== dirname2(workspaceRoot)) {
-        try {
-          const packageJSON = JSON.parse(
-            readFileSync(resolve(workspaceRoot, "package.json"), "utf8")
-          );
-          if (packageJSON.workspaces) {
-            break;
-          }
-        } catch {
+  #findWorkspaceRoot() {
+    const initialCwd = process.cwd();
+    let workspaceRoot = initialCwd;
+    while (workspaceRoot !== dirname2(workspaceRoot)) {
+      try {
+        const packageJSON = JSON.parse(
+          readFileSync(resolve(workspaceRoot, "package.json"), "utf8")
+        );
+        if (packageJSON.workspaces) {
+          return workspaceRoot;
         }
-        workspaceRoot = dirname2(workspaceRoot);
+      } catch {
       }
-      if (workspaceRoot === dirname2(workspaceRoot)) {
-        workspaceRoot = initialCwd;
-      }
-      logger.info("Building", { entryPath });
-      logger.info("Workspace root", { workspaceRoot });
-      await mkdir(join(outputDir, "server"), { recursive: true });
-      await mkdir(join(outputDir, "assets"), { recursive: true });
-      const result = await ESBuild.build({
-        entryPoints: [entryPath],
-        bundle: true,
-        format: "esm",
-        target: "es2022",
-        platform: "node",
-        outfile: `${outputDir}/server/app.js`,
-        packages: "external",
-        absWorkingDir: workspaceRoot,
-        plugins: [
-          importMetaPlugin(),
-          assetsPlugin({
-            outputDir: `${outputDir}/assets`,
-            manifest: `${outputDir}/server/asset-manifest.json`
-          })
-        ],
-        sourcemap: "inline",
-        minify: false,
-        treeShaking: true
-      });
-      if (result.errors.length > 0) {
-        logger.error("Build errors", { errors: result.errors });
-        this.#options.onBuild?.(false, version);
-      } else {
-        logger.info("Build complete", { version });
-        this.#options.onBuild?.(true, version);
-      }
-    } catch (error) {
-      logger.error("Build failed", { error });
-      this.#options.onBuild?.(false, Date.now());
-    } finally {
-      this.#building = false;
+      workspaceRoot = dirname2(workspaceRoot);
     }
+    return initialCwd;
   }
 };
 
@@ -248,9 +234,10 @@ async function developCommand(entrypoint, options) {
         }
       }
     });
-    logger2.info("Building", { entrypoint });
-    await watcher.start();
-    logger2.info("Build complete, watching for changes", {});
+    const buildSuccess = await watcher.start();
+    if (!buildSuccess) {
+      logger2.error("Initial build failed, watching for changes to retry", {});
+    }
     const builtEntrypoint = `${outDir}/server/app.js`;
     serviceWorker = await platformInstance.loadServiceWorker(builtEntrypoint, {
       hotReload: true,
@@ -277,8 +264,7 @@ async function developCommand(entrypoint, options) {
     process.on("SIGINT", () => shutdown("SIGINT"));
     process.on("SIGTERM", () => shutdown("SIGTERM"));
   } catch (error) {
-    logger2.error("Failed to start development server", {
-      error: error.message,
+    logger2.error("Failed to start development server:\n{stack}", {
       stack: error.stack
     });
     process.exit(1);
@@ -385,8 +371,7 @@ var BUILD_DEFAULTS = {
 };
 var BUILD_STRUCTURE = {
   serverDir: "server",
-  staticDir: "static",
-  assetsDir: "static/assets"
+  staticDir: "static"
 };
 async function buildForProduction({
   entrypoint,
@@ -414,7 +399,7 @@ async function buildForProduction({
   if (verbose) {
     logger5.info("Built app to", { outputDir: buildContext.outputDir });
     logger5.info("Server files", { dir: buildContext.serverDir });
-    logger5.info("Asset files", { dir: buildContext.assetsDir });
+    logger5.info("Static files", { dir: join2(buildContext.outputDir, "static") });
   }
 }
 async function initializeBuild({
@@ -462,7 +447,6 @@ async function initializeBuild({
     await mkdir2(outputDir, { recursive: true });
     await mkdir2(join2(outputDir, BUILD_STRUCTURE.serverDir), { recursive: true });
     await mkdir2(join2(outputDir, BUILD_STRUCTURE.staticDir), { recursive: true });
-    await mkdir2(join2(outputDir, BUILD_STRUCTURE.assetsDir), { recursive: true });
   } catch (error) {
     throw new Error(
       `Failed to create output directory structure: ${error.message}`
@@ -472,7 +456,6 @@ async function initializeBuild({
     entryPath,
     outputDir,
     serverDir: join2(outputDir, BUILD_STRUCTURE.serverDir),
-    assetsDir: join2(outputDir, BUILD_STRUCTURE.assetsDir),
     workspaceRoot,
     platform,
     verbose,
@@ -517,8 +500,8 @@ async function findShovelPackageRoot() {
 }
 async function createBuildConfig({
   entryPath,
+  outputDir,
   serverDir,
-  assetsDir,
   workspaceRoot,
   platform,
   workerCount
@@ -546,8 +529,7 @@ async function createBuildConfig({
         plugins: [
           importMetaPlugin(),
           assetsPlugin2({
-            outputDir: assetsDir,
-            manifest: join2(serverDir, "asset-manifest.json")
+            outDir: outputDir
           })
         ],
         metafile: true,
@@ -614,8 +596,7 @@ async function createBuildConfig({
       plugins: isCloudflare ? [
         importMetaPlugin(),
         assetsPlugin2({
-          outputDir: assetsDir,
-          manifest: join2(serverDir, "asset-manifest.json")
+          outDir: outputDir
         })
       ] : [],
       // Assets already handled in user code build

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@b9g/shovel",
-  "version": "0.2.0-beta.3",
+  "version": "0.2.0-beta.4",
   "description": "ServiceWorker-first universal deployment platform. Write ServiceWorker apps once, deploy anywhere (Node/Bun/Cloudflare). Registry-based multi-app orchestration.",
   "license": "MIT",
   "bin": {
@@ -21,13 +21,13 @@
     "source-map": "^0.7.4"
   },
   "devDependencies": {
-    "@b9g/assets": "^0.1.6",
+    "@b9g/assets": "^0.1.9",
     "@b9g/cache": "^0.1.4",
     "@b9g/crank": "^0.7.2",
     "@b9g/filesystem": "^0.1.5",
     "@b9g/http-errors": "^0.1.4",
     "@b9g/libuild": "^0.1.17",
-    "@b9g/platform": "^0.1.6",
+    "@b9g/platform": "^0.1.7",
     "@b9g/platform-bun": "^0.1.6",
     "@b9g/platform-cloudflare": "^0.1.5",
     "@b9g/platform-node": "^0.1.8",
@@ -38,7 +38,7 @@
   },
   "peerDependencies": {
     "@b9g/node-webworker": "^0.1.3",
-    "@b9g/platform": "^0.1.6",
+    "@b9g/platform": "^0.1.7",
     "@b9g/platform-node": "^0.1.8",
     "@b9g/platform-cloudflare": "^0.1.5",
     "@b9g/platform-bun": "^0.1.6",