@b9g/libuild 0.1.10 → 0.1.11

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.1.11] - 2025-11-02
+
+### Fixed
+- **CRITICAL**: Workspace dependencies (workspace:*) are now properly resolved to actual version numbers during build
+- Validation warnings for valid libuild output paths (dist/src/ files that libuild creates)
+
 ## [0.1.10] - 2025-10-29
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@b9g/libuild",
-  "version": "0.1.10",
+  "version": "0.1.11",
   "description": "Zero-config library builds",
   "keywords": [
     "build",

package/src/libuild.cjs

@@ -215463,67 +215463,70 @@ function transformSrcToDist(value) {
   }
   return value;
 }
-async function validateBinPaths(value, srcDir, fieldName = "bin") {
+async function validateBinPaths(value, cwd, save, fieldName = "bin") {
   if (typeof value === "string") {
-    await validateSingleBinPath(value, fieldName, srcDir);
+    await validateSingleBinPath(value, fieldName, cwd, save);
   } else if (typeof value === "object" && value !== null) {
     for (const [key, val] of Object.entries(value)) {
       if (typeof val === "string") {
-        await validateSingleBinPath(val, `${fieldName}.${key}`, srcDir);
+        await validateSingleBinPath(val, `${fieldName}.${key}`, cwd, save);
       }
     }
   }
 }
-async function validateSingleBinPath(binPath, fieldName, srcDir) {
-  if (binPath.startsWith("dist/") || binPath.startsWith("./dist/")) {
-    let srcPath;
-    if (binPath.startsWith("./dist/src/")) {
-      srcPath = binPath.replace("./dist/src/", "src/");
-    } else if (binPath.startsWith("dist/src/")) {
-      srcPath = binPath.replace("dist/src/", "src/");
-    } else if (binPath.startsWith("./dist/")) {
-      srcPath = binPath.replace("./dist/", "src/");
-    } else if (binPath.startsWith("dist/")) {
-      srcPath = binPath.replace("dist/", "src/");
-    } else {
-      srcPath = "";
+async function validateSingleBinPath(binPath, fieldName, cwd, save) {
+  if (save) {
+    return;
+  }
+  if (binPath.startsWith("dist/src/") || binPath.startsWith("./dist/src/")) {
+    const fullPath2 = Path3.join(cwd, binPath);
+    const distExists = await fileExists(fullPath2);
+    if (distExists) {
+      return;
     }
-    const basePath = srcPath.replace(/\.(js|cjs)$/, "");
-    const tsPath = Path3.join(srcDir, "..", basePath + ".ts");
-    const jsPath = Path3.join(srcDir, "..", basePath + ".js");
+    const srcPath = binPath.startsWith("./dist/src/") ? binPath.replace("./dist/src/", "src/") : binPath.replace("dist/src/", "src/");
+    const basePath = srcPath.replace(/\.(js|cjs|mjs)$/, "");
+    const tsPath = Path3.join(cwd, basePath + ".ts");
+    const jsPath = Path3.join(cwd, basePath + ".js");
     const srcExists = await fileExists(tsPath) || await fileExists(jsPath);
     if (!srcExists) {
-      throw new Error(`${fieldName} field points to dist/ directory: "${binPath}"
-
-The bin field should reference source files that libuild will build and transform:
-  CORRECT:   "bin": {"tool": "src/cli.js"}
-  INCORRECT: "bin": {"tool": "dist/cli.js"}
-
-Libuild workflow:
-1. Point bin entries to src/ files
-2. Run 'libuild build --save' to update package.json with dist/ paths
-3. Set "private": true in your development package.json
-
-If you need to include pre-built executable files, use the files field instead:
-  "files": ["scripts/my-tool.js"]`);
+      console.warn(`\u26A0\uFE0F  WARNING: ${fieldName} field points to "${binPath}" but neither the dist file nor corresponding src file exists.
+   
+   Create "${srcPath}" and run 'libuild build --save' to update paths correctly.`);
+      return;
     }
-    console.warn(`\u26A0\uFE0F  WARNING: ${fieldName} field points to dist/ directory: "${binPath}"
+    console.warn(`\u26A0\uFE0F  WARNING: ${fieldName} field points to "${binPath}" which doesn't exist yet.
    
-   libuild is ZERO-CONFIG - there is no libuild.config.js file!
-   Configuration comes from your package.json fields.
+   Run 'libuild build' to create the dist files, or use 'libuild build --save' to update the path to "${srcPath}".`);
+    return;
+  }
+  if (binPath.startsWith("dist/") || binPath.startsWith("./dist/")) {
+    console.warn(`\u26A0\uFE0F  WARNING: ${fieldName} field points to "${binPath}" in dist/ directory.
    
-   The libuild workflow is to point bin entries to src/ files and use --save to update paths.
-   Consider changing to: "${srcPath}" and running 'libuild build --save'`);
+   libuild expects bin entries to point to src/ files. Consider changing to the corresponding src/ path and using --save.`);
     return;
   }
-  if (binPath.startsWith("src/") || binPath.startsWith("./src/")) {
+  const fullPath = Path3.join(cwd, binPath);
+  const pathExists = await fileExists(fullPath);
+  if (pathExists) {
     return;
   }
-  if (!binPath.startsWith("src/") && !binPath.startsWith("./src/")) {
-    console.warn(`\u26A0\uFE0F  WARNING: ${fieldName} field points to "${binPath}" which is not in src/ directory.
-   Consider moving executable to src/ or using the files field for pre-built scripts.
-   Run 'libuild build --save' after fixing to update paths correctly.`);
+  if (binPath.startsWith("src/") || binPath.startsWith("./src/")) {
+    const basePath = fullPath.replace(/\.(js|cjs|mjs)$/, "");
+    const tsPath = basePath + ".ts";
+    const jsPath = basePath + ".js";
+    const tsExists = await fileExists(tsPath);
+    const jsExists = await fileExists(jsPath);
+    if (tsExists || jsExists) {
+      return;
+    }
   }
+  console.warn(`\u26A0\uFE0F  WARNING: ${fieldName} field points to "${binPath}" which doesn't exist
+   
+   libuild is ZERO-CONFIG - there is no libuild.config.js file!
+   Configuration comes from your package.json fields.
+   
+   Use 'libuild build --save' to update package.json with correct dist/ paths automatically.`);
 }
 function transformBinPaths(value) {
   if (typeof value === "string") {
@@ -215581,7 +215584,66 @@ function fixExportsForDist(obj) {
   }
   return obj;
 }
-function cleanPackageJSON(pkg, mainEntry, options) {
+async function resolveWorkspaceDependencies(dependencies, cwd) {
+  if (!dependencies)
+    return void 0;
+  const resolved = {};
+  for (const [depName, depVersion] of Object.entries(dependencies)) {
+    if (depVersion.startsWith("workspace:")) {
+      const resolvedVersion = await resolveWorkspaceVersion(depName, depVersion, cwd);
+      resolved[depName] = resolvedVersion;
+    } else {
+      resolved[depName] = depVersion;
+    }
+  }
+  return resolved;
+}
+async function resolveWorkspaceVersion(packageName, workspaceSpec, cwd) {
+  try {
+    if (workspaceSpec === "workspace:*") {
+      const packageNameParts = packageName.replace("@", "").replace("/", "-");
+      const packageBaseName = packageName.split("/").pop() || packageName;
+      const possiblePaths = [
+        `../packages/${packageNameParts}/package.json`,
+        `../packages/${packageBaseName}/package.json`,
+        `../${packageNameParts}/package.json`,
+        `../${packageBaseName}/package.json`,
+        `./packages/${packageNameParts}/package.json`,
+        `./packages/${packageBaseName}/package.json`,
+        `./${packageNameParts}/package.json`,
+        `./${packageBaseName}/package.json`
+      ];
+      for (const pkgPath of possiblePaths) {
+        try {
+          const resolvedPath = Path3.resolve(cwd, pkgPath);
+          if (await fileExists(resolvedPath)) {
+            const pkgContent = await FS3.readFile(resolvedPath, "utf-8");
+            const pkgJson = JSON.parse(pkgContent);
+            if (pkgJson.name === packageName) {
+              console.info(`  Resolved workspace:* dependency "${packageName}" to ^${pkgJson.version}`);
+              return `^${pkgJson.version}`;
+            }
+          }
+        } catch {
+          continue;
+        }
+      }
+      console.warn(`\u26A0\uFE0F  WARNING: Could not resolve workspace dependency "${packageName}" - keeping as workspace:*`);
+      console.warn(`    Searched in: ${possiblePaths.map((p) => Path3.resolve(cwd, p)).join(", ")}`);
+      return workspaceSpec;
+    }
+    const versionPart = workspaceSpec.replace("workspace:", "");
+    if (versionPart !== "*") {
+      console.info(`  Resolved workspace:${versionPart} dependency "${packageName}" to ${versionPart}`);
+      return versionPart;
+    }
+    return workspaceSpec;
+  } catch (error) {
+    console.warn(`\u26A0\uFE0F  WARNING: Error resolving workspace dependency "${packageName}": ${error.message}`);
+    return workspaceSpec;
+  }
+}
+async function cleanPackageJSON(pkg, mainEntry, options, cwd) {
   const cleaned = {
     name: pkg.name,
     version: pkg.version
@@ -215632,6 +215694,8 @@ function cleanPackageJSON(pkg, mainEntry, options) {
         cleaned[field] = transformBinPaths(pkg[field]);
       } else if (pathFields.includes(field)) {
         cleaned[field] = transformSrcToDist(pkg[field]);
+      } else if (field === "dependencies" || field === "devDependencies" || field === "peerDependencies" || field === "optionalDependencies") {
+        cleaned[field] = await resolveWorkspaceDependencies(pkg[field], cwd);
       } else {
         cleaned[field] = pkg[field];
       }
@@ -215681,7 +215745,7 @@ async function build2(cwd, save = false) {
   const pkgPath = Path3.join(cwd, "package.json");
   const pkg = JSON.parse(await FS3.readFile(pkgPath, "utf-8"));
   if (pkg.bin) {
-    await validateBinPaths(pkg.bin, srcDir, "bin");
+    await validateBinPaths(pkg.bin, cwd, save, "bin");
   }
   if (!pkg.private) {
     console.warn("\u26A0\uFE0F  WARNING: Root package.json is not private - this could lead to accidental publishing of development package.json");
@@ -215826,7 +215890,7 @@ async function build2(cwd, save = false) {
   }
   const autoDiscoveredFiles = [];
   console.info("  Generating package.json...");
-  const cleanedPkg = cleanPackageJSON(pkg, mainEntry, options);
+  const cleanedPkg = await cleanPackageJSON(pkg, mainEntry, options, cwd);
   const exportsResult = generateExports(entries, mainEntry, options, pkg.exports);
   cleanedPkg.exports = fixExportsForDist(exportsResult.exports);
   if (exportsResult.staleExports.length > 0) {

package/src/libuild.js

@@ -442,67 +442,70 @@ function transformSrcToDist(value) {
   }
   return value;
 }
-async function validateBinPaths(value, srcDir, fieldName = "bin") {
+async function validateBinPaths(value, cwd, save, fieldName = "bin") {
   if (typeof value === "string") {
-    await validateSingleBinPath(value, fieldName, srcDir);
+    await validateSingleBinPath(value, fieldName, cwd, save);
   } else if (typeof value === "object" && value !== null) {
     for (const [key, val] of Object.entries(value)) {
       if (typeof val === "string") {
-        await validateSingleBinPath(val, `${fieldName}.${key}`, srcDir);
+        await validateSingleBinPath(val, `${fieldName}.${key}`, cwd, save);
       }
     }
   }
 }
-async function validateSingleBinPath(binPath, fieldName, srcDir) {
-  if (binPath.startsWith("dist/") || binPath.startsWith("./dist/")) {
-    let srcPath;
-    if (binPath.startsWith("./dist/src/")) {
-      srcPath = binPath.replace("./dist/src/", "src/");
-    } else if (binPath.startsWith("dist/src/")) {
-      srcPath = binPath.replace("dist/src/", "src/");
-    } else if (binPath.startsWith("./dist/")) {
-      srcPath = binPath.replace("./dist/", "src/");
-    } else if (binPath.startsWith("dist/")) {
-      srcPath = binPath.replace("dist/", "src/");
-    } else {
-      srcPath = "";
+async function validateSingleBinPath(binPath, fieldName, cwd, save) {
+  if (save) {
+    return;
+  }
+  if (binPath.startsWith("dist/src/") || binPath.startsWith("./dist/src/")) {
+    const fullPath2 = Path3.join(cwd, binPath);
+    const distExists = await fileExists(fullPath2);
+    if (distExists) {
+      return;
     }
-    const basePath = srcPath.replace(/\.(js|cjs)$/, "");
-    const tsPath = Path3.join(srcDir, "..", basePath + ".ts");
-    const jsPath = Path3.join(srcDir, "..", basePath + ".js");
+    const srcPath = binPath.startsWith("./dist/src/") ? binPath.replace("./dist/src/", "src/") : binPath.replace("dist/src/", "src/");
+    const basePath = srcPath.replace(/\.(js|cjs|mjs)$/, "");
+    const tsPath = Path3.join(cwd, basePath + ".ts");
+    const jsPath = Path3.join(cwd, basePath + ".js");
     const srcExists = await fileExists(tsPath) || await fileExists(jsPath);
     if (!srcExists) {
-      throw new Error(`${fieldName} field points to dist/ directory: "${binPath}"
-
-The bin field should reference source files that libuild will build and transform:
-  CORRECT:   "bin": {"tool": "src/cli.js"}
-  INCORRECT: "bin": {"tool": "dist/cli.js"}
-
-Libuild workflow:
-1. Point bin entries to src/ files
-2. Run 'libuild build --save' to update package.json with dist/ paths
-3. Set "private": true in your development package.json
-
-If you need to include pre-built executable files, use the files field instead:
-  "files": ["scripts/my-tool.js"]`);
+      console.warn(`\u26A0\uFE0F  WARNING: ${fieldName} field points to "${binPath}" but neither the dist file nor corresponding src file exists.
+   
+   Create "${srcPath}" and run 'libuild build --save' to update paths correctly.`);
+      return;
     }
-    console.warn(`\u26A0\uFE0F  WARNING: ${fieldName} field points to dist/ directory: "${binPath}"
+    console.warn(`\u26A0\uFE0F  WARNING: ${fieldName} field points to "${binPath}" which doesn't exist yet.
    
-   libuild is ZERO-CONFIG - there is no libuild.config.js file!
-   Configuration comes from your package.json fields.
+   Run 'libuild build' to create the dist files, or use 'libuild build --save' to update the path to "${srcPath}".`);
+    return;
+  }
+  if (binPath.startsWith("dist/") || binPath.startsWith("./dist/")) {
+    console.warn(`\u26A0\uFE0F  WARNING: ${fieldName} field points to "${binPath}" in dist/ directory.
    
-   The libuild workflow is to point bin entries to src/ files and use --save to update paths.
-   Consider changing to: "${srcPath}" and running 'libuild build --save'`);
+   libuild expects bin entries to point to src/ files. Consider changing to the corresponding src/ path and using --save.`);
     return;
   }
-  if (binPath.startsWith("src/") || binPath.startsWith("./src/")) {
+  const fullPath = Path3.join(cwd, binPath);
+  const pathExists = await fileExists(fullPath);
+  if (pathExists) {
     return;
   }
-  if (!binPath.startsWith("src/") && !binPath.startsWith("./src/")) {
-    console.warn(`\u26A0\uFE0F  WARNING: ${fieldName} field points to "${binPath}" which is not in src/ directory.
-   Consider moving executable to src/ or using the files field for pre-built scripts.
-   Run 'libuild build --save' after fixing to update paths correctly.`);
+  if (binPath.startsWith("src/") || binPath.startsWith("./src/")) {
+    const basePath = fullPath.replace(/\.(js|cjs|mjs)$/, "");
+    const tsPath = basePath + ".ts";
+    const jsPath = basePath + ".js";
+    const tsExists = await fileExists(tsPath);
+    const jsExists = await fileExists(jsPath);
+    if (tsExists || jsExists) {
+      return;
+    }
   }
+  console.warn(`\u26A0\uFE0F  WARNING: ${fieldName} field points to "${binPath}" which doesn't exist
+   
+   libuild is ZERO-CONFIG - there is no libuild.config.js file!
+   Configuration comes from your package.json fields.
+   
+   Use 'libuild build --save' to update package.json with correct dist/ paths automatically.`);
 }
 function transformBinPaths(value) {
   if (typeof value === "string") {
@@ -560,7 +563,66 @@ function fixExportsForDist(obj) {
   }
   return obj;
 }
-function cleanPackageJSON(pkg, mainEntry, options) {
+async function resolveWorkspaceDependencies(dependencies, cwd) {
+  if (!dependencies)
+    return void 0;
+  const resolved = {};
+  for (const [depName, depVersion] of Object.entries(dependencies)) {
+    if (depVersion.startsWith("workspace:")) {
+      const resolvedVersion = await resolveWorkspaceVersion(depName, depVersion, cwd);
+      resolved[depName] = resolvedVersion;
+    } else {
+      resolved[depName] = depVersion;
+    }
+  }
+  return resolved;
+}
+async function resolveWorkspaceVersion(packageName, workspaceSpec, cwd) {
+  try {
+    if (workspaceSpec === "workspace:*") {
+      const packageNameParts = packageName.replace("@", "").replace("/", "-");
+      const packageBaseName = packageName.split("/").pop() || packageName;
+      const possiblePaths = [
+        `../packages/${packageNameParts}/package.json`,
+        `../packages/${packageBaseName}/package.json`,
+        `../${packageNameParts}/package.json`,
+        `../${packageBaseName}/package.json`,
+        `./packages/${packageNameParts}/package.json`,
+        `./packages/${packageBaseName}/package.json`,
+        `./${packageNameParts}/package.json`,
+        `./${packageBaseName}/package.json`
+      ];
+      for (const pkgPath of possiblePaths) {
+        try {
+          const resolvedPath = Path3.resolve(cwd, pkgPath);
+          if (await fileExists(resolvedPath)) {
+            const pkgContent = await FS3.readFile(resolvedPath, "utf-8");
+            const pkgJson = JSON.parse(pkgContent);
+            if (pkgJson.name === packageName) {
+              console.info(`  Resolved workspace:* dependency "${packageName}" to ^${pkgJson.version}`);
+              return `^${pkgJson.version}`;
+            }
+          }
+        } catch {
+          continue;
+        }
+      }
+      console.warn(`\u26A0\uFE0F  WARNING: Could not resolve workspace dependency "${packageName}" - keeping as workspace:*`);
+      console.warn(`    Searched in: ${possiblePaths.map((p) => Path3.resolve(cwd, p)).join(", ")}`);
+      return workspaceSpec;
+    }
+    const versionPart = workspaceSpec.replace("workspace:", "");
+    if (versionPart !== "*") {
+      console.info(`  Resolved workspace:${versionPart} dependency "${packageName}" to ${versionPart}`);
+      return versionPart;
+    }
+    return workspaceSpec;
+  } catch (error) {
+    console.warn(`\u26A0\uFE0F  WARNING: Error resolving workspace dependency "${packageName}": ${error.message}`);
+    return workspaceSpec;
+  }
+}
+async function cleanPackageJSON(pkg, mainEntry, options, cwd) {
   const cleaned = {
     name: pkg.name,
     version: pkg.version
@@ -611,6 +673,8 @@ function cleanPackageJSON(pkg, mainEntry, options) {
         cleaned[field] = transformBinPaths(pkg[field]);
       } else if (pathFields.includes(field)) {
         cleaned[field] = transformSrcToDist(pkg[field]);
+      } else if (field === "dependencies" || field === "devDependencies" || field === "peerDependencies" || field === "optionalDependencies") {
+        cleaned[field] = await resolveWorkspaceDependencies(pkg[field], cwd);
       } else {
         cleaned[field] = pkg[field];
       }
@@ -660,7 +724,7 @@ async function build2(cwd, save = false) {
   const pkgPath = Path3.join(cwd, "package.json");
   const pkg = JSON.parse(await FS3.readFile(pkgPath, "utf-8"));
   if (pkg.bin) {
-    await validateBinPaths(pkg.bin, srcDir, "bin");
+    await validateBinPaths(pkg.bin, cwd, save, "bin");
   }
   if (!pkg.private) {
     console.warn("\u26A0\uFE0F  WARNING: Root package.json is not private - this could lead to accidental publishing of development package.json");
@@ -805,7 +869,7 @@ async function build2(cwd, save = false) {
   }
   const autoDiscoveredFiles = [];
   console.info("  Generating package.json...");
-  const cleanedPkg = cleanPackageJSON(pkg, mainEntry, options);
+  const cleanedPkg = await cleanPackageJSON(pkg, mainEntry, options, cwd);
   const exportsResult = generateExports(entries, mainEntry, options, pkg.exports);
   cleanedPkg.exports = fixExportsForDist(exportsResult.exports);
   if (exportsResult.staleExports.length > 0) {