@azure/storage-file-share 12.8.0-beta.1 → 12.8.1-alpha.20211025.1

package/dist-esm/src/Clients.js

@@ -28,7 +28,10 @@ import { generateFileSASQueryParameters } from "./FileSASSignatureValues";
  * A ShareClient represents a URL to the Azure Storage share allowing you to manipulate its directories and files.
  */
 export class ShareClient extends StorageClient {
-    constructor(urlOrConnectionString, credentialOrPipelineOrShareName, options) {
+    constructor(urlOrConnectionString, credentialOrPipelineOrShareName, 
+    // Legacy, no way to fix the eslint error without breaking. Disable the rule for this line.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-options */
+    options) {
         let pipeline;
         let url;
         if (credentialOrPipelineOrShareName instanceof Pipeline) {
@@ -156,6 +159,8 @@ export class ShareClient extends StorageClient {
      * @param directoryName - A directory name
      * @returns The ShareDirectoryClient object for the given directory name.
      */
+    // Legacy, no way to fix the eslint error without breaking. Disable the rule for this line.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-subclients */
     getDirectoryClient(directoryName) {
         return new ShareDirectoryClient(appendToURLPath(this.url, encodeURIComponent(directoryName)), this.pipeline);
     }
@@ -165,6 +170,8 @@ export class ShareClient extends StorageClient {
      *
      * @readonly A new ShareDirectoryClient object for the root directory.
      */
+    // Legacy, no way to fix the eslint error without breaking. Disable the rule for this line.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-subclients */
     get rootDirectoryClient() {
         return this.getDirectoryClient("");
     }
@@ -993,6 +1000,8 @@ export class ShareDirectoryClient extends StorageClient {
      * console.log("Updated file successfully!")
      * ```
      */
+    // Legacy, no way to fix the eslint error without breaking. Disable the rule for this line.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-subclients */
     getFileClient(fileName) {
         return new ShareFileClient(appendToURLPath(this.url, encodeURIComponent(fileName)), this.pipeline);
     }
@@ -1585,8 +1594,12 @@ export class ShareDirectoryClient extends StorageClient {
             do {
                 const response = await this.forceCloseHandlesSegment(marker, updatedOptions);
                 marker = response.marker;
-                response.closedHandlesCount && (handlesClosed += response.closedHandlesCount);
-                response.closeFailureCount && (numberOfHandlesFailedToClose += response.closeFailureCount);
+                if (response.closedHandlesCount) {
+                    handlesClosed += response.closedHandlesCount;
+                }
+                if (response.closeFailureCount) {
+                    numberOfHandlesFailedToClose += response.closeFailureCount;
+                }
             } while (marker);
             return { closedHandlesCount: handlesClosed, closeFailureCount: numberOfHandlesFailedToClose };
         }
@@ -1639,7 +1652,10 @@ export class ShareDirectoryClient extends StorageClient {
  * A ShareFileClient represents a URL to an Azure Storage file.
  */
 export class ShareFileClient extends StorageClient {
-    constructor(url, credentialOrPipeline, options) {
+    constructor(url, credentialOrPipeline, 
+    // Legacy, no way to fix the eslint error without breaking. Disable the rule for this line.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-options */
+    options) {
         let pipeline;
         if (credentialOrPipeline instanceof Pipeline) {
             pipeline = credentialOrPipeline;
@@ -1824,7 +1840,7 @@ export class ShareFileClient extends StorageClient {
                 throw new RangeError(`File download response doesn't contain valid content length header`);
             }
             return new FileDownloadResponse(res, async (start) => {
-                const updatedOptions = {
+                const updatedDownloadOptions = {
                     range: rangeToString({
                         count: offset + res.contentLength - start,
                         offset: start
@@ -1833,10 +1849,10 @@ export class ShareFileClient extends StorageClient {
                 // Debug purpose only
                 // console.log(
                 //   `Read from internal stream, range: ${
-                //     updatedOptions.range
-                //   }, options: ${JSON.stringify(updatedOptions)}`
+                //     chunkDownloadOptions.range
+                //   }, options: ${JSON.stringify(chunkDownloadOptions)}`
                 // );
-                const downloadRes = await this.context.download(Object.assign(Object.assign({ abortSignal: options.abortSignal, leaseAccessConditions: options.leaseAccessConditions }, updatedOptions), convertTracingToRequestOptionsBase(updatedOptions)));
+                const downloadRes = await this.context.download(Object.assign(Object.assign({ abortSignal: options.abortSignal, leaseAccessConditions: options.leaseAccessConditions }, updatedDownloadOptions), convertTracingToRequestOptionsBase(updatedDownloadOptions)));
                 if (!(downloadRes.etag === res.etag)) {
                     throw new Error("File has been modified concurrently");
                 }
@@ -2896,8 +2912,12 @@ export class ShareFileClient extends StorageClient {
             do {
                 const response = await this.forceCloseHandlesSegment(marker, { tracingOptions: updatedOptions.tracingOptions });
                 marker = response.marker;
-                response.closedHandlesCount && (handlesClosed += response.closedHandlesCount);
-                response.closeFailureCount && (numberOfHandlesFailedToClose += response.closeFailureCount);
+                if (response.closedHandlesCount) {
+                    handlesClosed += response.closedHandlesCount;
+                }
+                if (response.closeFailureCount) {
+                    numberOfHandlesFailedToClose += response.closeFailureCount;
+                }
             } while (marker);
             return {
                 closedHandlesCount: handlesClosed,