@azure/storage-blob 12.8.0-beta.1 → 12.8.0

package/CHANGELOG.md

@@ -1,6 +1,12 @@
 # Release History
 
-## 12.8.0-beta.1 (2021-07-26)
+## 12.8.0 (2021-09-10)
+
+### Features Added
+
+- Includes all features released in 12.8.0-beta.1.
+
+## 12.8.0-beta.1 (2021-07-28)
 
 ### Features Added
 
@@ -13,7 +19,12 @@
 - Added support for OAuth copy sources for synchronous copy operations.
 - Added support for Parquet as an input format in `BlockBlobClient.query()`.
 - With the dropping of support for Node.js versions that are no longer in LTS, the dependency on `@types/node` has been updated to version 12. Read our [support policy](https://github.com/Azure/azure-sdk-for-js/blob/main/SUPPORT.md) for more details.
+
+## 12.7.0 (2021-08-02)
+
+- Support for Node.js 8 and IE 11 has been dropped. Please see our [support policy](https://github.com/Azure/azure-sdk-for-js/blob/main/SUPPORT.md) for more details.
 - Changed TS compilation target to ES2017 in order to produce smaller bundles and use more native platform features
+- Updated our internal core package dependencies to their latest versions in order to add support for Opentelemetry 1.0.0 which is compatible with the latest versions of our other client libraries.
 
 ## 12.6.0 (2021-06-09)
 

package/dist/index.js

@@ -13150,7 +13150,7 @@ const logger = logger$1.createClientLogger("storage-blob");
 
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
-const SDK_VERSION = "12.8.0-beta.1";
+const SDK_VERSION = "12.8.0";
 const SERVICE_VERSION = "2020-10-02";
 const BLOCK_BLOB_MAX_UPLOAD_BLOB_BYTES = 256 * 1024 * 1024; // 256MB
 const BLOCK_BLOB_MAX_STAGE_BLOCK_BYTES = 4000 * 1024 * 1024; // 4000MB
@@ -13592,7 +13592,7 @@ function getURLPathAndQuery(url) {
     }
     let queryString = urlParsed.getQuery() || "";
     queryString = queryString.trim();
-    if (queryString != "") {
+    if (queryString !== "") {
         queryString = queryString.startsWith("?") ? queryString : `?${queryString}`; // Ensure query string start with '?'
     }
     return `${pathString}${queryString}`;
@@ -13693,6 +13693,7 @@ function generateBlockID(blockIDPrefix, blockIndex) {
  */
 async function delay(timeInMs, aborter, abortError) {
     return new Promise((resolve, reject) => {
+        /* eslint-disable-next-line prefer-const */
         let timeout;
         const abortHandler = () => {
             if (timeout !== undefined) {
@@ -13720,8 +13721,7 @@ async function delay(timeInMs, aborter, abortError) {
  * @param padString -
  */
 function padStart(currentString, targetLength, padString = " ") {
-    // TS doesn't know this code needs to run downlevel sometimes.
-    // @ts-expect-error
+    // @ts-expect-error: TS doesn't know this code needs to run downlevel sometimes
     if (String.prototype.padStart) {
         return currentString.padStart(targetLength, padString);
     }
@@ -13776,10 +13776,10 @@ function getAccountNameFromUrl(url) {
     }
 }
 function isIpEndpointStyle(parsedUrl) {
-    if (parsedUrl.getHost() == undefined) {
+    if (parsedUrl.getHost() === undefined) {
         return false;
     }
-    const host = parsedUrl.getHost() + (parsedUrl.getPort() == undefined ? "" : ":" + parsedUrl.getPort());
+    const host = parsedUrl.getHost() + (parsedUrl.getPort() === undefined ? "" : ":" + parsedUrl.getPort());
     // Case 1: Ipv6, use a broad regex to find out candidates whose host contains two ':'.
     // Case 2: localhost(:port), use broad regex to match port part.
     // Case 3: Ipv4, use broad regex which just check if host contains Ipv4.
@@ -13797,7 +13797,7 @@ function toBlobTagsString(tags) {
     }
     const tagPairs = [];
     for (const key in tags) {
-        if (tags.hasOwnProperty(key)) {
+        if (Object.prototype.hasOwnProperty.call(tags, key)) {
             const value = tags[key];
             tagPairs.push(`${encodeURIComponent(key)}=${encodeURIComponent(value)}`);
         }
@@ -13817,7 +13817,7 @@ function toBlobTags(tags) {
         blobTagSet: []
     };
     for (const key in tags) {
-        if (tags.hasOwnProperty(key)) {
+        if (Object.prototype.hasOwnProperty.call(tags, key)) {
             const value = tags[key];
             res.blobTagSet.push({
                 key,
@@ -13937,9 +13937,7 @@ function attachCredential(thing, credential) {
     return thing;
 }
 function httpAuthorizationToString(httpAuthorization) {
-    return httpAuthorization
-        ? httpAuthorization.scheme + " " + httpAuthorization.parameter
-        : undefined;
+    return httpAuthorization ? httpAuthorization.scheme + " " + httpAuthorization.value : undefined;
 }
 
 // Copyright (c) Microsoft Corporation.
@@ -13960,6 +13958,8 @@ class StorageBrowserPolicy extends coreHttp.BaseRequestPolicy {
      * @param nextPolicy -
      * @param options -
      */
+    // The base class has a protected constructor. Adding a public one to enable constructing of this class.
+    /* eslint-disable-next-line @typescript-eslint/no-useless-constructor*/
     constructor(nextPolicy, options) {
         super(nextPolicy, options);
     }
@@ -14096,7 +14096,7 @@ class StorageRetryPolicy extends coreHttp.BaseRequestPolicy {
             }
         }
         await this.delay(isPrimaryRetry, attempt, request.abortSignal);
-        return await this.attemptSendRequest(request, secondaryHas404, ++attempt);
+        return this.attemptSendRequest(request, secondaryHas404, ++attempt);
     }
     /**
      * Decide whether to retry according to last HTTP response and retry counters.
@@ -14244,6 +14244,8 @@ class AnonymousCredentialPolicy extends CredentialPolicy {
      * @param nextPolicy -
      * @param options -
      */
+    // The base class has a protected constructor. Adding a public one to enable constructing of this class.
+    /* eslint-disable-next-line @typescript-eslint/no-useless-constructor*/
     constructor(nextPolicy, options) {
         super(nextPolicy, options);
     }
@@ -14262,11 +14264,7 @@ class Credential {
      * @param _nextPolicy -
      * @param _options -
      */
-    create(
-    // tslint:disable-next-line:variable-name
-    _nextPolicy, 
-    // tslint:disable-next-line:variable-name
-    _options) {
+    create(_nextPolicy, _options) {
         throw new Error("Method should be implemented in children classes.");
     }
 }
@@ -14372,6 +14370,20 @@ function getCachedDefaultHttpClient() {
 }
 
 // Copyright (c) Microsoft Corporation.
+/**
+ * A helper to decide if a given argument satisfies the Pipeline contract
+ * @param pipeline - An argument that may be a Pipeline
+ * @returns true when the argument satisfies the Pipeline contract
+ */
+function isPipelineLike(pipeline) {
+    if (!pipeline || typeof pipeline !== "object") {
+        return false;
+    }
+    const castPipeline = pipeline;
+    return (Array.isArray(castPipeline.factories) &&
+        typeof castPipeline.options === "object" &&
+        typeof castPipeline.toServiceClientOptions === "function");
+}
 /**
  * A Pipeline class containing HTTP request policies.
  * You can create a default Pipeline by calling {@link newPipeline}.
@@ -14568,7 +14580,7 @@ class StorageSharedKeyCredentialPolicy extends CredentialPolicy {
         if (queries) {
             const queryKeys = [];
             for (const key in queries) {
-                if (queries.hasOwnProperty(key)) {
+                if (Object.prototype.hasOwnProperty.call(queries, key)) {
                     const lowercaseKey = key.toLowerCase();
                     lowercaseQueries[lowercaseKey] = queries[key];
                     queryKeys.push(lowercaseKey);
@@ -14629,7 +14641,7 @@ class StorageSharedKeyCredential extends Credential {
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.
  */
 const packageName = "azure-storage-blob";
-const packageVersion = "12.7.0-beta.1";
+const packageVersion = "12.8.0";
 class StorageClientContext extends coreHttp.ServiceClient {
     /**
      * Initializes a new instance of the StorageClientContext class.
@@ -14714,6 +14726,7 @@ const createSpan = coreTracing.createSpanFunction({
 function convertTracingToRequestOptionsBase(options) {
     var _a, _b;
     return {
+        // By passing spanOptions if they exist at runtime, we're backwards compatible with @azure/core-tracing@preview.13 and earlier.
         spanOptions: (_a = options === null || options === void 0 ? void 0 : options.tracingOptions) === null || _a === void 0 ? void 0 : _a.spanOptions,
         tracingContext: (_b = options === null || options === void 0 ? void 0 : options.tracingOptions) === null || _b === void 0 ? void 0 : _b.tracingContext
     };
@@ -15154,7 +15167,7 @@ function ipRangeToString(ipRange) {
 /**
  * Represents the components that make up an Azure Storage SAS' query parameters. This type is not constructed directly
  * by the user; it is only generated by the {@link AccountSASSignatureValues} and {@link BlobSASSignatureValues}
- * types. Once generated, it can be encoded into a {@code String} and appended to a URL directly (though caution should
+ * types. Once generated, it can be encoded into a {@link String} and appended to a URL directly (though caution should
  * be taken here in case there are existing query parameters, which might affect the appropriate means of appending
  * these query parameters).
  *
@@ -16012,15 +16025,14 @@ class RetriableReadableStream extends stream.Readable {
                         .then((newSource) => {
                         this.source = newSource;
                         this.setSourceEventHandlers();
+                        return;
                     })
                         .catch((error) => {
                         this.destroy(error);
                     });
                 }
                 else {
-                    this.destroy(new Error(
-                    // tslint:disable-next-line:max-line-length
-                    `Data corruption failure: received less data than required and reached maxRetires limitation. Received data offset: ${this
+                    this.destroy(new Error(`Data corruption failure: received less data than required and reached maxRetires limitation. Received data offset: ${this
                         .offset - 1}, data needed offset: ${this.end}, retries: ${this.retries}, max retries: ${this.maxRetryRequests}`));
                 }
             }
@@ -17075,21 +17087,25 @@ class BlobQuickQueryStream extends stream.Readable {
             }
             switch (schema) {
                 case "com.microsoft.azure.storage.queryBlobContents.resultData":
-                    const data = obj.data;
-                    if (data instanceof Uint8Array === false) {
-                        throw Error("Invalid data in avro result record.");
-                    }
-                    if (!this.push(Buffer.from(data))) {
-                        this.avroPaused = true;
+                    {
+                        const data = obj.data;
+                        if (data instanceof Uint8Array === false) {
+                            throw Error("Invalid data in avro result record.");
+                        }
+                        if (!this.push(Buffer.from(data))) {
+                            this.avroPaused = true;
+                        }
                     }
                     break;
                 case "com.microsoft.azure.storage.queryBlobContents.progress":
-                    const bytesScanned = obj.bytesScanned;
-                    if (typeof bytesScanned !== "number") {
-                        throw Error("Invalid bytesScanned in avro progress record.");
-                    }
-                    if (this.onProgress) {
-                        this.onProgress({ loadedBytes: bytesScanned });
+                    {
+                        const bytesScanned = obj.bytesScanned;
+                        if (typeof bytesScanned !== "number") {
+                            throw Error("Invalid bytesScanned in avro progress record.");
+                        }
+                        if (this.onProgress) {
+                            this.onProgress({ loadedBytes: bytesScanned });
+                        }
                     }
                     break;
                 case "com.microsoft.azure.storage.queryBlobContents.end":
@@ -17562,7 +17578,7 @@ class BlobQueryResponse {
     PremiumPageBlobTier["P80"] = "P80";
 })(exports.PremiumPageBlobTier || (exports.PremiumPageBlobTier = {}));
 function toAccessTier(tier) {
-    if (tier == undefined) {
+    if (tier === undefined) {
         return undefined;
     }
     return tier; // No more check if string is a valid AccessTier, and left this to underlay logic to decide(service).
@@ -18389,11 +18405,14 @@ const fsCreateReadStream = fs.createReadStream;
  * append blob, or page blob.
  */
 class BlobClient extends StorageClient {
-    constructor(urlOrConnectionString, credentialOrPipelineOrContainerName, blobNameOrOptions, options) {
+    constructor(urlOrConnectionString, credentialOrPipelineOrContainerName, blobNameOrOptions, 
+    // Legacy, no fix for eslint error without breaking. Disable it for this interface.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-options*/
+    options) {
         options = options || {};
         let pipeline;
         let url;
-        if (credentialOrPipelineOrContainerName instanceof Pipeline) {
+        if (isPipelineLike(credentialOrPipelineOrContainerName)) {
             // (url: string, pipeline: Pipeline)
             url = urlOrConnectionString;
             pipeline = credentialOrPipelineOrContainerName;
@@ -18596,7 +18615,7 @@ class BlobClient extends StorageClient {
             }
             return new BlobDownloadResponse(wrappedRes, async (start) => {
                 var _a;
-                const updatedOptions = {
+                const updatedDownloadOptions = {
                     leaseAccessConditions: options.conditions,
                     modifiedAccessConditions: {
                         ifMatch: options.conditions.ifMatch || res.etag,
@@ -18620,7 +18639,7 @@ class BlobClient extends StorageClient {
                 //     updatedOptions.range
                 //   }, options: ${JSON.stringify(updatedOptions)}`
                 // );
-                return (await this.blobContext.download(Object.assign({ abortSignal: options.abortSignal }, updatedOptions))).readableStreamBody;
+                return (await this.blobContext.download(Object.assign({ abortSignal: options.abortSignal }, updatedDownloadOptions))).readableStreamBody;
             }, offset, res.contentLength, {
                 maxRetryRequests: options.maxRetryRequests,
                 onProgress: options.onProgress
@@ -19426,13 +19445,16 @@ class BlobClient extends StorageClient {
  * AppendBlobClient defines a set of operations applicable to append blobs.
  */
 class AppendBlobClient extends BlobClient {
-    constructor(urlOrConnectionString, credentialOrPipelineOrContainerName, blobNameOrOptions, options) {
+    constructor(urlOrConnectionString, credentialOrPipelineOrContainerName, blobNameOrOptions, 
+    // Legacy, no fix for eslint error without breaking. Disable it for this interface.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-options*/
+    options) {
         // In TypeScript we cannot simply pass all parameters to super() like below so have to duplicate the code instead.
         //   super(s, credentialOrPipelineOrContainerNameOrOptions, blobNameOrOptions, options);
         let pipeline;
         let url;
         options = options || {};
-        if (credentialOrPipelineOrContainerName instanceof Pipeline) {
+        if (isPipelineLike(credentialOrPipelineOrContainerName)) {
             // (url: string, pipeline: Pipeline)
             url = urlOrConnectionString;
             pipeline = credentialOrPipelineOrContainerName;
@@ -19675,13 +19697,16 @@ class AppendBlobClient extends BlobClient {
  * BlockBlobClient defines a set of operations applicable to block blobs.
  */
 class BlockBlobClient extends BlobClient {
-    constructor(urlOrConnectionString, credentialOrPipelineOrContainerName, blobNameOrOptions, options) {
+    constructor(urlOrConnectionString, credentialOrPipelineOrContainerName, blobNameOrOptions, 
+    // Legacy, no fix for eslint error without breaking. Disable it for this interface.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-options*/
+    options) {
         // In TypeScript we cannot simply pass all parameters to super() like below so have to duplicate the code instead.
         //   super(s, credentialOrPipelineOrContainerNameOrOptions, blobNameOrOptions, options);
         let pipeline;
         let url;
         options = options || {};
-        if (credentialOrPipelineOrContainerName instanceof Pipeline) {
+        if (isPipelineLike(credentialOrPipelineOrContainerName)) {
             // (url: string, pipeline: Pipeline)
             url = urlOrConnectionString;
             pipeline = credentialOrPipelineOrContainerName;
@@ -20317,13 +20342,16 @@ class BlockBlobClient extends BlobClient {
  * PageBlobClient defines a set of operations applicable to page blobs.
  */
 class PageBlobClient extends BlobClient {
-    constructor(urlOrConnectionString, credentialOrPipelineOrContainerName, blobNameOrOptions, options) {
+    constructor(urlOrConnectionString, credentialOrPipelineOrContainerName, blobNameOrOptions, 
+    // Legacy, no fix for eslint error without breaking. Disable it for this interface.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-options*/
+    options) {
         // In TypeScript we cannot simply pass all parameters to super() like below so have to duplicate the code instead.
         //   super(s, credentialOrPipelineOrContainerNameOrOptions, blobNameOrOptions, options);
         let pipeline;
         let url;
         options = options || {};
-        if (credentialOrPipelineOrContainerName instanceof Pipeline) {
+        if (isPipelineLike(credentialOrPipelineOrContainerName)) {
             // (url: string, pipeline: Pipeline)
             url = urlOrConnectionString;
             pipeline = credentialOrPipelineOrContainerName;
@@ -20758,7 +20786,7 @@ class BatchResponseParser {
     async parseBatchResponse() {
         // When logic reach here, suppose batch request has already succeeded with 202, so we can further parse
         // sub request's response.
-        if (this.batchResponse._response.status != HTTPURLConnection.HTTP_ACCEPTED) {
+        if (this.batchResponse._response.status !== HTTPURLConnection.HTTP_ACCEPTED) {
             throw new Error(`Invalid state: batch request failed with status: '${this.batchResponse._response.status}'.`);
         }
         const responseBodyAsText = await getBodyAsText(this.batchResponse);
@@ -20771,7 +20799,7 @@ class BatchResponseParser {
         // Note: subResponseCount == 1 is special case where sub request is invalid.
         // We try to prevent such cases through early validation, e.g. validate sub request count >= 1.
         // While in unexpected sub request invalid case, we allow sub response to be parsed and return to user.
-        if (subResponseCount != this.subRequests.size && subResponseCount != 1) {
+        if (subResponseCount !== this.subRequests.size && subResponseCount !== 1) {
             throw new Error("Invalid state: sub responses' count is not equal to sub requests' count.");
         }
         const deserializedSubResponses = new Array(subResponseCount);
@@ -20836,7 +20864,7 @@ class BatchResponseParser {
             // The Content-IDs are set to a valid index in the subrequests we sent. In the status code 202 path, we could expect it
             // to be 1-1 mapping from the [0, subRequests.size) to the Content-IDs returned. If not, we simply don't return that
             // unexpected subResponse in the parsed reponse and we can always look it up in the raw response for debugging purpose.
-            if (contentId != NOT_FOUND &&
+            if (contentId !== NOT_FOUND &&
                 Number.isInteger(contentId) &&
                 contentId >= 0 &&
                 contentId < this.subRequests.size &&
@@ -21131,7 +21159,7 @@ class InnerBatchRequest {
         }
         // Fast fail if url for sub request is invalid
         const path = getURLPath(subRequest.url);
-        if (!path || path == "") {
+        if (!path || path === "") {
             throw new RangeError(`Invalid url for sub request: '${subRequest.url}'`);
         }
     }
@@ -21174,6 +21202,8 @@ class BatchRequestAssemblePolicyFactory {
     }
 }
 class BatchHeaderFilterPolicy extends coreHttp.BaseRequestPolicy {
+    // The base class has a protected constructor. Adding a public one to enable constructing of this class.
+    /* eslint-disable-next-line @typescript-eslint/no-useless-constructor*/
     constructor(nextPolicy, options) {
         super(nextPolicy, options);
     }
@@ -21191,7 +21221,6 @@ class BatchHeaderFilterPolicy extends coreHttp.BaseRequestPolicy {
     }
 }
 class BatchHeaderFilterPolicyFactory {
-    constructor() { }
     create(nextPolicy, options) {
         return new BatchHeaderFilterPolicy(nextPolicy, options);
     }
@@ -21204,9 +21233,12 @@ class BatchHeaderFilterPolicyFactory {
  * @see https://docs.microsoft.com/en-us/rest/api/storageservices/blob-batch
  */
 class BlobBatchClient {
-    constructor(url, credentialOrPipeline, options) {
+    constructor(url, credentialOrPipeline, 
+    // Legacy, no fix for eslint error without breaking. Disable it for this interface.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-options*/
+    options) {
         let pipeline;
-        if (credentialOrPipeline instanceof Pipeline) {
+        if (isPipelineLike(credentialOrPipeline)) {
             pipeline = credentialOrPipeline;
         }
         else if (!credentialOrPipeline) {
@@ -21233,7 +21265,10 @@ class BlobBatchClient {
     createBatch() {
         return new BlobBatch();
     }
-    async deleteBlobs(urlsOrBlobClients, credentialOrOptions, options) {
+    async deleteBlobs(urlsOrBlobClients, credentialOrOptions, 
+    // Legacy, no fix for eslint error without breaking. Disable it for this interface.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-options*/
+    options) {
         const batch = new BlobBatch();
         for (const urlOrBlobClient of urlsOrBlobClients) {
             if (typeof urlOrBlobClient === "string") {
@@ -21245,7 +21280,10 @@ class BlobBatchClient {
         }
         return this.submitBatch(batch);
     }
-    async setBlobsAccessTier(urlsOrBlobClients, credentialOrTier, tierOrOptions, options) {
+    async setBlobsAccessTier(urlsOrBlobClients, credentialOrTier, tierOrOptions, 
+    // Legacy, no fix for eslint error without breaking. Disable it for this interface.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-options*/
+    options) {
         const batch = new BlobBatch();
         for (const urlOrBlobClient of urlsOrBlobClients) {
             if (typeof urlOrBlobClient === "string") {
@@ -21293,7 +21331,7 @@ class BlobBatchClient {
      * @param options -
      */
     async submitBatch(batchRequest, options = {}) {
-        if (!batchRequest || batchRequest.getSubRequests().size == 0) {
+        if (!batchRequest || batchRequest.getSubRequests().size === 0) {
             throw new RangeError("Batch request should contain one or more sub requests.");
         }
         const { span, updatedOptions } = createSpan("BlobBatchClient-submitBatch", options);
@@ -21334,11 +21372,14 @@ class BlobBatchClient {
  * A ContainerClient represents a URL to the Azure Storage container allowing you to manipulate its blobs.
  */
 class ContainerClient extends StorageClient {
-    constructor(urlOrConnectionString, credentialOrPipelineOrContainerName, options) {
+    constructor(urlOrConnectionString, credentialOrPipelineOrContainerName, 
+    // Legacy, no fix for eslint error without breaking. Disable it for this interface.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-options*/
+    options) {
         let pipeline;
         let url;
         options = options || {};
-        if (credentialOrPipelineOrContainerName instanceof Pipeline) {
+        if (isPipelineLike(credentialOrPipelineOrContainerName)) {
             // (url: string, pipeline: Pipeline)
             url = urlOrConnectionString;
             pipeline = credentialOrPipelineOrContainerName;
@@ -22061,7 +22102,7 @@ class ContainerClient extends StorageClient {
         if (options.includeTags) {
             include.push("tags");
         }
-        if (options.includeDeletedwithVersions) {
+        if (options.includeDeletedWithVersions) {
             include.push("deletedwithversions");
         }
         if (options.includeImmutabilityPolicy) {
@@ -22257,7 +22298,7 @@ class ContainerClient extends StorageClient {
         if (options.includeTags) {
             include.push("tags");
         }
-        if (options.includeDeletedwithVersions) {
+        if (options.includeDeletedWithVersions) {
             include.push("deletedwithversions");
         }
         if (options.includeImmutabilityPolicy) {
@@ -22790,9 +22831,12 @@ function generateAccountSASQueryParameters(accountSASSignatureValues, sharedKeyC
  * to manipulate blob containers.
  */
 class BlobServiceClient extends StorageClient {
-    constructor(url, credentialOrPipeline, options) {
+    constructor(url, credentialOrPipeline, 
+    // Legacy, no fix for eslint error without breaking. Disable it for this interface.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-options*/
+    options) {
         let pipeline;
-        if (credentialOrPipeline instanceof Pipeline) {
+        if (isPipelineLike(credentialOrPipeline)) {
             pipeline = credentialOrPipeline;
         }
         else if ((coreHttp.isNode && credentialOrPipeline instanceof StorageSharedKeyCredential) ||
@@ -22819,7 +22863,10 @@ class BlobServiceClient extends StorageClient {
      *                                  `BlobEndpoint=https://myaccount.blob.core.windows.net/;QueueEndpoint=https://myaccount.queue.core.windows.net/;FileEndpoint=https://myaccount.file.core.windows.net/;TableEndpoint=https://myaccount.table.core.windows.net/;SharedAccessSignature=sasString`
      * @param options - Optional. Options to configure the HTTP pipeline.
      */
-    static fromConnectionString(connectionString, options) {
+    static fromConnectionString(connectionString, 
+    // Legacy, no fix for eslint error without breaking. Disable it for this interface.
+    /* eslint-disable-next-line @azure/azure-sdk/ts-naming-options*/
+    options) {
         options = options || {};
         const extractedCreds = extractConnectionStringParts(connectionString);
         if (extractedCreds.kind === "AccountConnString") {
@@ -22942,6 +22989,7 @@ class BlobServiceClient extends StorageClient {
      * @param destinationContainerName - The new name of the container.
      * @param options - Options to configure Container Rename operation.
      */
+    /* eslint-disable-next-line @typescript-eslint/ban-ts-comment */
     // @ts-ignore Need to hide this interface for now. Make it public and turn on the live tests for it when the service is ready.
     async renameContainer(sourceContainerName, destinationContainerName, options = {}) {
         var _a;
@@ -23602,6 +23650,7 @@ exports.StorageSharedKeyCredential = StorageSharedKeyCredential;
 exports.StorageSharedKeyCredentialPolicy = StorageSharedKeyCredentialPolicy;
 exports.generateAccountSASQueryParameters = generateAccountSASQueryParameters;
 exports.generateBlobSASQueryParameters = generateBlobSASQueryParameters;
+exports.isPipelineLike = isPipelineLike;
 exports.logger = logger;
 exports.newPipeline = newPipeline;
 //# sourceMappingURL=index.js.map