@azure/service-bus 7.4.0-beta.1 → 7.4.0

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Release History
 
+## 7.4.0 (2021-11-08)
+
+### Features Added
+
+- Allowing the service API version to be configurable when using `ServiceBusAdministrationClient` as part of the constructor client options.
+  Supported versions being "2021-05" and "2017-04".
+  [#18254](https://github.com/Azure/azure-sdk-for-js/pull/18254)
+
+### Bugs Fixed
+
+- Resolves an issue ([#17932](https://github.com/Azure/azure-sdk-for-js/issues/17932)) of receivers not being closed correctly when service bus client is closed.
+
 ## 7.4.0-beta.1 (2021-10-04)
 
 ### Features Added

package/README.md

@@ -37,7 +37,7 @@ Install the latest version for the Azure Service Bus client library using npm.
 - An [Azure subscription](https://azure.microsoft.com/free/)
 - A [Service Bus Namespace](https://docs.microsoft.com/azure/service-bus-messaging/) 
 
-### Configure Typescript
+### Configure TypeScript
 
 TypeScript users need to have Node type definitions installed:
 

package/dist/index.js

@@ -151,7 +151,7 @@ function isError(err) {
  */
 const packageJsonInfo = {
     name: "@azure/service-bus",
-    version: "7.4.0-beta.1"
+    version: "7.4.0"
 };
 /**
  * @internal
@@ -1299,7 +1299,7 @@ function buildQueue(rawQueue) {
         status: rawQueue[STATUS],
         enableExpress: getBoolean(rawQueue[ENABLE_EXPRESS], "enableExpress"),
         availabilityStatus: rawQueue[ENTITY_AVAILABILITY_STATUS],
-        maxMessageSizeInKilobytes: getInteger(rawQueue[MAX_MESSAGE_SIZE_IN_KILOBYTES], "maxMessageSizeInKilobytes")
+        maxMessageSizeInKilobytes: getIntegerOrUndefined(rawQueue[MAX_MESSAGE_SIZE_IN_KILOBYTES])
     };
 }
 /**
@@ -1739,7 +1739,7 @@ function buildTopic(rawTopic) {
         status: rawTopic[STATUS],
         enableExpress: getBoolean(rawTopic[ENABLE_EXPRESS], "enableExpress"),
         availabilityStatus: rawTopic[ENTITY_AVAILABILITY_STATUS],
-        maxMessageSizeInKilobytes: getInteger(rawTopic[MAX_MESSAGE_SIZE_IN_KILOBYTES], "maxMessageSizeInKilobytes")
+        maxMessageSizeInKilobytes: getIntegerOrUndefined(rawTopic[MAX_MESSAGE_SIZE_IN_KILOBYTES])
     };
 }
 /**
@@ -1969,7 +1969,7 @@ class ServiceBusAdministrationClient extends coreHttp.ServiceClient {
     constructor(fullyQualifiedNamespaceOrConnectionString1, credentialOrOptions2, 
     // eslint-disable-next-line @azure/azure-sdk/ts-naming-options
     options3) {
-        var _a;
+        var _a, _b;
         let options;
         let fullyQualifiedNamespace;
         let credentials;
@@ -2014,6 +2014,7 @@ class ServiceBusAdministrationClient extends coreHttp.ServiceClient {
         this.endpointWithProtocol = fullyQualifiedNamespace.endsWith("/")
             ? "sb://" + fullyQualifiedNamespace
             : "sb://" + fullyQualifiedNamespace + "/";
+        this.serviceVersion = (_b = options.serviceVersion) !== null && _b !== void 0 ? _b : CURRENT_API_VERSION;
         this.credentials = credentials;
         this.namespaceResourceSerializer = new NamespaceResourceSerializer();
         this.queueResourceSerializer = new QueueResourceSerializer();
@@ -3632,7 +3633,7 @@ class ServiceBusAdministrationClient extends coreHttp.ServiceClient {
     getUrl(path, queryParams) {
         const baseUri = `https://${this.endpoint}/${path}`;
         const requestUrl = coreHttp.URLBuilder.parse(baseUri);
-        requestUrl.setQueryParameter(API_VERSION_QUERY_KEY, CURRENT_API_VERSION);
+        requestUrl.setQueryParameter(API_VERSION_QUERY_KEY, this.serviceVersion);
         if (queryParams) {
             for (const key of Object.keys(queryParams)) {
                 requestUrl.setQueryParameter(key, queryParams[key]);
@@ -6241,30 +6242,17 @@ var ConnectionContext;
         const logPrefix = `[${context.connectionId}]`;
         try {
             connectionLogger.verbose(`${logPrefix} Permanently closing the amqp connection on the client.`);
-            // Close all the senders.
             const senderNames = Object.keys(context.senders);
-            connectionLogger.verbose(`${logPrefix} Permanently closing ${senderNames.length} senders.`);
-            for (const senderName of senderNames) {
-                await context.senders[senderName].close();
-            }
-            // Close all MessageReceiver instances
             const messageReceiverNames = Object.keys(context.messageReceivers);
-            connectionLogger.verbose(`${logPrefix} Permanently closing ${messageReceiverNames.length} receivers.`);
-            for (const receiverName of messageReceiverNames) {
-                await context.messageReceivers[receiverName].close();
-            }
-            // Close all MessageSession instances
             const messageSessionNames = Object.keys(context.messageSessions);
-            connectionLogger.verbose(`${logPrefix} Permanently closing ${messageSessionNames.length} session receivers.`);
-            for (const messageSessionName of messageSessionNames) {
-                await context.messageSessions[messageSessionName].close();
-            }
-            // Close all the ManagementClients.
             const managementClientsEntityPaths = Object.keys(context.managementClients);
-            connectionLogger.verbose(`${logPrefix} Permanently closing ${managementClientsEntityPaths.length} session receivers.`);
-            for (const entityPath of managementClientsEntityPaths) {
-                await context.managementClients[entityPath].close();
-            }
+            connectionLogger.verbose(`${logPrefix} Permanently closing all the senders(${senderNames.length}), MessageReceivers(${messageReceiverNames.length}), MessageSessions(${messageSessionNames.length}), and ManagementClients(${managementClientsEntityPaths.length}).`);
+            await Promise.all([
+                ...senderNames.map((n) => context.senders[n].close()),
+                ...messageReceiverNames.map((n) => context.messageReceivers[n].close()),
+                ...messageSessionNames.map((n) => context.messageSessions[n].close()),
+                ...managementClientsEntityPaths.map((p) => context.managementClients[p].close())
+            ]);
             connectionLogger.verbose(`${logPrefix} Permanently closing cbsSession`);
             await context.cbsSession.close();
             connectionLogger.verbose(`${logPrefix} Permanently closing internal connection`);