@azure/service-bus 1.1.8 → 1.1.9

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Release History
 
+## 1.1.9 (2020-08-19)
+
+- Fixes [bug 10641](https://github.com/Azure/azure-sdk-for-js/issues/10641) where parallel requests
+  on the management link would fail with a `ServiceUnavailableError`.
+- Fixes [bug 9287](https://github.com/Azure/azure-sdk-for-js/issues/9287)
+  where operations that used the `RequestResponseLink` and encountered an error
+  would fail to cleanup their internal timer.
+  This caused exiting the process to be delayed until the timer reached its timeout.
+
 ## 1.1.8 (2020-07-15)
 
 - Fixes [bug 9926](https://github.com/Azure/azure-sdk-for-js/issues/9926)

package/README.md

@@ -7,7 +7,7 @@ Use the client library for Azure Service Bus in your Node.js application to
 - Send messages to a Queue or Topic
 - Receive messages from a Queue or Subscription
 
-[Source code](https://github.com/Azure/azure-sdk-for-js/tree/%40azure/service-bus_1.1.8/sdk/servicebus/service-bus) | [Package (npm)](https://www.npmjs.com/package/@azure/service-bus) | [API Reference Documentation](https://docs.microsoft.com/en-us/javascript/api/%40azure/service-bus/) | [Product documentation](https://azure.microsoft.com/en-us/services/service-bus/) | [Samples](https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/servicebus/service-bus/samples-v1)
+[Source code](https://github.com/Azure/azure-sdk-for-js/tree/%40azure/service-bus_1.1.9/sdk/servicebus/service-bus) | [Package (npm)](https://www.npmjs.com/package/@azure/service-bus) | [API Reference Documentation](https://docs.microsoft.com/en-us/javascript/api/%40azure/service-bus/) | [Product documentation](https://azure.microsoft.com/en-us/services/service-bus/) | [Samples](https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/servicebus/service-bus/samples-v1)
 
 ## Getting Started
 
@@ -253,6 +253,6 @@ directory for detailed examples on how to use this library to send and receive m
 
 ## Contributing
 
-If you'd like to contribute to this library, please read the [contributing guide](https://github.com/Azure/azure-sdk-for-js/tree/91859225ae42af3fc9f8004817160d59c1837b16/CONTRIBUTING.md) to learn more about how to build and test the code.
+If you'd like to contribute to this library, please read the [contributing guide](https://github.com/Azure/azure-sdk-for-js/tree/083d38dc872d6071e0951461af48a6cbe8e09bc1/CONTRIBUTING.md) to learn more about how to build and test the code.
 
 ![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js%2Fsdk%2Fservicebus%2Fservice-bus%2FREADME.png)

package/browser/service-bus.js

@@ -1254,7 +1254,7 @@
     // Licensed under the MIT License.
     const packageJsonInfo = {
         name: "@azure/service-bus",
-        version: "1.1.8"
+        version: "1.1.9"
     };
     const max32BitNumber = Math.pow(2, 31) - 1;
 
@@ -12927,24 +12927,25 @@
                     };
                 };
                 const messageCallback = (context) => {
-                    // remove the event listener as this will be registered next time when someone makes a request.
-                    this.receiver.removeListener(lib_7.message, messageCallback);
                     const info = getCodeDescriptionAndError(context.message.application_properties);
                     const responseCorrelationId = context.message.correlation_id;
                     reqres("[%s] %s response: ", this.connection.id, request.to || "$management", context.message);
+                    if (request.message_id !== responseCorrelationId && request.correlation_id !== responseCorrelationId) {
+                        // do not remove message listener.
+                        // parallel requests listen on the same receiver, so continue waiting until respose that matches
+                        // request via correlationId is found.
+                        error$1("[%s] request-messageId | '%s' != '%s' | response-correlationId. " +
+                            "Hence dropping this response and waiting for the next one.", this.connection.id, request.message_id, responseCorrelationId);
+                        return;
+                    }
+                    // remove the event listeners as they will be registered next time when someone makes a request.
+                    this.receiver.removeListener(lib_7.message, messageCallback);
+                    if (!timeOver) {
+                        clearTimeout(waitTimer);
+                    }
                     if (info.statusCode > 199 && info.statusCode < 300) {
-                        if (request.message_id === responseCorrelationId ||
-                            request.correlation_id === responseCorrelationId) {
-                            if (!timeOver) {
-                                clearTimeout(waitTimer);
-                            }
-                            reqres("[%s] request-messageId | '%s' == '%s' | response-correlationId.", this.connection.id, request.message_id, responseCorrelationId);
-                            return resolve(context.message);
-                        }
-                        else {
-                            error$1("[%s] request-messageId | '%s' != '%s' | response-correlationId. " +
-                                "Hence dropping this response and waiting for the next one.", this.connection.id, request.message_id, responseCorrelationId);
-                        }
+                        reqres("[%s] request-messageId | '%s' == '%s' | response-correlationId.", this.connection.id, request.message_id, responseCorrelationId);
+                        return resolve(context.message);
                     }
                     else {
                         const condition = info.errorCondition ||