@azure/notification-hubs 1.0.0-beta.7 → 1.0.0-beta.8

package/README.md

@@ -53,7 +53,7 @@ This SDK for JavaScript offers two ways of interacting with Azure Notification H
 
 ```typescript
 import { 
-  NotificationHubsServiceClient
+  NotificationHubsClient,
   createAppleInstallation 
 } from "@azure/notification-hubs";
 
@@ -81,6 +81,7 @@ The above code snippet then becomes the following:
 
 ```typescript
 import { createClientContext, createOrUpdateInstallation } from "@azure/notification-hubs/api";
+import { createAppleInstallation } from "@azure/notification-hubs/models";
 
 const context = createClientContext("<connection string>", "<hub name>");
 
@@ -193,7 +194,7 @@ Using the modular approach, the code would be as follows:
 
 ```typescript
 import { createClientContext, updateInstallation } from "@azure/notification-hubs/api";
-import { JsonPatch, createAppleInstallation } from "@azure/notification-hubs/models";
+import { JsonPatch } from "@azure/notification-hubs/models";
 
 const context = createClientContext("<connection string>", "<hub name>");
 

package/dist/index.cjs

@@ -14,7 +14,7 @@ var uuid = require('uuid');
 
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
-const SDK_VERSION = "1.0.0-beta.7";
+const SDK_VERSION = "1.0.0-beta.8";
 const JSON_CONTENT_TYPE = "application/json;charset=utf-8";
 const XML_CONTENT_TYPE = "application/xml";
 const STREAM_CONTENT_TYPE = "application/octet-stream";
@@ -771,6 +771,7 @@ const registrationDescriptionParser = {
      */
     async parseRegistrationEntry(bodyText) {
         const xml = await coreXml.parseXML(bodyText, { includeRoot: true });
+        delete xml.entry.content["$"];
         const keyName = Object.keys(xml.entry.content)[0];
         const content = xml.entry.content[keyName];
         const methodName = `create${keyName}`;
@@ -1190,6 +1191,13 @@ function createRegistrationId(context, options = {}) {
         const response = await sendRequest(context, request, 201);
         // In the form: https://{namespace}.servicebus.windows.net/{NotificationHub}/registrations/<registrationId>
         const locationHeader = response.headers.get("Location");
+        if (!locationHeader || !locationHeader.startsWith("https://")) {
+            throw new coreRestPipeline.RestError(`Location header ${locationHeader} is an invalid URL`, {
+                statusCode: 500,
+                request,
+                response,
+            });
+        }
         const locationUrl = new URL(locationHeader);
         const registrationId = locationUrl.pathname.split("/")[3];
         return registrationId;
@@ -1320,6 +1328,7 @@ async function parseNotificationDetails(bodyText) {
         endTime: getDateOrUndefined(notificationDetails["EndTime"]),
         pnsErrorDetailsUrl: getStringOrUndefined(notificationDetails["PnsErrorDetailsUri"]),
         targetPlatforms: getStringOrUndefined(notificationDetails["TargetPlatforms"]),
+        notificationBody: getStringOrUndefined(notificationDetails["NotificationBody"]),
         apnsOutcomeCounts,
         admOutcomeCounts,
         baiduOutcomeCounts,