@azure/msal-node-extensions 1.0.0-alpha.14 → 1.0.0-alpha.15

package/dist/persistence/PersistenceCreator.d.ts

@@ -1,5 +1,5 @@
 import { IPersistence } from "./IPersistence";
-import { IPersistenceConfiguration } from "../persistence/IPersistenceConfiguration";
+import { IPersistenceConfiguration } from "./IPersistenceConfiguration";
 export declare class PersistenceCreator {
     static createPersistence(config: IPersistenceConfiguration): Promise<IPersistence>;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@azure/msal-node-extensions",
-  "version": "1.0.0-alpha.14",
+  "version": "1.0.0-alpha.15",
   "repository": {
     "type": "git",
     "url": "https://github.com/AzureAD/microsoft-authentication-library-for-js.git"
@@ -30,6 +30,7 @@
     "build:common": "cd ../../lib/msal-common && npm run build",
     "build:all": "npm run build:common && npm run build",
     "test": "tsdx test",
+    "test:coverage": "tsdx test --coverage",
     "lint": "cd ../../ && npm run lint:node:extensions",
     "lint:fix": "npm run lint -- -- --fix",
     "link:localDeps": "npx lerna bootstrap --scope @azure/msal-common --scope @azure/msal-node-extensions",
@@ -49,9 +50,9 @@
     ]
   },
   "dependencies": {
-    "@azure/msal-common": "^6.0.0",
+    "@azure/msal-common": "^6.1.0",
     "bindings": "git+https://github.com/samuelkubai/node-bindings.git#v1.6.0",
-    "keytar": "^7.6.0",
+    "keytar": "^7.8.0",
     "nan": "^2.13.2"
   },
   "devDependencies": {

package/src/dpapi-addon/Dpapi.ts

@@ -7,11 +7,11 @@ export interface DpapiBindings{
     protectData(dataToEncrypt: Uint8Array, optionalEntropy: Uint8Array, scope: string): Uint8Array
     unprotectData(encryptData: Uint8Array, optionalEntropy: Uint8Array, scope: string): Uint8Array
 }
-/* eslint-disable-next-line @typescript-eslint/no-var-requires, no-var */
+/* eslint-disable-next-line @typescript-eslint/no-var-requires, no-var, import/no-commonjs */
 export var Dpapi: DpapiBindings = require("bindings")({
     bindings: "dpapi",
     userDefinedTries: [
-        ['module_root', 'node_modules', '@azure', 'msal-node-extensions', 'build', 'Release',  'bindings'],
+        ["module_root", "node_modules", "@azure", "msal-node-extensions", "build", "Release",  "bindings"],
     ]
 });
 export default Dpapi;

package/src/persistence/PersistenceCreator.ts

@@ -3,15 +3,15 @@
  * Licensed under the MIT License.
  */
 
-import { FilePersistenceWithDataProtection } from "../persistence/FilePersistenceWithDataProtection";
-import { LibSecretPersistence } from "../persistence/LibSecretPersistence";
-import { KeychainPersistence } from "../persistence/KeychainPersistence";
-import { DataProtectionScope } from "../persistence/DataProtectionScope";
+import { FilePersistenceWithDataProtection } from "./FilePersistenceWithDataProtection";
+import { LibSecretPersistence } from "./LibSecretPersistence";
+import { KeychainPersistence } from "./KeychainPersistence";
+import { DataProtectionScope } from "./DataProtectionScope";
 import { Environment } from "../utils/Environment";
 import { IPersistence } from "./IPersistence";
 import { FilePersistence } from "./FilePersistence";
 import { PersistenceError } from "../error/PersistenceError";
-import { IPersistenceConfiguration } from "../persistence/IPersistenceConfiguration";
+import { IPersistenceConfiguration } from "./IPersistenceConfiguration";
 
 export class PersistenceCreator {
     static async createPersistence(config: IPersistenceConfiguration): Promise<IPersistence> {
@@ -20,7 +20,7 @@ export class PersistenceCreator {
         // On Windows, uses a DPAPI encrypted file
         if (Environment.isWindowsPlatform()) {
             if (!config.cachePath || !config.dataProtectionScope) {
-                throw PersistenceError.createPersistenceNotValidatedError(`Cache path and/or data protection scope not provided for the FilePersistenceWithDataProtection cache plugin`);
+                throw PersistenceError.createPersistenceNotValidatedError("Cache path and/or data protection scope not provided for the FilePersistenceWithDataProtection cache plugin");
             }
 
             peristence = await FilePersistenceWithDataProtection.create(config.cachePath, DataProtectionScope.CurrentUser);
@@ -29,7 +29,7 @@ export class PersistenceCreator {
         // On Mac, uses keychain.
         else if (Environment.isMacPlatform()) {
             if (!config.cachePath || !config.serviceName || !config.accountName) {
-                throw PersistenceError.createPersistenceNotValidatedError(`Cache path, service name and/or account name not provided for the KeychainPersistence cache plugin`);
+                throw PersistenceError.createPersistenceNotValidatedError("Cache path, service name and/or account name not provided for the KeychainPersistence cache plugin");
             }
 
             peristence = await KeychainPersistence.create(config.cachePath, config.serviceName, config.accountName);
@@ -38,7 +38,7 @@ export class PersistenceCreator {
         // On Linux, uses  libsecret to store to secret service. Libsecret has to be installed.
         else if (Environment.isLinuxPlatform()) {
             if (!config.cachePath || !config.serviceName || !config.accountName) {
-                throw PersistenceError.createPersistenceNotValidatedError(`Cache path, service name and/or account name not provided for the LibSecretPersistence cache plugin`);
+                throw PersistenceError.createPersistenceNotValidatedError("Cache path, service name and/or account name not provided for the LibSecretPersistence cache plugin");
             }
 
             peristence = await LibSecretPersistence.create(config.cachePath, config.serviceName, config.accountName);
@@ -54,7 +54,7 @@ export class PersistenceCreator {
         if (!isPersistenceVerified) {
             if (Environment.isLinuxPlatform() && config.usePlaintextFileOnLinux) {
                 if (!config.cachePath) {
-                    throw PersistenceError.createPersistenceNotValidatedError(`Cache path not provided for the FilePersistence cache plugin`);
+                    throw PersistenceError.createPersistenceNotValidatedError("Cache path not provided for the FilePersistence cache plugin");
                 }
 
                 peristence = await FilePersistence.create(config.cachePath);

package/src/utils/Constants.ts

@@ -59,4 +59,4 @@ export enum Platform {
     WINDOWS = "win32",
     LINUX = "linux",
     MACOS = "darwin"
-};
+}

package/src/utils/Environment.ts

@@ -9,23 +9,23 @@ import { PersistenceError } from "../error/PersistenceError";
 import { StringUtils } from "@azure/msal-common";
 
 export class Environment {
-    static get homeEnvVar() {
+    static get homeEnvVar(): string {
         return this.getEnvironmentVariable(Constants.ENVIRONMENT.HOME);
     }
     
-    static get lognameEnvVar() {
+    static get lognameEnvVar(): string {
         return this.getEnvironmentVariable(Constants.ENVIRONMENT.LOGNAME);
     }
 
-    static get userEnvVar() {
+    static get userEnvVar(): string {
         return this.getEnvironmentVariable(Constants.ENVIRONMENT.USER);
     }
 
-    static get lnameEnvVar() {
+    static get lnameEnvVar(): string {
         return this.getEnvironmentVariable(Constants.ENVIRONMENT.LNAME);
     }
 
-    static get usernameEnvVar() {
+    static get usernameEnvVar(): string {
         return this.getEnvironmentVariable(Constants.ENVIRONMENT.USERNAME);
     }
 
@@ -50,13 +50,13 @@ export class Environment {
     }
 
     static isLinuxRootUser(): boolean {
-        return process.getuid() == Constants.LINUX_ROOT_USER_GUID;
+        return process.getuid() === Constants.LINUX_ROOT_USER_GUID;
     }
 
     static getUserRootDirectory(): string {
         return !this.isWindowsPlatform ?
             this.getUserHomeDirOnUnix() :
-            this.getUserHomeDirOnWindows()
+            this.getUserHomeDirOnWindows();
     }
 
     static getUserHomeDirOnWindows(): string {
@@ -65,7 +65,7 @@ export class Environment {
 
     static getUserHomeDirOnUnix(): string | null {
         if (this.isWindowsPlatform()) {
-            throw PersistenceError.createNotSupportedError("Getting the user home directory for unix is not supported in windows")
+            throw PersistenceError.createNotSupportedError("Getting the user home directory for unix is not supported in windows");
         }
 
         if (!StringUtils.isEmpty(this.homeEnvVar)) {
@@ -92,7 +92,7 @@ export class Environment {
                 return !StringUtils.isEmpty(username) ? path.join("/home", username) : null;
             }
         } else {
-            throw PersistenceError.createNotSupportedError("Getting the user home directory for unix is not supported in windows")
+            throw PersistenceError.createNotSupportedError("Getting the user home directory for unix is not supported in windows");
         }
 
     }