@azure/msal-common 14.2.0 → 14.3.0

package/dist/utils/Constants.mjs

@@ -1,4 +1,4 @@
-/*! @azure/msal-common v14.2.0 2023-10-20 */
+/*! @azure/msal-common v14.3.0 2023-10-30 */
 'use strict';
 /*
  * Copyright (c) Microsoft Corporation. All rights reserved.

package/dist/utils/FunctionWrappers.mjs

@@ -1,4 +1,4 @@
-/*! @azure/msal-common v14.2.0 2023-10-20 */
+/*! @azure/msal-common v14.3.0 2023-10-30 */
 'use strict';
 /*
  * Copyright (c) Microsoft Corporation. All rights reserved.

package/dist/utils/ProtocolUtils.mjs

@@ -1,4 +1,4 @@
-/*! @azure/msal-common v14.2.0 2023-10-20 */
+/*! @azure/msal-common v14.3.0 2023-10-30 */
 'use strict';
 import { Constants } from './Constants.mjs';
 import { createClientAuthError } from '../error/ClientAuthError.mjs';

package/dist/utils/StringUtils.mjs

@@ -1,4 +1,4 @@
-/*! @azure/msal-common v14.2.0 2023-10-20 */
+/*! @azure/msal-common v14.3.0 2023-10-30 */
 'use strict';
 /*
  * Copyright (c) Microsoft Corporation. All rights reserved.

package/dist/utils/TimeUtils.mjs

@@ -1,4 +1,4 @@
-/*! @azure/msal-common v14.2.0 2023-10-20 */
+/*! @azure/msal-common v14.3.0 2023-10-30 */
 'use strict';
 /*
  * Copyright (c) Microsoft Corporation. All rights reserved.

package/package.json

@@ -10,7 +10,7 @@
     "type": "git",
     "url": "https://github.com/AzureAD/microsoft-authentication-library-for-js.git"
   },
-  "version": "14.2.0",
+  "version": "14.3.0",
   "description": "Microsoft Authentication Library for js",
   "keywords": [
     "implicit",

package/src/authority/Authority.ts

@@ -855,7 +855,7 @@ export class Authority {
         } else {
             const hardcodedMetadata =
                 getCloudDiscoveryMetadataFromHardcodedValues(
-                    this.canonicalAuthority
+                    this.hostnameAndPort
                 );
             if (hardcodedMetadata) {
                 this.logger.verbose(
@@ -1264,13 +1264,11 @@ export function buildStaticAuthorityOptions(
     authOptions: Partial<AuthorityOptions>
 ): StaticAuthorityOptions {
     const rawCloudDiscoveryMetadata = authOptions.cloudDiscoveryMetadata;
-    let cloudDiscoveryMetadata: CloudDiscoveryMetadata[] | undefined =
+    let cloudDiscoveryMetadata: CloudInstanceDiscoveryResponse | undefined =
         undefined;
     if (rawCloudDiscoveryMetadata) {
         try {
-            cloudDiscoveryMetadata = JSON.parse(
-                rawCloudDiscoveryMetadata
-            ).metadata;
+            cloudDiscoveryMetadata = JSON.parse(rawCloudDiscoveryMetadata);
         } catch (e) {
             throw createClientConfigurationError(
                 ClientConfigurationErrorCodes.invalidCloudDiscoveryMetadata

package/src/authority/AuthorityMetadata.ts

@@ -3,7 +3,10 @@
  * Licensed under the MIT License.
  */
 
+import { Logger } from "../logger/Logger";
 import { UrlString } from "../url/UrlString";
+import { AuthorityMetadataSource } from "../utils/Constants";
+import { StaticAuthorityOptions } from "./AuthorityOptions";
 import { CloudDiscoveryMetadata } from "./CloudDiscoveryMetadata";
 
 export const rawMetdataJSON = {
@@ -552,393 +555,47 @@ export const rawMetdataJSON = {
         },
     },
     instanceDiscoveryMetadata: {
-        "https://login.microsoftonline.com/common/": {
-            tenant_discovery_endpoint:
-                "https://login.microsoftonline.com/common/v2.0/.well-known/openid-configuration",
-            "api-version": "1.1",
-            metadata: [
-                {
-                    preferred_network: "login.microsoftonline.com",
-                    preferred_cache: "login.windows.net",
-                    aliases: [
-                        "login.microsoftonline.com",
-                        "login.windows.net",
-                        "login.microsoft.com",
-                        "sts.windows.net",
-                    ],
-                },
-                {
-                    preferred_network: "login.partner.microsoftonline.cn",
-                    preferred_cache: "login.partner.microsoftonline.cn",
-                    aliases: [
-                        "login.partner.microsoftonline.cn",
-                        "login.chinacloudapi.cn",
-                    ],
-                },
-                {
-                    preferred_network: "login.microsoftonline.de",
-                    preferred_cache: "login.microsoftonline.de",
-                    aliases: ["login.microsoftonline.de"],
-                },
-                {
-                    preferred_network: "login.microsoftonline.us",
-                    preferred_cache: "login.microsoftonline.us",
-                    aliases: [
-                        "login.microsoftonline.us",
-                        "login.usgovcloudapi.net",
-                    ],
-                },
-                {
-                    preferred_network: "login-us.microsoftonline.com",
-                    preferred_cache: "login-us.microsoftonline.com",
-                    aliases: ["login-us.microsoftonline.com"],
-                },
-            ],
-        },
-        "https://login.chinacloudapi.cn/common/": {
-            tenant_discovery_endpoint:
-                "https://login.chinacloudapi.cn/common/v2.0/.well-known/openid-configuration",
-            "api-version": "1.1",
-            metadata: [
-                {
-                    preferred_network: "login.microsoftonline.com",
-                    preferred_cache: "login.windows.net",
-                    aliases: [
-                        "login.microsoftonline.com",
-                        "login.windows.net",
-                        "login.microsoft.com",
-                        "sts.windows.net",
-                    ],
-                },
-                {
-                    preferred_network: "login.partner.microsoftonline.cn",
-                    preferred_cache: "login.partner.microsoftonline.cn",
-                    aliases: [
-                        "login.partner.microsoftonline.cn",
-                        "login.chinacloudapi.cn",
-                    ],
-                },
-                {
-                    preferred_network: "login.microsoftonline.de",
-                    preferred_cache: "login.microsoftonline.de",
-                    aliases: ["login.microsoftonline.de"],
-                },
-                {
-                    preferred_network: "login.microsoftonline.us",
-                    preferred_cache: "login.microsoftonline.us",
-                    aliases: [
-                        "login.microsoftonline.us",
-                        "login.usgovcloudapi.net",
-                    ],
-                },
-                {
-                    preferred_network: "login-us.microsoftonline.com",
-                    preferred_cache: "login-us.microsoftonline.com",
-                    aliases: ["login-us.microsoftonline.com"],
-                },
-            ],
-        },
-        "https://login.microsoftonline.us/common/": {
-            tenant_discovery_endpoint:
-                "https://login.microsoftonline.us/common/v2.0/.well-known/openid-configuration",
-            "api-version": "1.1",
-            metadata: [
-                {
-                    preferred_network: "login.microsoftonline.com",
-                    preferred_cache: "login.windows.net",
-                    aliases: [
-                        "login.microsoftonline.com",
-                        "login.windows.net",
-                        "login.microsoft.com",
-                        "sts.windows.net",
-                    ],
-                },
-                {
-                    preferred_network: "login.partner.microsoftonline.cn",
-                    preferred_cache: "login.partner.microsoftonline.cn",
-                    aliases: [
-                        "login.partner.microsoftonline.cn",
-                        "login.chinacloudapi.cn",
-                    ],
-                },
-                {
-                    preferred_network: "login.microsoftonline.de",
-                    preferred_cache: "login.microsoftonline.de",
-                    aliases: ["login.microsoftonline.de"],
-                },
-                {
-                    preferred_network: "login.microsoftonline.us",
-                    preferred_cache: "login.microsoftonline.us",
-                    aliases: [
-                        "login.microsoftonline.us",
-                        "login.usgovcloudapi.net",
-                    ],
-                },
-                {
-                    preferred_network: "login-us.microsoftonline.com",
-                    preferred_cache: "login-us.microsoftonline.com",
-                    aliases: ["login-us.microsoftonline.com"],
-                },
-            ],
-        },
-        "https://login.microsoftonline.com/consumers/": {
-            tenant_discovery_endpoint:
-                "https://login.microsoftonline.com/consumers/v2.0/.well-known/openid-configuration",
-            "api-version": "1.1",
-            metadata: [
-                {
-                    preferred_network: "login.microsoftonline.com",
-                    preferred_cache: "login.windows.net",
-                    aliases: [
-                        "login.microsoftonline.com",
-                        "login.windows.net",
-                        "login.microsoft.com",
-                        "sts.windows.net",
-                    ],
-                },
-                {
-                    preferred_network: "login.partner.microsoftonline.cn",
-                    preferred_cache: "login.partner.microsoftonline.cn",
-                    aliases: [
-                        "login.partner.microsoftonline.cn",
-                        "login.chinacloudapi.cn",
-                    ],
-                },
-                {
-                    preferred_network: "login.microsoftonline.de",
-                    preferred_cache: "login.microsoftonline.de",
-                    aliases: ["login.microsoftonline.de"],
-                },
-                {
-                    preferred_network: "login.microsoftonline.us",
-                    preferred_cache: "login.microsoftonline.us",
-                    aliases: [
-                        "login.microsoftonline.us",
-                        "login.usgovcloudapi.net",
-                    ],
-                },
-                {
-                    preferred_network: "login-us.microsoftonline.com",
-                    preferred_cache: "login-us.microsoftonline.com",
-                    aliases: ["login-us.microsoftonline.com"],
-                },
-            ],
-        },
-        "https://login.chinacloudapi.cn/consumers/": {
-            tenant_discovery_endpoint:
-                "https://login.chinacloudapi.cn/consumers/v2.0/.well-known/openid-configuration",
-            "api-version": "1.1",
-            metadata: [
-                {
-                    preferred_network: "login.microsoftonline.com",
-                    preferred_cache: "login.windows.net",
-                    aliases: [
-                        "login.microsoftonline.com",
-                        "login.windows.net",
-                        "login.microsoft.com",
-                        "sts.windows.net",
-                    ],
-                },
-                {
-                    preferred_network: "login.partner.microsoftonline.cn",
-                    preferred_cache: "login.partner.microsoftonline.cn",
-                    aliases: [
-                        "login.partner.microsoftonline.cn",
-                        "login.chinacloudapi.cn",
-                    ],
-                },
-                {
-                    preferred_network: "login.microsoftonline.de",
-                    preferred_cache: "login.microsoftonline.de",
-                    aliases: ["login.microsoftonline.de"],
-                },
-                {
-                    preferred_network: "login.microsoftonline.us",
-                    preferred_cache: "login.microsoftonline.us",
-                    aliases: [
-                        "login.microsoftonline.us",
-                        "login.usgovcloudapi.net",
-                    ],
-                },
-                {
-                    preferred_network: "login-us.microsoftonline.com",
-                    preferred_cache: "login-us.microsoftonline.com",
-                    aliases: ["login-us.microsoftonline.com"],
-                },
-            ],
-        },
-        "https://login.microsoftonline.us/consumers/": {
-            tenant_discovery_endpoint:
-                "https://login.microsoftonline.us/consumers/v2.0/.well-known/openid-configuration",
-            "api-version": "1.1",
-            metadata: [
-                {
-                    preferred_network: "login.microsoftonline.com",
-                    preferred_cache: "login.windows.net",
-                    aliases: [
-                        "login.microsoftonline.com",
-                        "login.windows.net",
-                        "login.microsoft.com",
-                        "sts.windows.net",
-                    ],
-                },
-                {
-                    preferred_network: "login.partner.microsoftonline.cn",
-                    preferred_cache: "login.partner.microsoftonline.cn",
-                    aliases: [
-                        "login.partner.microsoftonline.cn",
-                        "login.chinacloudapi.cn",
-                    ],
-                },
-                {
-                    preferred_network: "login.microsoftonline.de",
-                    preferred_cache: "login.microsoftonline.de",
-                    aliases: ["login.microsoftonline.de"],
-                },
-                {
-                    preferred_network: "login.microsoftonline.us",
-                    preferred_cache: "login.microsoftonline.us",
-                    aliases: [
-                        "login.microsoftonline.us",
-                        "login.usgovcloudapi.net",
-                    ],
-                },
-                {
-                    preferred_network: "login-us.microsoftonline.com",
-                    preferred_cache: "login-us.microsoftonline.com",
-                    aliases: ["login-us.microsoftonline.com"],
-                },
-            ],
-        },
-        "https://login.microsoftonline.com/organizations/": {
-            tenant_discovery_endpoint:
-                "https://login.microsoftonline.com/organizations/v2.0/.well-known/openid-configuration",
-            "api-version": "1.1",
-            metadata: [
-                {
-                    preferred_network: "login.microsoftonline.com",
-                    preferred_cache: "login.windows.net",
-                    aliases: [
-                        "login.microsoftonline.com",
-                        "login.windows.net",
-                        "login.microsoft.com",
-                        "sts.windows.net",
-                    ],
-                },
-                {
-                    preferred_network: "login.partner.microsoftonline.cn",
-                    preferred_cache: "login.partner.microsoftonline.cn",
-                    aliases: [
-                        "login.partner.microsoftonline.cn",
-                        "login.chinacloudapi.cn",
-                    ],
-                },
-                {
-                    preferred_network: "login.microsoftonline.de",
-                    preferred_cache: "login.microsoftonline.de",
-                    aliases: ["login.microsoftonline.de"],
-                },
-                {
-                    preferred_network: "login.microsoftonline.us",
-                    preferred_cache: "login.microsoftonline.us",
-                    aliases: [
-                        "login.microsoftonline.us",
-                        "login.usgovcloudapi.net",
-                    ],
-                },
-                {
-                    preferred_network: "login-us.microsoftonline.com",
-                    preferred_cache: "login-us.microsoftonline.com",
-                    aliases: ["login-us.microsoftonline.com"],
-                },
-            ],
-        },
-        "https://login.chinacloudapi.cn/organizations/": {
-            tenant_discovery_endpoint:
-                "https://login.chinacloudapi.cn/organizations/v2.0/.well-known/openid-configuration",
-            "api-version": "1.1",
-            metadata: [
-                {
-                    preferred_network: "login.microsoftonline.com",
-                    preferred_cache: "login.windows.net",
-                    aliases: [
-                        "login.microsoftonline.com",
-                        "login.windows.net",
-                        "login.microsoft.com",
-                        "sts.windows.net",
-                    ],
-                },
-                {
-                    preferred_network: "login.partner.microsoftonline.cn",
-                    preferred_cache: "login.partner.microsoftonline.cn",
-                    aliases: [
-                        "login.partner.microsoftonline.cn",
-                        "login.chinacloudapi.cn",
-                    ],
-                },
-                {
-                    preferred_network: "login.microsoftonline.de",
-                    preferred_cache: "login.microsoftonline.de",
-                    aliases: ["login.microsoftonline.de"],
-                },
-                {
-                    preferred_network: "login.microsoftonline.us",
-                    preferred_cache: "login.microsoftonline.us",
-                    aliases: [
-                        "login.microsoftonline.us",
-                        "login.usgovcloudapi.net",
-                    ],
-                },
-                {
-                    preferred_network: "login-us.microsoftonline.com",
-                    preferred_cache: "login-us.microsoftonline.com",
-                    aliases: ["login-us.microsoftonline.com"],
-                },
-            ],
-        },
-        "https://login.microsoftonline.us/organizations/": {
-            tenant_discovery_endpoint:
-                "https://login.microsoftonline.us/organizations/v2.0/.well-known/openid-configuration",
-            "api-version": "1.1",
-            metadata: [
-                {
-                    preferred_network: "login.microsoftonline.com",
-                    preferred_cache: "login.windows.net",
-                    aliases: [
-                        "login.microsoftonline.com",
-                        "login.windows.net",
-                        "login.microsoft.com",
-                        "sts.windows.net",
-                    ],
-                },
-                {
-                    preferred_network: "login.partner.microsoftonline.cn",
-                    preferred_cache: "login.partner.microsoftonline.cn",
-                    aliases: [
-                        "login.partner.microsoftonline.cn",
-                        "login.chinacloudapi.cn",
-                    ],
-                },
-                {
-                    preferred_network: "login.microsoftonline.de",
-                    preferred_cache: "login.microsoftonline.de",
-                    aliases: ["login.microsoftonline.de"],
-                },
-                {
-                    preferred_network: "login.microsoftonline.us",
-                    preferred_cache: "login.microsoftonline.us",
-                    aliases: [
-                        "login.microsoftonline.us",
-                        "login.usgovcloudapi.net",
-                    ],
-                },
-                {
-                    preferred_network: "login-us.microsoftonline.com",
-                    preferred_cache: "login-us.microsoftonline.com",
-                    aliases: ["login-us.microsoftonline.com"],
-                },
-            ],
-        },
+        tenant_discovery_endpoint:
+            "https://{canonicalAuthority}/v2.0/.well-known/openid-configuration",
+        "api-version": "1.1",
+        metadata: [
+            {
+                preferred_network: "login.microsoftonline.com",
+                preferred_cache: "login.windows.net",
+                aliases: [
+                    "login.microsoftonline.com",
+                    "login.windows.net",
+                    "login.microsoft.com",
+                    "sts.windows.net",
+                ],
+            },
+            {
+                preferred_network: "login.partner.microsoftonline.cn",
+                preferred_cache: "login.partner.microsoftonline.cn",
+                aliases: [
+                    "login.partner.microsoftonline.cn",
+                    "login.chinacloudapi.cn",
+                ],
+            },
+            {
+                preferred_network: "login.microsoftonline.de",
+                preferred_cache: "login.microsoftonline.de",
+                aliases: ["login.microsoftonline.de"],
+            },
+            {
+                preferred_network: "login.microsoftonline.us",
+                preferred_cache: "login.microsoftonline.us",
+                aliases: [
+                    "login.microsoftonline.us",
+                    "login.usgovcloudapi.net",
+                ],
+            },
+            {
+                preferred_network: "login-us.microsoftonline.com",
+                preferred_cache: "login-us.microsoftonline.com",
+                aliases: ["login-us.microsoftonline.com"],
+            },
+        ],
     },
 };
 
@@ -947,58 +604,96 @@ export const InstanceDiscoveryMetadata =
     rawMetdataJSON.instanceDiscoveryMetadata;
 
 export const InstanceDiscoveryMetadataAliases: Set<String> = new Set();
-for (const key in InstanceDiscoveryMetadata) {
-    for (const metadata of InstanceDiscoveryMetadata[key].metadata) {
-        for (const alias of metadata.aliases) {
+InstanceDiscoveryMetadata.metadata.forEach(
+    (metadataEntry: CloudDiscoveryMetadata) => {
+        metadataEntry.aliases.forEach((alias: string) => {
             InstanceDiscoveryMetadataAliases.add(alias);
-        }
+        });
     }
-}
+);
 
 /**
- * Returns aliases for the given canonical authority if found in hardcoded Instance Discovery Metadata or null if not found
- * @param canonicalAuthority
+ * Attempts to get an aliases array from the static authority metadata sources based on the canonical authority host
+ * @param staticAuthorityOptions
+ * @param logger
  * @returns
  */
-export function getHardcodedAliasesForCanonicalAuthority(
-    canonicalAuthority?: string
-): string[] | null {
+export function getAliasesFromStaticSources(
+    staticAuthorityOptions: StaticAuthorityOptions,
+    logger?: Logger
+): string[] {
+    let staticAliases: string[] | undefined;
+    const canonicalAuthority = staticAuthorityOptions.canonicalAuthority;
     if (canonicalAuthority) {
-        const instanceDiscoveryMetadata =
-            getCloudDiscoveryMetadataFromHardcodedValues(canonicalAuthority);
-        if (instanceDiscoveryMetadata) {
-            return instanceDiscoveryMetadata.aliases;
-        }
+        const authorityHost = new UrlString(
+            canonicalAuthority
+        ).getUrlComponents().HostNameAndPort;
+        staticAliases =
+            getAliasesFromMetadata(
+                authorityHost,
+                staticAuthorityOptions.cloudDiscoveryMetadata?.metadata,
+                AuthorityMetadataSource.CONFIG,
+                logger
+            ) ||
+            getAliasesFromMetadata(
+                authorityHost,
+                InstanceDiscoveryMetadata.metadata,
+                AuthorityMetadataSource.HARDCODED_VALUES,
+                logger
+            ) ||
+            staticAuthorityOptions.knownAuthorities;
     }
-    return null;
+
+    return staticAliases || [];
 }
 
 /**
- * Returns aliases for from the raw cloud discovery metadata given in configuration or null if no configuration was provided
+ * Returns aliases for from the raw cloud discovery metadata passed in
+ * @param authorityHost
  * @param rawCloudDiscoveryMetadata
  * @returns
  */
-export function getAliasesFromConfigMetadata(
-    canonicalAuthority?: string,
-    cloudDiscoveryMetadata?: CloudDiscoveryMetadata[]
+export function getAliasesFromMetadata(
+    authorityHost?: string,
+    cloudDiscoveryMetadata?: CloudDiscoveryMetadata[],
+    source?: AuthorityMetadataSource,
+    logger?: Logger
 ): string[] | null {
-    if (canonicalAuthority && cloudDiscoveryMetadata) {
-        const canonicalAuthorityUrlComponents = new UrlString(
-            canonicalAuthority
-        ).getUrlComponents();
+    logger?.trace(`getAliasesFromMetadata called with source: ${source}`);
+    if (authorityHost && cloudDiscoveryMetadata) {
         const metadata = getCloudDiscoveryMetadataFromNetworkResponse(
             cloudDiscoveryMetadata,
-            canonicalAuthorityUrlComponents.HostNameAndPort
+            authorityHost
         );
 
         if (metadata) {
+            logger?.trace(
+                `getAliasesFromMetadata: found cloud discovery metadata in ${source}, returning aliases`
+            );
             return metadata.aliases;
+        } else {
+            logger?.trace(
+                `getAliasesFromMetadata: did not find cloud discovery metadata in ${source}`
+            );
         }
     }
 
     return null;
 }
 
+/**
+ * Get cloud discovery metadata for common authorities
+ */
+export function getCloudDiscoveryMetadataFromHardcodedValues(
+    authorityHost: string
+): CloudDiscoveryMetadata | null {
+    const metadata = getCloudDiscoveryMetadataFromNetworkResponse(
+        InstanceDiscoveryMetadata.metadata,
+        authorityHost
+    );
+    return metadata;
+}
+
 /**
  * Searches instance discovery network response for the entry that contains the host in the aliases list
  * @param response
@@ -1006,35 +701,14 @@ export function getAliasesFromConfigMetadata(
  */
 export function getCloudDiscoveryMetadataFromNetworkResponse(
     response: CloudDiscoveryMetadata[],
-    authority: string
+    authorityHost: string
 ): CloudDiscoveryMetadata | null {
     for (let i = 0; i < response.length; i++) {
         const metadata = response[i];
-        if (metadata.aliases.includes(authority)) {
+        if (metadata.aliases.includes(authorityHost)) {
             return metadata;
         }
     }
 
     return null;
 }
-
-/**
- * Get cloud discovery metadata for common authorities
- */
-export function getCloudDiscoveryMetadataFromHardcodedValues(
-    canonicalAuthority: string
-): CloudDiscoveryMetadata | null {
-    const canonicalAuthorityUrlComponents = new UrlString(
-        canonicalAuthority
-    ).getUrlComponents();
-
-    if (canonicalAuthority in InstanceDiscoveryMetadata) {
-        const metadata = getCloudDiscoveryMetadataFromNetworkResponse(
-            InstanceDiscoveryMetadata[canonicalAuthority].metadata,
-            canonicalAuthorityUrlComponents.HostNameAndPort
-        );
-        return metadata;
-    }
-
-    return null;
-}