@azure/msal-browser 5.14.0 → 5.16.0

package/package.json

@@ -10,7 +10,7 @@
     "type": "git",
     "url": "https://github.com/AzureAD/microsoft-authentication-library-for-js.git"
   },
-  "version": "5.14.0",
+  "version": "5.16.0",
   "description": "Microsoft Authentication Library for js",
   "keywords": [
     "implicit",
@@ -129,6 +129,6 @@
     "typescript": "^4.9.5"
   },
   "dependencies": {
-    "@azure/msal-common": "16.9.0"
+    "@azure/msal-common": "16.11.0"
   }
 }

package/src/app/IPublicClientApplication.ts

@@ -81,35 +81,40 @@ export const stubbedPublicClientApplication: IPublicClientApplication = {
     initialize: () => {
         return Promise.reject(
             createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+                ""
             )
         );
     },
     acquireTokenPopup: () => {
         return Promise.reject(
             createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+                ""
             )
         );
     },
     acquireTokenRedirect: () => {
         return Promise.reject(
             createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+                ""
             )
         );
     },
     acquireTokenSilent: () => {
         return Promise.reject(
             createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+                ""
             )
         );
     },
     acquireTokenByCode: () => {
         return Promise.reject(
             createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+                ""
             )
         );
     },
@@ -122,42 +127,48 @@ export const stubbedPublicClientApplication: IPublicClientApplication = {
     handleRedirectPromise: () => {
         return Promise.reject(
             createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+                ""
             )
         );
     },
     loginPopup: () => {
         return Promise.reject(
             createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+                ""
             )
         );
     },
     loginRedirect: () => {
         return Promise.reject(
             createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+                ""
             )
         );
     },
     logoutRedirect: () => {
         return Promise.reject(
             createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+                ""
             )
         );
     },
     logoutPopup: () => {
         return Promise.reject(
             createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+                ""
             )
         );
     },
     ssoSilent: () => {
         return Promise.reject(
             createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+                ""
             )
         );
     },
@@ -175,7 +186,8 @@ export const stubbedPublicClientApplication: IPublicClientApplication = {
     },
     getLogger: () => {
         throw createBrowserConfigurationAuthError(
-            BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+            BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+            ""
         );
     },
     setLogger: () => {
@@ -195,20 +207,23 @@ export const stubbedPublicClientApplication: IPublicClientApplication = {
     },
     getConfiguration: () => {
         throw createBrowserConfigurationAuthError(
-            BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+            BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+            ""
         );
     },
     hydrateCache: () => {
         return Promise.reject(
             createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+                ""
             )
         );
     },
     clearCache: () => {
         return Promise.reject(
             createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled
+                BrowserConfigurationAuthErrorCodes.stubbedPublicClientApplicationCalled,
+                ""
             )
         );
     },

package/src/broker/nativeBroker/PlatformAuthDOMHandler.ts

@@ -208,6 +208,7 @@ export class PlatformAuthDOMHandler implements IPlatformAuthHandler {
                     );
                     throw createNativeAuthError(
                         errorResponse.error.code,
+                        correlationId,
                         errorResponse.error.description,
                         {
                             error: parseInt(errorResponse.error.errorCode),
@@ -221,6 +222,7 @@ export class PlatformAuthDOMHandler implements IPlatformAuthHandler {
         }
         throw createAuthError(
             AuthErrorCodes.unexpectedError,
+            correlationId,
             "Response missing expected properties."
         );
     }

package/src/broker/nativeBroker/PlatformAuthExtensionHandler.ts

@@ -211,7 +211,8 @@ export class PlatformAuthExtensionHandler implements IPlatformAuthHandler {
                 });
                 reject(
                     createBrowserAuthError(
-                        BrowserAuthErrorCodes.nativeHandshakeTimeout
+                        BrowserAuthErrorCodes.nativeHandshakeTimeout,
+                        ""
                     )
                 );
                 this.handshakeResolvers.delete(req.responseId);
@@ -280,7 +281,8 @@ export class PlatformAuthExtensionHandler implements IPlatformAuthHandler {
             });
             handshakeResolver.reject(
                 createBrowserAuthError(
-                    BrowserAuthErrorCodes.nativeExtensionNotInstalled
+                    BrowserAuthErrorCodes.nativeExtensionNotInstalled,
+                    ""
                 )
             );
         }
@@ -327,6 +329,7 @@ export class PlatformAuthExtensionHandler implements IPlatformAuthHandler {
                     resolver.reject(
                         createNativeAuthError(
                             response.code,
+                            correlationId,
                             response.description,
                             response.ext
                         )
@@ -339,6 +342,7 @@ export class PlatformAuthExtensionHandler implements IPlatformAuthHandler {
                         resolver.reject(
                             createNativeAuthError(
                                 response.result["code"],
+                                correlationId,
                                 response.result["description"],
                                 response.result["ext"]
                             )
@@ -349,6 +353,7 @@ export class PlatformAuthExtensionHandler implements IPlatformAuthHandler {
                 } else {
                     throw createAuthError(
                         AuthErrorCodes.unexpectedError,
+                        correlationId,
                         "Event does not contain result."
                     );
                 }
@@ -420,6 +425,7 @@ export class PlatformAuthExtensionHandler implements IPlatformAuthHandler {
         } else {
             throw createAuthError(
                 AuthErrorCodes.unexpectedError,
+                "",
                 "Response missing expected properties."
             );
         }

package/src/broker/nativeBroker/PlatformAuthProvider.ts

@@ -128,7 +128,8 @@ export function isPlatformAuthAllowed(
         config.experimental.allowPlatformBrokerWithDOM
     ) {
         throw createClientConfigurationError(
-            ClientConfigurationErrorCodes.invalidPlatformBrokerConfiguration
+            ClientConfigurationErrorCodes.invalidPlatformBrokerConfiguration,
+            ""
         );
     }
 

package/src/cache/BrowserCacheManager.ts

@@ -446,7 +446,8 @@ export class BrowserCacheManager extends CacheManager {
                 const idToken = JSON.parse(rawValue) as IdTokenEntity;
                 const claims = AuthToken.extractTokenClaims(
                     idToken.secret,
-                    base64Decode
+                    base64Decode,
+                    ""
                 );
                 if (claims) {
                     kmsiMap[idToken.homeAccountId] = AuthToken.isKmsi(claims);
@@ -561,7 +562,8 @@ export class BrowserCacheManager extends CacheManager {
 
             const claims = AuthToken.extractTokenClaims(
                 oldSchemaData.secret,
-                base64Decode
+                base64Decode,
+                correlationId
             );
 
             const newIdTokenKey = this.generateCredentialKey(oldSchemaData);
@@ -576,7 +578,8 @@ export class BrowserCacheManager extends CacheManager {
                 Object.keys(
                     AuthToken.extractTokenClaims(
                         currentIdToken.secret,
-                        base64Decode
+                        base64Decode,
+                        correlationId
                     ) || {}
                 ).includes("signin_state");
 
@@ -603,6 +606,7 @@ export class BrowserCacheManager extends CacheManager {
                         account.homeAccountId,
                         account.localAccountId,
                         tenantId,
+                        account.nativeAccountId,
                         claims
                     );
                     tenantProfiles.push(newTenantProfile);
@@ -920,10 +924,9 @@ export class BrowserCacheManager extends CacheManager {
                 `MSAL.js was last initialized by version: '${previousVersion}'`,
                 correlationId
             );
-            this.performanceClient.addFields(
-                { previousLibraryVersion: previousVersion },
-                correlationId
-            );
+            this.performanceClient.addGlobalFields({
+                previousLibraryVersion: previousVersion,
+            });
         }
 
         if (previousVersion !== version) {
@@ -2236,7 +2239,8 @@ export class BrowserCacheManager extends CacheManager {
         );
         if (!encodedTokenRequest) {
             throw createBrowserAuthError(
-                BrowserAuthErrorCodes.noTokenRequestCacheError
+                BrowserAuthErrorCodes.noTokenRequestCacheError,
+                ""
             );
         }
         const encodedVerifier = this.getTemporaryCache(
@@ -2262,7 +2266,8 @@ export class BrowserCacheManager extends CacheManager {
                 correlationId
             );
             throw createBrowserAuthError(
-                BrowserAuthErrorCodes.unableToParseTokenRequestCacheError
+                BrowserAuthErrorCodes.unableToParseTokenRequestCacheError,
+                ""
             );
         }
 
@@ -2363,7 +2368,8 @@ export class BrowserCacheManager extends CacheManager {
                     this.removeTemporaryItem(key);
                 } else {
                     throw createBrowserAuthError(
-                        BrowserAuthErrorCodes.interactionInProgress
+                        BrowserAuthErrorCodes.interactionInProgress,
+                        ""
                     );
                 }
             }
@@ -2425,6 +2431,7 @@ export class BrowserCacheManager extends CacheManager {
                 ? TimeUtils.toSecondsFromDate(result.extExpiresOn)
                 : 0,
             base64Decode,
+            request.correlationId || "",
             undefined, // refreshOn
             result.tokenType as Constants.AuthenticationScheme,
             undefined, // userAssertionHash
@@ -2443,7 +2450,11 @@ export class BrowserCacheManager extends CacheManager {
             cacheRecord,
             result.correlationId,
             AuthToken.isKmsi(
-                AuthToken.extractTokenClaims(result.idToken, base64Decode)
+                AuthToken.extractTokenClaims(
+                    result.idToken,
+                    base64Decode,
+                    result.correlationId
+                )
             ),
             ApiId.hydrateCache
         );

package/src/cache/CookieStorage.ts

@@ -46,7 +46,10 @@ export class CookieStorage implements IWindowStorage<string> {
     }
 
     getUserData(): string | null {
-        throw createClientAuthError(ClientAuthErrorCodes.methodNotImplemented);
+        throw createClientAuthError(
+            ClientAuthErrorCodes.methodNotImplemented,
+            ""
+        );
     }
 
     setItem(
@@ -73,9 +76,16 @@ export class CookieStorage implements IWindowStorage<string> {
         document.cookie = cookieStr;
     }
 
-    async setUserData(): Promise<void> {
+    async setUserData(
+        _key: string,
+        _value: string,
+        correlationId: string
+    ): Promise<void> {
         return Promise.reject(
-            createClientAuthError(ClientAuthErrorCodes.methodNotImplemented)
+            createClientAuthError(
+                ClientAuthErrorCodes.methodNotImplemented,
+                correlationId
+            )
         );
     }
 

package/src/cache/DatabaseStorage.ts

@@ -65,7 +65,8 @@ export class DatabaseStorage<T> implements IAsyncStorage<T> {
             openDB.addEventListener("error", () =>
                 reject(
                     createBrowserAuthError(
-                        BrowserAuthErrorCodes.databaseUnavailable
+                        BrowserAuthErrorCodes.databaseUnavailable,
+                        ""
                     )
                 )
             );
@@ -104,7 +105,8 @@ export class DatabaseStorage<T> implements IAsyncStorage<T> {
             if (!this.db) {
                 return reject(
                     createBrowserAuthError(
-                        BrowserAuthErrorCodes.databaseNotOpen
+                        BrowserAuthErrorCodes.databaseNotOpen,
+                        ""
                     )
                 );
             }
@@ -140,7 +142,8 @@ export class DatabaseStorage<T> implements IAsyncStorage<T> {
             if (!this.db) {
                 return reject(
                     createBrowserAuthError(
-                        BrowserAuthErrorCodes.databaseNotOpen
+                        BrowserAuthErrorCodes.databaseNotOpen,
+                        ""
                     )
                 );
             }
@@ -175,7 +178,8 @@ export class DatabaseStorage<T> implements IAsyncStorage<T> {
             if (!this.db) {
                 return reject(
                     createBrowserAuthError(
-                        BrowserAuthErrorCodes.databaseNotOpen
+                        BrowserAuthErrorCodes.databaseNotOpen,
+                        ""
                     )
                 );
             }
@@ -208,7 +212,8 @@ export class DatabaseStorage<T> implements IAsyncStorage<T> {
             if (!this.db) {
                 return reject(
                     createBrowserAuthError(
-                        BrowserAuthErrorCodes.databaseNotOpen
+                        BrowserAuthErrorCodes.databaseNotOpen,
+                        ""
                     )
                 );
             }
@@ -244,7 +249,8 @@ export class DatabaseStorage<T> implements IAsyncStorage<T> {
             if (!this.db) {
                 return reject(
                     createBrowserAuthError(
-                        BrowserAuthErrorCodes.databaseNotOpen
+                        BrowserAuthErrorCodes.databaseNotOpen,
+                        ""
                     )
                 );
             }

package/src/cache/LocalStorage.ts

@@ -60,7 +60,8 @@ export class LocalStorage implements IWindowStorage<string> {
     ) {
         if (!window.localStorage) {
             throw createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.storageNotSupported
+                BrowserConfigurationAuthErrorCodes.storageNotSupported,
+                ""
             );
         }
         this.memoryStorage = new MemoryStorage<string>();
@@ -164,7 +165,8 @@ export class LocalStorage implements IWindowStorage<string> {
     getUserData(key: string): string | null {
         if (!this.initialized) {
             throw createBrowserAuthError(
-                BrowserAuthErrorCodes.uninitializedPublicClientApplication
+                BrowserAuthErrorCodes.uninitializedPublicClientApplication,
+                ""
             );
         }
         return this.memoryStorage.getItem(key);
@@ -177,7 +179,8 @@ export class LocalStorage implements IWindowStorage<string> {
     ): Promise<object | null> {
         if (!this.initialized || !this.encryptionCookie) {
             throw createBrowserAuthError(
-                BrowserAuthErrorCodes.uninitializedPublicClientApplication
+                BrowserAuthErrorCodes.uninitializedPublicClientApplication,
+                ""
             );
         }
 
@@ -234,7 +237,8 @@ export class LocalStorage implements IWindowStorage<string> {
     ): Promise<void> {
         if (!this.initialized || !this.encryptionCookie) {
             throw createBrowserAuthError(
-                BrowserAuthErrorCodes.uninitializedPublicClientApplication
+                BrowserAuthErrorCodes.uninitializedPublicClientApplication,
+                ""
             );
         }
 

package/src/cache/SessionStorage.ts

@@ -13,7 +13,8 @@ export class SessionStorage implements IWindowStorage<string> {
     constructor() {
         if (!window.sessionStorage) {
             throw createBrowserConfigurationAuthError(
-                BrowserConfigurationAuthErrorCodes.storageNotSupported
+                BrowserConfigurationAuthErrorCodes.storageNotSupported,
+                ""
             );
         }
     }

package/src/cache/TokenCache.ts

@@ -81,7 +81,11 @@ export async function loadExternalTokens(
 
     try {
         const idTokenClaims = response.id_token
-            ? AuthToken.extractTokenClaims(response.id_token, base64Decode)
+            ? AuthToken.extractTokenClaims(
+                  response.id_token,
+                  base64Decode,
+                  correlationId
+              )
             : undefined;
         const kmsi = AuthToken.isKmsi(idTokenClaims || {});
 
@@ -260,7 +264,10 @@ async function loadAccount(
             "TokenCache - if an account is not provided on the request, clientInfo or idToken must be provided instead.",
             correlationId
         );
-        throw createBrowserAuthError(BrowserAuthErrorCodes.unableToLoadToken);
+        throw createBrowserAuthError(
+            BrowserAuthErrorCodes.unableToLoadToken,
+            ""
+        );
     }
 
     const homeAccountId = AccountEntityUtils.generateHomeAccountId(
@@ -384,8 +391,8 @@ async function loadAccessToken(
     logger.verbose("TokenCache - loading access token", correlationId);
 
     const scopes = response.scope
-        ? ScopeSet.fromString(response.scope)
-        : new ScopeSet(request.scopes);
+        ? ScopeSet.fromString(response.scope, correlationId)
+        : new ScopeSet(request.scopes, correlationId);
     const expiresOn =
         options.expiresOn || response.expires_in + TimeUtils.nowSeconds();
 
@@ -403,7 +410,8 @@ async function loadAccessToken(
         scopes.printScopes(),
         expiresOn,
         extendedExpiresOn,
-        base64Decode
+        base64Decode,
+        correlationId
     );
 
     await storage.setAccessTokenCredential(
@@ -492,7 +500,8 @@ function generateAuthenticationResult(
     if (cacheRecord?.accessToken) {
         accessToken = cacheRecord.accessToken.secret;
         responseScopes = ScopeSet.fromString(
-            cacheRecord.accessToken.target
+            cacheRecord.accessToken.target,
+            request.correlationId || ""
         ).asArray();
         // Access token expiresOn stored in seconds, converting to Date for AuthenticationResult
         expiresOn = TimeUtils.toDateFromSeconds(

package/src/config/Configuration.ts

@@ -360,7 +360,8 @@ export function buildConfiguration(
         logger.warning(
             JSON.stringify(
                 createClientConfigurationError(
-                    ClientConfigurationErrorCodes.cannotSetOIDCOptions
+                    ClientConfigurationErrorCodes.cannotSetOIDCOptions,
+                    ""
                 )
             ),
             ""
@@ -374,7 +375,8 @@ export function buildConfiguration(
         providedSystemOptions?.allowPlatformBroker
     ) {
         throw createClientConfigurationError(
-            ClientConfigurationErrorCodes.cannotAllowPlatformBroker
+            ClientConfigurationErrorCodes.cannotAllowPlatformBroker,
+            ""
         );
     }
 

package/src/controllers/NestedAppAuthController.ts

@@ -628,9 +628,8 @@ export class NestedAppAuthController implements IController {
      * acquireTokenRedirect flow is not supported in nested app auth
      * @param request
      */
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     acquireTokenRedirect(request: RedirectRequest): Promise<void> {
-        throw NestedAppAuthError.createUnsupportedError();
+        throw NestedAppAuthError.createUnsupportedError(request?.correlationId);
     }
 
     /**
@@ -648,11 +647,10 @@ export class NestedAppAuthController implements IController {
      * Hybrid flow is not currently supported in nested app auth
      * @param request
      */
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     acquireTokenByCode(
-        request: AuthorizationCodeRequest // eslint-disable-line @typescript-eslint/no-unused-vars
+        request: AuthorizationCodeRequest
     ): Promise<AuthenticationResult> {
-        throw NestedAppAuthError.createUnsupportedError();
+        throw NestedAppAuthError.createUnsupportedError(request?.correlationId);
     }
 
     /**
@@ -677,11 +675,13 @@ export class NestedAppAuthController implements IController {
 
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     addPerformanceCallback(callback: PerformanceCallbackFunction): string {
+        // No request context: callback registration is not per-request
         throw NestedAppAuthError.createUnsupportedError();
     }
 
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     removePerformanceCallback(callbackId: string): boolean {
+        // No request context: callback registration is not per-request
         throw NestedAppAuthError.createUnsupportedError();
     }
 
@@ -756,17 +756,21 @@ export class NestedAppAuthController implements IController {
     }
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     loginRedirect(request?: RedirectRequest | undefined): Promise<void> {
-        throw NestedAppAuthError.createUnsupportedError();
+        throw NestedAppAuthError.createUnsupportedError(request?.correlationId);
     }
     logoutRedirect(
-        logoutRequest?: EndSessionRequest | undefined // eslint-disable-line @typescript-eslint/no-unused-vars
+        logoutRequest?: EndSessionRequest | undefined
     ): Promise<void> {
-        throw NestedAppAuthError.createUnsupportedError();
+        throw NestedAppAuthError.createUnsupportedError(
+            logoutRequest?.correlationId
+        );
     }
     logoutPopup(
-        logoutRequest?: EndSessionPopupRequest | undefined // eslint-disable-line @typescript-eslint/no-unused-vars
+        logoutRequest?: EndSessionPopupRequest | undefined
     ): Promise<void> {
-        throw NestedAppAuthError.createUnsupportedError();
+        throw NestedAppAuthError.createUnsupportedError(
+            logoutRequest?.correlationId
+        );
     }
     ssoSilent(
         // eslint-disable-next-line @typescript-eslint/no-unused-vars
@@ -829,16 +833,20 @@ export class NestedAppAuthController implements IController {
     }
 
     getPerformanceClient(): IPerformanceClient {
+        // Accessor stub with no request context
         throw NestedAppAuthError.createUnsupportedError();
     }
 
     getRedirectResponse(): Map<string, Promise<AuthenticationResult | null>> {
+        // Accessor stub with no request context
         throw NestedAppAuthError.createUnsupportedError();
     }
 
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     async clearCache(logoutRequest?: ClearCacheRequest): Promise<void> {
-        throw NestedAppAuthError.createUnsupportedError();
+        throw NestedAppAuthError.createUnsupportedError(
+            logoutRequest?.correlationId
+        );
     }
 
     async hydrateCache(