@azure/msal-browser 4.24.1 → 5.0.0-alpha.0

package/src/interaction_client/PopupClient.ts

@@ -8,20 +8,22 @@ import {
     CommonEndSessionRequest,
     UrlString,
     AuthError,
-    OIDC_DEFAULT_SCOPES,
-    PerformanceEvents,
     IPerformanceClient,
     Logger,
     ICrypto,
     ProtocolMode,
-    ServerResponseType,
+    PerformanceEvents,
+    Constants,
     invokeAsync,
     invoke,
     PkceCodes,
     CommonAuthorizationUrlRequest,
-    HttpMethod,
 } from "@azure/msal-common/browser";
-import { StandardInteractionClient } from "./StandardInteractionClient.js";
+import {
+    initializeAuthorizationRequest,
+    StandardInteractionClient,
+} from "./StandardInteractionClient.js";
+import * as BrowserPerformanceEvents from "../telemetry/BrowserPerformanceEvents.js";
 import { EventType } from "../event/EventType.js";
 import {
     InteractionType,
@@ -49,7 +51,12 @@ import { generatePkceCodes } from "../crypto/PkceGenerator.js";
 import { isPlatformAuthAllowed } from "../broker/nativeBroker/PlatformAuthProvider.js";
 import { generateEarKey } from "../crypto/BrowserCrypto.js";
 import { IPlatformAuthHandler } from "../broker/nativeBroker/IPlatformAuthHandler.js";
-import { validateRequestMethod } from "../request/RequestHelpers.js";
+import {
+    clearCacheOnLogout,
+    getDiscoveredAuthority,
+    initializeServerTelemetryManager,
+} from "./BaseInteractionClient.js";
+import { monitorPopupForHash } from "../utils/PopupUtils.js";
 
 export type PopupParams = {
     popup?: Window | null;
@@ -71,8 +78,8 @@ export class PopupClient extends StandardInteractionClient {
         navigationClient: INavigationClient,
         performanceClient: IPerformanceClient,
         nativeStorageImpl: BrowserCacheManager,
-        platformAuthHandler?: IPlatformAuthHandler,
-        correlationId?: string
+        correlationId: string,
+        platformAuthHandler?: IPlatformAuthHandler
     ) {
         super(
             config,
@@ -82,8 +89,8 @@ export class PopupClient extends StandardInteractionClient {
             eventHandler,
             navigationClient,
             performanceClient,
-            platformAuthHandler,
-            correlationId
+            correlationId,
+            platformAuthHandler
         );
         // Properly sets this reference for the unload event.
         this.unloadWindow = this.unloadWindow.bind(this);
@@ -100,26 +107,28 @@ export class PopupClient extends StandardInteractionClient {
         request: PopupRequest,
         pkceCodes?: PkceCodes
     ): Promise<AuthenticationResult> {
-        let popupParams: PopupParams | undefined = undefined;
         try {
             const popupName = this.generatePopupName(
-                request.scopes || OIDC_DEFAULT_SCOPES,
+                request.scopes || Constants.OIDC_DEFAULT_SCOPES,
                 request.authority || this.config.auth.authority
             );
-            popupParams = {
+            const popupParams: PopupParams = {
                 popupName,
                 popupWindowAttributes: request.popupWindowAttributes || {},
                 popupWindowParent: request.popupWindowParent ?? window,
             };
 
             this.performanceClient.addFields(
-                { isAsyncPopup: this.config.system.asyncPopups },
+                { isAsyncPopup: !this.config.system.navigatePopups },
                 this.correlationId
             );
 
-            // asyncPopups flag is true. Acquires token without first opening popup. Popup will be opened later asynchronously.
-            if (this.config.system.asyncPopups) {
-                this.logger.verbose("asyncPopups set to true, acquiring token");
+            // navigatePopups flag is false. Acquires token without first opening popup. Popup will be opened later asynchronously.
+            if (!this.config.system.navigatePopups) {
+                this.logger.verbose(
+                    "navigatePopups set to false, acquiring token",
+                    this.correlationId
+                );
                 // Passes on popup position and dimensions if in request
                 return this.acquireTokenPopupAsync(
                     request,
@@ -127,24 +136,17 @@ export class PopupClient extends StandardInteractionClient {
                     pkceCodes
                 );
             } else {
-                // Pre-validate request method to avoid opening popup if the request is invalid
-                const validatedRequest: PopupRequest = {
-                    ...request,
-                    httpMethod: validateRequestMethod(
-                        request,
-                        this.config.auth.protocolMode
-                    ),
-                };
-                // asyncPopups flag is set to false. Opens popup before acquiring token.
+                // navigatePopups flag is set to true. Opens popup before acquiring token.
                 this.logger.verbose(
-                    "asyncPopup set to false, opening popup before acquiring token"
+                    "navigatePopups set to true, opening popup before acquiring token",
+                    this.correlationId
                 );
                 popupParams.popup = this.openSizedPopup(
                     "about:blank",
                     popupParams
                 );
                 return this.acquireTokenPopupAsync(
-                    validatedRequest,
+                    request,
                     popupParams,
                     pkceCodes
                 );
@@ -160,7 +162,7 @@ export class PopupClient extends StandardInteractionClient {
      */
     logout(logoutRequest?: EndSessionPopupRequest): Promise<void> {
         try {
-            this.logger.verbose("logoutPopup called");
+            this.logger.verbose("logoutPopup called", this.correlationId);
             const validLogoutRequest =
                 this.initializeLogoutRequest(logoutRequest);
             const popupParams: PopupParams = {
@@ -173,9 +175,12 @@ export class PopupClient extends StandardInteractionClient {
             const mainWindowRedirectUri =
                 logoutRequest && logoutRequest.mainWindowRedirectUri;
 
-            // asyncPopups flag is true. Acquires token without first opening popup. Popup will be opened later asynchronously.
-            if (this.config.system.asyncPopups) {
-                this.logger.verbose("asyncPopups set to true");
+            // navigatePopups flag set to false. Acquires token without first opening popup. Popup will be opened later asynchronously.
+            if (!this.config.system.navigatePopups) {
+                this.logger.verbose(
+                    "navigatePopups set to false",
+                    this.correlationId
+                );
                 // Passes on popup position and dimensions if in request
                 return this.logoutPopupAsync(
                     validLogoutRequest,
@@ -184,8 +189,11 @@ export class PopupClient extends StandardInteractionClient {
                     mainWindowRedirectUri
                 );
             } else {
-                // asyncPopups flag is set to false. Opens popup before logging out.
-                this.logger.verbose("asyncPopup set to false, opening popup");
+                // navigatePopups flag is set to true. Opens popup before logging out.
+                this.logger.verbose(
+                    "navigatePopups set to true, opening popup",
+                    this.correlationId
+                );
                 popupParams.popup = this.openSizedPopup(
                     "about:blank",
                     popupParams
@@ -216,15 +224,27 @@ export class PopupClient extends StandardInteractionClient {
         popupParams: PopupParams,
         pkceCodes?: PkceCodes
     ): Promise<AuthenticationResult> {
-        this.logger.verbose("acquireTokenPopupAsync called");
+        this.logger.verbose(
+            "acquireTokenPopupAsync called",
+            this.correlationId
+        );
 
         const validRequest = await invokeAsync(
-            this.initializeAuthorizationRequest.bind(this),
-            PerformanceEvents.StandardInteractionClientInitializeAuthorizationRequest,
+            initializeAuthorizationRequest,
+            BrowserPerformanceEvents.StandardInteractionClientInitializeAuthorizationRequest,
             this.logger,
             this.performanceClient,
             this.correlationId
-        )(request, InteractionType.Popup);
+        )(
+            request,
+            InteractionType.Popup,
+            this.config,
+            this.browserCrypto,
+            this.browserStorage,
+            this.logger,
+            this.performanceClient,
+            this.correlationId
+        );
 
         /*
          * Skip pre-connect for async popups to reduce time between user interaction and popup window creation to avoid
@@ -237,12 +257,13 @@ export class PopupClient extends StandardInteractionClient {
         const isPlatformBroker = isPlatformAuthAllowed(
             this.config,
             this.logger,
+            this.correlationId,
             this.platformAuthProvider,
             request.authenticationScheme
         );
         validRequest.platformBroker = isPlatformBroker;
 
-        if (this.config.auth.protocolMode === ProtocolMode.EAR) {
+        if (this.config.system.protocolMode === ProtocolMode.EAR) {
             return this.executeEarFlow(validRequest, popupParams);
         } else {
             return this.executeCodeFlow(validRequest, popupParams, pkceCodes);
@@ -262,15 +283,19 @@ export class PopupClient extends StandardInteractionClient {
         pkceCodes?: PkceCodes
     ): Promise<AuthenticationResult> {
         const correlationId = request.correlationId;
-        const serverTelemetryManager = this.initializeServerTelemetryManager(
-            ApiId.acquireTokenPopup
+        const serverTelemetryManager = initializeServerTelemetryManager(
+            ApiId.acquireTokenPopup,
+            this.config.auth.clientId,
+            this.correlationId,
+            this.browserStorage,
+            this.logger
         );
 
         const pkce =
             pkceCodes ||
             (await invokeAsync(
                 generatePkceCodes,
-                PerformanceEvents.GeneratePkceCodes,
+                BrowserPerformanceEvents.GeneratePkceCodes,
                 this.logger,
                 this.performanceClient,
                 correlationId
@@ -285,7 +310,7 @@ export class PopupClient extends StandardInteractionClient {
             // Initialize the client
             const authClient: AuthorizationCodeClient = await invokeAsync(
                 this.createAuthCodeClient.bind(this),
-                PerformanceEvents.StandardInteractionClientCreateAuthCodeClient,
+                BrowserPerformanceEvents.StandardInteractionClientCreateAuthCodeClient,
                 this.logger,
                 this.performanceClient,
                 correlationId
@@ -297,80 +322,77 @@ export class PopupClient extends StandardInteractionClient {
                 account: popupRequest.account,
             });
 
-            if (popupRequest.httpMethod === HttpMethod.POST) {
-                return await this.executeCodeFlowWithPost(
-                    popupRequest,
-                    popupParams,
-                    authClient,
-                    pkce.verifier
-                );
-            } else {
-                // Create acquire token url.
-                const navigateUrl = await invokeAsync(
-                    Authorize.getAuthCodeRequestUrl,
-                    PerformanceEvents.GetAuthCodeUrl,
-                    this.logger,
-                    this.performanceClient,
-                    correlationId
-                )(
-                    this.config,
-                    authClient.authority,
-                    popupRequest,
-                    this.logger,
-                    this.performanceClient
-                );
+            // Create acquire token url.
+            const navigateUrl = await invokeAsync(
+                Authorize.getAuthCodeRequestUrl,
+                PerformanceEvents.GetAuthCodeUrl,
+                this.logger,
+                this.performanceClient,
+                correlationId
+            )(
+                this.config,
+                authClient.authority,
+                popupRequest,
+                this.logger,
+                this.performanceClient
+            );
 
-                // Show the UI once the url has been created. Get the window handle for the popup.
-                const popupWindow: Window = this.initiateAuthRequest(
-                    navigateUrl,
-                    popupParams
-                );
-                this.eventHandler.emitEvent(
-                    EventType.POPUP_OPENED,
-                    InteractionType.Popup,
-                    { popupWindow },
-                    null
-                );
+            // Show the UI once the url has been created. Get the window handle for the popup.
+            const popupWindow: Window = this.initiateAuthRequest(
+                navigateUrl,
+                popupParams
+            );
+            this.eventHandler.emitEvent(
+                EventType.POPUP_OPENED,
+                InteractionType.Popup,
+                { popupWindow },
+                null
+            );
 
-                // Monitor the window for the hash. Return the string value and close the popup when the hash is received. Default timeout is 60 seconds.
-                const responseString = await this.monitorPopupForHash(
-                    popupWindow,
-                    popupParams.popupWindowParent
-                );
+            // Monitor the window for the hash. Return the string value and close the popup when the hash is received. Default timeout is 60 seconds.
+            const responseString = await monitorPopupForHash(
+                popupWindow,
+                popupParams.popupWindowParent,
+                this.config.auth.OIDCOptions.responseMode,
+                this.config.system.pollIntervalMilliseconds,
+                this.logger,
+                this.unloadWindow,
+                this.correlationId
+            );
 
-                const serverParams = invoke(
-                    ResponseHandler.deserializeResponse,
-                    PerformanceEvents.DeserializeResponse,
-                    this.logger,
-                    this.performanceClient,
-                    this.correlationId
-                )(
-                    responseString,
-                    this.config.auth.OIDCOptions.serverResponseType,
-                    this.logger
-                );
+            const serverParams = invoke(
+                ResponseHandler.deserializeResponse,
+                BrowserPerformanceEvents.DeserializeResponse,
+                this.logger,
+                this.performanceClient,
+                this.correlationId
+            )(
+                responseString,
+                this.config.auth.OIDCOptions.responseMode,
+                this.logger,
+                this.correlationId
+            );
 
-                return await invokeAsync(
-                    Authorize.handleResponseCode,
-                    PerformanceEvents.HandleResponseCode,
-                    this.logger,
-                    this.performanceClient,
-                    correlationId
-                )(
-                    request,
-                    serverParams,
-                    pkce.verifier,
-                    ApiId.acquireTokenPopup,
-                    this.config,
-                    authClient,
-                    this.browserStorage,
-                    this.nativeStorage,
-                    this.eventHandler,
-                    this.logger,
-                    this.performanceClient,
-                    this.platformAuthProvider
-                );
-            }
+            return await invokeAsync(
+                Authorize.handleResponseCode,
+                BrowserPerformanceEvents.HandleResponseCode,
+                this.logger,
+                this.performanceClient,
+                correlationId
+            )(
+                request,
+                serverParams,
+                pkce.verifier,
+                ApiId.acquireTokenPopup,
+                this.config,
+                authClient,
+                this.browserStorage,
+                this.nativeStorage,
+                this.eventHandler,
+                this.logger,
+                this.performanceClient,
+                this.platformAuthProvider
+            );
         } catch (e) {
             // Close the synchronous popup if an error is thrown before the window unload event is registered
             popupParams.popup?.close();
@@ -391,24 +413,35 @@ export class PopupClient extends StandardInteractionClient {
         request: CommonAuthorizationUrlRequest,
         popupParams: PopupParams
     ): Promise<AuthenticationResult> {
-        const correlationId = request.correlationId;
+        const {
+            correlationId,
+            authority,
+            azureCloudOptions,
+            extraQueryParameters,
+            account,
+        } = request;
         // Get the frame handle for the silent request
         const discoveredAuthority = await invokeAsync(
-            this.getDiscoveredAuthority.bind(this),
-            PerformanceEvents.StandardInteractionClientGetDiscoveredAuthority,
+            getDiscoveredAuthority,
+            BrowserPerformanceEvents.StandardInteractionClientGetDiscoveredAuthority,
             this.logger,
             this.performanceClient,
             correlationId
-        )({
-            requestAuthority: request.authority,
-            requestAzureCloudOptions: request.azureCloudOptions,
-            requestExtraQueryParameters: request.extraQueryParameters,
-            account: request.account,
-        });
+        )(
+            this.config,
+            this.correlationId,
+            this.performanceClient,
+            this.browserStorage,
+            this.logger,
+            authority,
+            azureCloudOptions,
+            extraQueryParameters,
+            account
+        );
 
         const earJwk = await invokeAsync(
             generateEarKey,
-            PerformanceEvents.GenerateEarKey,
+            BrowserPerformanceEvents.GenerateEarKey,
             this.logger,
             this.performanceClient,
             correlationId
@@ -432,115 +465,46 @@ export class PopupClient extends StandardInteractionClient {
 
         // Monitor the popup for the hash. Return the string value and close the popup when the hash is received. Default timeout is 60 seconds.
         const responseString = await invokeAsync(
-            this.monitorPopupForHash.bind(this),
-            PerformanceEvents.SilentHandlerMonitorIframeForHash,
-            this.logger,
-            this.performanceClient,
-            correlationId
-        )(popupWindow, popupParams.popupWindowParent);
-
-        const serverParams = invoke(
-            ResponseHandler.deserializeResponse,
-            PerformanceEvents.DeserializeResponse,
-            this.logger,
-            this.performanceClient,
-            this.correlationId
-        )(
-            responseString,
-            this.config.auth.OIDCOptions.serverResponseType,
-            this.logger
-        );
-
-        return invokeAsync(
-            Authorize.handleResponseEAR,
-            PerformanceEvents.HandleResponseEar,
+            monitorPopupForHash,
+            BrowserPerformanceEvents.SilentHandlerMonitorIframeForHash,
             this.logger,
             this.performanceClient,
             correlationId
         )(
-            popupRequest,
-            serverParams,
-            ApiId.acquireTokenPopup,
-            this.config,
-            discoveredAuthority,
-            this.browserStorage,
-            this.nativeStorage,
-            this.eventHandler,
-            this.logger,
-            this.performanceClient,
-            this.platformAuthProvider
-        );
-    }
-
-    async executeCodeFlowWithPost(
-        request: CommonAuthorizationUrlRequest,
-        popupParams: PopupParams,
-        authClient: AuthorizationCodeClient,
-        pkceVerifier: string
-    ): Promise<AuthenticationResult> {
-        const correlationId = request.correlationId;
-        // Get the frame handle for the silent request
-        const discoveredAuthority = await invokeAsync(
-            this.getDiscoveredAuthority.bind(this),
-            PerformanceEvents.StandardInteractionClientGetDiscoveredAuthority,
+            popupWindow,
+            popupParams.popupWindowParent,
+            this.config.auth.OIDCOptions.responseMode,
+            this.config.system.pollIntervalMilliseconds,
             this.logger,
-            this.performanceClient,
+            this.unloadWindow,
             correlationId
-        )({
-            requestAuthority: request.authority,
-            requestAzureCloudOptions: request.azureCloudOptions,
-            requestExtraQueryParameters: request.extraQueryParameters,
-            account: request.account,
-        });
-
-        const popupWindow =
-            popupParams.popup || this.openPopup("about:blank", popupParams);
-
-        const form = await Authorize.getCodeForm(
-            popupWindow.document,
-            this.config,
-            discoveredAuthority,
-            request,
-            this.logger,
-            this.performanceClient
         );
 
-        form.submit();
-
-        // Monitor the popup for the hash. Return the string value and close the popup when the hash is received. Default timeout is 60 seconds.
-        const responseString = await invokeAsync(
-            this.monitorPopupForHash.bind(this),
-            PerformanceEvents.SilentHandlerMonitorIframeForHash,
-            this.logger,
-            this.performanceClient,
-            correlationId
-        )(popupWindow, popupParams.popupWindowParent);
-
         const serverParams = invoke(
             ResponseHandler.deserializeResponse,
-            PerformanceEvents.DeserializeResponse,
+            BrowserPerformanceEvents.DeserializeResponse,
             this.logger,
             this.performanceClient,
             this.correlationId
         )(
             responseString,
-            this.config.auth.OIDCOptions.serverResponseType,
-            this.logger
+            this.config.auth.OIDCOptions.responseMode,
+            this.logger,
+            this.correlationId
         );
 
         return invokeAsync(
-            Authorize.handleResponseCode,
-            PerformanceEvents.HandleResponseCode,
+            Authorize.handleResponseEAR,
+            BrowserPerformanceEvents.HandleResponseEar,
             this.logger,
             this.performanceClient,
             correlationId
         )(
-            request,
+            popupRequest,
             serverParams,
-            pkceVerifier,
             ApiId.acquireTokenPopup,
             this.config,
-            authClient,
+            discoveredAuthority,
             this.browserStorage,
             this.nativeStorage,
             this.eventHandler,
@@ -565,20 +529,27 @@ export class PopupClient extends StandardInteractionClient {
         requestAuthority?: string,
         mainWindowRedirectUri?: string
     ): Promise<void> {
-        this.logger.verbose("logoutPopupAsync called");
+        this.logger.verbose("logoutPopupAsync called", this.correlationId);
         this.eventHandler.emitEvent(
             EventType.LOGOUT_START,
             InteractionType.Popup,
             validRequest
         );
 
-        const serverTelemetryManager = this.initializeServerTelemetryManager(
-            ApiId.logoutPopup
+        const serverTelemetryManager = initializeServerTelemetryManager(
+            ApiId.logoutPopup,
+            this.config.auth.clientId,
+            this.correlationId,
+            this.browserStorage,
+            this.logger
         );
 
         try {
             // Clear cache on logout
-            await this.clearCacheOnLogout(
+            await clearCacheOnLogout(
+                this.browserStorage,
+                this.browserCrypto,
+                this.logger,
                 this.correlationId,
                 validRequest.account
             );
@@ -586,7 +557,7 @@ export class PopupClient extends StandardInteractionClient {
             // Initialize the client
             const authClient = await invokeAsync(
                 this.createAuthCodeClient.bind(this),
-                PerformanceEvents.StandardInteractionClientCreateAuthCodeClient,
+                BrowserPerformanceEvents.StandardInteractionClientCreateAuthCodeClient,
                 this.logger,
                 this.performanceClient,
                 this.correlationId
@@ -651,9 +622,14 @@ export class PopupClient extends StandardInteractionClient {
                 null
             );
 
-            await this.monitorPopupForHash(
+            await monitorPopupForHash(
                 popupWindow,
-                popupParams.popupWindowParent
+                popupParams.popupWindowParent,
+                this.config.auth.OIDCOptions.responseMode,
+                this.config.system.pollIntervalMilliseconds,
+                this.logger,
+                this.unloadWindow,
+                this.correlationId
             ).catch(() => {
                 // Swallow any errors related to monitoring the window. Server logout is best effort
             });
@@ -670,17 +646,22 @@ export class PopupClient extends StandardInteractionClient {
                 );
 
                 this.logger.verbose(
-                    "Redirecting main window to url specified in the request"
+                    "Redirecting main window to url specified in the request",
+                    this.correlationId
                 );
                 this.logger.verbosePii(
-                    `Redirecting main window to: ${absoluteUrl}`
+                    `Redirecting main window to: '${absoluteUrl}'`,
+                    this.correlationId
                 );
                 await this.navigationClient.navigateInternal(
                     absoluteUrl,
                     navigationOptions
                 );
             } else {
-                this.logger.verbose("No main window navigation requested");
+                this.logger.verbose(
+                    "No main window navigation requested",
+                    this.correlationId
+                );
             }
         } catch (e) {
             // Close the synchronous popup if an error is thrown before the window unload event is registered
@@ -716,85 +697,21 @@ export class PopupClient extends StandardInteractionClient {
     initiateAuthRequest(requestUrl: string, params: PopupParams): Window {
         // Check that request url is not empty.
         if (requestUrl) {
-            this.logger.infoPii(`Navigate to: ${requestUrl}`);
+            this.logger.infoPii(
+                `Navigate to: '${requestUrl}'`,
+                this.correlationId
+            );
             // Open the popup window to requestUrl.
             return this.openPopup(requestUrl, params);
         } else {
             // Throw error if request URL is empty.
-            this.logger.error("Navigate url is empty");
+            this.logger.error("Navigate url is empty", this.correlationId);
             throw createBrowserAuthError(
                 BrowserAuthErrorCodes.emptyNavigateUri
             );
         }
     }
 
-    /**
-     * Monitors a window until it loads a url with the same origin.
-     * @param popupWindow - window that is being monitored
-     * @param timeout - timeout for processing hash once popup is redirected back to application
-     */
-    monitorPopupForHash(
-        popupWindow: Window,
-        popupWindowParent: Window
-    ): Promise<string> {
-        return new Promise<string>((resolve, reject) => {
-            this.logger.verbose(
-                "PopupHandler.monitorPopupForHash - polling started"
-            );
-
-            const intervalId = setInterval(() => {
-                // Window is closed
-                if (popupWindow.closed) {
-                    this.logger.error(
-                        "PopupHandler.monitorPopupForHash - window closed"
-                    );
-                    clearInterval(intervalId);
-                    reject(
-                        createBrowserAuthError(
-                            BrowserAuthErrorCodes.userCancelled
-                        )
-                    );
-                    return;
-                }
-
-                let href = "";
-                try {
-                    /*
-                     * Will throw if cross origin,
-                     * which should be caught and ignored
-                     * since we need the interval to keep running while on STS UI.
-                     */
-                    href = popupWindow.location.href;
-                } catch (e) {}
-
-                // Don't process blank pages or cross domain
-                if (!href || href === "about:blank") {
-                    return;
-                }
-                clearInterval(intervalId);
-
-                let responseString = "";
-                const responseType =
-                    this.config.auth.OIDCOptions.serverResponseType;
-                if (popupWindow) {
-                    if (responseType === ServerResponseType.QUERY) {
-                        responseString = popupWindow.location.search;
-                    } else {
-                        responseString = popupWindow.location.hash;
-                    }
-                }
-
-                this.logger.verbose(
-                    "PopupHandler.monitorPopupForHash - popup window is on same origin as caller"
-                );
-
-                resolve(responseString);
-            }, this.config.system.pollIntervalMilliseconds);
-        }).finally(() => {
-            this.cleanPopup(popupWindow, popupWindowParent);
-        });
-    }
-
     /**
      * @hidden
      *
@@ -815,13 +732,15 @@ export class PopupClient extends StandardInteractionClient {
             if (popupParams.popup) {
                 popupWindow = popupParams.popup;
                 this.logger.verbosePii(
-                    `Navigating popup window to: ${urlNavigate}`
+                    `Navigating popup window to: '${urlNavigate}'`,
+                    this.correlationId
                 );
                 popupWindow.location.assign(urlNavigate);
             } else if (typeof popupParams.popup === "undefined") {
                 // Popup will be undefined if it was not passed in
                 this.logger.verbosePii(
-                    `Opening popup window to: ${urlNavigate}`
+                    `Opening popup window to: '${urlNavigate}'`,
+                    this.correlationId
                 );
                 popupWindow = this.openSizedPopup(urlNavigate, popupParams);
             }
@@ -844,7 +763,8 @@ export class PopupClient extends StandardInteractionClient {
             return popupWindow;
         } catch (e) {
             this.logger.error(
-                "error opening popup " + (e as AuthError).message
+                `error opening popup '${(e as AuthError).message}'`,
+                this.correlationId
             );
             throw createBrowserAuthError(
                 BrowserAuthErrorCodes.popupWindowError
@@ -893,21 +813,24 @@ export class PopupClient extends StandardInteractionClient {
 
         if (!width || width < 0 || width > winWidth) {
             this.logger.verbose(
-                "Default popup window width used. Window width not configured or invalid."
+                "Default popup window width used. Window width not configured or invalid.",
+                this.correlationId
             );
             width = BrowserConstants.POPUP_WIDTH;
         }
 
         if (!height || height < 0 || height > winHeight) {
             this.logger.verbose(
-                "Default popup window height used. Window height not configured or invalid."
+                "Default popup window height used. Window height not configured or invalid.",
+                this.correlationId
             );
             height = BrowserConstants.POPUP_HEIGHT;
         }
 
         if (!top || top < 0 || top > winHeight) {
             this.logger.verbose(
-                "Default popup window top position used. Window top not configured or invalid."
+                "Default popup window top position used. Window top not configured or invalid.",
+                this.correlationId
             );
             top = Math.max(
                 0,
@@ -917,7 +840,8 @@ export class PopupClient extends StandardInteractionClient {
 
         if (!left || left < 0 || left > winWidth) {
             this.logger.verbose(
-                "Default popup window left position used. Window left not configured or invalid."
+                "Default popup window left position used. Window left not configured or invalid.",
+                this.correlationId
             );
             left = Math.max(
                 0,
@@ -943,21 +867,6 @@ export class PopupClient extends StandardInteractionClient {
         e.preventDefault();
     }
 
-    /**
-     * Closes popup, removes any state vars created during popup calls.
-     * @param popupWindow
-     */
-    cleanPopup(popupWindow: Window, popupWindowParent: Window): void {
-        // Close window.
-        popupWindow.close();
-
-        // Remove window unload function
-        popupWindowParent.removeEventListener(
-            "beforeunload",
-            this.unloadWindow
-        );
-    }
-
     /**
      * Generates the name for the popup based on the client id and request
      * @param clientId