@azure/msal-browser 3.26.0 → 3.27.0

package/src/naa/mapping/NestedAppAuthAdapter.ts

@@ -72,7 +72,9 @@ export class NestedAppAuthAdapter {
             );
         }
 
-        const requestBuilder = new RequestParameterBuilder();
+        const correlationId =
+            request.correlationId || this.crypto.createNewGuid();
+        const requestBuilder = new RequestParameterBuilder(correlationId);
         const claims = requestBuilder.addClientCapabilitiesToClaims(
             request.claims,
             this.clientCapabilities
@@ -83,10 +85,7 @@ export class NestedAppAuthAdapter {
             clientId: this.clientId,
             authority: request.authority,
             scope: scopes.join(" "),
-            correlationId:
-                request.correlationId !== undefined
-                    ? request.correlationId
-                    : this.crypto.createNewGuid(),
+            correlationId,
             claims: !StringUtils.isEmptyObj(claims) ? claims : undefined,
             state: request.state,
             authenticationScheme:

package/src/network/FetchClient.ts

@@ -4,10 +4,10 @@
  */
 
 import {
-    Constants,
     INetworkModule,
     NetworkRequestOptions,
     NetworkResponse,
+    createNetworkError,
 } from "@azure/msal-common/browser";
 import {
     createBrowserAuthError,
@@ -29,33 +29,38 @@ export class FetchClient implements INetworkModule {
         url: string,
         options?: NetworkRequestOptions
     ): Promise<NetworkResponse<T>> {
-        let response;
+        let response: Response;
+        let responseHeaders: Record<string, string> = {};
+        let responseStatus = 0;
+        const reqHeaders = getFetchHeaders(options);
         try {
             response = await fetch(url, {
                 method: HTTP_REQUEST_TYPE.GET,
-                headers: this.getFetchHeaders(options),
+                headers: reqHeaders,
             });
         } catch (e) {
-            if (window.navigator.onLine) {
-                throw createBrowserAuthError(
-                    BrowserAuthErrorCodes.getRequestFailed
-                );
-            } else {
-                throw createBrowserAuthError(
-                    BrowserAuthErrorCodes.noNetworkConnectivity
-                );
-            }
+            throw createBrowserAuthError(
+                window.navigator.onLine
+                    ? BrowserAuthErrorCodes.getRequestFailed
+                    : BrowserAuthErrorCodes.noNetworkConnectivity
+            );
         }
 
+        responseHeaders = getHeaderDict(response.headers);
         try {
+            responseStatus = response.status;
             return {
-                headers: this.getHeaderDict(response.headers),
+                headers: responseHeaders,
                 body: (await response.json()) as T,
-                status: response.status,
+                status: responseStatus,
             };
         } catch (e) {
-            throw createBrowserAuthError(
-                BrowserAuthErrorCodes.failedToParseResponse
+            throw createNetworkError(
+                createBrowserAuthError(
+                    BrowserAuthErrorCodes.failedToParseResponse
+                ),
+                responseStatus,
+                responseHeaders
             );
         }
     }
@@ -70,61 +75,83 @@ export class FetchClient implements INetworkModule {
         url: string,
         options?: NetworkRequestOptions
     ): Promise<NetworkResponse<T>> {
-        const reqBody = (options && options.body) || Constants.EMPTY_STRING;
+        const reqBody = (options && options.body) || "";
+        const reqHeaders = getFetchHeaders(options);
 
-        let response;
+        let response: Response;
+        let responseStatus = 0;
+        let responseHeaders: Record<string, string> = {};
         try {
             response = await fetch(url, {
                 method: HTTP_REQUEST_TYPE.POST,
-                headers: this.getFetchHeaders(options),
+                headers: reqHeaders,
                 body: reqBody,
             });
         } catch (e) {
-            if (window.navigator.onLine) {
-                throw createBrowserAuthError(
-                    BrowserAuthErrorCodes.postRequestFailed
-                );
-            } else {
-                throw createBrowserAuthError(
-                    BrowserAuthErrorCodes.noNetworkConnectivity
-                );
-            }
+            throw createBrowserAuthError(
+                window.navigator.onLine
+                    ? BrowserAuthErrorCodes.postRequestFailed
+                    : BrowserAuthErrorCodes.noNetworkConnectivity
+            );
         }
 
+        responseHeaders = getHeaderDict(response.headers);
         try {
+            responseStatus = response.status;
             return {
-                headers: this.getHeaderDict(response.headers),
+                headers: responseHeaders,
                 body: (await response.json()) as T,
-                status: response.status,
+                status: responseStatus,
             };
         } catch (e) {
-            throw createBrowserAuthError(
-                BrowserAuthErrorCodes.failedToParseResponse
+            throw createNetworkError(
+                createBrowserAuthError(
+                    BrowserAuthErrorCodes.failedToParseResponse
+                ),
+                responseStatus,
+                responseHeaders
             );
         }
     }
+}
 
-    /**
-     * Get Fetch API Headers object from string map
-     * @param inputHeaders
-     */
-    private getFetchHeaders(options?: NetworkRequestOptions): Headers {
+/**
+ * Get Fetch API Headers object from string map
+ * @param inputHeaders
+ */
+function getFetchHeaders(options?: NetworkRequestOptions): Headers {
+    try {
         const headers = new Headers();
         if (!(options && options.headers)) {
             return headers;
         }
         const optionsHeaders = options.headers;
-        Object.keys(optionsHeaders).forEach((key) => {
-            headers.append(key, optionsHeaders[key]);
+        Object.entries(optionsHeaders).forEach(([key, value]) => {
+            headers.append(key, value);
         });
         return headers;
+    } catch (e) {
+        throw createBrowserAuthError(
+            BrowserAuthErrorCodes.failedToBuildHeaders
+        );
     }
+}
 
-    private getHeaderDict(headers: Headers): Record<string, string> {
+/**
+ * Returns object representing response headers
+ * @param headers
+ * @returns
+ */
+function getHeaderDict(headers: Headers): Record<string, string> {
+    try {
         const headerDict: Record<string, string> = {};
         headers.forEach((value: string, key: string) => {
             headerDict[key] = value;
         });
         return headerDict;
+    } catch (e) {
+        throw createBrowserAuthError(
+            BrowserAuthErrorCodes.failedToParseHeaders
+        );
     }
 }

package/src/packageMetadata.ts

@@ -1,3 +1,3 @@
 /* eslint-disable header/header */
 export const name = "@azure/msal-browser";
-export const version = "3.26.0";
+export const version = "3.27.0";