@azure/core-rest-pipeline 1.4.0 → 1.4.1-alpha.20220120.2

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Release History
 
+## 1.4.1 (Unreleased)
+
+### Features Added
+
+### Breaking Changes
+
+### Bugs Fixed
+
+- Updated the HTTP tracing span names to conform to the [OpenTelemetry Specification](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#name). [#19838](https://github.com/Azure/azure-sdk-for-js/pull/19838)
+  - New HTTP spans will use the `HTTP <VERB>` convention instead of using the URL path.
+
+### Other Changes
+
 ## 1.4.0 (2022-01-06)
 
 ### Features Added

package/core-rest-pipeline.shims-3_1.d.ts

@@ -5,6 +5,8 @@ declare global {
   interface FormData {}
   interface Blob {}
   interface File {}
+  interface ReadableStream<R = any> {}
+  interface TransformStream<I = any, O = any>  {}
 }
 
 export * from "./types/3.1/core-rest-pipeline";

package/core-rest-pipeline.shims.d.ts

@@ -5,6 +5,8 @@ declare global {
   interface FormData {}
   interface Blob {}
   interface File {}
+  interface ReadableStream<R = any> {}
+  interface TransformStream<I = any, O = any>  {}
 }
 
 export * from "./types/latest/core-rest-pipeline";

package/dist/index.js

@@ -847,7 +847,7 @@ function setPlatformSpecificData(map) {
 
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
-const SDK_VERSION = "1.3.3";
+const SDK_VERSION = "1.4.1";
 
 // Copyright (c) Microsoft Corporation.
 function getUserAgentString(telemetryInfo) {
@@ -920,11 +920,10 @@ function tryCreateSpan(request, userAgent) {
     var _a, _b, _c;
     try {
         const createSpanOptions = Object.assign(Object.assign({}, (_a = request.tracingOptions) === null || _a === void 0 ? void 0 : _a.spanOptions), { kind: coreTracing.SpanKind.CLIENT });
-        const url$1 = new url.URL(request.url);
-        const path = url$1.pathname || "/";
         // Passing spanOptions as part of tracingOptions to maintain compatibility @azure/core-tracing@preview.13 and earlier.
         // We can pass this as a separate parameter once we upgrade to the latest core-tracing.
-        const { span } = createSpan(path, {
+        // As per spec, we do not need to differentiate between HTTP and HTTPS in span name.
+        const { span } = createSpan(`HTTP ${request.method}`, {
             tracingOptions: Object.assign(Object.assign({}, request.tracingOptions), { spanOptions: createSpanOptions }),
         });
         // If the span is not recording, don't do any more work.
@@ -1720,7 +1719,7 @@ function generateUuid() {
 // Copyright (c) Microsoft Corporation.
 class PipelineRequestImpl {
     constructor(options) {
-        var _a, _b, _c, _d, _e, _f;
+        var _a, _b, _c, _d, _e, _f, _g;
         this.url = options.url;
         this.body = options.body;
         this.headers = (_a = options.headers) !== null && _a !== void 0 ? _a : createHttpHeaders();
@@ -1737,6 +1736,7 @@ class PipelineRequestImpl {
         this.onDownloadProgress = options.onDownloadProgress;
         this.requestId = options.requestId || generateUuid();
         this.allowInsecureConnection = (_f = options.allowInsecureConnection) !== null && _f !== void 0 ? _f : false;
+        this.enableBrowserStreams = (_g = options.enableBrowserStreams) !== null && _g !== void 0 ? _g : false;
     }
 }
 /**