@azure/core-client 1.5.1-alpha.20220406.3 → 1.6.0-alpha.20220421.2

package/CHANGELOG.md

@@ -1,14 +1,11 @@
 # Release History
 
-## 1.5.1 (Unreleased)
+## 1.6.0 (unreleased)
 
 ### Features Added
 
-### Breaking Changes
-
-### Bugs Fixed
-
-### Other Changes
+- Added a new property endpoint in ServiceClientOptions and mark the baseUri as deprecated to encourage people to use endpoint. See issue link [here](https://github.com/Azure/autorest.typescript/issues/1337)
+- Upgraded our `@azure/core-tracing` dependency to version 1.0
 
 ## 1.5.0 (2022-02-03)
 

package/dist/index.js

@@ -3,8 +3,7 @@
 Object.defineProperty(exports, '__esModule', { value: true });
 
 var coreRestPipeline = require('@azure/core-rest-pipeline');
-var logger = require('@azure/logger');
-require('@azure/core-asynciterator-polyfill');
+var logger$1 = require('@azure/logger');
 
 // Copyright (c) Microsoft Corporation.
 /**
@@ -1797,6 +1796,9 @@ function appendQueryParams(url, queryParams, sequenceParams, noOverwrite = false
     return parsedUrl.toString();
 }
 
+// Copyright (c) Microsoft Corporation.
+const logger = logger$1.createClientLogger("core-client");
+
 // Copyright (c) Microsoft Corporation.
 /**
  * Initializes a new instance of the ServiceClient.
@@ -1808,13 +1810,16 @@ class ServiceClient {
      * @param options - The service client options that govern the behavior of the client.
      */
     constructor(options = {}) {
-        var _a;
+        var _a, _b;
         this._requestContentType = options.requestContentType;
-        this._baseUri = options.baseUri;
+        this._endpoint = (_a = options.endpoint) !== null && _a !== void 0 ? _a : options.baseUri;
+        if (options.baseUri) {
+            logger.warning("The baseUri option for SDK Clients has been deprecated, please use endpoint instead.");
+        }
         this._allowInsecureConnection = options.allowInsecureConnection;
         this._httpClient = options.httpClient || getCachedDefaultHttpClient();
         this.pipeline = options.pipeline || createDefaultPipeline(options);
-        if ((_a = options.additionalPolicies) === null || _a === void 0 ? void 0 : _a.length) {
+        if ((_b = options.additionalPolicies) === null || _b === void 0 ? void 0 : _b.length) {
             for (const { policy, position } of options.additionalPolicies) {
                 // Sign happens after Retry and is commonly needed to occur
                 // before policies that intercept post-retry.
@@ -1838,14 +1843,14 @@ class ServiceClient {
      * @param operationSpec - The OperationSpec to use to populate the httpRequest.
      */
     async sendOperationRequest(operationArguments, operationSpec) {
-        const baseUri = operationSpec.baseUrl || this._baseUri;
-        if (!baseUri) {
-            throw new Error("If operationSpec.baseUrl is not specified, then the ServiceClient must have a baseUri string property that contains the base URL to use.");
+        const endpoint = operationSpec.baseUrl || this._endpoint;
+        if (!endpoint) {
+            throw new Error("If operationSpec.baseUrl is not specified, then the ServiceClient must have a endpoint string property that contains the base URL to use.");
         }
         // Templatized URLs sometimes reference properties on the ServiceClient child class,
         // so we have to pass `this` below in order to search these properties if they're
         // not part of OperationArguments
-        const url = getRequestUrl(baseUri, operationSpec, operationArguments, this);
+        const url = getRequestUrl(endpoint, operationSpec, operationArguments, this);
         const request = coreRestPipeline.createPipelineRequest({
             url,
         });
@@ -1925,17 +1930,19 @@ function getCredentialScopes(options) {
             ? scopes.map((scope) => new URL(scope).toString())
             : new URL(scopes).toString();
     }
+    if (options.endpoint) {
+        return `${options.endpoint}/.default`;
+    }
     if (options.baseUri) {
         return `${options.baseUri}/.default`;
     }
     if (options.credential && !options.credentialScopes) {
-        throw new Error(`When using credentials, the ServiceClientOptions must contain either a baseUri or a credentialScopes. Unable to create a bearerTokenAuthenticationPolicy`);
+        throw new Error(`When using credentials, the ServiceClientOptions must contain either a endpoint or a credentialScopes. Unable to create a bearerTokenAuthenticationPolicy`);
     }
     return undefined;
 }
 
 // Copyright (c) Microsoft Corporation.
-const defaultLogger = logger.createClientLogger("authorizeRequestOnClaimChallenge");
 /**
  * Converts: `Bearer a="b", c="d", Bearer d="e", f="g"`.
  * Into: `[ { a: 'b', c: 'd' }, { d: 'e', f: 'g' } ]`.
@@ -1979,16 +1986,16 @@ function parseCAEChallenge(challenges) {
  */
 async function authorizeRequestOnClaimChallenge(onChallengeOptions) {
     const { scopes, response } = onChallengeOptions;
-    const logger = onChallengeOptions.logger || defaultLogger;
+    const logger$1 = onChallengeOptions.logger || logger;
     const challenge = response.headers.get("WWW-Authenticate");
     if (!challenge) {
-        logger.info(`The WWW-Authenticate header was missing. Failed to perform the Continuous Access Evaluation authentication flow.`);
+        logger$1.info(`The WWW-Authenticate header was missing. Failed to perform the Continuous Access Evaluation authentication flow.`);
         return false;
     }
     const challenges = parseCAEChallenge(challenge) || [];
     const parsedChallenge = challenges.find((x) => x.claims);
     if (!parsedChallenge) {
-        logger.info(`The WWW-Authenticate header was missing the necessary "claims" to perform the Continuous Access Evaluation authentication flow.`);
+        logger$1.info(`The WWW-Authenticate header was missing the necessary "claims" to perform the Continuous Access Evaluation authentication flow.`);
         return false;
     }
     const accessToken = await onChallengeOptions.getAccessToken(parsedChallenge.scope ? [parsedChallenge.scope] : scopes, {