@azure/core-client 1.4.0 → 1.4.1-alpha.20220120.2

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Release History
 
+## 1.4.1 (Unreleased)
+
+### Features Added
+
+### Breaking Changes
+
+### Bugs Fixed
+
+- Addressed an issue where the `onResponse` callback wouldn't be called in certain cases where an unexpected response was received from the service. [PR #19702](https://github.com/Azure/azure-sdk-for-js/pull/19702)
+
+### Other Changes
+
 ## 1.4.0 (2022-01-06)
 
 ### Features Added

package/README.md

@@ -37,11 +37,11 @@ The method `createSerializer` creates a `Serializer` that is used to do the bulk
 
 ## Examples
 
-Examples can be found in the `samples` folder.
+Examples can be found in the [samples](https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/core/core-client/samples) folder.
 
 ## Next steps
 
-You can build and run the tests locally by executing `rushx test`. Explore the `test` folder to see advanced usage and behavior of the public classes.
+You can build and run the tests locally by executing `rushx test`. Explore the [test](https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/core/core-client/test) folder to see advanced usage and behavior of the public classes.
 
 Learn more about [AutoRest](https://github.com/Azure/autorest) and the [autorest.typescript extension](https://github.com/Azure/autorest.typescript) for generating a compatible client on top of this package.
 

package/dist/index.js

@@ -1172,7 +1172,13 @@ function getRequestUrl(baseUri, operationSpec, operationArguments, fallbackObjec
     let isAbsolutePath = false;
     let requestUrl = replaceAll(baseUri, urlReplacements);
     if (operationSpec.path) {
-        const path = replaceAll(operationSpec.path, urlReplacements);
+        let path = replaceAll(operationSpec.path, urlReplacements);
+        // QUIRK: sometimes we get a path component like /{nextLink}
+        // which may be a fully formed URL with a leading /. In that case, we should
+        // remove the leading /
+        if (operationSpec.path === "/{nextLink}" && path.startsWith("/")) {
+            path = path.substring(1);
+        }
         // QUIRK: sometimes we get a path component like {nextLink}
         // which may be a fully formed URL. In that case, we should
         // ignore the baseUri.
@@ -1881,8 +1887,13 @@ class ServiceClient {
             return flatResponse;
         }
         catch (error) {
-            if (error.response) {
-                error.details = flattenResponse(error.response, operationSpec.responses[error.statusCode] || operationSpec.responses["default"]);
+            if (typeof error === "object" && (error === null || error === void 0 ? void 0 : error.response)) {
+                const rawResponse = error.response;
+                const flatResponse = flattenResponse(rawResponse, operationSpec.responses[error.statusCode] || operationSpec.responses["default"]);
+                error.details = flatResponse;
+                if (options === null || options === void 0 ? void 0 : options.onResponse) {
+                    options.onResponse(rawResponse, flatResponse, error);
+                }
             }
             throw error;
         }