@azure/core-client 1.3.3-alpha.20211101.2 → 1.4.0-alpha.20211214.4

package/CHANGELOG.md

@@ -1,11 +1,11 @@
 # Release History
 
-## 1.3.3 (Unreleased)
+## 1.4.0 (Unreleased)
 
 ### Features Added
 
 - Added a new function `authorizeRequestOnClaimChallenge`, that can be used with the `@azure/core-rest-pipeline`'s `bearerTokenAuthenticationPolicy` to support [Continuous Access Evaluation (CAE) challenges](https://docs.microsoft.com/azure/active-directory/conditional-access/concept-continuous-access-evaluation).
-  - Call the `bearerTokenAuthenticationPolicy` with the following options: `bearerTokenAuthenticationPolicy({ authorizeRequestOnChallenge: authorizeRequestOnClaimChallenge })`. Once provided, the `bearerTokenAuthenticationPolicy` policy will internally handle Continuous Access Evaluation (CAE) challenges. When it can't complete a challenge it will return the 401 (unauthorized) response from ARM.
+- Call the `bearerTokenAuthenticationPolicy` with the following options: `bearerTokenAuthenticationPolicy({ authorizeRequestOnChallenge: authorizeRequestOnClaimChallenge })`. Once provided, the `bearerTokenAuthenticationPolicy` policy will internally handle Continuous Access Evaluation (CAE) challenges. When it can't complete a challenge it will return the 401 (unauthorized) response from ARM.
 
 ### Breaking Changes
 
@@ -13,6 +13,12 @@
 
 ### Other Changes
 
+## 1.3.3 (2021-12-02)
+
+### Bugs Fixed
+
+- Added a check to handle undefined value during the parsing of query parameters. Please refer to [PR #18621](https://github.com/Azure/azure-sdk-for-js/pull/18621) for further details.
+
 ## 1.3.2 (2021-10-25)
 
 ### Bugs Fixed

package/README.md

@@ -1,4 +1,4 @@
-# Azure Core Service client library for JavaScript (Experimental)
+# Azure Core Service client library for JavaScript
 
 This library is primarily intended to be used in code generated by [AutoRest](https://github.com/Azure/Autorest) and [`autorest.typescript`](https://github.com/Azure/autorest.typescript).
 

package/dist/index.js

@@ -3,7 +3,7 @@
 Object.defineProperty(exports, '__esModule', { value: true });
 
 var coreRestPipeline = require('@azure/core-rest-pipeline');
-var logger$1 = require('@azure/logger');
+var logger = require('@azure/logger');
 require('@azure/core-asynciterator-polyfill');
 
 // Copyright (c) Microsoft Corporation.
@@ -144,6 +144,7 @@ function decodeString(value) {
 /**
  * Decodes a base64 string into a string.
  * @param value - the base64 string to decode
+ * @internal
  */
 function decodeStringToString(value) {
     return Buffer.from(value, "base64").toString();
@@ -1354,12 +1355,15 @@ function appendQueryParams(url, queryParams, sequenceParams, noOverwrite = false
         if (typeof value === "string") {
             searchPieces.push(`${name}=${value}`);
         }
-        else {
+        else if (Array.isArray(value)) {
             // QUIRK: If we get an array of values, include multiple key/value pairs
             for (const subValue of value) {
                 searchPieces.push(`${name}=${subValue}`);
             }
         }
+        else {
+            searchPieces.push(`${name}=${value}`);
+        }
     }
     // QUIRK: we have to set search manually as searchParams will encode comma when it shouldn't.
     parsedUrl.search = searchPieces.length ? `?${searchPieces.join("&")}` : "";
@@ -1892,7 +1896,7 @@ function getCredentialScopes(options) {
 }
 
 // Copyright (c) Microsoft Corporation.
-const logger = logger$1.createClientLogger("authorizeRequestOnClaimChallenge");
+const defaultLogger = logger.createClientLogger("authorizeRequestOnClaimChallenge");
 /**
  * Converts: `Bearer a="b", c="d", Bearer d="e", f="g"`.
  * Into: `[ { a: 'b', c: 'd' }, { d: 'e', f: 'g' } ]`.
@@ -1936,6 +1940,7 @@ function parseCAEChallenge(challenges) {
  */
 async function authorizeRequestOnClaimChallenge(onChallengeOptions) {
     const { scopes, response } = onChallengeOptions;
+    const logger = onChallengeOptions.logger || defaultLogger;
     const challenge = response.headers.get("WWW-Authenticate");
     if (!challenge) {
         logger.info(`The WWW-Authenticate header was missing. Failed to perform the Continuous Access Evaluation authentication flow.`);