@azure/communication-react 1.4.0 → 1.4.1

package/CHANGELOG.md

@@ -1,9 +1,18 @@
 # Change Log - @azure/communication-react
 
-This log was last generated on Fri, 21 Oct 2022 23:01:52 GMT and should not be manually modified.
+This log was last generated on Wed, 30 Nov 2022 17:40:55 GMT and should not be manually modified.
 
 <!-- Start content -->
 
+## [1.4.1](https://github.com/azure/communication-ui-library/tree/1.4.1)
+
+Wed, 30 Nov 2022 17:40:55 GMT
+[Compare changes](https://github.com/azure/communication-ui-library/compare/1.4.0...1.4.1)
+
+This is a patch release for issue where the local video tile was not showing the users local stream despite the camera being on [more details](https://github.com/Azure/communication-ui-library/pull/2558):
+
+- Fix: Local video not showing to local user but still broadcasts to others in the call. ([PR #2558](https://github.com/Azure/communication-ui-library/pull/2558) by 2684369+JamesBurnside@users.noreply.github.com).
+
 ## [1.4.0](https://github.com/azure/communication-ui-library/tree/1.4.0)
 
 Fri, 21 Oct 2022 23:01:52 GMT

package/dist/dist-cjs/communication-react/index.js

@@ -219,7 +219,7 @@ const _toCommunicationIdentifier = (id) => {
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 // GENERATED FILE. DO NOT EDIT MANUALLY.
-var telemetryVersion = '1.4.0';
+var telemetryVersion = '1.4.1';
 
 // Copyright (c) Microsoft Corporation.
 /**
@@ -8710,6 +8710,7 @@ var EventNames;
     EventNames["CREATE_STREAM_INVALID_PARAMS"] = "CREATE_STREAM_INVALID_PARAMS";
     EventNames["DISPOSE_STREAM_INVALID_PARAMS"] = "DISPOSE_LOCAL_STREAM_INVALID_PARAMS";
     EventNames["LOCAL_STREAM_ALREADY_RENDERED"] = "LOCAL_STREAM_ALREADY_RENDERED";
+    EventNames["LOCAL_STREAM_ALREADY_DISPOSED"] = "LOCAL_STREAM_ALREADY_DISPOSED";
     EventNames["LOCAL_STREAM_STOPPING"] = "LOCAL_STREAM_STOPPING";
     EventNames["LOCAL_CREATED_STREAM_STOPPING"] = "LOCAL_CREATED_STREAM_STOPPING";
     EventNames["LOCAL_STREAM_RENDERING"] = "LOCAL_STREAM_RENDERING";
@@ -9722,14 +9723,15 @@ function createViewLocalVideo(context, internalContext, callId, options) {
                 message: 'LocalVideoStream is rendering.'
             });
             return;
-        }
+        } // "Stopping" only happens if the stream was in "rendering" but `disposeView` was called.
+        // Now that `createView` has been re-called, we can flip the state back to "rendering".
         if (renderInfo.status === 'Stopping') {
             _logEvent(callingStatefulLogger, {
                 name: EventNames.LOCAL_STREAM_STOPPING,
                 level: 'warning',
-                message: 'LocalVideoStream is in the middle of stopping.'
+                message: 'LocalVideoStream was marked as stopping by dispose view. Resetting state to "Rendering".'
             });
-            console.warn('LocalVideoStream is in the middle of stopping');
+            internalContext.setLocalRenderInfo(callId, renderInfo.stream, 'Rendering', renderInfo.renderer);
             return;
         }
         const renderer = new communicationCalling.VideoStreamRenderer(renderInfo.stream);
@@ -9940,21 +9942,39 @@ function disposeViewLocalVideo(context, internalContext, callId) {
             data: streamLogInfo
         });
         return;
-    } // Sets the status and also renderer. I think we need to always set renderer to undefined since in all status when
-    // cleaned up should have renderer as undefined. If the status is 'Rendered' and renderer is not defined it should
-    // be cleaned up below so we can set it to undefined here.
-    if (renderInfo.status === 'Rendering') {
+    } // Nothing to dispose of or clean up -- we can safely exit early here.
+    if (renderInfo.status === 'NotRendered') {
+        _logEvent(callingStatefulLogger, {
+            name: EventNames.LOCAL_STREAM_ALREADY_DISPOSED,
+            level: 'info',
+            message: 'LocalVideoStream is already disposed.'
+        });
+        return;
+    } // Status is already marked as "stopping" so we can exit early here. This is because stopping only occurs
+    // when the stream is being created in createView but hasn't been completed being created yet. The createView
+    // method will see the "stopping" status and perform the cleanup
+    if (renderInfo.status === 'Stopping') {
         _logEvent(callingStatefulLogger, {
             name: EventNames.LOCAL_STREAM_STOPPING,
             level: 'info',
-            message: 'Local stream is still rendering. Changing status to stopping.',
+            message: 'Local stream is already stopping.',
             data: streamLogInfo
         });
-        internalContext.setLocalRenderInfo(callId, renderInfo.stream, 'Stopping', undefined);
-    }
-    else {
-        internalContext.setLocalRenderInfo(callId, renderInfo.stream, 'NotRendered', undefined);
-    }
+        return;
+    } // If the stream is in the middle of being rendered (i.e. has state "Rendering"), we need the status as
+    // "stopping" without performing any cleanup. This will tell the `createView` method that it should stop
+    // rendering and clean up the state once the view has finished being created.
+    if (renderInfo.status === 'Rendering') {
+        _logEvent(callingStatefulLogger, {
+            name: EventNames.REMOTE_STREAM_STOPPING,
+            level: 'info',
+            message: 'Remote stream is still rendering. Changing status to stopping.',
+            data: streamLogInfo
+        });
+        internalContext.setLocalRenderInfo(callId, renderInfo.stream, 'Stopping', renderInfo.renderer);
+        return;
+    } // Else the state must be in the "Rendered" state, so we can dispose the renderer and clean up the state.
+    internalContext.setLocalRenderInfo(callId, renderInfo.stream, 'NotRendered', undefined);
     if (renderInfo.renderer) {
         _logEvent(callingStatefulLogger, {
             name: EventNames.DISPOSING_LOCAL_RENDERER,