@azure/arm-privatedns 3.1.1-alpha.20230502.1 → 3.2.0-alpha.20230522.3

package/src/lroImpl.ts

@@ -6,29 +6,37 @@
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.
  */
 
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+import { AbortSignalLike } from "@azure/abort-controller";
 import { LongRunningOperation, LroResponse } from "@azure/core-lro";
 
-export class LroImpl<T> implements LongRunningOperation<T> {
-  constructor(
-    private sendOperationFn: (args: any, spec: any) => Promise<LroResponse<T>>,
-    private args: Record<string, unknown>,
-    private spec: {
-      readonly requestBody?: unknown;
-      readonly path?: string;
-      readonly httpMethod: string;
-    } & Record<string, any>,
-    public requestPath: string = spec.path!,
-    public requestMethod: string = spec.httpMethod
-  ) {}
-  public async sendInitialRequest(): Promise<LroResponse<T>> {
-    return this.sendOperationFn(this.args, this.spec);
-  }
-  public async sendPollRequest(path: string): Promise<LroResponse<T>> {
-    const { requestBody, ...restSpec } = this.spec;
-    return this.sendOperationFn(this.args, {
-      ...restSpec,
-      path,
-      httpMethod: "GET"
-    });
-  }
+export function createLroSpec<T>(inputs: {
+  sendOperationFn: (args: any, spec: any) => Promise<LroResponse<T>>;
+  args: Record<string, unknown>;
+  spec: {
+    readonly requestBody?: unknown;
+    readonly path?: string;
+    readonly httpMethod: string;
+  } & Record<string, any>;
+}): LongRunningOperation<T> {
+  const { args, spec, sendOperationFn } = inputs;
+  return {
+    requestMethod: spec.httpMethod,
+    requestPath: spec.path!,
+    sendInitialRequest: () => sendOperationFn(args, spec),
+    sendPollRequest: (
+      path: string,
+      options?: { abortSignal?: AbortSignalLike }
+    ) => {
+      const { requestBody, ...restSpec } = spec;
+      return sendOperationFn(args, {
+        ...restSpec,
+        httpMethod: "GET",
+        path,
+        abortSignal: options?.abortSignal
+      });
+    }
+  };
 }

package/src/models/index.ts

@@ -393,20 +393,14 @@ export type PrivateZonesListByResourceGroupResponse = PrivateZoneListResult;
 
 /** Optional parameters. */
 export interface PrivateZonesListNextOptionalParams
-  extends coreClient.OperationOptions {
-  /** The maximum number of Private DNS zones to return. If not specified, returns up to 100 zones. */
-  top?: number;
-}
+  extends coreClient.OperationOptions {}
 
 /** Contains response data for the listNext operation. */
 export type PrivateZonesListNextResponse = PrivateZoneListResult;
 
 /** Optional parameters. */
 export interface PrivateZonesListByResourceGroupNextOptionalParams
-  extends coreClient.OperationOptions {
-  /** The maximum number of record sets to return. If not specified, returns up to 100 record sets. */
-  top?: number;
-}
+  extends coreClient.OperationOptions {}
 
 /** Contains response data for the listByResourceGroupNext operation. */
 export type PrivateZonesListByResourceGroupNextResponse = PrivateZoneListResult;
@@ -471,10 +465,7 @@ export type VirtualNetworkLinksListResponse = VirtualNetworkLinkListResult;
 
 /** Optional parameters. */
 export interface VirtualNetworkLinksListNextOptionalParams
-  extends coreClient.OperationOptions {
-  /** The maximum number of virtual network links to return. If not specified, returns up to 100 virtual network links. */
-  top?: number;
-}
+  extends coreClient.OperationOptions {}
 
 /** Contains response data for the listNext operation. */
 export type VirtualNetworkLinksListNextResponse = VirtualNetworkLinkListResult;
@@ -541,24 +532,14 @@ export type RecordSetsListResponse = RecordSetListResult;
 
 /** Optional parameters. */
 export interface RecordSetsListByTypeNextOptionalParams
-  extends coreClient.OperationOptions {
-  /** The maximum number of record sets to return. If not specified, returns up to 100 record sets. */
-  top?: number;
-  /** The suffix label of the record set name to be used to filter the record set enumeration. If this parameter is specified, the returned enumeration will only contain records that end with ".<recordsetnamesuffix>". */
-  recordsetnamesuffix?: string;
-}
+  extends coreClient.OperationOptions {}
 
 /** Contains response data for the listByTypeNext operation. */
 export type RecordSetsListByTypeNextResponse = RecordSetListResult;
 
 /** Optional parameters. */
 export interface RecordSetsListNextOptionalParams
-  extends coreClient.OperationOptions {
-  /** The maximum number of record sets to return. If not specified, returns up to 100 record sets. */
-  top?: number;
-  /** The suffix label of the record set name to be used to filter the record set enumeration. If this parameter is specified, the returned enumeration will only contain records that end with ".<recordsetnamesuffix>". */
-  recordsetnamesuffix?: string;
-}
+  extends coreClient.OperationOptions {}
 
 /** Contains response data for the listNext operation. */
 export type RecordSetsListNextResponse = RecordSetListResult;

package/src/operations/privateZones.ts

@@ -13,8 +13,12 @@ import * as coreClient from "@azure/core-client";
 import * as Mappers from "../models/mappers";
 import * as Parameters from "../models/parameters";
 import { PrivateDnsManagementClient } from "../privateDnsManagementClient";
-import { PollerLike, PollOperationState, LroEngine } from "@azure/core-lro";
-import { LroImpl } from "../lroImpl";
+import {
+  SimplePollerLike,
+  OperationState,
+  createHttpPoller
+} from "@azure/core-lro";
+import { createLroSpec } from "../lroImpl";
 import {
   PrivateZone,
   PrivateZonesListNextOptionalParams,
@@ -184,8 +188,8 @@ export class PrivateZonesImpl implements PrivateZones {
     parameters: PrivateZone,
     options?: PrivateZonesCreateOrUpdateOptionalParams
   ): Promise<
-    PollerLike<
-      PollOperationState<PrivateZonesCreateOrUpdateResponse>,
+    SimplePollerLike<
+      OperationState<PrivateZonesCreateOrUpdateResponse>,
       PrivateZonesCreateOrUpdateResponse
     >
   > {
@@ -195,7 +199,7 @@ export class PrivateZonesImpl implements PrivateZones {
     ): Promise<PrivateZonesCreateOrUpdateResponse> => {
       return this.client.sendOperationRequest(args, spec);
     };
-    const sendOperation = async (
+    const sendOperationFn = async (
       args: coreClient.OperationArguments,
       spec: coreClient.OperationSpec
     ) => {
@@ -228,13 +232,16 @@ export class PrivateZonesImpl implements PrivateZones {
       };
     };
 
-    const lro = new LroImpl(
-      sendOperation,
-      { resourceGroupName, privateZoneName, parameters, options },
-      createOrUpdateOperationSpec
-    );
-    const poller = new LroEngine(lro, {
-      resumeFrom: options?.resumeFrom,
+    const lro = createLroSpec({
+      sendOperationFn,
+      args: { resourceGroupName, privateZoneName, parameters, options },
+      spec: createOrUpdateOperationSpec
+    });
+    const poller = await createHttpPoller<
+      PrivateZonesCreateOrUpdateResponse,
+      OperationState<PrivateZonesCreateOrUpdateResponse>
+    >(lro, {
+      restoreFrom: options?.resumeFrom,
       intervalInMs: options?.updateIntervalInMs
     });
     await poller.poll();
@@ -277,8 +284,8 @@ export class PrivateZonesImpl implements PrivateZones {
     parameters: PrivateZone,
     options?: PrivateZonesUpdateOptionalParams
   ): Promise<
-    PollerLike<
-      PollOperationState<PrivateZonesUpdateResponse>,
+    SimplePollerLike<
+      OperationState<PrivateZonesUpdateResponse>,
       PrivateZonesUpdateResponse
     >
   > {
@@ -288,7 +295,7 @@ export class PrivateZonesImpl implements PrivateZones {
     ): Promise<PrivateZonesUpdateResponse> => {
       return this.client.sendOperationRequest(args, spec);
     };
-    const sendOperation = async (
+    const sendOperationFn = async (
       args: coreClient.OperationArguments,
       spec: coreClient.OperationSpec
     ) => {
@@ -321,13 +328,16 @@ export class PrivateZonesImpl implements PrivateZones {
       };
     };
 
-    const lro = new LroImpl(
-      sendOperation,
-      { resourceGroupName, privateZoneName, parameters, options },
-      updateOperationSpec
-    );
-    const poller = new LroEngine(lro, {
-      resumeFrom: options?.resumeFrom,
+    const lro = createLroSpec({
+      sendOperationFn,
+      args: { resourceGroupName, privateZoneName, parameters, options },
+      spec: updateOperationSpec
+    });
+    const poller = await createHttpPoller<
+      PrivateZonesUpdateResponse,
+      OperationState<PrivateZonesUpdateResponse>
+    >(lro, {
+      restoreFrom: options?.resumeFrom,
       intervalInMs: options?.updateIntervalInMs
     });
     await poller.poll();
@@ -368,14 +378,14 @@ export class PrivateZonesImpl implements PrivateZones {
     resourceGroupName: string,
     privateZoneName: string,
     options?: PrivateZonesDeleteOptionalParams
-  ): Promise<PollerLike<PollOperationState<void>, void>> {
+  ): Promise<SimplePollerLike<OperationState<void>, void>> {
     const directSendOperation = async (
       args: coreClient.OperationArguments,
       spec: coreClient.OperationSpec
     ): Promise<void> => {
       return this.client.sendOperationRequest(args, spec);
     };
-    const sendOperation = async (
+    const sendOperationFn = async (
       args: coreClient.OperationArguments,
       spec: coreClient.OperationSpec
     ) => {
@@ -408,13 +418,13 @@ export class PrivateZonesImpl implements PrivateZones {
       };
     };
 
-    const lro = new LroImpl(
-      sendOperation,
-      { resourceGroupName, privateZoneName, options },
-      deleteOperationSpec
-    );
-    const poller = new LroEngine(lro, {
-      resumeFrom: options?.resumeFrom,
+    const lro = createLroSpec({
+      sendOperationFn,
+      args: { resourceGroupName, privateZoneName, options },
+      spec: deleteOperationSpec
+    });
+    const poller = await createHttpPoller<void, OperationState<void>>(lro, {
+      restoreFrom: options?.resumeFrom,
       intervalInMs: options?.updateIntervalInMs
     });
     await poller.poll();
@@ -689,7 +699,6 @@ const listNextOperationSpec: coreClient.OperationSpec = {
       bodyMapper: Mappers.CloudError
     }
   },
-  queryParameters: [Parameters.apiVersion, Parameters.top],
   urlParameters: [
     Parameters.$host,
     Parameters.subscriptionId,
@@ -709,7 +718,6 @@ const listByResourceGroupNextOperationSpec: coreClient.OperationSpec = {
       bodyMapper: Mappers.CloudError
     }
   },
-  queryParameters: [Parameters.apiVersion, Parameters.top],
   urlParameters: [
     Parameters.$host,
     Parameters.resourceGroupName,

package/src/operations/recordSets.ts

@@ -589,11 +589,6 @@ const listByTypeNextOperationSpec: coreClient.OperationSpec = {
       bodyMapper: Mappers.CloudError
     }
   },
-  queryParameters: [
-    Parameters.apiVersion,
-    Parameters.top,
-    Parameters.recordsetnamesuffix
-  ],
   urlParameters: [
     Parameters.$host,
     Parameters.resourceGroupName,
@@ -616,11 +611,6 @@ const listNextOperationSpec: coreClient.OperationSpec = {
       bodyMapper: Mappers.CloudError
     }
   },
-  queryParameters: [
-    Parameters.apiVersion,
-    Parameters.top,
-    Parameters.recordsetnamesuffix
-  ],
   urlParameters: [
     Parameters.$host,
     Parameters.resourceGroupName,

package/src/operations/virtualNetworkLinks.ts

@@ -13,8 +13,12 @@ import * as coreClient from "@azure/core-client";
 import * as Mappers from "../models/mappers";
 import * as Parameters from "../models/parameters";
 import { PrivateDnsManagementClient } from "../privateDnsManagementClient";
-import { PollerLike, PollOperationState, LroEngine } from "@azure/core-lro";
-import { LroImpl } from "../lroImpl";
+import {
+  SimplePollerLike,
+  OperationState,
+  createHttpPoller
+} from "@azure/core-lro";
+import { createLroSpec } from "../lroImpl";
 import {
   VirtualNetworkLink,
   VirtualNetworkLinksListNextOptionalParams,
@@ -138,8 +142,8 @@ export class VirtualNetworkLinksImpl implements VirtualNetworkLinks {
     parameters: VirtualNetworkLink,
     options?: VirtualNetworkLinksCreateOrUpdateOptionalParams
   ): Promise<
-    PollerLike<
-      PollOperationState<VirtualNetworkLinksCreateOrUpdateResponse>,
+    SimplePollerLike<
+      OperationState<VirtualNetworkLinksCreateOrUpdateResponse>,
       VirtualNetworkLinksCreateOrUpdateResponse
     >
   > {
@@ -149,7 +153,7 @@ export class VirtualNetworkLinksImpl implements VirtualNetworkLinks {
     ): Promise<VirtualNetworkLinksCreateOrUpdateResponse> => {
       return this.client.sendOperationRequest(args, spec);
     };
-    const sendOperation = async (
+    const sendOperationFn = async (
       args: coreClient.OperationArguments,
       spec: coreClient.OperationSpec
     ) => {
@@ -182,19 +186,22 @@ export class VirtualNetworkLinksImpl implements VirtualNetworkLinks {
       };
     };
 
-    const lro = new LroImpl(
-      sendOperation,
-      {
+    const lro = createLroSpec({
+      sendOperationFn,
+      args: {
         resourceGroupName,
         privateZoneName,
         virtualNetworkLinkName,
         parameters,
         options
       },
-      createOrUpdateOperationSpec
-    );
-    const poller = new LroEngine(lro, {
-      resumeFrom: options?.resumeFrom,
+      spec: createOrUpdateOperationSpec
+    });
+    const poller = await createHttpPoller<
+      VirtualNetworkLinksCreateOrUpdateResponse,
+      OperationState<VirtualNetworkLinksCreateOrUpdateResponse>
+    >(lro, {
+      restoreFrom: options?.resumeFrom,
       intervalInMs: options?.updateIntervalInMs
     });
     await poller.poll();
@@ -241,8 +248,8 @@ export class VirtualNetworkLinksImpl implements VirtualNetworkLinks {
     parameters: VirtualNetworkLink,
     options?: VirtualNetworkLinksUpdateOptionalParams
   ): Promise<
-    PollerLike<
-      PollOperationState<VirtualNetworkLinksUpdateResponse>,
+    SimplePollerLike<
+      OperationState<VirtualNetworkLinksUpdateResponse>,
       VirtualNetworkLinksUpdateResponse
     >
   > {
@@ -252,7 +259,7 @@ export class VirtualNetworkLinksImpl implements VirtualNetworkLinks {
     ): Promise<VirtualNetworkLinksUpdateResponse> => {
       return this.client.sendOperationRequest(args, spec);
     };
-    const sendOperation = async (
+    const sendOperationFn = async (
       args: coreClient.OperationArguments,
       spec: coreClient.OperationSpec
     ) => {
@@ -285,19 +292,22 @@ export class VirtualNetworkLinksImpl implements VirtualNetworkLinks {
       };
     };
 
-    const lro = new LroImpl(
-      sendOperation,
-      {
+    const lro = createLroSpec({
+      sendOperationFn,
+      args: {
         resourceGroupName,
         privateZoneName,
         virtualNetworkLinkName,
         parameters,
         options
       },
-      updateOperationSpec
-    );
-    const poller = new LroEngine(lro, {
-      resumeFrom: options?.resumeFrom,
+      spec: updateOperationSpec
+    });
+    const poller = await createHttpPoller<
+      VirtualNetworkLinksUpdateResponse,
+      OperationState<VirtualNetworkLinksUpdateResponse>
+    >(lro, {
+      restoreFrom: options?.resumeFrom,
       intervalInMs: options?.updateIntervalInMs
     });
     await poller.poll();
@@ -343,14 +353,14 @@ export class VirtualNetworkLinksImpl implements VirtualNetworkLinks {
     privateZoneName: string,
     virtualNetworkLinkName: string,
     options?: VirtualNetworkLinksDeleteOptionalParams
-  ): Promise<PollerLike<PollOperationState<void>, void>> {
+  ): Promise<SimplePollerLike<OperationState<void>, void>> {
     const directSendOperation = async (
       args: coreClient.OperationArguments,
       spec: coreClient.OperationSpec
     ): Promise<void> => {
       return this.client.sendOperationRequest(args, spec);
     };
-    const sendOperation = async (
+    const sendOperationFn = async (
       args: coreClient.OperationArguments,
       spec: coreClient.OperationSpec
     ) => {
@@ -383,13 +393,18 @@ export class VirtualNetworkLinksImpl implements VirtualNetworkLinks {
       };
     };
 
-    const lro = new LroImpl(
-      sendOperation,
-      { resourceGroupName, privateZoneName, virtualNetworkLinkName, options },
-      deleteOperationSpec
-    );
-    const poller = new LroEngine(lro, {
-      resumeFrom: options?.resumeFrom,
+    const lro = createLroSpec({
+      sendOperationFn,
+      args: {
+        resourceGroupName,
+        privateZoneName,
+        virtualNetworkLinkName,
+        options
+      },
+      spec: deleteOperationSpec
+    });
+    const poller = await createHttpPoller<void, OperationState<void>>(lro, {
+      restoreFrom: options?.resumeFrom,
       intervalInMs: options?.updateIntervalInMs
     });
     await poller.poll();
@@ -635,7 +650,6 @@ const listNextOperationSpec: coreClient.OperationSpec = {
       bodyMapper: Mappers.CloudError
     }
   },
-  queryParameters: [Parameters.apiVersion, Parameters.top],
   urlParameters: [
     Parameters.$host,
     Parameters.resourceGroupName,

package/src/operationsInterfaces/privateZones.ts

@@ -7,7 +7,7 @@
  */
 
 import { PagedAsyncIterableIterator } from "@azure/core-paging";
-import { PollerLike, PollOperationState } from "@azure/core-lro";
+import { SimplePollerLike, OperationState } from "@azure/core-lro";
 import {
   PrivateZone,
   PrivateZonesListOptionalParams,
@@ -54,8 +54,8 @@ export interface PrivateZones {
     parameters: PrivateZone,
     options?: PrivateZonesCreateOrUpdateOptionalParams
   ): Promise<
-    PollerLike<
-      PollOperationState<PrivateZonesCreateOrUpdateResponse>,
+    SimplePollerLike<
+      OperationState<PrivateZonesCreateOrUpdateResponse>,
       PrivateZonesCreateOrUpdateResponse
     >
   >;
@@ -86,8 +86,8 @@ export interface PrivateZones {
     parameters: PrivateZone,
     options?: PrivateZonesUpdateOptionalParams
   ): Promise<
-    PollerLike<
-      PollOperationState<PrivateZonesUpdateResponse>,
+    SimplePollerLike<
+      OperationState<PrivateZonesUpdateResponse>,
       PrivateZonesUpdateResponse
     >
   >;
@@ -116,7 +116,7 @@ export interface PrivateZones {
     resourceGroupName: string,
     privateZoneName: string,
     options?: PrivateZonesDeleteOptionalParams
-  ): Promise<PollerLike<PollOperationState<void>, void>>;
+  ): Promise<SimplePollerLike<OperationState<void>, void>>;
   /**
    * Deletes a Private DNS zone. WARNING: All DNS records in the zone will also be deleted. This
    * operation cannot be undone. Private DNS zone cannot be deleted unless all virtual network links to

package/src/operationsInterfaces/virtualNetworkLinks.ts

@@ -7,7 +7,7 @@
  */
 
 import { PagedAsyncIterableIterator } from "@azure/core-paging";
-import { PollerLike, PollOperationState } from "@azure/core-lro";
+import { SimplePollerLike, OperationState } from "@azure/core-lro";
 import {
   VirtualNetworkLink,
   VirtualNetworkLinksListOptionalParams,
@@ -49,8 +49,8 @@ export interface VirtualNetworkLinks {
     parameters: VirtualNetworkLink,
     options?: VirtualNetworkLinksCreateOrUpdateOptionalParams
   ): Promise<
-    PollerLike<
-      PollOperationState<VirtualNetworkLinksCreateOrUpdateResponse>,
+    SimplePollerLike<
+      OperationState<VirtualNetworkLinksCreateOrUpdateResponse>,
       VirtualNetworkLinksCreateOrUpdateResponse
     >
   >;
@@ -84,8 +84,8 @@ export interface VirtualNetworkLinks {
     parameters: VirtualNetworkLink,
     options?: VirtualNetworkLinksUpdateOptionalParams
   ): Promise<
-    PollerLike<
-      PollOperationState<VirtualNetworkLinksUpdateResponse>,
+    SimplePollerLike<
+      OperationState<VirtualNetworkLinksUpdateResponse>,
       VirtualNetworkLinksUpdateResponse
     >
   >;
@@ -118,7 +118,7 @@ export interface VirtualNetworkLinks {
     privateZoneName: string,
     virtualNetworkLinkName: string,
     options?: VirtualNetworkLinksDeleteOptionalParams
-  ): Promise<PollerLike<PollOperationState<void>, void>>;
+  ): Promise<SimplePollerLike<OperationState<void>, void>>;
   /**
    * Deletes a virtual network link to the specified Private DNS zone. WARNING: In case of a registration
    * virtual network, all auto-registered DNS records in the zone for the virtual network will also be

package/src/pagingHelper.ts

@@ -13,11 +13,11 @@ export interface PageInfo {
 const pageMap = new WeakMap<object, PageInfo>();
 
 /**
- * Given a result page from a pageable operation, returns a
- * continuation token that can be used to begin paging from
+ * Given the last `.value` produced by the `byPage` iterator,
+ * returns a continuation token that can be used to begin paging from
  * that point later.
- * @param page A result object from calling .byPage() on a paged operation.
- * @returns The continuation token that can be passed into byPage().
+ * @param page An object from accessing `value` on the IteratorResult from a `byPage` iterator.
+ * @returns The continuation token that can be passed into byPage() during future calls.
  */
 export function getContinuationToken(page: unknown): string | undefined {
   if (typeof page !== "object" || page === null) {

package/src/privateDnsManagementClient.ts

@@ -59,7 +59,7 @@ export class PrivateDnsManagementClient extends coreClient.ServiceClient {
       credential: credentials
     };
 
-    const packageDetails = `azsdk-js-arm-privatedns/3.1.1`;
+    const packageDetails = `azsdk-js-arm-privatedns/3.2.0`;
     const userAgentPrefix =
       options.userAgentOptions && options.userAgentOptions.userAgentPrefix
         ? `${options.userAgentOptions.userAgentPrefix} ${packageDetails}`