@azure/arm-privatedns 3.0.1 → 3.1.0

package/dist-esm/test/sampleTest.js

@@ -6,24 +6,22 @@
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.
  */
 import { __awaiter } from "tslib";
-import { record } from "@azure-tools/test-recorder";
-const recorderEnvSetup = {
-    replaceableVariables: {
-        AZURE_CLIENT_ID: "azure_client_id",
-        AZURE_CLIENT_SECRET: "azure_client_secret",
-        AZURE_TENANT_ID: "88888888-8888-8888-8888-888888888888",
-        SUBSCRIPTION_ID: "azure_subscription_id"
-    },
-    customizationsOnRecordings: [
-        (recording) => recording.replace(/"access_token":"[^"]*"/g, `"access_token":"access_token"`)
-    ],
-    queryParametersToSkip: []
+import { Recorder } from "@azure-tools/test-recorder";
+const replaceableVariables = {
+    AZURE_CLIENT_ID: "azure_client_id",
+    AZURE_CLIENT_SECRET: "azure_client_secret",
+    AZURE_TENANT_ID: "88888888-8888-8888-8888-888888888888",
+    SUBSCRIPTION_ID: "azure_subscription_id"
+};
+const recorderOptions = {
+    envSetupForPlayback: replaceableVariables
 };
 describe("My test", () => {
     let recorder;
     beforeEach(function () {
         return __awaiter(this, void 0, void 0, function* () {
-            recorder = record(this, recorderEnvSetup);
+            recorder = new Recorder(this.currentTest);
+            yield recorder.start(recorderOptions);
         });
     });
     afterEach(function () {

package/dist-esm/test/sampleTest.js.map

@@ -1 +1 @@
-{"version":3,"file":"sampleTest.js","sourceRoot":"","sources":["../../test/sampleTest.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;;AAEH,OAAO,EAEL,MAAM,EAGP,MAAM,4BAA4B,CAAC;AAGpC,MAAM,gBAAgB,GAA6B;IACjD,oBAAoB,EAAE;QACpB,eAAe,EAAE,iBAAiB;QAClC,mBAAmB,EAAE,qBAAqB;QAC1C,eAAe,EAAE,sCAAsC;QACvD,eAAe,EAAE,uBAAuB;KACzC;IACD,0BAA0B,EAAE;QAC1B,CAAC,SAAc,EAAO,EAAE,CACtB,SAAS,CAAC,OAAO,CACf,yBAAyB,EACzB,+BAA+B,CAChC;KACJ;IACD,qBAAqB,EAAE,EAAE;CAC1B,CAAC;AAEF,QAAQ,CAAC,SAAS,EAAE,GAAG,EAAE;IACvB,IAAI,QAAkB,CAAC;IAEvB,UAAU,CAAC;;YACT,QAAQ,GAAG,MAAM,CAAC,IAAI,EAAE,gBAAgB,CAAC,CAAC;QAC5C,CAAC;KAAA,CAAC,CAAC;IAEH,SAAS,CAAC;;YACR,MAAM,QAAQ,CAAC,IAAI,EAAE,CAAC;QACxB,CAAC;KAAA,CAAC,CAAC;IAEH,EAAE,CAAC,aAAa,EAAE;;YAChB,OAAO,CAAC,GAAG,CAAC,iBAAiB,CAAC,CAAC;QACjC,CAAC;KAAA,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
+{"version":3,"file":"sampleTest.js","sourceRoot":"","sources":["../../test/sampleTest.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;;AAEH,OAAO,EACL,QAAQ,EAGT,MAAM,4BAA4B,CAAC;AAIpC,MAAM,oBAAoB,GAA2B;IACnD,eAAe,EAAE,iBAAiB;IAClC,mBAAmB,EAAE,qBAAqB;IAC1C,eAAe,EAAE,sCAAsC;IACvD,eAAe,EAAE,uBAAuB;CACzC,CAAC;AAEF,MAAM,eAAe,GAAyB;IAC5C,mBAAmB,EAAE,oBAAoB;CAC1C,CAAC;AAEF,QAAQ,CAAC,SAAS,EAAE,GAAG,EAAE;IACvB,IAAI,QAAkB,CAAC;IAEvB,UAAU,CAAC;;YACT,QAAQ,GAAG,IAAI,QAAQ,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;YAC1C,MAAM,QAAQ,CAAC,KAAK,CAAC,eAAe,CAAC,CAAC;QACxC,CAAC;KAAA,CAAC,CAAC;IAEH,SAAS,CAAC;;YACR,MAAM,QAAQ,CAAC,IAAI,EAAE,CAAC;QACxB,CAAC;KAAA,CAAC,CAAC;IAEH,EAAE,CAAC,aAAa,EAAE;;YAChB,OAAO,CAAC,GAAG,CAAC,iBAAiB,CAAC,CAAC;QACjC,CAAC;KAAA,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/package.json

@@ -3,15 +3,15 @@
   "sdk-type": "mgmt",
   "author": "Microsoft Corporation",
   "description": "A generated SDK for PrivateDnsManagementClient.",
-  "version": "3.0.1",
+  "version": "3.1.0",
   "engines": {
-    "node": ">=12.0.0"
+    "node": ">=14.0.0"
   },
   "dependencies": {
     "@azure/core-lro": "^2.2.0",
     "@azure/abort-controller": "^1.0.0",
     "@azure/core-paging": "^1.2.0",
-    "@azure/core-client": "^1.5.0",
+    "@azure/core-client": "^1.6.1",
     "@azure/core-auth": "^1.3.0",
     "@azure/core-rest-pipeline": "^1.8.0",
     "tslib": "^2.2.0"
@@ -28,7 +28,7 @@
   "module": "./dist-esm/src/index.js",
   "types": "./types/arm-privatedns.d.ts",
   "devDependencies": {
-    "@microsoft/api-extractor": "7.18.11",
+    "@microsoft/api-extractor": "^7.31.1",
     "@rollup/plugin-commonjs": "^21.0.1",
     "@rollup/plugin-json": "^4.1.0",
     "@rollup/plugin-multi-entry": "^4.1.0",
@@ -36,13 +36,18 @@
     "mkdirp": "^1.0.4",
     "rollup": "^2.66.1",
     "rollup-plugin-sourcemaps": "^0.6.3",
-    "typescript": "~4.2.0",
+    "typescript": "~4.8.0",
     "uglify-js": "^3.4.9",
     "rimraf": "^3.0.0",
     "@azure/identity": "^2.0.1",
-    "@azure-tools/test-recorder": "^1.0.0",
+    "@azure-tools/test-recorder": "^2.0.0",
+    "@azure-tools/test-credential": "^1.0.0",
     "mocha": "^7.1.1",
-    "cross-env": "^7.0.2"
+    "@types/chai": "^4.2.8",
+    "chai": "^4.2.0",
+    "cross-env": "^7.0.2",
+    "@types/node": "^14.0.0",
+    "@azure/dev-tool": "^1.0.0"
   },
   "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/privatedns/arm-privatedns",
   "repository": {
@@ -93,9 +98,8 @@
     "unit-test:node": "cross-env TEST_MODE=playback npm run integration-test:node",
     "unit-test:browser": "echo skipped",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",
-    "integration-test:node": "mocha -r esm --require ts-node/register --timeout 1200000 --full-trace test/*.ts --reporter ../../../common/tools/mocha-multi-reporter.js",
-    "integration-test:browser": "echo skipped",
-    "docs": "echo skipped"
+    "integration-test:node": "dev-tool run test:node-ts-input -- --timeout 1200000 'test/*.ts'",
+    "integration-test:browser": "echo skipped"
   },
   "sideEffects": false,
   "//metadata": {
@@ -115,4 +119,4 @@
     "disableDocsMs": true,
     "apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-privatedns?view=azure-node-preview"
   }
-}
+}

package/review/arm-privatedns.api.md

@@ -38,27 +38,22 @@ export interface CnameRecord {
     cname?: string;
 }
 
+// @public
+export function getContinuationToken(page: unknown): string | undefined;
+
 // @public
 export enum KnownProvisioningState {
-    // (undocumented)
     Canceled = "Canceled",
-    // (undocumented)
     Creating = "Creating",
-    // (undocumented)
     Deleting = "Deleting",
-    // (undocumented)
     Failed = "Failed",
-    // (undocumented)
     Succeeded = "Succeeded",
-    // (undocumented)
     Updating = "Updating"
 }
 
 // @public
 export enum KnownVirtualNetworkLinkState {
-    // (undocumented)
     Completed = "Completed",
-    // (undocumented)
     InProgress = "InProgress"
 }
 
@@ -93,17 +88,17 @@ export interface PrivateDnsManagementClientOptionalParams extends coreClient.Ser
 }
 
 // @public
-export type PrivateZone = TrackedResource & {
+export interface PrivateZone extends TrackedResource {
     etag?: string;
+    readonly internalId?: string;
     readonly maxNumberOfRecordSets?: number;
-    readonly numberOfRecordSets?: number;
     readonly maxNumberOfVirtualNetworkLinks?: number;
-    readonly numberOfVirtualNetworkLinks?: number;
     readonly maxNumberOfVirtualNetworkLinksWithRegistration?: number;
+    readonly numberOfRecordSets?: number;
+    readonly numberOfVirtualNetworkLinks?: number;
     readonly numberOfVirtualNetworkLinksWithRegistration?: number;
     readonly provisioningState?: ProvisioningState;
-    readonly internalId?: string;
-};
+}
 
 // @public
 export interface PrivateZoneListResult {
@@ -195,7 +190,8 @@ export type PrivateZonesUpdateResponse = PrivateZone;
 export type ProvisioningState = string;
 
 // @public
-export type ProxyResource = Resource & {};
+export interface ProxyResource extends Resource {
+}
 
 // @public
 export interface PtrRecord {
@@ -203,23 +199,23 @@ export interface PtrRecord {
 }
 
 // @public
-export type RecordSet = ProxyResource & {
+export interface RecordSet extends ProxyResource {
+    aaaaRecords?: AaaaRecord[];
+    aRecords?: ARecord[];
+    cnameRecord?: CnameRecord;
     etag?: string;
+    readonly fqdn?: string;
+    readonly isAutoRegistered?: boolean;
     metadata?: {
         [propertyName: string]: string;
     };
-    ttl?: number;
-    readonly fqdn?: string;
-    readonly isAutoRegistered?: boolean;
-    aRecords?: ARecord[];
-    aaaaRecords?: AaaaRecord[];
-    cnameRecord?: CnameRecord;
     mxRecords?: MxRecord[];
     ptrRecords?: PtrRecord[];
     soaRecord?: SoaRecord;
     srvRecords?: SrvRecord[];
+    ttl?: number;
     txtRecords?: TxtRecord[];
-};
+}
 
 // @public
 export interface RecordSetListResult {
@@ -337,12 +333,12 @@ export interface SubResource {
 }
 
 // @public
-export type TrackedResource = Resource & {
+export interface TrackedResource extends Resource {
+    location?: string;
     tags?: {
         [propertyName: string]: string;
     };
-    location?: string;
-};
+}
 
 // @public
 export interface TxtRecord {
@@ -350,13 +346,13 @@ export interface TxtRecord {
 }
 
 // @public
-export type VirtualNetworkLink = TrackedResource & {
+export interface VirtualNetworkLink extends TrackedResource {
     etag?: string;
-    virtualNetwork?: SubResource;
+    readonly provisioningState?: ProvisioningState;
     registrationEnabled?: boolean;
+    virtualNetwork?: SubResource;
     readonly virtualNetworkLinkState?: VirtualNetworkLinkState;
-    readonly provisioningState?: ProvisioningState;
-};
+}
 
 // @public
 export interface VirtualNetworkLinkListResult {

package/src/index.ts

@@ -7,6 +7,7 @@
  */
 
 /// <reference lib="esnext.asynciterable" />
+export { getContinuationToken } from "./pagingHelper";
 export * from "./models";
 export { PrivateDnsManagementClient } from "./privateDnsManagementClient";
 export * from "./operationsInterfaces";

package/src/models/index.ts

@@ -153,18 +153,18 @@ export interface RecordSetListResult {
 }
 
 /** The resource model definition for a ARM tracked top level resource */
-export type TrackedResource = Resource & {
+export interface TrackedResource extends Resource {
   /** Resource tags. */
   tags?: { [propertyName: string]: string };
   /** The Azure Region where the resource lives */
   location?: string;
-};
+}
 
 /** The resource model definition for an ARM proxy resource. */
-export type ProxyResource = Resource & {};
+export interface ProxyResource extends Resource {}
 
 /** Describes a Private DNS zone. */
-export type PrivateZone = TrackedResource & {
+export interface PrivateZone extends TrackedResource {
   /** The ETag of the zone. */
   etag?: string;
   /**
@@ -207,10 +207,10 @@ export type PrivateZone = TrackedResource & {
    * NOTE: This property will not be serialized. It can only be populated by the server.
    */
   readonly internalId?: string;
-};
+}
 
 /** Describes a link to virtual network for a Private DNS zone. */
-export type VirtualNetworkLink = TrackedResource & {
+export interface VirtualNetworkLink extends TrackedResource {
   /** The ETag of the virtual network link. */
   etag?: string;
   /** The reference of the virtual network. */
@@ -227,10 +227,10 @@ export type VirtualNetworkLink = TrackedResource & {
    * NOTE: This property will not be serialized. It can only be populated by the server.
    */
   readonly provisioningState?: ProvisioningState;
-};
+}
 
 /** Describes a DNS record set (a collection of DNS records with the same name and type) in a Private DNS zone. */
-export type RecordSet = ProxyResource & {
+export interface RecordSet extends ProxyResource {
   /** The ETag of the record set. */
   etag?: string;
   /** The metadata attached to the record set. */
@@ -263,15 +263,21 @@ export type RecordSet = ProxyResource & {
   srvRecords?: SrvRecord[];
   /** The list of TXT records in the record set. */
   txtRecords?: TxtRecord[];
-};
+}
 
 /** Known values of {@link ProvisioningState} that the service accepts. */
 export enum KnownProvisioningState {
+  /** Creating */
   Creating = "Creating",
+  /** Updating */
   Updating = "Updating",
+  /** Deleting */
   Deleting = "Deleting",
+  /** Succeeded */
   Succeeded = "Succeeded",
+  /** Failed */
   Failed = "Failed",
+  /** Canceled */
   Canceled = "Canceled"
 }
 
@@ -291,7 +297,9 @@ export type ProvisioningState = string;
 
 /** Known values of {@link VirtualNetworkLinkState} that the service accepts. */
 export enum KnownVirtualNetworkLinkState {
+  /** InProgress */
   InProgress = "InProgress",
+  /** Completed */
   Completed = "Completed"
 }
 

package/src/operations/privateZones.ts

@@ -6,7 +6,8 @@
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.
  */
 
-import { PagedAsyncIterableIterator } from "@azure/core-paging";
+import { PagedAsyncIterableIterator, PageSettings } from "@azure/core-paging";
+import { setContinuationToken } from "../pagingHelper";
 import { PrivateZones } from "../operationsInterfaces";
 import * as coreClient from "@azure/core-client";
 import * as Mappers from "../models/mappers";
@@ -18,8 +19,10 @@ import {
   PrivateZone,
   PrivateZonesListNextOptionalParams,
   PrivateZonesListOptionalParams,
+  PrivateZonesListResponse,
   PrivateZonesListByResourceGroupNextOptionalParams,
   PrivateZonesListByResourceGroupOptionalParams,
+  PrivateZonesListByResourceGroupResponse,
   PrivateZonesCreateOrUpdateOptionalParams,
   PrivateZonesCreateOrUpdateResponse,
   PrivateZonesUpdateOptionalParams,
@@ -27,8 +30,6 @@ import {
   PrivateZonesDeleteOptionalParams,
   PrivateZonesGetOptionalParams,
   PrivateZonesGetResponse,
-  PrivateZonesListResponse,
-  PrivateZonesListByResourceGroupResponse,
   PrivateZonesListNextResponse,
   PrivateZonesListByResourceGroupNextResponse
 } from "../models";
@@ -61,22 +62,34 @@ export class PrivateZonesImpl implements PrivateZones {
       [Symbol.asyncIterator]() {
         return this;
       },
-      byPage: () => {
-        return this.listPagingPage(options);
+      byPage: (settings?: PageSettings) => {
+        if (settings?.maxPageSize) {
+          throw new Error("maxPageSize is not supported by this operation.");
+        }
+        return this.listPagingPage(options, settings);
       }
     };
   }
 
   private async *listPagingPage(
-    options?: PrivateZonesListOptionalParams
+    options?: PrivateZonesListOptionalParams,
+    settings?: PageSettings
   ): AsyncIterableIterator<PrivateZone[]> {
-    let result = await this._list(options);
-    yield result.value || [];
-    let continuationToken = result.nextLink;
+    let result: PrivateZonesListResponse;
+    let continuationToken = settings?.continuationToken;
+    if (!continuationToken) {
+      result = await this._list(options);
+      let page = result.value || [];
+      continuationToken = result.nextLink;
+      setContinuationToken(page, continuationToken);
+      yield page;
+    }
     while (continuationToken) {
       result = await this._listNext(continuationToken, options);
       continuationToken = result.nextLink;
-      yield result.value || [];
+      let page = result.value || [];
+      setContinuationToken(page, continuationToken);
+      yield page;
     }
   }
 
@@ -105,19 +118,33 @@ export class PrivateZonesImpl implements PrivateZones {
       [Symbol.asyncIterator]() {
         return this;
       },
-      byPage: () => {
-        return this.listByResourceGroupPagingPage(resourceGroupName, options);
+      byPage: (settings?: PageSettings) => {
+        if (settings?.maxPageSize) {
+          throw new Error("maxPageSize is not supported by this operation.");
+        }
+        return this.listByResourceGroupPagingPage(
+          resourceGroupName,
+          options,
+          settings
+        );
       }
     };
   }
 
   private async *listByResourceGroupPagingPage(
     resourceGroupName: string,
-    options?: PrivateZonesListByResourceGroupOptionalParams
+    options?: PrivateZonesListByResourceGroupOptionalParams,
+    settings?: PageSettings
   ): AsyncIterableIterator<PrivateZone[]> {
-    let result = await this._listByResourceGroup(resourceGroupName, options);
-    yield result.value || [];
-    let continuationToken = result.nextLink;
+    let result: PrivateZonesListByResourceGroupResponse;
+    let continuationToken = settings?.continuationToken;
+    if (!continuationToken) {
+      result = await this._listByResourceGroup(resourceGroupName, options);
+      let page = result.value || [];
+      continuationToken = result.nextLink;
+      setContinuationToken(page, continuationToken);
+      yield page;
+    }
     while (continuationToken) {
       result = await this._listByResourceGroupNext(
         resourceGroupName,
@@ -125,7 +152,9 @@ export class PrivateZonesImpl implements PrivateZones {
         options
       );
       continuationToken = result.nextLink;
-      yield result.value || [];
+      let page = result.value || [];
+      setContinuationToken(page, continuationToken);
+      yield page;
     }
   }
 

package/src/operations/recordSets.ts

@@ -6,7 +6,8 @@
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.
  */
 
-import { PagedAsyncIterableIterator } from "@azure/core-paging";
+import { PagedAsyncIterableIterator, PageSettings } from "@azure/core-paging";
+import { setContinuationToken } from "../pagingHelper";
 import { RecordSets } from "../operationsInterfaces";
 import * as coreClient from "@azure/core-client";
 import * as Mappers from "../models/mappers";
@@ -17,8 +18,10 @@ import {
   RecordType,
   RecordSetsListByTypeNextOptionalParams,
   RecordSetsListByTypeOptionalParams,
+  RecordSetsListByTypeResponse,
   RecordSetsListNextOptionalParams,
   RecordSetsListOptionalParams,
+  RecordSetsListResponse,
   RecordSetsCreateOrUpdateOptionalParams,
   RecordSetsCreateOrUpdateResponse,
   RecordSetsUpdateOptionalParams,
@@ -26,8 +29,6 @@ import {
   RecordSetsDeleteOptionalParams,
   RecordSetsGetOptionalParams,
   RecordSetsGetResponse,
-  RecordSetsListByTypeResponse,
-  RecordSetsListResponse,
   RecordSetsListByTypeNextResponse,
   RecordSetsListNextResponse
 } from "../models";
@@ -71,12 +72,16 @@ export class RecordSetsImpl implements RecordSets {
       [Symbol.asyncIterator]() {
         return this;
       },
-      byPage: () => {
+      byPage: (settings?: PageSettings) => {
+        if (settings?.maxPageSize) {
+          throw new Error("maxPageSize is not supported by this operation.");
+        }
         return this.listByTypePagingPage(
           resourceGroupName,
           privateZoneName,
           recordType,
-          options
+          options,
+          settings
         );
       }
     };
@@ -86,16 +91,23 @@ export class RecordSetsImpl implements RecordSets {
     resourceGroupName: string,
     privateZoneName: string,
     recordType: RecordType,
-    options?: RecordSetsListByTypeOptionalParams
+    options?: RecordSetsListByTypeOptionalParams,
+    settings?: PageSettings
   ): AsyncIterableIterator<RecordSet[]> {
-    let result = await this._listByType(
-      resourceGroupName,
-      privateZoneName,
-      recordType,
-      options
-    );
-    yield result.value || [];
-    let continuationToken = result.nextLink;
+    let result: RecordSetsListByTypeResponse;
+    let continuationToken = settings?.continuationToken;
+    if (!continuationToken) {
+      result = await this._listByType(
+        resourceGroupName,
+        privateZoneName,
+        recordType,
+        options
+      );
+      let page = result.value || [];
+      continuationToken = result.nextLink;
+      setContinuationToken(page, continuationToken);
+      yield page;
+    }
     while (continuationToken) {
       result = await this._listByTypeNext(
         resourceGroupName,
@@ -105,7 +117,9 @@ export class RecordSetsImpl implements RecordSets {
         options
       );
       continuationToken = result.nextLink;
-      yield result.value || [];
+      let page = result.value || [];
+      setContinuationToken(page, continuationToken);
+      yield page;
     }
   }
 
@@ -148,8 +162,16 @@ export class RecordSetsImpl implements RecordSets {
       [Symbol.asyncIterator]() {
         return this;
       },
-      byPage: () => {
-        return this.listPagingPage(resourceGroupName, privateZoneName, options);
+      byPage: (settings?: PageSettings) => {
+        if (settings?.maxPageSize) {
+          throw new Error("maxPageSize is not supported by this operation.");
+        }
+        return this.listPagingPage(
+          resourceGroupName,
+          privateZoneName,
+          options,
+          settings
+        );
       }
     };
   }
@@ -157,11 +179,18 @@ export class RecordSetsImpl implements RecordSets {
   private async *listPagingPage(
     resourceGroupName: string,
     privateZoneName: string,
-    options?: RecordSetsListOptionalParams
+    options?: RecordSetsListOptionalParams,
+    settings?: PageSettings
   ): AsyncIterableIterator<RecordSet[]> {
-    let result = await this._list(resourceGroupName, privateZoneName, options);
-    yield result.value || [];
-    let continuationToken = result.nextLink;
+    let result: RecordSetsListResponse;
+    let continuationToken = settings?.continuationToken;
+    if (!continuationToken) {
+      result = await this._list(resourceGroupName, privateZoneName, options);
+      let page = result.value || [];
+      continuationToken = result.nextLink;
+      setContinuationToken(page, continuationToken);
+      yield page;
+    }
     while (continuationToken) {
       result = await this._listNext(
         resourceGroupName,
@@ -170,7 +199,9 @@ export class RecordSetsImpl implements RecordSets {
         options
       );
       continuationToken = result.nextLink;
-      yield result.value || [];
+      let page = result.value || [];
+      setContinuationToken(page, continuationToken);
+      yield page;
     }
   }
 

package/src/operations/virtualNetworkLinks.ts

@@ -6,7 +6,8 @@
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.
  */
 
-import { PagedAsyncIterableIterator } from "@azure/core-paging";
+import { PagedAsyncIterableIterator, PageSettings } from "@azure/core-paging";
+import { setContinuationToken } from "../pagingHelper";
 import { VirtualNetworkLinks } from "../operationsInterfaces";
 import * as coreClient from "@azure/core-client";
 import * as Mappers from "../models/mappers";
@@ -18,6 +19,7 @@ import {
   VirtualNetworkLink,
   VirtualNetworkLinksListNextOptionalParams,
   VirtualNetworkLinksListOptionalParams,
+  VirtualNetworkLinksListResponse,
   VirtualNetworkLinksCreateOrUpdateOptionalParams,
   VirtualNetworkLinksCreateOrUpdateResponse,
   VirtualNetworkLinksUpdateOptionalParams,
@@ -25,7 +27,6 @@ import {
   VirtualNetworkLinksDeleteOptionalParams,
   VirtualNetworkLinksGetOptionalParams,
   VirtualNetworkLinksGetResponse,
-  VirtualNetworkLinksListResponse,
   VirtualNetworkLinksListNextResponse
 } from "../models";
 
@@ -65,8 +66,16 @@ export class VirtualNetworkLinksImpl implements VirtualNetworkLinks {
       [Symbol.asyncIterator]() {
         return this;
       },
-      byPage: () => {
-        return this.listPagingPage(resourceGroupName, privateZoneName, options);
+      byPage: (settings?: PageSettings) => {
+        if (settings?.maxPageSize) {
+          throw new Error("maxPageSize is not supported by this operation.");
+        }
+        return this.listPagingPage(
+          resourceGroupName,
+          privateZoneName,
+          options,
+          settings
+        );
       }
     };
   }
@@ -74,11 +83,18 @@ export class VirtualNetworkLinksImpl implements VirtualNetworkLinks {
   private async *listPagingPage(
     resourceGroupName: string,
     privateZoneName: string,
-    options?: VirtualNetworkLinksListOptionalParams
+    options?: VirtualNetworkLinksListOptionalParams,
+    settings?: PageSettings
   ): AsyncIterableIterator<VirtualNetworkLink[]> {
-    let result = await this._list(resourceGroupName, privateZoneName, options);
-    yield result.value || [];
-    let continuationToken = result.nextLink;
+    let result: VirtualNetworkLinksListResponse;
+    let continuationToken = settings?.continuationToken;
+    if (!continuationToken) {
+      result = await this._list(resourceGroupName, privateZoneName, options);
+      let page = result.value || [];
+      continuationToken = result.nextLink;
+      setContinuationToken(page, continuationToken);
+      yield page;
+    }
     while (continuationToken) {
       result = await this._listNext(
         resourceGroupName,
@@ -87,7 +103,9 @@ export class VirtualNetworkLinksImpl implements VirtualNetworkLinks {
         options
       );
       continuationToken = result.nextLink;
-      yield result.value || [];
+      let page = result.value || [];
+      setContinuationToken(page, continuationToken);
+      yield page;
     }
   }