@azure/arm-operations 4.0.0-beta.2 → 4.0.0-beta.3

package/package.json

@@ -3,31 +3,39 @@
   "sdk-type": "mgmt",
   "author": "Microsoft Corporation",
   "description": "A generated SDK for OperationsManagementClient.",
-  "version": "4.0.0-beta.2",
-  "engines": { "node": ">=12.0.0" },
+  "version": "4.0.0-beta.3",
+  "engines": {
+    "node": ">=12.0.0"
+  },
   "dependencies": {
     "@azure/core-lro": "^2.2.0",
     "@azure/abort-controller": "^1.0.0",
     "@azure/core-paging": "^1.2.0",
-    "@azure/core-client": "^1.0.0",
+    "@azure/core-client": "^1.5.0",
     "@azure/core-auth": "^1.3.0",
-    "@azure/core-rest-pipeline": "^1.1.0",
+    "@azure/core-rest-pipeline": "^1.8.0",
     "tslib": "^2.2.0"
   },
-  "keywords": ["node", "azure", "typescript", "browser", "isomorphic"],
+  "keywords": [
+    "node",
+    "azure",
+    "typescript",
+    "browser",
+    "isomorphic"
+  ],
   "license": "MIT",
   "main": "./dist/index.js",
   "module": "./dist-esm/src/index.js",
   "types": "./types/arm-operations.d.ts",
   "devDependencies": {
-    "@microsoft/api-extractor": "^7.18.11",
-    "@rollup/plugin-commonjs": "11.0.2",
-    "@rollup/plugin-json": "^4.0.0",
-    "@rollup/plugin-multi-entry": "^3.0.0",
-    "@rollup/plugin-node-resolve": "^8.0.0",
+    "@microsoft/api-extractor": "7.18.11",
+    "@rollup/plugin-commonjs": "^21.0.1",
+    "@rollup/plugin-json": "^4.1.0",
+    "@rollup/plugin-multi-entry": "^4.1.0",
+    "@rollup/plugin-node-resolve": "^13.1.3",
     "mkdirp": "^1.0.4",
-    "rollup": "^1.16.3",
-    "rollup-plugin-sourcemaps": "^0.4.2",
+    "rollup": "^2.66.1",
+    "rollup-plugin-sourcemaps": "^0.6.3",
     "typescript": "~4.2.0",
     "uglify-js": "^3.4.9",
     "rimraf": "^3.0.0",
@@ -41,7 +49,9 @@
     "type": "git",
     "url": "https://github.com/Azure/azure-sdk-for-js.git"
   },
-  "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" },
+  "bugs": {
+    "url": "https://github.com/Azure/azure-sdk-for-js/issues"
+  },
   "files": [
     "dist/**/*.js",
     "dist/**/*.js.map",
@@ -88,5 +98,21 @@
     "docs": "echo skipped"
   },
   "sideEffects": false,
-  "autoPublish": true
+  "//metadata": {
+    "constantPaths": [
+      {
+        "path": "src/operationsManagementClient.ts",
+        "prefix": "packageDetails"
+      }
+    ]
+  },
+  "autoPublish": true,
+  "//sampleConfiguration": {
+    "productName": "",
+    "productSlugs": [
+      "azure"
+    ],
+    "disableDocsMs": true,
+    "apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-operations?view=azure-node-preview"
+  }
 }

package/review/arm-operations.api.md

@@ -48,9 +48,9 @@ export interface ManagementAssociationPropertiesList {
 
 // @public
 export interface ManagementAssociations {
-    createOrUpdate(resourceGroupName: string, managementAssociationName: string, parameters: ManagementAssociation, options?: ManagementAssociationsCreateOrUpdateOptionalParams): Promise<ManagementAssociationsCreateOrUpdateResponse>;
-    delete(resourceGroupName: string, managementAssociationName: string, options?: ManagementAssociationsDeleteOptionalParams): Promise<void>;
-    get(resourceGroupName: string, managementAssociationName: string, options?: ManagementAssociationsGetOptionalParams): Promise<ManagementAssociationsGetResponse>;
+    createOrUpdate(resourceGroupName: string, providerName: string, resourceType: string, resourceName: string, managementAssociationName: string, parameters: ManagementAssociation, options?: ManagementAssociationsCreateOrUpdateOptionalParams): Promise<ManagementAssociationsCreateOrUpdateResponse>;
+    delete(resourceGroupName: string, providerName: string, resourceType: string, resourceName: string, managementAssociationName: string, options?: ManagementAssociationsDeleteOptionalParams): Promise<void>;
+    get(resourceGroupName: string, providerName: string, resourceType: string, resourceName: string, managementAssociationName: string, options?: ManagementAssociationsGetOptionalParams): Promise<ManagementAssociationsGetResponse>;
     listBySubscription(options?: ManagementAssociationsListBySubscriptionOptionalParams): Promise<ManagementAssociationsListBySubscriptionResponse>;
 }
 
@@ -169,7 +169,7 @@ export type OperationsListResponse = OperationListResult;
 export class OperationsManagementClient extends coreClient.ServiceClient {
     // (undocumented)
     $host: string;
-    constructor(credentials: coreAuth.TokenCredential, subscriptionId: string, providerName: string, resourceType: string, resourceName: string, options?: OperationsManagementClientOptionalParams);
+    constructor(credentials: coreAuth.TokenCredential, subscriptionId: string, options?: OperationsManagementClientOptionalParams);
     // (undocumented)
     apiVersion: string;
     // (undocumented)
@@ -179,12 +179,6 @@ export class OperationsManagementClient extends coreClient.ServiceClient {
     // (undocumented)
     operations: Operations;
     // (undocumented)
-    providerName: string;
-    // (undocumented)
-    resourceName: string;
-    // (undocumented)
-    resourceType: string;
-    // (undocumented)
     solutions: Solutions;
     // (undocumented)
     subscriptionId: string;

package/rollup.config.js

@@ -14,62 +14,14 @@ import json from "@rollup/plugin-json";
 
 import nodeBuiltins from "builtin-modules";
 
-/**
- * Gets the proper configuration needed for rollup's commonJS plugin for @opentelemetry/api.
- *
- * NOTE: this manual configuration is only needed because OpenTelemetry uses an
- * __exportStar downleveled helper function to declare its exports which confuses
- * rollup's automatic discovery mechanism.
- *
- * @returns an object reference that can be `...`'d into your cjs() configuration.
- */
-export function openTelemetryCommonJs() {
-  const namedExports = {};
-
-  for (const key of [
-    "@opentelemetry/api",
-    "@azure/core-tracing/node_modules/@opentelemetry/api"
-  ]) {
-    namedExports[key] = [
-      "SpanKind",
-      "TraceFlags",
-      "getSpan",
-      "setSpan",
-      "SpanStatusCode",
-      "getSpanContext",
-      "setSpanContext"
-    ];
-  }
-
-  const releasedOpenTelemetryVersions = ["0.10.2", "1.0.0-rc.0"];
-
-  for (const version of releasedOpenTelemetryVersions) {
-    namedExports[
-      // working around a limitation in the rollup common.js plugin - it's not able to resolve these modules so the named exports listed above will not get applied. We have to drill down to the actual path.
-      `../../../common/temp/node_modules/.pnpm/@opentelemetry/api@${version}/node_modules/@opentelemetry/api/build/src/index.js`
-    ] = [
-      "SpanKind",
-      "TraceFlags",
-      "getSpan",
-      "setSpan",
-      "StatusCode",
-      "CanonicalCode",
-      "getSpanContext",
-      "setSpanContext"
-    ];
-  }
-
-  return namedExports;
-}
-
 // #region Warning Handler
 
 /**
- * A function that can determine whether a rollupwarning should be ignored. If
+ * A function that can determine whether a rollup warning should be ignored. If
  * the function returns `true`, then the warning will not be displayed.
  */
 
-function ignoreNiseSinonEvalWarnings(warning) {
+function ignoreNiseSinonEval(warning) {
   return (
     warning.code === "EVAL" &&
     warning.id &&
@@ -78,17 +30,14 @@ function ignoreNiseSinonEvalWarnings(warning) {
   );
 }
 
-function ignoreChaiCircularDependencyWarnings(warning) {
+function ignoreChaiCircularDependency(warning) {
   return (
     warning.code === "CIRCULAR_DEPENDENCY" &&
     warning.importer && warning.importer.includes("node_modules/chai") === true
   );
 }
 
-const warningInhibitors = [
-  ignoreChaiCircularDependencyWarnings,
-  ignoreNiseSinonEvalWarnings
-];
+const warningInhibitors = [ignoreChaiCircularDependency, ignoreNiseSinonEval];
 
 /**
  * Construct a warning handler for the shared rollup configuration
@@ -122,22 +71,7 @@ function makeBrowserTestConfig() {
       nodeResolve({
         mainFields: ["module", "browser"]
       }),
-      cjs({
-        namedExports: {
-          // Chai's strange internal architecture makes it impossible to statically
-          // analyze its exports.
-          chai: [
-            "version",
-            "use",
-            "util",
-            "config",
-            "expect",
-            "should",
-            "assert"
-          ],
-          ...openTelemetryCommonJs()
-        }
-      }),
+      cjs(),
       json(),
       sourcemaps()
       //viz({ filename: "dist-test/browser-stats.html", sourcemap: true })
@@ -173,7 +107,7 @@ export function makeConfig(pkg, options) {
     ],
     output: { file: "dist/index.js", format: "cjs", sourcemap: true },
     preserveSymlinks: false,
-    plugins: [sourcemaps(), nodeResolve(), cjs()]
+    plugins: [sourcemaps(), nodeResolve()]
   };
 
   const config = [baseConfig];

package/src/operations/managementAssociations.ts

@@ -50,18 +50,32 @@ export class ManagementAssociationsImpl implements ManagementAssociations {
   /**
    * Creates or updates the ManagementAssociation.
    * @param resourceGroupName The name of the resource group to get. The name is case insensitive.
+   * @param providerName Provider name for the parent resource.
+   * @param resourceType Resource type for the parent resource
+   * @param resourceName Parent resource name.
    * @param managementAssociationName User ManagementAssociation Name.
    * @param parameters The parameters required to create ManagementAssociation extension.
    * @param options The options parameters.
    */
   createOrUpdate(
     resourceGroupName: string,
+    providerName: string,
+    resourceType: string,
+    resourceName: string,
     managementAssociationName: string,
     parameters: ManagementAssociation,
     options?: ManagementAssociationsCreateOrUpdateOptionalParams
   ): Promise<ManagementAssociationsCreateOrUpdateResponse> {
     return this.client.sendOperationRequest(
-      { resourceGroupName, managementAssociationName, parameters, options },
+      {
+        resourceGroupName,
+        providerName,
+        resourceType,
+        resourceName,
+        managementAssociationName,
+        parameters,
+        options
+      },
       createOrUpdateOperationSpec
     );
   }
@@ -69,16 +83,29 @@ export class ManagementAssociationsImpl implements ManagementAssociations {
   /**
    * Deletes the ManagementAssociation in the subscription.
    * @param resourceGroupName The name of the resource group to get. The name is case insensitive.
+   * @param providerName Provider name for the parent resource.
+   * @param resourceType Resource type for the parent resource
+   * @param resourceName Parent resource name.
    * @param managementAssociationName User ManagementAssociation Name.
    * @param options The options parameters.
    */
   delete(
     resourceGroupName: string,
+    providerName: string,
+    resourceType: string,
+    resourceName: string,
     managementAssociationName: string,
     options?: ManagementAssociationsDeleteOptionalParams
   ): Promise<void> {
     return this.client.sendOperationRequest(
-      { resourceGroupName, managementAssociationName, options },
+      {
+        resourceGroupName,
+        providerName,
+        resourceType,
+        resourceName,
+        managementAssociationName,
+        options
+      },
       deleteOperationSpec
     );
   }
@@ -86,16 +113,29 @@ export class ManagementAssociationsImpl implements ManagementAssociations {
   /**
    * Retrieves the user ManagementAssociation.
    * @param resourceGroupName The name of the resource group to get. The name is case insensitive.
+   * @param providerName Provider name for the parent resource.
+   * @param resourceType Resource type for the parent resource
+   * @param resourceName Parent resource name.
    * @param managementAssociationName User ManagementAssociation Name.
    * @param options The options parameters.
    */
   get(
     resourceGroupName: string,
+    providerName: string,
+    resourceType: string,
+    resourceName: string,
     managementAssociationName: string,
     options?: ManagementAssociationsGetOptionalParams
   ): Promise<ManagementAssociationsGetResponse> {
     return this.client.sendOperationRequest(
-      { resourceGroupName, managementAssociationName, options },
+      {
+        resourceGroupName,
+        providerName,
+        resourceType,
+        resourceName,
+        managementAssociationName,
+        options
+      },
       getOperationSpec
     );
   }

package/src/operations/solutions.ts

@@ -103,10 +103,12 @@ export class SolutionsImpl implements Solutions {
       { resourceGroupName, solutionName, parameters, options },
       createOrUpdateOperationSpec
     );
-    return new LroEngine(lro, {
+    const poller = new LroEngine(lro, {
       resumeFrom: options?.resumeFrom,
       intervalInMs: options?.updateIntervalInMs
     });
+    await poller.poll();
+    return poller;
   }
 
   /**
@@ -193,10 +195,12 @@ export class SolutionsImpl implements Solutions {
       { resourceGroupName, solutionName, parameters, options },
       updateOperationSpec
     );
-    return new LroEngine(lro, {
+    const poller = new LroEngine(lro, {
       resumeFrom: options?.resumeFrom,
       intervalInMs: options?.updateIntervalInMs
     });
+    await poller.poll();
+    return poller;
   }
 
   /**
@@ -276,10 +280,12 @@ export class SolutionsImpl implements Solutions {
       { resourceGroupName, solutionName, options },
       deleteOperationSpec
     );
-    return new LroEngine(lro, {
+    const poller = new LroEngine(lro, {
       resumeFrom: options?.resumeFrom,
       intervalInMs: options?.updateIntervalInMs
     });
+    await poller.poll();
+    return poller;
   }
 
   /**

package/src/operationsInterfaces/managementAssociations.ts

@@ -29,12 +29,18 @@ export interface ManagementAssociations {
   /**
    * Creates or updates the ManagementAssociation.
    * @param resourceGroupName The name of the resource group to get. The name is case insensitive.
+   * @param providerName Provider name for the parent resource.
+   * @param resourceType Resource type for the parent resource
+   * @param resourceName Parent resource name.
    * @param managementAssociationName User ManagementAssociation Name.
    * @param parameters The parameters required to create ManagementAssociation extension.
    * @param options The options parameters.
    */
   createOrUpdate(
     resourceGroupName: string,
+    providerName: string,
+    resourceType: string,
+    resourceName: string,
     managementAssociationName: string,
     parameters: ManagementAssociation,
     options?: ManagementAssociationsCreateOrUpdateOptionalParams
@@ -42,22 +48,34 @@ export interface ManagementAssociations {
   /**
    * Deletes the ManagementAssociation in the subscription.
    * @param resourceGroupName The name of the resource group to get. The name is case insensitive.
+   * @param providerName Provider name for the parent resource.
+   * @param resourceType Resource type for the parent resource
+   * @param resourceName Parent resource name.
    * @param managementAssociationName User ManagementAssociation Name.
    * @param options The options parameters.
    */
   delete(
     resourceGroupName: string,
+    providerName: string,
+    resourceType: string,
+    resourceName: string,
     managementAssociationName: string,
     options?: ManagementAssociationsDeleteOptionalParams
   ): Promise<void>;
   /**
    * Retrieves the user ManagementAssociation.
    * @param resourceGroupName The name of the resource group to get. The name is case insensitive.
+   * @param providerName Provider name for the parent resource.
+   * @param resourceType Resource type for the parent resource
+   * @param resourceName Parent resource name.
    * @param managementAssociationName User ManagementAssociation Name.
    * @param options The options parameters.
    */
   get(
     resourceGroupName: string,
+    providerName: string,
+    resourceType: string,
+    resourceName: string,
     managementAssociationName: string,
     options?: ManagementAssociationsGetOptionalParams
   ): Promise<ManagementAssociationsGetResponse>;

package/src/operationsManagementClient.ts

@@ -7,6 +7,7 @@
  */
 
 import * as coreClient from "@azure/core-client";
+import * as coreRestPipeline from "@azure/core-rest-pipeline";
 import * as coreAuth from "@azure/core-auth";
 import {
   SolutionsImpl,
@@ -26,26 +27,17 @@ export class OperationsManagementClient extends coreClient.ServiceClient {
   $host: string;
   subscriptionId: string;
   apiVersion: string;
-  providerName: string;
-  resourceType: string;
-  resourceName: string;
 
   /**
    * Initializes a new instance of the OperationsManagementClient class.
    * @param credentials Subscription credentials which uniquely identify client subscription.
    * @param subscriptionId Gets subscription credentials which uniquely identify Microsoft Azure
    *                       subscription. The subscription ID forms part of the URI for every service call.
-   * @param providerName Provider name for the parent resource.
-   * @param resourceType Resource type for the parent resource
-   * @param resourceName Parent resource name.
    * @param options The parameter options
    */
   constructor(
     credentials: coreAuth.TokenCredential,
     subscriptionId: string,
-    providerName: string,
-    resourceType: string,
-    resourceName: string,
     options?: OperationsManagementClientOptionalParams
   ) {
     if (credentials === undefined) {
@@ -54,15 +46,6 @@ export class OperationsManagementClient extends coreClient.ServiceClient {
     if (subscriptionId === undefined) {
       throw new Error("'subscriptionId' cannot be null");
     }
-    if (providerName === undefined) {
-      throw new Error("'providerName' cannot be null");
-    }
-    if (resourceType === undefined) {
-      throw new Error("'resourceType' cannot be null");
-    }
-    if (resourceName === undefined) {
-      throw new Error("'resourceName' cannot be null");
-    }
 
     // Initializing default values for options
     if (!options) {
@@ -73,7 +56,7 @@ export class OperationsManagementClient extends coreClient.ServiceClient {
       credential: credentials
     };
 
-    const packageDetails = `azsdk-js-arm-operations/4.0.0-beta.2`;
+    const packageDetails = `azsdk-js-arm-operations/4.0.0-beta.3`;
     const userAgentPrefix =
       options.userAgentOptions && options.userAgentOptions.userAgentPrefix
         ? `${options.userAgentOptions.userAgentPrefix} ${packageDetails}`
@@ -88,14 +71,35 @@ export class OperationsManagementClient extends coreClient.ServiceClient {
       userAgentOptions: {
         userAgentPrefix
       },
-      baseUri: options.endpoint || "https://management.azure.com"
+      baseUri:
+        options.endpoint ?? options.baseUri ?? "https://management.azure.com"
     };
     super(optionsWithDefaults);
+
+    if (options?.pipeline && options.pipeline.getOrderedPolicies().length > 0) {
+      const pipelinePolicies: coreRestPipeline.PipelinePolicy[] = options.pipeline.getOrderedPolicies();
+      const bearerTokenAuthenticationPolicyFound = pipelinePolicies.some(
+        (pipelinePolicy) =>
+          pipelinePolicy.name ===
+          coreRestPipeline.bearerTokenAuthenticationPolicyName
+      );
+      if (!bearerTokenAuthenticationPolicyFound) {
+        this.pipeline.removePolicy({
+          name: coreRestPipeline.bearerTokenAuthenticationPolicyName
+        });
+        this.pipeline.addPolicy(
+          coreRestPipeline.bearerTokenAuthenticationPolicy({
+            scopes: `${optionsWithDefaults.baseUri}/.default`,
+            challengeCallbacks: {
+              authorizeRequestOnChallenge:
+                coreClient.authorizeRequestOnClaimChallenge
+            }
+          })
+        );
+      }
+    }
     // Parameter assignments
     this.subscriptionId = subscriptionId;
-    this.providerName = providerName;
-    this.resourceType = resourceType;
-    this.resourceName = resourceName;
 
     // Assigning values to Constant parameters
     this.$host = options.$host || "https://management.azure.com";

package/tsconfig.json

@@ -9,11 +9,25 @@
     "esModuleInterop": true,
     "allowSyntheticDefaultImports": true,
     "forceConsistentCasingInFileNames": true,
-    "lib": ["es6", "dom"],
+    "lib": [
+      "es6",
+      "dom"
+    ],
     "declaration": true,
     "outDir": "./dist-esm",
-    "importHelpers": true
+    "importHelpers": true,
+    "paths": {
+      "@azure/arm-operations": [
+        "./src/index"
+      ]
+    }
   },
-  "include": ["./src/**/*.ts", "./test/**/*.ts"],
-  "exclude": ["node_modules"]
-}
+  "include": [
+    "./src/**/*.ts",
+    "./test/**/*.ts",
+    "samples-dev/**/*.ts"
+  ],
+  "exclude": [
+    "node_modules"
+  ]
+}

package/types/arm-operations.d.ts

@@ -71,25 +71,34 @@ export declare interface ManagementAssociations {
     /**
      * Creates or updates the ManagementAssociation.
      * @param resourceGroupName The name of the resource group to get. The name is case insensitive.
+     * @param providerName Provider name for the parent resource.
+     * @param resourceType Resource type for the parent resource
+     * @param resourceName Parent resource name.
      * @param managementAssociationName User ManagementAssociation Name.
      * @param parameters The parameters required to create ManagementAssociation extension.
      * @param options The options parameters.
      */
-    createOrUpdate(resourceGroupName: string, managementAssociationName: string, parameters: ManagementAssociation, options?: ManagementAssociationsCreateOrUpdateOptionalParams): Promise<ManagementAssociationsCreateOrUpdateResponse>;
+    createOrUpdate(resourceGroupName: string, providerName: string, resourceType: string, resourceName: string, managementAssociationName: string, parameters: ManagementAssociation, options?: ManagementAssociationsCreateOrUpdateOptionalParams): Promise<ManagementAssociationsCreateOrUpdateResponse>;
     /**
      * Deletes the ManagementAssociation in the subscription.
      * @param resourceGroupName The name of the resource group to get. The name is case insensitive.
+     * @param providerName Provider name for the parent resource.
+     * @param resourceType Resource type for the parent resource
+     * @param resourceName Parent resource name.
      * @param managementAssociationName User ManagementAssociation Name.
      * @param options The options parameters.
      */
-    delete(resourceGroupName: string, managementAssociationName: string, options?: ManagementAssociationsDeleteOptionalParams): Promise<void>;
+    delete(resourceGroupName: string, providerName: string, resourceType: string, resourceName: string, managementAssociationName: string, options?: ManagementAssociationsDeleteOptionalParams): Promise<void>;
     /**
      * Retrieves the user ManagementAssociation.
      * @param resourceGroupName The name of the resource group to get. The name is case insensitive.
+     * @param providerName Provider name for the parent resource.
+     * @param resourceType Resource type for the parent resource
+     * @param resourceName Parent resource name.
      * @param managementAssociationName User ManagementAssociation Name.
      * @param options The options parameters.
      */
-    get(resourceGroupName: string, managementAssociationName: string, options?: ManagementAssociationsGetOptionalParams): Promise<ManagementAssociationsGetResponse>;
+    get(resourceGroupName: string, providerName: string, resourceType: string, resourceName: string, managementAssociationName: string, options?: ManagementAssociationsGetOptionalParams): Promise<ManagementAssociationsGetResponse>;
 }
 
 /** Optional parameters. */
@@ -263,20 +272,14 @@ export declare class OperationsManagementClient extends coreClient.ServiceClient
     $host: string;
     subscriptionId: string;
     apiVersion: string;
-    providerName: string;
-    resourceType: string;
-    resourceName: string;
     /**
      * Initializes a new instance of the OperationsManagementClient class.
      * @param credentials Subscription credentials which uniquely identify client subscription.
      * @param subscriptionId Gets subscription credentials which uniquely identify Microsoft Azure
      *                       subscription. The subscription ID forms part of the URI for every service call.
-     * @param providerName Provider name for the parent resource.
-     * @param resourceType Resource type for the parent resource
-     * @param resourceName Parent resource name.
      * @param options The parameter options
      */
-    constructor(credentials: coreAuth.TokenCredential, subscriptionId: string, providerName: string, resourceType: string, resourceName: string, options?: OperationsManagementClientOptionalParams);
+    constructor(credentials: coreAuth.TokenCredential, subscriptionId: string, options?: OperationsManagementClientOptionalParams);
     solutions: Solutions;
     managementAssociations: ManagementAssociations;
     managementConfigurations: ManagementConfigurations;

package/types/tsdoc-metadata.json

@@ -5,7 +5,7 @@
   "toolPackages": [
     {
       "packageName": "@microsoft/api-extractor",
-      "packageVersion": "7.19.2"
+      "packageVersion": "7.18.11"
     }
   ]
 }