@azure-tools/typespec-ts 0.55.0-dev.3 → 0.55.0-dev.5

package/src/modular/emit-tests.ts

@@ -1,5 +1,4 @@
-import { joinPaths } from "@typespec/compiler";
-import { existsSync, rmSync } from "fs";
+import { type CompilerHost, joinPaths } from "@typespec/compiler";
 import { SourceFile } from "ts-morph";
 import { resolveReference } from "../framework/reference.js";
 import { NameType, normalizeName } from "../rlc-common/index.js";
@@ -22,7 +21,7 @@ import { CreateRecorderHelpers } from "./static-helpers-metadata.js";
 /**
  * Clean up the test/generated folder before generating new tests
  */
-async function cleanupTestFolder(dpgContext: SdkContext) {
+async function cleanupTestFolder(dpgContext: SdkContext, host: CompilerHost) {
   const clients = dpgContext.sdkPackage.clients;
   const baseTestFolder = joinPaths(
     dpgContext.generationPathDetail?.rootDir ?? "",
@@ -30,19 +29,28 @@ async function cleanupTestFolder(dpgContext: SdkContext) {
     "generated",
   );
 
+  async function dirExists(path: string): Promise<boolean> {
+    try {
+      const s = await host.stat(path);
+      return s.isDirectory();
+    } catch {
+      return false;
+    }
+  }
+
   // If there are multiple clients, clean up subfolders
   if (clients.length > 1) {
     for (const client of clients) {
       const subFolder = normalizeName(getClassicalClientName(client), NameType.File);
       const clientTestFolder = joinPaths(baseTestFolder, subFolder);
-      if (existsSync(clientTestFolder)) {
-        rmSync(clientTestFolder, { recursive: true, force: true });
+      if (await dirExists(clientTestFolder)) {
+        await host.rm(clientTestFolder, { recursive: true });
       }
     }
   } else {
     // Single client, clean up the entire test/generated folder
-    if (existsSync(baseTestFolder)) {
-      rmSync(baseTestFolder, { recursive: true, force: true });
+    if (await dirExists(baseTestFolder)) {
+      await host.rm(baseTestFolder, { recursive: true });
     }
   }
 }
@@ -50,9 +58,14 @@ async function cleanupTestFolder(dpgContext: SdkContext) {
 /**
  * Helpers to emit tests similar to samples
  */
-export async function emitTests(dpgContext: SdkContext): Promise<SourceFile[]> {
+export async function emitTests(
+  dpgContext: SdkContext,
+  host?: CompilerHost,
+): Promise<SourceFile[]> {
   // Clean up the test/generated folder before generating new tests
-  await cleanupTestFolder(dpgContext);
+  if (host) {
+    await cleanupTestFolder(dpgContext, host);
+  }
 
   return iterateClientsAndMethods(dpgContext, emitMethodTests);
 }

package/src/modular/helpers/client-helpers.ts

@@ -10,7 +10,7 @@ import { OptionalKind, ParameterDeclarationStructure, StatementedNode } from "ts
 import { ModularEmitterOptions } from "../interfaces.js";
 
 import { resolveReference } from "../../framework/reference.js";
-import { NameType, normalizeName, PackageFlavor } from "../../rlc-common/index.js";
+import { NameType, normalizeName } from "../../rlc-common/index.js";
 import { SdkContext } from "../../utils/interfaces.js";
 import { CloudSettingHelpers } from "../static-helpers-metadata.js";
 import { getTypeExpression } from "../type-expressions/get-type-expression.js";
@@ -169,16 +169,10 @@ export function buildGetClientEndpointParam(
   client: SdkClientType<SdkServiceOperation>,
 ): { endpointParamName: string; assignedOptionalParams?: Set<string> } {
   const assignedOptionalParams = new Set<string>();
-  let coreEndpointParam: string;
-  if (dpgContext.rlcOptions?.flavor === "azure") {
-    const cloudSettingSuffix = dpgContext.arm
-      ? ` ?? ${resolveReference(CloudSettingHelpers.getArmEndpoint)}(options.cloudSetting)`
-      : "";
-    coreEndpointParam = `options.endpoint${cloudSettingSuffix}`;
-  } else {
-    // unbranded does not have the deprecated baseUrl parameter
-    coreEndpointParam = `options.endpoint`;
-  }
+  const cloudSettingSuffix = dpgContext.arm
+    ? ` ?? ${resolveReference(CloudSettingHelpers.getArmEndpoint)}(options.cloudSetting)`
+    : "";
+  const coreEndpointParam = `options.endpoint${cloudSettingSuffix}`;
   // Special case: endpoint URL not defined
   const endpointParam = getClientParameters(client, dpgContext, {
     onClientOnly: true,
@@ -248,7 +242,7 @@ export function buildGetClientOptionsParam(
   apiVersionParamName?: string,
 ): string {
   const userAgentOptions = buildUserAgentOptions(context, emitterOptions, "azsdk-js-api");
-  const loggingOptions = buildLoggingOptions(emitterOptions.options.flavor);
+  const loggingOptions = buildLoggingOptions();
   const credentials = buildCredentials(emitterOptions, endpointParam);
 
   // Use the actual api version parameter name for destructuring, defaulting to "apiVersion"
@@ -315,11 +309,7 @@ function buildCredentials(
   return `{ ${scopes}${apiKeyHeaderName} }`;
 }
 
-function buildLoggingOptions(flavor?: PackageFlavor): string | undefined {
-  if (flavor !== "azure") {
-    return undefined;
-  }
-
+function buildLoggingOptions(): string | undefined {
   return `{ logger: options.loggingOptions?.logger ?? logger.info }`;
 }
 

package/src/modular/helpers/example-value-helpers.ts

@@ -12,7 +12,7 @@ import { joinPaths } from "@typespec/compiler";
 import { SourceFile } from "ts-morph";
 import { useContext } from "../../context-manager.js";
 import { resolveReference } from "../../framework/reference.js";
-import { isAzurePackage, NameType, normalizeName } from "../../rlc-common/index.js";
+import { NameType, normalizeName } from "../../rlc-common/index.js";
 import { getSubscriptionId } from "../../transform/transfrom-rlc-options.js";
 import { hasKeyCredential, hasTokenCredential } from "../../utils/credential-utils.js";
 import { SdkContext } from "../../utils/interfaces.js";
@@ -73,7 +73,7 @@ export function prepareCommonValue(
  * Get credential value for samples
  */
 export function getCredentialSampleValue(
-  dpgContext: SdkContext,
+  _dpgContext: SdkContext,
   initialization: SdkClientInitializationType,
 ): CommonValue | undefined {
   const keyCredential = hasKeyCredential(initialization),
@@ -84,26 +84,11 @@ export function getCredentialSampleValue(
     name: "credential",
   };
   if (keyCredential || tokenCredential) {
-    if (isAzurePackage({ options: dpgContext.rlcOptions })) {
-      // Support DefaultAzureCredential for Azure packages
-      return {
-        ...defaultSetting,
-        value: `new ${resolveReference(AzureIdentityDependencies.DefaultAzureCredential)}()`,
-      };
-    } else if (keyCredential) {
-      // Support ApiKeyCredential for non-Azure packages
-      return {
-        ...defaultSetting,
-        value: `{ key: "INPUT_YOUR_KEY_HERE" }`,
-      };
-    } else if (tokenCredential) {
-      // Support TokenCredential for non-Azure packages
-      return {
-        ...defaultSetting,
-        value: `{ getToken: async () => {
-          return { token: "INPUT_YOUR_TOKEN_HERE", expiresOnTimestamp: Date.now() }; } }`,
-      };
-    }
+    // Support DefaultAzureCredential for Azure packages
+    return {
+      ...defaultSetting,
+      value: `new ${resolveReference(AzureIdentityDependencies.DefaultAzureCredential)}()`,
+    };
   }
   return undefined;
 }

package/src/modular/helpers/operation-helpers.ts

@@ -2060,7 +2060,7 @@ function getSerializationExpressionForFlatten(
   );
   const optionalPrefix = property.optional
     ? `${resolveReference(SerializationHelpers.areAllPropsUndefined)}(${propertyPath}, [${validProps
-        .map((p) => `"${p.name}"`)
+        .map((p) => normalizeModelPropertyName(context, p))
         .join(", ")}]) ? undefined : `
     : "";
   return `${optionalPrefix}${serializeFunctionName}(${propertyPath})`;

package/src/rlc-common/build-client-definitions.ts

@@ -30,7 +30,7 @@ export function buildClientDefinitions(model: RLCModel) {
     importedResponses: new Set<string>(),
     clientImports: new Set<string>(),
   };
-  const project = new Project();
+  const project = new Project({ useInMemoryFileSystem: true });
   const srcPath = model.srcPath;
   const filePath = joinPaths(srcPath, `clientDefinitions.ts`);
   const clientDefinitionsFile = project.createSourceFile(filePath, undefined, {

package/src/rlc-common/build-client.ts

@@ -16,7 +16,6 @@ import { buildMethodShortcutImplementation } from "./build-method-shortcuts.js";
 import { getImportSpecifier } from "./helpers/imports-util.js";
 import { getClientName, getImportModuleName } from "./helpers/name-constructors.js";
 import { NameType, normalizeName } from "./helpers/name-utils.js";
-import { isAzurePackage } from "./helpers/package-util.js";
 import { File, PathParameter, RLCModel } from "./interfaces.js";
 
 function getClientOptionsInterface(
@@ -62,7 +61,7 @@ function getClientOptionsInterface(
 export function buildClient(model: RLCModel): File | undefined {
   const name = normalizeName(model.libraryName, NameType.File);
   const { srcPath } = model;
-  const project = new Project();
+  const project = new Project({ useInMemoryFileSystem: true });
   const filePath = joinPaths(srcPath, `${name}.ts`);
   const clientFile = project.createSourceFile(filePath, undefined, {
     overwrite: true,
@@ -192,20 +191,18 @@ export function buildClient(model: RLCModel): File | undefined {
       moduleSpecifier: getImportSpecifier("restClient", model.importInfo.runtimeImports),
     },
   ]);
-  if (isAzurePackage(model)) {
-    clientFile.addImportDeclarations([
-      {
-        namedImports: ["logger"],
-        moduleSpecifier: getImportModuleName(
-          {
-            cjsName: loggerPath,
-            esModulesName: `${loggerPath}.js`,
-          },
-          model,
-        ),
-      },
-    ]);
-  }
+  clientFile.addImportDeclarations([
+    {
+      namedImports: ["logger"],
+      moduleSpecifier: getImportModuleName(
+        {
+          cjsName: loggerPath,
+          esModulesName: `${loggerPath}.js`,
+        },
+        model,
+      ),
+    },
+  ]);
 
   const includeKeyCredentialHelper =
     customHttpAuthHeaderName &&
@@ -349,12 +346,10 @@ export function getClientFactoryBody(
   const apiKeyHeaderName = credentialKeyHeaderName
     ? `apiKeyHeaderName: options.credentials?.apiKeyHeaderName ?? "${credentialKeyHeaderName}",`
     : "";
-  const loggerOptions = isAzurePackage(model)
-    ? `,
+  const loggerOptions = `,
   loggingOptions: {
     logger: options.loggingOptions?.logger ?? logger.info
-  }`
-    : "";
+  }`;
 
   const credentialsOptions =
     (scopes || apiKeyHeaderName) && addCredentials
@@ -400,16 +395,12 @@ export function getClientFactoryBody(
   }
 
   let apiVersionPolicyStatement = `client.pipeline.removePolicy({ name: "ApiVersionPolicy" });`;
-  if (isAzurePackage(model) && model.apiVersionInfo?.isCrossedVersion !== false) {
+  if (model.apiVersionInfo?.isCrossedVersion !== false) {
     apiVersionPolicyStatement += `
       if (options.apiVersion) {
         logger.warning("This client does not support client api-version, please change it at the operation level");
       }`;
-  } else if (
-    isAzurePackage(model) &&
-    !model.apiVersionInfo?.defaultValue &&
-    model.apiVersionInfo?.required
-  ) {
+  } else if (!model.apiVersionInfo?.defaultValue && model.apiVersionInfo?.required) {
     apiVersionPolicyStatement += `
       if (options.apiVersion) {
         logger.warning("This client does not support to set api-version in options, please change it at positional argument");

package/src/rlc-common/build-index-file.ts

@@ -17,13 +17,12 @@ import {
   hasTsvCollection,
   hasUnexpectedHelper,
 } from "./helpers/operation-helpers.js";
-import { isAzurePackage } from "./helpers/package-util.js";
 import { RLCModel } from "./interfaces.js";
 
 export function buildIndexFile(model: RLCModel) {
   const multiClient = Boolean(model.options?.multiClient),
     batch = model.options?.batch;
-  const project = new Project();
+  const project = new Project({ useInMemoryFileSystem: true });
   const { srcPath } = model;
   const filePath = joinPaths(srcPath, `index.ts`);
   const indexFile = project.createSourceFile(filePath, undefined, {
@@ -328,14 +327,12 @@ function generateRLCIndex(file: SourceFile, model: RLCModel) {
     ]);
   }
 
-  if (isAzurePackage(model)) {
-    file.addExportDeclarations([
-      {
-        moduleSpecifier: "@azure/core-rest-pipeline",
-        namedExports: ["RestError", "isRestError"],
-      },
-    ]);
-  }
+  file.addExportDeclarations([
+    {
+      moduleSpecifier: "@azure/core-rest-pipeline",
+      namedExports: ["RestError", "isRestError"],
+    },
+  ]);
 
   file.addExportAssignment({
     expression: createClientFuncName,

package/src/rlc-common/build-is-unexpected-helper.ts

@@ -15,7 +15,7 @@ export function buildIsUnexpectedHelper(model: RLCModel) {
   if (!hasUnexpectedHelper(model)) {
     return;
   }
-  const project = new Project();
+  const project = new Project({ useInMemoryFileSystem: true });
   const srcPath = model.srcPath;
   const filePath = joinPaths(srcPath, `isUnexpected.ts`);
   const isErrorHelper = project.createSourceFile(filePath, undefined, {

package/src/rlc-common/build-logger.ts

@@ -9,11 +9,7 @@ export function buildLogger(model: RLCModel) {
   if (!model.options) {
     return undefined;
   }
-  // Disable logger for non-Azure packages
-  if (model.options.flavor !== "azure") {
-    return undefined;
-  }
-  const project = new Project();
+  const project = new Project({ useInMemoryFileSystem: true });
   const { srcPath, rlcSourceDir } = model;
   const { packageDetails } = model.options;
   const filePath = joinPaths(

package/src/rlc-common/build-parameter-types.ts

@@ -27,7 +27,7 @@ import {
 } from "./interfaces.js";
 
 export function buildParameterTypes(model: RLCModel) {
-  const project = new Project();
+  const project = new Project({ useInMemoryFileSystem: true });
   const srcPath = model.srcPath;
   const filePath = joinPaths(srcPath, `parameters.ts`);
   const partialBodyTypeNames = new Set<string>();

package/src/rlc-common/build-response-types.ts

@@ -19,7 +19,7 @@ import { ResponseHeaderSchema, ResponseMetadata, RLCModel } from "./interfaces.j
 
 let hasErrorResponse = false;
 export function buildResponseTypes(model: RLCModel) {
-  const project = new Project();
+  const project = new Project({ useInMemoryFileSystem: true });
   const srcPath = model.srcPath;
   const filePath = joinPaths(srcPath, `responses.ts`);
   hasErrorResponse = false;

package/src/rlc-common/build-schema-type.ts

@@ -17,7 +17,7 @@ import { RLCModel, SchemaContext } from "./interfaces.js";
  */
 export function buildSchemaTypes(model: RLCModel) {
   const { srcPath } = model;
-  const project = new Project();
+  const project = new Project({ useInMemoryFileSystem: true });
   let filePath = joinPaths(srcPath, `models.ts`);
   const inputModelFile = generateModelFiles(model, project, filePath, [SchemaContext.Input]);
   filePath = joinPaths(srcPath, `outputModels.ts`);

package/src/rlc-common/build-top-level-index-file.ts

@@ -14,7 +14,7 @@ export function buildTopLevelIndex(model: RLCModel) {
   if (!model.options) {
     return undefined;
   }
-  const project = new Project();
+  const project = new Project({ useInMemoryFileSystem: true });
   const { srcPath } = model;
   const { multiClient } = model.options;
   const batch = model.options.batch;

package/src/rlc-common/helpers/imports-util.ts

@@ -1,64 +1,52 @@
 import { SourceFile } from "ts-morph";
-import { ImportType, Imports, PackageFlavor } from "../interfaces.js";
+import { ImportType, Imports } from "../interfaces.js";
 
 /**
- * Build the common imports for generated SDK
- * @param flavor flavor of SDK to generate, if any. When set to "azure", Azure Core packages will be used. When unset, the generic `ts-http-runtime` package will be used.
+ * Build the common imports for generated SDK. Azure Core packages are always used.
  * @returns
  */
-export function buildRuntimeImports(flavor?: PackageFlavor): Imports {
-  if (flavor === "azure") {
-    return {
-      restClient: {
-        type: "restClient",
-        specifier: "@azure-rest/core-client",
-        version: "^2.0.0",
-      },
-      coreAuth: {
-        type: "coreAuth",
-        specifier: "@azure/core-auth",
-        version: "^1.6.0",
-      },
-      restPipeline: {
-        type: "restPipeline",
-        specifier: "@azure/core-rest-pipeline",
-        version: "^1.14.0",
-      },
-      coreUtil: {
-        type: "coreUtil",
-        specifier: "@azure/core-util",
-        version: "^1.4.0",
-      },
-      coreLogger: {
-        type: "coreLogger",
-        specifier: "@azure/logger",
-        version: "^1.0.4",
-      },
-      azureEslintPlugin: {
-        type: "azureEslintPlugin",
-        specifier: "@azure/eslint-plugin-azure-sdk",
-        version: "^3.0.0",
-      },
-      azureTestRecorder: {
-        type: "azureTestRecorder",
-        specifier: "@azure-tools/test-recorder",
-        version: "^3.0.0",
-      },
-      azureCoreLro: {
-        type: "azureCoreLro",
-        specifier: "@azure/core-lro",
-      },
-    } as Imports;
-  } else {
-    // In non-azure branded scope we only have one dependency that is ts-http-runtime
-    return {
-      commonFallback: {
-        type: "commonFallback",
-        specifier: "@typespec/ts-http-runtime",
-        version: "0.1.0",
-      },
-    } as Imports;
-  }
+export function buildRuntimeImports(): Imports {
+  return {
+    restClient: {
+      type: "restClient",
+      specifier: "@azure-rest/core-client",
+      version: "^2.0.0",
+    },
+    coreAuth: {
+      type: "coreAuth",
+      specifier: "@azure/core-auth",
+      version: "^1.6.0",
+    },
+    restPipeline: {
+      type: "restPipeline",
+      specifier: "@azure/core-rest-pipeline",
+      version: "^1.14.0",
+    },
+    coreUtil: {
+      type: "coreUtil",
+      specifier: "@azure/core-util",
+      version: "^1.4.0",
+    },
+    coreLogger: {
+      type: "coreLogger",
+      specifier: "@azure/logger",
+      version: "^1.0.4",
+    },
+    azureEslintPlugin: {
+      type: "azureEslintPlugin",
+      specifier: "@azure/eslint-plugin-azure-sdk",
+      version: "^3.0.0",
+    },
+    azureTestRecorder: {
+      type: "azureTestRecorder",
+      specifier: "@azure-tools/test-recorder",
+      version: "^3.0.0",
+    },
+    azureCoreLro: {
+      type: "azureCoreLro",
+      specifier: "@azure/core-lro",
+    },
+  } as Imports;
 }
 
 /**

package/src/rlc-common/helpers/package-util.ts

@@ -1,13 +1,9 @@
-import { RLCModel, RLCOptions } from "../interfaces.js";
-
-export function isAzurePackage(model: { options?: RLCOptions }): boolean {
-  return Boolean(model.options?.flavor === "azure");
-}
+import { RLCModel } from "../interfaces.js";
 
 export function isAzureMonorepoPackage(model: RLCModel): boolean {
-  return Boolean(model.options?.azureSdkForJs) && isAzurePackage(model);
+  return Boolean(model.options?.azureSdkForJs);
 }
 
 export function isAzureStandalonePackage(model: RLCModel): boolean {
-  return isAzurePackage(model) && !model.options?.azureSdkForJs;
+  return !model.options?.azureSdkForJs;
 }

package/src/rlc-common/interfaces.ts

@@ -39,7 +39,6 @@ export type ImportType =
   | "coreUtil"
   | "coreLogger"
   // this is a fallback import if above imports are not available
-  // mainly used in non-branded scope
   | "commonFallback"
   /**azure specific imports */
   | "azureEslintPlugin"
@@ -191,11 +190,6 @@ export interface OperationLroDetail {
   precedence?: number;
 }
 
-/**
- * Flavor of the package to generate. If "azure", an Azure-branded package should be generated. If left undefined, a package without Azure branding will be generated.
- */
-export type PackageFlavor = "azure" | undefined;
-
 export interface RLCOptions {
   /**
    * Whether to include response headers in the generated response types. If true, the generated response types will include headers as properties.
@@ -242,7 +236,6 @@ export interface RLCOptions {
   isModularLibrary?: boolean;
   moduleKind?: "esm" | "cjs";
   enableOperationGroup?: boolean;
-  flavor?: PackageFlavor;
   enableModelNamespace?: boolean;
   hierarchyClient?: boolean;
   compatibilityMode?: boolean;
@@ -259,7 +252,7 @@ export interface RLCOptions {
   /**
    * When set to true, non-model return types (arrays, scalars, enums, bytes with binary content type)
    * will be wrapped in an XxxResponse type to maintain backward compatibility with HLC.
-   * This option defaults to true for Azure flavor and to false otherwise, unless explicitly set.
+   * This option defaults to true unless explicitly set.
    */
   wrapNonModelReturn?: boolean;
   /**

package/src/rlc-common/metadata/build-api-extractor-config.ts

@@ -6,7 +6,7 @@ import { RLCModel } from "../interfaces.js";
 
 export function buildApiExtractorConfig(model: RLCModel) {
   const { packageDetails, isModularLibrary, generateTest, azureSdkForJs } = model.options || {};
-  const project = new Project();
+  const project = new Project({ useInMemoryFileSystem: true });
 
   let mainEntryPointFilePath = "dist/esm/index.d.ts";
 

package/src/rlc-common/metadata/build-es-lint-config.ts

@@ -62,10 +62,7 @@ export default [
 `;
 
 export function buildEsLintConfig(model: RLCModel) {
-  if (model.options?.flavor !== "azure") {
-    return;
-  }
-  const project = new Project();
+  const project = new Project({ useInMemoryFileSystem: true });
   const filePath = "eslint.config.mjs";
 
   let template: string;

package/src/rlc-common/metadata/build-package-file.ts

@@ -4,16 +4,11 @@
 import { Project, SourceFile } from "ts-morph";
 import { NameType, normalizeName } from "../helpers/name-utils.js";
 import { hasPollingOperations } from "../helpers/operation-helpers.js";
-import {
-  isAzureMonorepoPackage,
-  isAzurePackage,
-  isAzureStandalonePackage,
-} from "../helpers/package-util.js";
+import { isAzureMonorepoPackage } from "../helpers/package-util.js";
 import { getRelativePartFromSrcPath } from "../helpers/path-utils.js";
 import { RLCModel } from "../interfaces.js";
 import { buildAzureMonorepoPackage } from "./package-json/build-azure-monorepo-package.js";
 import { buildAzureStandalonePackage } from "./package-json/build-azure-standalone-package.js";
-import { buildFlavorlessPackage } from "./package-json/build-flavorless-package.js";
 import {
   PackageCommonInfoConfig,
   getTshyConfig,
@@ -46,8 +41,6 @@ export function buildPackageFile(
     generateReactNativeTarget: model.options?.generateReactNativeTarget,
   };
 
-  let packageInfo: Record<string, any> = buildFlavorlessPackage(config);
-
   const extendedConfig = {
     ...config,
     clientFilePaths: [getClientFilePath(model)],
@@ -58,15 +51,11 @@ export function buildPackageFile(
     clientContextPaths,
   };
 
-  if (isAzureMonorepoPackage(model)) {
-    packageInfo = buildAzureMonorepoPackage(extendedConfig);
-  }
-
-  if (isAzureStandalonePackage(model)) {
-    packageInfo = buildAzureStandalonePackage(extendedConfig);
-  }
+  const packageInfo: Record<string, any> = isAzureMonorepoPackage(model)
+    ? buildAzureMonorepoPackage(extendedConfig)
+    : buildAzureStandalonePackage(extendedConfig);
 
-  const project = new Project();
+  const project = new Project({ useInMemoryFileSystem: true });
   const filePath = "package.json";
 
   if (!packageInfo) {
@@ -97,8 +86,7 @@ export function updatePackageFile(
   { exports, clientContextPaths }: PackageFileOptions = {},
 ) {
   const hasLro = hasPollingOperations(model);
-  const isAzure = isAzurePackage(model);
-  const needsLroUpdate = isAzure && hasLro;
+  const needsLroUpdate = hasLro;
   const needsExportsUpdate = exports;
   const needsConstantPathsUpdate = clientContextPaths && clientContextPaths.length > 0;
   const needsPlatformImportsUpdate =
@@ -200,7 +188,7 @@ export function updatePackageFile(
   }
 
   // Update constantPaths metadata for Azure packages
-  if (needsConstantPathsUpdate && isAzure && packageInfo["//metadata"]) {
+  if (needsConstantPathsUpdate && packageInfo["//metadata"]) {
     const metadata = packageInfo["//metadata"];
     // Filter out existing userAgentInfo entries
     const nonUserAgentPaths = (metadata.constantPaths || []).filter(