@azure-tools/typespec-ts 0.54.0 → 0.55.0-dev.6

package/src/rlc-common/transformSampleGroups.ts

@@ -1,20 +1,20 @@
-import { generateParameterTypeValue } from "./helpers/valueGenerationUtil.js";
 import { getClientName } from "./helpers/nameConstructors.js";
-import { normalizeName, NameType, camelCase } from "./helpers/nameUtils.js";
+import { NameType, camelCase, normalizeName } from "./helpers/nameUtils.js";
+import { isAzurePackage } from "./helpers/packageUtil.js";
 import { buildSchemaObjectMap } from "./helpers/schemaHelpers.js";
+import { generateParameterTypeValue } from "./helpers/valueGenerationUtil.js";
 import {
-  RLCModel,
-  RLCSampleGroup,
-  Paths,
   OperationMethod,
+  OperationParameter,
+  PathMetadata,
+  Paths,
+  RLCModel,
   RLCSampleDetail,
-  SampleParameters,
+  RLCSampleGroup,
   SampleParameter,
+  SampleParameters,
   Schema,
-  PathMetadata,
-  OperationParameter
 } from "./interfaces.js";
-import { isAzurePackage } from "./helpers/packageUtil.js";
 
 /**
  * Transform the sample data based RLC detail e.g path, operations & schemas
@@ -28,10 +28,7 @@ export function transformSampleGroups(model: RLCModel, allowMockValue = true) {
     // Not support to generate if modular libraries
     return;
   }
-  if (
-    (model.sampleGroups && model.sampleGroups.length > 0) ||
-    !allowMockValue
-  ) {
+  if ((model.sampleGroups && model.sampleGroups.length > 0) || !allowMockValue) {
     // Skip to transform if already has sample data
     // Skip to transform if not allow to mock value
     return;
@@ -45,7 +42,7 @@ export function transformSampleGroups(model: RLCModel, allowMockValue = true) {
     : `${clientName}Client`;
   const defaultFactoryName = normalizeName(
     camelCase(`create ${clientInterfaceName}`),
-    NameType.Method
+    NameType.Method,
   );
   const packageName = model.options?.packageDetails?.name ?? "";
   const methodParameterMap = buildMethodParamMap(model);
@@ -69,17 +66,17 @@ export function transformSampleGroups(model: RLCModel, allowMockValue = true) {
       const operatonConcante = getOperationConcate(
         detail.operationName,
         pathDetails.operationGroupName,
-        model.options?.sourceFrom
+        model.options?.sourceFrom,
       );
       const operationPrefix = normalizeName(
         camelCase(transformSpecialLetterToSpace(operatonConcante)),
-        NameType.Operation
+        NameType.Operation,
       );
       const sampleGroup: RLCSampleGroup = {
         filename: `${operationPrefix}Sample`,
         defaultFactoryName,
         clientPackageName: packageName,
-        samples: []
+        samples: [],
       };
 
       // initialize the sample
@@ -97,21 +94,17 @@ export function transformSampleGroups(model: RLCModel, allowMockValue = true) {
         method,
         isLRO: detail.operationHelperDetail?.lroDetails?.isLongRunning ?? false,
         isPaging: detail.operationHelperDetail?.isPaging ?? false,
-        useLegacyLro: false
+        useLegacyLro: false,
       };
       // client-level, path-level and method-level parameter preparation
       const parameters: SampleParameters = {
-        client: convertClientLevelParameters(
-          model,
-          importedDict,
-          schemaObjectMap
-        ),
+        client: convertClientLevelParameters(model, importedDict, schemaObjectMap),
         path: convertPathLevelParameters(pathDetails, path, schemaObjectMap),
         method: convertMethodLevelParameters(
           methodArray,
           schemaObjectMap,
-          methodParameterMap.get(operatonConcante)
-        )
+          methodParameterMap.get(operatonConcante),
+        ),
       };
       // enrich parameter details
       enrichParameterInSample(sample, parameters);
@@ -119,12 +112,7 @@ export function transformSampleGroups(model: RLCModel, allowMockValue = true) {
       enrichLROAndPagingInSample(detail, importedDict, packageName);
       sampleGroup.samples.push(sample);
       rlcSampleGroups.push(sampleGroup);
-      enrichImportedString(
-        sampleGroup,
-        importedDict,
-        defaultFactoryName,
-        packageName
-      );
+      enrichImportedString(sampleGroup, importedDict, defaultFactoryName, packageName);
     }
   }
   return rlcSampleGroups;
@@ -133,10 +121,9 @@ export function transformSampleGroups(model: RLCModel, allowMockValue = true) {
 function enrichLROAndPagingInSample(
   operation: OperationMethod,
   importedDict: Record<string, Set<string>>,
-  packageName: string
+  packageName: string,
 ) {
-  const isLRO =
-      operation.operationHelperDetail?.lroDetails?.isLongRunning ?? false,
+  const isLRO = operation.operationHelperDetail?.lroDetails?.isLongRunning ?? false,
     isPaging = operation.operationHelperDetail?.isPaging ?? false;
   if (isPaging) {
     if (isLRO) {
@@ -163,7 +150,7 @@ function enrichImportedString(
   sampleGroup: RLCSampleGroup,
   importedDict: Record<string, Set<string>>,
   defaultFactoryName: string,
-  packageName: string
+  packageName: string,
 ) {
   const importedTypes: string[] = [];
   if (!importedDict[packageName] || importedDict[packageName].size === 0) {
@@ -175,26 +162,19 @@ function enrichImportedString(
       continue;
     }
     const values = Array.from(importedSet).join(", ");
-    const hasDefaultFactory =
-      key === packageName ? `${defaultFactoryName},` : "";
-    importedTypes.push(
-      `import ${hasDefaultFactory} { ${values} } from "${key}";`
-    );
+    const hasDefaultFactory = key === packageName ? `${defaultFactoryName},` : "";
+    importedTypes.push(`import ${hasDefaultFactory} { ${values} } from "${key}";`);
   }
   sampleGroup.importedTypes = importedTypes;
 }
 
-function enrichParameterInSample(
-  sample: RLCSampleDetail,
-  parameters: SampleParameters
-) {
+function enrichParameterInSample(sample: RLCSampleDetail, parameters: SampleParameters) {
   sample.clientParamAssignments = getAssignmentStrArray(parameters.client);
   sample.clientParamNames = getContactParameterNames(parameters.client);
   sample.pathParamAssignments = getAssignmentStrArray(parameters.path);
   sample.pathParamNames = getContactParameterNames(parameters.path);
   // Directly apply the inline option value as method parameter
-  sample.methodParamNames =
-    parameters.method.length > 0 ? (parameters.method[0]?.value ?? "") : "";
+  sample.methodParamNames = parameters.method.length > 0 ? (parameters.method[0]?.value ?? "") : "";
 }
 
 function getAssignmentStrArray(parameters: SampleParameter[]) {
@@ -211,7 +191,7 @@ function getContactParameterNames(parameters: SampleParameter[]) {
 function convertClientLevelParameters(
   model: RLCModel,
   importedDict: Record<string, Set<string>>,
-  schemaMap: Map<string, Schema>
+  schemaMap: Map<string, Schema>,
 ): SampleParameter[] {
   if (!model.options) {
     return [];
@@ -219,35 +199,27 @@ function convertClientLevelParameters(
   const clientParams: SampleParameter[] = [];
   const urlParameters = model?.urlInfo?.urlParameters?.filter(
     // Do not include parameters with constant values in the signature, these should go in the options bag
-    (p) => p.value === undefined
+    (p) => p.value === undefined,
   );
   const {
     addCredentials,
     credentialScopes,
     credentialKeyHeaderName,
     customHttpAuthHeaderName,
-    flavor
+    flavor,
   } = model.options;
   const hasUrlParameter = !!urlParameters,
     hasCredentials =
-      addCredentials &&
-      (credentialScopes || credentialKeyHeaderName || customHttpAuthHeaderName);
+      addCredentials && (credentialScopes || credentialKeyHeaderName || customHttpAuthHeaderName);
 
   if (hasUrlParameter) {
     // convert the host parameters in url
     const clientParamAssignments = urlParameters.map((urlParameter) => {
-      const urlValue = generateParameterTypeValue(
-        urlParameter.type,
-        urlParameter.name,
-        schemaMap
-      );
-      const normalizedName = normalizeName(
-        urlParameter.name,
-        NameType.Parameter
-      );
+      const urlValue = generateParameterTypeValue(urlParameter.type, urlParameter.name, schemaMap);
+      const normalizedName = normalizeName(urlParameter.name, NameType.Parameter);
       return {
         name: normalizedName,
-        assignment: `const ${normalizedName} = ` + urlValue + `;`
+        assignment: `const ${normalizedName} = ` + urlValue + `;`,
       };
     });
 
@@ -264,35 +236,24 @@ function convertClientLevelParameters(
     if (credentialKeyHeaderName && isAzurePackage(model)) {
       clientParams.push({
         name: "credential",
-        assignment: `const credential = new AzureKeyCredential("{Your API key}");`
+        assignment: `const credential = new AzureKeyCredential("{Your API key}");`,
       });
-      addValueInImportedDict(
-        apiKeyCredentialPackage,
-        "AzureKeyCredential",
-        importedDict
-      );
-    } else if (
-      (credentialKeyHeaderName && flavor !== "azure") ||
-      customHttpAuthHeaderName
-    ) {
+      addValueInImportedDict(apiKeyCredentialPackage, "AzureKeyCredential", importedDict);
+    } else if ((credentialKeyHeaderName && flavor !== "azure") || customHttpAuthHeaderName) {
       clientParams.push({
         name: "credential",
-        assignment: `const credential = { key: "{Your API key}"};`
+        assignment: `const credential = { key: "{Your API key}"};`,
       });
     } else if (isAzurePackage(model)) {
       clientParams.push({
         name: "credential",
-        assignment: "const credential = new DefaultAzureCredential();"
+        assignment: "const credential = new DefaultAzureCredential();",
       });
-      addValueInImportedDict(
-        tokenCredentialPackage,
-        "DefaultAzureCredential",
-        importedDict
-      );
+      addValueInImportedDict(tokenCredentialPackage, "DefaultAzureCredential", importedDict);
     } else {
       clientParams.push({
         name: "credential",
-        assignment: `const credential = {getToken: () => Promise.resolve({ token: "{Your token}", expiresOnTimestamp: 0 })};`
+        assignment: `const credential = {getToken: () => Promise.resolve({ token: "{Your token}", expiresOnTimestamp: 0 })};`,
       });
     }
   }
@@ -302,14 +263,14 @@ function convertClientLevelParameters(
 function convertPathLevelParameters(
   pathDetail: PathMetadata,
   path: string,
-  schemaMap: Map<string, Schema>
+  schemaMap: Map<string, Schema>,
 ): SampleParameter[] {
   const pathItself = {
-    name: `"${path}"`
+    name: `"${path}"`,
   };
   const pathParams = (pathDetail || []).pathParameters.map((p) => {
     const pathParam: SampleParameter = {
-      name: normalizeName(p.name, NameType.Parameter)
+      name: normalizeName(p.name, NameType.Parameter),
     };
     const value = generateParameterTypeValue(p.type, p.name, schemaMap);
     pathParam.assignment = `const ${pathParam.name} =` + value + `;`;
@@ -321,7 +282,7 @@ function convertPathLevelParameters(
 function convertMethodLevelParameters(
   methods: OperationMethod[],
   schemaMap: Map<string, Schema>,
-  operationParameter?: OperationParameter
+  operationParameter?: OperationParameter,
 ): SampleParameter[] {
   if (
     !methods ||
@@ -359,7 +320,7 @@ function convertMethodLevelParameters(
         schemaMap.set(bodyTypeName, body.oriSchema);
       }
       allSideAssignments.push(
-        ` body: ` + generateParameterTypeValue(bodyTypeName, "body", schemaMap)
+        ` body: ` + generateParameterTypeValue(bodyTypeName, "body", schemaMap),
       );
     }
   }
@@ -369,14 +330,12 @@ function convertMethodLevelParameters(
     .forEach((p) => {
       const name = `${p.name}`;
       querySideAssignments.push(
-        `${name}: ` + generateParameterTypeValue(p.param.type, name, schemaMap)
+        `${name}: ` + generateParameterTypeValue(p.param.type, name, schemaMap),
       );
     });
 
   if (querySideAssignments.length > 0) {
-    allSideAssignments.push(
-      ` queryParameters: { ` + querySideAssignments.join(", ") + `}`
-    );
+    allSideAssignments.push(` queryParameters: { ` + querySideAssignments.join(", ") + `}`);
   }
   requestParameter.parameters
     ?.filter((p) => p.type === "header")
@@ -384,13 +343,11 @@ function convertMethodLevelParameters(
     .forEach((p) => {
       const name = `${p.name}`;
       headerSideAssignments.push(
-        `${name}: ` + generateParameterTypeValue(p.param.type, name, schemaMap)
+        `${name}: ` + generateParameterTypeValue(p.param.type, name, schemaMap),
       );
     });
   if (headerSideAssignments.length > 0) {
-    allSideAssignments.push(
-      ` headers: { ` + headerSideAssignments.join(", ") + `}`
-    );
+    allSideAssignments.push(` headers: { ` + headerSideAssignments.join(", ") + `}`);
   }
   const contentType = requestParameter.parameters
     ?.filter((p) => p.type === "header")
@@ -399,11 +356,7 @@ function convertMethodLevelParameters(
   if (firstContentType) {
     allSideAssignments.push(
       ` ${firstContentType.name}: ` +
-        generateParameterTypeValue(
-          firstContentType.param.type,
-          firstContentType.name,
-          schemaMap
-        )
+        generateParameterTypeValue(firstContentType.param.type, firstContentType.name, schemaMap),
     );
   }
   let value: string = `{}`;
@@ -416,7 +369,7 @@ function convertMethodLevelParameters(
   const optionParam: SampleParameter = {
     name: "options",
     assignment: `const options =` + value + `;`,
-    value
+    value,
   };
   return [optionParam];
 }
@@ -424,7 +377,7 @@ function convertMethodLevelParameters(
 function addValueInImportedDict(
   key: string,
   val: string,
-  importedDict: Record<string, Set<string>>
+  importedDict: Record<string, Set<string>>,
 ) {
   if (!importedDict[key]) {
     importedDict[key] = new Set<string>();
@@ -438,18 +391,14 @@ function buildMethodParamMap(model: RLCModel): Map<string, OperationParameter> {
     const operatonConcante = getOperationConcate(
       p.operationName,
       p.operationGroup,
-      model.options?.sourceFrom
+      model.options?.sourceFrom,
     );
     map.set(operatonConcante, p);
   });
   return map;
 }
 
-function getOperationConcate(
-  opName: string,
-  opGroup: string,
-  sourceFrom?: string
-) {
+function getOperationConcate(opName: string, opGroup: string, sourceFrom?: string) {
   return sourceFrom === "Swagger"
     ? opGroup === "" || opGroup === "Client"
       ? opName

package/src/testing/index.ts

@@ -1,10 +1,7 @@
-import {
-  createTestLibrary,
-  findTestPackageRoot
-} from "@typespec/compiler/testing";
+import { createTestLibrary, findTestPackageRoot } from "@typespec/compiler/testing";
 
 export const TypespecTsTestLibrary = createTestLibrary({
   name: "@azure-tools/typespec-ts",
   // Set this to the absolute path to the root of the package. (e.g. in this case this file would be compiled to ./dist/src/testing/index.js)
-  packageRoot: await findTestPackageRoot(import.meta.url)
+  packageRoot: await findTestPackageRoot(import.meta.url),
 });

package/src/transform/transform.ts

@@ -1,6 +1,10 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
+import { SdkClient } from "@azure-tools/typespec-client-generator-core";
+import { getDoc } from "@typespec/compiler";
+import { getServers } from "@typespec/http";
+import * as path from "path";
 import {
   buildRuntimeImports,
   Imports,
@@ -16,12 +20,8 @@ import {
   Schema,
   SchemaContext,
   transformSampleGroups,
-  UrlInfo
+  UrlInfo,
 } from "../rlc-common/index.js";
-import { SdkClient } from "@azure-tools/typespec-client-generator-core";
-import { getDoc } from "@typespec/compiler";
-import { getServers } from "@typespec/http";
-import * as path from "path";
 import { SdkContext } from "../utils/interfaces.js";
 import {
   getDefaultService,
@@ -29,7 +29,7 @@ import {
   getImportedModelName,
   getSchemaForType,
   getTypeName,
-  predictDefaultValue
+  predictDefaultValue,
 } from "../utils/modelUtils.js";
 import { getClientLroOverload } from "../utils/operationUtil.js";
 import { transformApiVersionInfo } from "./transformApiVersionInfo.js";
@@ -42,7 +42,7 @@ import { transformTelemetryInfo } from "./transformTelemetryInfo.js";
 
 export async function transformRLCModel(
   client: SdkClient,
-  dpgContext: SdkContext
+  dpgContext: SdkContext,
 ): Promise<RLCModel> {
   const program = dpgContext.program;
   const options: RLCOptions = dpgContext.rlcOptions!;
@@ -51,7 +51,7 @@ export async function transformRLCModel(
     dpgContext.generationPathDetail?.rlcSourcesDir ?? "",
     options.batch && options.batch.length > 1
       ? normalizeName(client.name.replace("Client", ""), NameType.File)
-      : ""
+      : "",
   );
   const libraryName = normalizeName(
     options.batch && (options.isModularLibrary || options.batch.length > 1)
@@ -60,28 +60,20 @@ export async function transformRLCModel(
           client.name ??
           getDefaultService(program, options.isModularLibrary)?.title ??
           ""),
-    NameType.Class
+    NameType.Class,
   );
   const importSet = initInternalImports();
   const urlInfo = transformUrlInfo(client, dpgContext, importSet);
   const paths: Paths = transformPaths(client, dpgContext, importSet);
   const schemas: Schema[] = transformSchemas(client, dpgContext);
-  const responses: OperationResponse[] = transformToResponseTypes(
-    client,
-    dpgContext,
-    importSet
-  );
+  const responses: OperationResponse[] = transformToResponseTypes(client, dpgContext, importSet);
   const parameters: OperationParameter[] = transformToParameterTypes(
     client,
     dpgContext,
     importSet,
-    urlInfo?.apiVersionInfo
-  );
-  const helperDetails = transformHelperFunctionDetails(
-    client,
-    dpgContext,
-    options.flavor
+    urlInfo?.apiVersionInfo,
   );
+  const helperDetails = transformHelperFunctionDetails(client, dpgContext, options.flavor);
   // Enrich client-level annotation detail
   helperDetails.clientLroOverload = getClientLroOverload(paths);
 
@@ -100,14 +92,13 @@ export async function transformRLCModel(
     telemetryOptions,
     importInfo: {
       internalImports: importSet,
-      runtimeImports: buildRuntimeImports(options.flavor)
+      runtimeImports: buildRuntimeImports(options.flavor),
     },
-    rlcSourceDir
+    rlcSourceDir,
   };
   model.sampleGroups = transformSampleGroups(
     model,
-    options?.generateSample ===
-      true /* Enable mock sample content if generateSample === true */
+    options?.generateSample === true /* Enable mock sample content if generateSample === true */,
   );
   options.generateSample =
     (options.generateSample === true || options.generateSample === undefined) &&
@@ -118,7 +109,7 @@ export async function transformRLCModel(
 export function transformUrlInfo(
   client: SdkClient,
   dpgContext: SdkContext,
-  importDetails: Imports
+  importDetails: Imports,
 ): UrlInfo | undefined {
   const importedModels = new Set<string>();
   const usage = [SchemaContext.Exception, SchemaContext.Input];
@@ -144,12 +135,9 @@ export function transformUrlInfo(
         const schema = getSchemaForType(dpgContext, type, {
           usage: usage,
           needRef: false,
-          relevantProperty: property
+          relevantProperty: property,
         });
-        getImportedModelName(schema, usage)?.forEach(
-          importedModels.add,
-          importedModels
-        );
+        getImportedModelName(schema, usage)?.forEach(importedModels.add, importedModels);
         const normName = normalizeName(key, NameType.Parameter, true);
         if (normName !== key && endpoint) {
           endpoint = endpoint.replace(`{${key}}`, `{${normName}}`);
@@ -162,7 +150,7 @@ export function transformUrlInfo(
             (getDoc(program, property) &&
               getFormattedPropertyDoc(program, property, schema, " ")) ??
             getFormattedPropertyDoc(program, type, schema, " " /* separator*/),
-          value: predictDefaultValue(dpgContext, host?.[0]?.parameters.get(key))
+          value: predictDefaultValue(dpgContext, host?.[0]?.parameters.get(key)),
         });
       }
     }
@@ -186,12 +174,12 @@ export function transformUrlInfo(
     endpoint = "{endpointParam}";
     urlParameters.push({
       name: "endpointParam",
-      type: "string"
+      type: "string",
     });
   }
   const apiVersionInfo = transformApiVersionInfo(client, dpgContext, {
     endpoint,
-    urlParameters
+    urlParameters,
   });
   if (
     apiVersionInfo &&
@@ -203,7 +191,7 @@ export function transformUrlInfo(
     urlParameters.push({
       oriName: "api-version",
       name: "apiVersion",
-      type: "string"
+      type: "string",
     });
   }
   return { endpoint, urlParameters, apiVersionInfo };

package/src/transform/transformApiVersionInfo.ts

@@ -1,37 +1,30 @@
+import {
+  getHttpOperationWithCache,
+  isApiVersion,
+  SdkClient,
+} from "@azure-tools/typespec-client-generator-core";
 import {
   ApiVersionInfo,
   ApiVersionPosition,
   extractDefinedPosition,
   extractPathApiVersion,
   SchemaContext,
-  UrlInfo
+  UrlInfo,
 } from "../rlc-common/index.js";
-import {
-  getHttpOperationWithCache,
-  isApiVersion,
-  SdkClient
-} from "@azure-tools/typespec-client-generator-core";
-import { SdkContext } from "../utils/interfaces.js";
-import {
-  getDefaultApiVersionString,
-  getSchemaForType,
-  trimUsage
-} from "../utils/modelUtils.js";
 import { listOperationsUnderRLCClient } from "../utils/clientUtils.js";
+import { SdkContext } from "../utils/interfaces.js";
+import { getDefaultApiVersionString, getSchemaForType, trimUsage } from "../utils/modelUtils.js";
 
 export function transformApiVersionInfo(
   client: SdkClient,
   dpgContext: SdkContext,
-  urlInfo?: UrlInfo
+  urlInfo?: UrlInfo,
 ): ApiVersionInfo | undefined {
   const queryVersionDetail = getOperationApiVersion(client, dpgContext);
   const pathVersionDetail = extractPathApiVersion(urlInfo);
   const isCrossedVersion =
     queryVersionDetail || pathVersionDetail
-      ? Boolean(
-          pathVersionDetail?.isCrossedVersion ||
-          queryVersionDetail?.isCrossedVersion
-        )
+      ? Boolean(pathVersionDetail?.isCrossedVersion || queryVersionDetail?.isCrossedVersion)
       : undefined;
   const defaultValue =
     (pathVersionDetail || queryVersionDetail) && !isCrossedVersion
@@ -47,19 +40,16 @@ export function transformApiVersionInfo(
     dpgContext.hasApiVersionInClient = true;
   }
   return {
-    definedPosition: extractDefinedPosition(
-      queryVersionDetail,
-      pathVersionDetail
-    ),
+    definedPosition: extractDefinedPosition(queryVersionDetail, pathVersionDetail),
     isCrossedVersion,
     defaultValue,
-    required: pathVersionDetail?.required ?? queryVersionDetail?.required
+    required: pathVersionDetail?.required ?? queryVersionDetail?.required,
   };
 }
 
 export function getOperationApiVersion(
   client: SdkClient,
-  dpgContext: SdkContext
+  dpgContext: SdkContext,
 ): ApiVersionInfo | undefined {
   const apiVersionTypes = new Set<string>();
   const locations = new Set<ApiVersionPosition>();
@@ -74,15 +64,13 @@ export function getOperationApiVersion(
       continue;
     }
     const params = route.parameters.parameters.filter(
-      (p) =>
-        (p.type === "query" || p.type === "path") &&
-        isApiVersion(dpgContext, p.param)
+      (p) => (p.type === "query" || p.type === "path") && isApiVersion(dpgContext, p.param),
     );
     params.map((p) => {
       const type = getSchemaForType(dpgContext, p.param.type, {
         usage: [SchemaContext.Exception, SchemaContext.Input],
         needRef: false,
-        relevantProperty: p.param
+        relevantProperty: p.param,
       });
       required.add(!p.param.optional);
       if (p.type === "query" || p.type === "path") {
@@ -106,11 +94,10 @@ export function getOperationApiVersion(
     return;
   }
   const detail: ApiVersionInfo = {
-    definedPosition:
-      locations.size > 1 ? "duplicate" : locations.values().next().value,
+    definedPosition: locations.size > 1 ? "duplicate" : locations.values().next().value,
     isCrossedVersion: apiVersionTypes.size > 1,
     defaultValue: undefined, // We won't prompt the query versions into client one
-    required: required.values().next().value
+    required: required.values().next().value,
   };
   return detail;
 }