@azure-tools/typespec-ts 0.52.1 → 0.52.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@azure-tools/typespec-ts",
-  "version": "0.52.1",
+  "version": "0.52.2",
   "description": "An experimental TypeSpec emitter for TypeScript RLC",
   "main": "dist/src/index.js",
   "type": "module",
@@ -22,11 +22,11 @@
     "@typespec/spector": "0.1.0-alpha.25-dev.5",
     "@typespec/spec-api": "0.1.0-alpha.14-dev.4",
     "@typespec/tspd": "0.74.1",
-    "@azure-tools/azure-http-specs": "0.1.0-alpha.40-dev.0",
+    "@azure-tools/azure-http-specs": "0.1.0-alpha.40-dev.4",
     "@azure-tools/typespec-autorest": "^0.67.0",
     "@azure-tools/typespec-azure-core": "^0.67.0",
-    "@azure-tools/typespec-azure-resource-manager": "^0.67.0",
-    "@azure-tools/typespec-client-generator-core": "^0.67.1",
+    "@azure-tools/typespec-azure-resource-manager": "^0.67.1",
+    "@azure-tools/typespec-client-generator-core": "^0.67.2",
     "@azure/abort-controller": "^2.1.2",
     "@azure/core-auth": "^1.6.0",
     "@azure/core-lro": "^3.1.0",
@@ -64,7 +64,7 @@
   },
   "peerDependencies": {
     "@azure-tools/typespec-azure-core": "^0.67.0",
-    "@azure-tools/typespec-client-generator-core": "^0.67.1",
+    "@azure-tools/typespec-client-generator-core": "^0.67.2",
     "@typespec/compiler": "^1.11.0",
     "@typespec/http": "^1.11.0",
     "@typespec/rest": "^0.81.0",
@@ -72,7 +72,7 @@
     "@typespec/xml": "^0.81.0"
   },
   "dependencies": {
-    "@azure-tools/rlc-common": "^0.52.1",
+    "@azure-tools/rlc-common": "^0.52.2",
     "fast-xml-parser": "^4.5.0",
     "fs-extra": "^11.1.0",
     "lodash": "^4.17.21",

package/src/modular/emitModels.ts

@@ -33,6 +33,7 @@ import {
   isReadOnly,
   listAllServiceNamespaces
 } from "@azure-tools/typespec-client-generator-core";
+// import { isKey } from "@typespec/compiler";
 import {
   getExternalModel,
   getModelExpression,
@@ -59,7 +60,7 @@ import {
 import path from "path";
 import { refkey } from "../framework/refkey.js";
 import { useContext } from "../contextManager.js";
-import { isMetadata, isOrExtendsHttpFile } from "@typespec/http";
+import { isMetadata, isOrExtendsHttpFile, Visibility } from "@typespec/http";
 import { isAzureCoreErrorType } from "../utils/modelUtils.js";
 import { getHeaderClientOptions } from "./helpers/clientOptionHelpers.js";
 import { isExtensibleEnum } from "./type-expressions/get-enum-expression.js";
@@ -736,7 +737,6 @@ function buildModelInterface(
   // properties (@header, @query, @path) since they are deserialized separately.
   // For input models, keep metadata properties — users need to pass them.
   const hasInputUsage = (type.usage & UsageFlags.Input) === UsageFlags.Input;
-  const isArmResource = isArmResourceModel(type);
   const interfaceStructure = {
     kind: StructureKind.Interface,
     name: normalizeModelName(context, type, NameType.Interface, true),
@@ -746,14 +746,13 @@ function buildModelInterface(
         if (!hasInputUsage && p.__raw && isMetadata(context.program, p.__raw)) {
           return false;
         }
-        // Skip the "name" metadata property on ARM resource models.
-        // ARM resource "name" is a @path property inherited from the base Resource type
-        // and is handled by the ARM infrastructure, not set by the user directly.
+        // Skip required metadata properties with Read visibility for ARM as they are not intended to be in the model
+        // These properties are not be generated no matter they are in input or output models in most cases in HLC
         if (
-          isArmResource &&
-          p.name === "name" &&
+          context.arm &&
           p.__raw &&
-          isMetadata(context.program, p.__raw)
+          isMetadata(context.program, p.__raw) &&
+          p.visibility?.includes(Visibility.Read)
         ) {
           return false;
         }
@@ -950,20 +949,6 @@ export function normalizeModelName(
   return `${internalModelPrefix}${normalizeName(namespacePrefix + type.name, nameType, true)}${unionSuffix}`;
 }
 
-/**
- * Checks if a model descends from the ARM common-types Resource base type
- * (TrackedResource, ProxyResource, etc.) by walking the ancestor chain.
- */
-function isArmResourceModel(type: SdkModelType): boolean {
-  const ancestors = getAllAncestors(type);
-  return ancestors.some(
-    (ancestor) =>
-      ancestor.kind === "model" &&
-      ancestor.crossLanguageDefinitionId ===
-        "Azure.ResourceManager.CommonTypes.Resource"
-  );
-}
-
 function buildModelPolymorphicType(context: SdkContext, type: SdkModelType) {
   // Only include direct subtypes in this union
   const directSubtypes = getDirectSubtypes(type);