@azure-tools/typespec-ts 0.45.1 → 0.46.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@azure-tools/typespec-ts",
-  "version": "0.45.1",
+  "version": "0.46.0",
   "description": "An experimental TypeSpec emitter for TypeScript RLC",
   "main": "dist/src/index.js",
   "type": "module",
@@ -18,11 +18,11 @@
   "license": "MIT",
   "devDependencies": {
     "@azure-rest/core-client": "^2.3.1",
-    "@typespec/http-specs": "0.1.0-alpha.28-dev.0",
+    "@typespec/http-specs": "0.1.0-alpha.28-dev.1",
     "@typespec/spector": "0.1.0-alpha.20-dev.0",
     "@typespec/spec-api": "0.1.0-alpha.10-dev.0",
     "@typespec/tspd": "0.73.0",
-    "@azure-tools/azure-http-specs": "0.1.0-alpha.31-dev.0",
+    "@azure-tools/azure-http-specs": "0.1.0-alpha.32-dev.2",
     "@azure-tools/typespec-autorest": "^0.61.0",
     "@azure-tools/typespec-azure-core": "^0.61.0",
     "@azure-tools/typespec-azure-resource-manager": "^0.61.0",
@@ -77,7 +77,7 @@
     "@typespec/xml": "^0.75.0"
   },
   "dependencies": {
-    "@azure-tools/rlc-common": "^0.45.1",
+    "@azure-tools/rlc-common": "^0.46.0",
     "fs-extra": "^11.1.0",
     "lodash": "^4.17.21",
     "prettier": "^3.3.3",

package/src/framework/hooks/binder.ts

@@ -303,7 +303,7 @@ class BinderImp implements Binder {
   }
 
   private cleanUnreferencedHelpers(sourceRoot: string) {
-    const usedHelperFiles = new Set<SourceFile>();
+    const usedHelperNames: string[] = [];
     for (const helper of this.staticHelpers.values()) {
       const sourceFile = helper[SourceFileSymbol];
       if (!sourceFile) {
@@ -315,16 +315,24 @@ class BinderImp implements Binder {
       const referencedHelper = this.references.get(refkey(helper));
 
       if (referencedHelper?.size) {
-        usedHelperFiles.add(sourceFile);
+        usedHelperNames.push(sourceFile.getBaseNameWithoutExtension());
       }
     }
 
+    function isFileUnused(file: SourceFile) {
+      const name = file.getBaseNameWithoutExtension();
+
+      // If one of the used helpers' name is a prefix of this file, the file likely represents a platform-specific implementation of the helper
+      // so it should be marked as used even if the file has no direct references.
+      return !usedHelperNames.some((s) => name.startsWith(s));
+    }
+
     this.project
       //normalizae the final path to adapt to different systems
       .getSourceFiles(
-        normalizePath(path.join(sourceRoot, "static-helpers/**/*.ts"))
+        normalizePath(path.join(sourceRoot, "static-helpers/**/*.*ts"))
       )
-      .filter((helperFile) => !usedHelperFiles.has(helperFile))
+      .filter(isFileUnused)
       .forEach((helperFile) => helperFile.delete());
   }
 }

package/src/framework/load-static-helpers.ts

@@ -13,6 +13,8 @@ import { refkey } from "./refkey.js";
 import { resolveProjectRoot } from "../utils/resolve-project-root.js";
 import { isAzurePackage } from "@azure-tools/rlc-common";
 import { ModularEmitterOptions } from "../modular/interfaces.js";
+import { NoTarget, Program } from "@typespec/compiler";
+import { reportDiagnostic } from "../lib.js";
 export const SourceFileSymbol = Symbol("SourceFile");
 export interface StaticHelperMetadata {
   name: string;
@@ -41,6 +43,7 @@ export interface LoadStaticHelpersOptions
   extends Partial<ModularEmitterOptions> {
   helpersAssetDirectory?: string;
   sourcesDir?: string;
+  program?: Program;
 }
 
 export async function loadStaticHelpers(
@@ -55,7 +58,8 @@ export async function loadStaticHelpers(
     DEFAULT_STATIC_HELPERS_PATH
   );
   const files = await traverseDirectory(
-    options.helpersAssetDirectory ?? defaultStaticHelpersPath
+    options.helpersAssetDirectory ?? defaultStaticHelpersPath,
+    options.program
   );
 
   for (const file of files) {
@@ -161,6 +165,7 @@ function getDeclarationByMetadata(
 const _targetStaticHelpersBaseDir = "static-helpers";
 async function traverseDirectory(
   directory: string,
+  program?: Program,
   result: { source: string; target: string }[] = [],
   relativePath: string = ""
 ): Promise<{ source: string; target: string }[]> {
@@ -175,13 +180,14 @@ async function traverseDirectory(
         if (fileStat.isDirectory()) {
           await traverseDirectory(
             filePath,
+            program,
             result,
             path.join(relativePath, file)
           );
         } else if (
           fileStat.isFile() &&
           !file.endsWith(".d.ts") &&
-          file.endsWith(".ts")
+          /.*\..?ts$/.test(file)
         ) {
           const target = path.join(
             _targetStaticHelpersBaseDir,
@@ -195,7 +201,13 @@ async function traverseDirectory(
 
     return result;
   } catch (error) {
-    console.error(`Error traversing directory ${directory}:`, error);
+    if (program) {
+      reportDiagnostic(program, {
+        code: "directory-traversal-error",
+        format: { directory, error: String(error) },
+        target: NoTarget
+      });
+    }
     throw error;
   }
 }

package/src/framework/sample.ts

@@ -69,12 +69,6 @@ sourceFile2.addStatements(`let obj: ${modelReference} = { id: 1 };`);
 // Apply imports to ensure correct references
 binder.resolveAllReferences("/modularPackageFolder/src");
 
-// Output the generated files
-console.log("// test.ts");
-console.log(sourceFile.getFullText());
-console.log("// test2.ts");
-console.log(sourceFile2.getFullText());
-
 // Output
 // test.ts
 // interface MyInterface {

package/src/index.ts

@@ -8,6 +8,7 @@ import {
   AzurePollingDependencies,
   DefaultCoreDependencies
 } from "./modular/external-dependencies.js";
+import { clearDirectory } from "./utils/fileSystemUtils.js";
 import { EmitContext, Program } from "@typespec/compiler";
 import { GenerationDirDetail, SdkContext } from "./utils/interfaces.js";
 import {
@@ -43,7 +44,9 @@ import {
   buildTopLevelIndex,
   buildTsConfig,
   buildTsSnippetsConfig,
-  buildTsTestBrowserConfig,
+  buildTestBrowserTsConfig,
+  buildTestNodeTsConfig,
+  buildTestMainTsConfig,
   buildVitestConfig,
   getClientName,
   hasUnexpectedHelper,
@@ -52,8 +55,7 @@ import {
   buildSampleEnvFile,
   buildSnippets,
   buildTsSrcConfig,
-  buildTsSampleConfig,
-  buildTsTestConfig
+  buildTsSampleConfig
 } from "@azure-tools/rlc-common";
 import {
   buildRootIndex,
@@ -98,7 +100,6 @@ import { generateCrossLanguageDefinitionFile } from "./utils/crossLanguageDef.js
 export * from "./lib.js";
 
 export async function $onEmit(context: EmitContext) {
-  console.time("onEmit");
   if (context.program.compilerOptions.noEmit || context.program.hasError()) {
     return;
   }
@@ -106,9 +107,7 @@ export async function $onEmit(context: EmitContext) {
   const outputProject = new Project();
   const program: Program = context.program;
   const emitterOptions: EmitterOptions = context.options;
-  console.time("onEmit: create context");
   const dpgContext = await createContextWithDefaultOptions(context);
-  console.timeEnd("onEmit: create context");
   // Enrich the dpg context with path detail and common options
   await enrichDpgContext();
   const rlcOptions = dpgContext.rlcOptions ?? {};
@@ -125,7 +124,6 @@ export async function $onEmit(context: EmitContext) {
     compilerContext: context,
     tcgcContext: dpgContext
   });
-  console.time("onEmit: load static helpers");
   const staticHelpers = await loadStaticHelpers(
     outputProject,
     {
@@ -138,10 +136,10 @@ export async function $onEmit(context: EmitContext) {
     },
     {
       sourcesDir: dpgContext.generationPathDetail?.modularSourcesDir,
-      options: rlcOptions
+      options: rlcOptions,
+      program
     }
   );
-  console.timeEnd("onEmit: load static helpers");
   const extraDependencies = isAzurePackage({ options: rlcOptions })
     ? {
         ...AzurePollingDependencies,
@@ -149,7 +147,6 @@ export async function $onEmit(context: EmitContext) {
         ...AzureIdentityDependencies
       }
     : { ...DefaultCoreDependencies };
-  console.time("onEmit: provide binder");
   const binder = provideBinder(outputProject, {
     staticHelpers,
     dependencies: {
@@ -157,7 +154,6 @@ export async function $onEmit(context: EmitContext) {
     }
   });
   provideSdkTypes(dpgContext);
-  console.timeEnd("onEmit: provide binder");
 
   const rlcCodeModels: RLCModel[] = [];
   let modularEmitterOptions: ModularEmitterOptions;
@@ -165,9 +161,7 @@ export async function $onEmit(context: EmitContext) {
   await clearSrcFolder();
   // 2. Generate RLC code model
   // TODO: skip this step in modular once modular generator is sufficiently decoupled
-  console.time("onEmit: build RLC code models");
   await buildRLCCodeModels();
-  console.timeEnd("onEmit: build RLC code models");
 
   // 4. Generate sources
   if (emitterOptions["is-modular-library"]) {
@@ -195,7 +189,12 @@ export async function $onEmit(context: EmitContext) {
     emitterOptions["generate-sample"] = options.generateSample;
     // clear output folder if needed
     if (options.clearOutputFolder) {
-      await fsextra.emptyDir(context.emitterOutputDir);
+      // Clear output directory while preserving TempTypeSpecFiles
+      await clearDirectory(
+        context.emitterOutputDir,
+        ["TempTypeSpecFiles"],
+        program
+      );
     }
     const hasTestFolder = await fsextra.pathExists(
       join(dpgContext.generationPathDetail?.metadataDir ?? "", "test")
@@ -274,7 +273,6 @@ export async function $onEmit(context: EmitContext) {
   }
 
   async function generateModularSources() {
-    console.time("onEmit: generate modular sources");
     const modularSourcesRoot =
       dpgContext.generationPathDetail?.modularSourcesDir ?? "src";
     const project = useContext("outputProject");
@@ -297,13 +295,10 @@ export async function $onEmit(context: EmitContext) {
     );
 
     const isMultiClients = dpgContext.sdkPackage.clients.length > 1;
-    console.time("onEmit: emit models");
     emitTypes(dpgContext, { sourceRoot: modularSourcesRoot });
-    console.timeEnd("onEmit: emit models");
     buildSubpathIndexFile(modularEmitterOptions, "models", undefined, {
       recursive: true
     });
-    console.time("onEmit: emit source files");
     const clientMap = getClientHierarchyMap(dpgContext);
     if (clientMap.length === 0) {
       // If no clients, we still need to build the root index file
@@ -343,12 +338,9 @@ export async function $onEmit(context: EmitContext) {
         subClient
       );
     }
-    console.timeEnd("onEmit: emit source files");
     // Enable modular sample generation when explicitly set to true or MPG
     if (emitterOptions["generate-sample"] === true) {
-      console.time("onEmit: emit samples");
       const samples = emitSamples(dpgContext);
-      console.timeEnd("onEmit: emit samples");
       // Refine the rlc sample generation logic
       // TODO: remember to remove this out when RLC is splitted from Modular
       if (samples.length > 0) {
@@ -356,14 +348,10 @@ export async function $onEmit(context: EmitContext) {
       }
     }
 
-    console.time("onEmit: resolve references");
     binder.resolveAllReferences(modularSourcesRoot);
     if (program.compilerOptions.noEmit || program.hasError()) {
       return;
     }
-    console.timeEnd("onEmit: resolve references");
-
-    console.time("onEmit: generate files");
 
     for (const file of project.getSourceFiles()) {
       await emitContentByBuilder(
@@ -372,8 +360,6 @@ export async function $onEmit(context: EmitContext) {
         modularEmitterOptions as any
       );
     }
-    console.timeEnd("onEmit: generate files");
-    console.timeEnd("onEmit: generate modular sources");
   }
 
   interface Metadata {
@@ -456,7 +442,9 @@ export async function $onEmit(context: EmitContext) {
         commonBuilders.push((model) => buildVitestConfig(model, "node"));
         commonBuilders.push((model) => buildVitestConfig(model, "esm"));
         commonBuilders.push((model) => buildVitestConfig(model, "browser"));
-        commonBuilders.push((model) => buildTsTestBrowserConfig(model));
+        commonBuilders.push((model) => buildTestBrowserTsConfig(model));
+        commonBuilders.push((model) => buildTestNodeTsConfig(model));
+        commonBuilders.push((model) => buildTestMainTsConfig(model));
       }
       if (isAzureFlavor) {
         commonBuilders.push(buildEsLintConfig);
@@ -488,9 +476,6 @@ export async function $onEmit(context: EmitContext) {
         if (option.generateSample) {
           commonBuilders.push(buildTsSampleConfig);
         }
-        if (option.generateTest) {
-          commonBuilders.push(buildTsTestConfig);
-        }
       }
 
       // TODO: need support snippets generation for multi-client cases. https://github.com/Azure/autorest.typescript/issues/3048
@@ -558,7 +543,6 @@ export async function $onEmit(context: EmitContext) {
       .map((subClient) => getClientContextPath(subClient, options))
       .map((path) => path.substring(path.indexOf("src")));
   }
-  console.timeEnd("onEmit");
 }
 
 export async function createContextWithDefaultOptions(

package/src/lib.ts

@@ -582,6 +582,12 @@ const libDef = {
       messages: {
         default: paramMessage`Failed to format file: ${"filePath"}. Error: ${"error"}.`
       }
+    },
+    "directory-traversal-error": {
+      severity: "error",
+      messages: {
+        default: paramMessage`Error traversing directory ${"directory"}: ${"error"}`
+      }
     }
   },
   emitter: {

package/src/modular/buildRestorePoller.ts

@@ -126,8 +126,7 @@ export function buildRestorePoller(
     }
     
     interface DeserializationHelper {
-      // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
-      deserializer: Function;
+      deserializer: (result: PathUncheckedResponse) => Promise<any>;
       expectedStatuses: string[];
     }
 

package/src/modular/emitModels.ts

@@ -112,6 +112,13 @@ export function emitTypes(
     sourceFile = outputProject.getSourceFile(filepath);
     if (!sourceFile) {
       sourceFile = outputProject.createSourceFile(filepath);
+      sourceFile.addStatements(
+        `/**
+* This file contains only generated model types and (de)serializers.
+* Disable this rule for deserializer functions which require 'any' for raw JSON input.
+*/
+/* eslint-disable @typescript-eslint/explicit-module-boundary-types */`
+      );
     }
     emitType(context, type, sourceFile);
   }

package/src/modular/emitSamples.ts

@@ -37,6 +37,8 @@ import {
   ServiceOperation
 } from "../utils/operationUtil.js";
 import { getSubscriptionId } from "../transform/transfromRLCOptions.js";
+import { getClientParametersDeclaration } from "./helpers/clientHelpers.js";
+import { getOperationFunction } from "./helpers/operationHelpers.js";
 
 /**
  * Interfaces for samples generations
@@ -53,6 +55,7 @@ interface EmitSampleOptions {
   generatedFiles: SourceFile[];
   classicalMethodPrefix?: string;
   subFolder?: string;
+  hierarchies?: string[]; // Add hierarchies to track operation path
 }
 /**
  * Helpers to emit samples
@@ -80,8 +83,8 @@ function emitClientSamples(
 ) {
   const methodMap = getMethodHierarchiesMap(dpgContext, client);
   for (const [prefixKey, operations] of methodMap) {
-    const prefix = prefixKey
-      .split("/")
+    const hierarchies = prefixKey ? prefixKey.split("/") : [];
+    const prefix = hierarchies
       .map((name) => {
         return normalizeName(name, NameType.Property);
       })
@@ -89,7 +92,8 @@ function emitClientSamples(
     for (const op of operations) {
       emitMethodSamples(dpgContext, op, {
         ...options,
-        classicalMethodPrefix: prefix
+        classicalMethodPrefix: prefix,
+        hierarchies: hierarchies
       });
     }
   }
@@ -173,10 +177,35 @@ function emitMethodSamples(
     );
 
     // prepare operation-level parameters
+    // Get the actual function signature parameter order
+    const operationFunction = getOperationFunction(
+      dpgContext,
+      [options.hierarchies ?? [], method],
+      "Client"
+    );
+
+    // Extract parameter names from the function signature (excluding context and options)
+    const signatureParamNames =
+      operationFunction.parameters
+        ?.filter(
+          (p) =>
+            p.name !== "context" &&
+            !p.type?.toString().includes("OptionalParams")
+        )
+        .map((p) => p.name) ?? [];
+
     const methodParamValues = parameters.filter((p) => !p.onClient);
-    const methodParams = methodParamValues
-      .filter((p) => !p.isOptional)
-      .map((p) => `${p.value}`);
+
+    // Create a map for quick lookup of parameter values by name
+    const paramValueMap = new Map(methodParamValues.map((p) => [p.name, p]));
+
+    // Reorder methodParamValues according to the signature order
+    const orderedRequiredParams = signatureParamNames
+      .map((name) => paramValueMap.get(name))
+      .filter((p): p is ExampleValue => p !== undefined && !p.isOptional);
+
+    const methodParams = orderedRequiredParams.map((p) => `${p.value}`);
+
     const optionalParams = methodParamValues
       .filter((p) => p.isOptional)
       .map((param) => `${param.name}: ${param.value}`);
@@ -265,6 +294,31 @@ function prepareExampleParameters(
   // TODO: blocked by TCGC issue: https://github.com/Azure/typespec-azure/issues/1419
   // refine this to support generic client-level parameters once resolved
   const result: ExampleValue[] = [];
+  const clientParams = getClientParametersDeclaration(
+    topLevelClient,
+    dpgContext,
+    {
+      onClientOnly: true
+    }
+  );
+
+  for (const param of clientParams) {
+    if (param.name === "options" || param.name === "credential") {
+      continue;
+    }
+
+    const exampleValue: ExampleValue = {
+      name: param.name === "endpointParam" ? "endpoint" : param.name,
+      value: getEnvironmentVariableName(
+        param.name,
+        getClassicalClientName(topLevelClient)
+      ),
+      isOptional: Boolean(param.hasQuestionToken),
+      onClient: true
+    };
+
+    result.push(exampleValue);
+  }
   const credentialExampleValue = getCredentialExampleValue(
     dpgContext,
     topLevelClient.clientInitialization
@@ -513,3 +567,30 @@ function escapeSpecialCharToSpace(str: string) {
   }
   return str.replace(/_|,|\.|\(|\)|'s |\[|\]/g, " ").replace(/\//g, " Or ");
 }
+
+function getEnvironmentVariableName(
+  paramName: string,
+  clientName?: string
+): string {
+  // Remove "Param" suffix if present
+  const cleanName = paramName.replace(/Param$/, "");
+
+  // Remove "Client" suffix from client name if present and convert to UPPER_SNAKE_CASE
+  let prefix = "";
+  if (clientName) {
+    const cleanClientName = clientName.replace(/Client$/, "");
+    prefix =
+      cleanClientName
+        .replace(/([A-Z])/g, "_$1")
+        .toUpperCase()
+        .replace(/^_/, "") + "_";
+  }
+
+  // Convert camelCase to UPPER_SNAKE_CASE
+  const envVarName = cleanName
+    .replace(/([A-Z])/g, "_$1")
+    .toUpperCase()
+    .replace(/^_/, "");
+
+  return `process.env.${prefix}${envVarName} || ""`;
+}

package/src/modular/external-dependencies.ts

@@ -85,6 +85,11 @@ export const DefaultCoreDependencies: CoreDependencies = {
     kind: "externalDependency",
     name: "ErrorModel",
     module: "@typespec/ts-http-runtime"
+  },
+  AzureCoreErrorResponse: {
+    kind: "externalDependency",
+    name: "ErrorResponse",
+    module: "@azure-rest/core-client"
   }
 } as const;
 
@@ -196,6 +201,11 @@ export const AzureCoreDependencies: CoreDependencies = {
     kind: "externalDependency",
     name: "ErrorModel",
     module: "@azure-rest/core-client"
+  },
+  AzureCoreErrorResponse: {
+    kind: "externalDependency",
+    name: "ErrorResponse",
+    module: "@azure-rest/core-client"
   }
 };
 

package/src/modular/helpers/clientHelpers.ts

@@ -73,14 +73,15 @@ export function getClientParameters(
   const hasDefaultValue = (p: SdkParameter) =>
     p.clientDefaultValue || p.__raw?.defaultValue || p.type.kind === "constant";
   const isRequired = (p: SdkParameter) =>
-    !p.optional &&
-    ((!hasDefaultValue(p) &&
+    // Special case: when apiVersionAsRequired is true, apiVersion should always be considered required
+    (options.apiVersionAsRequired && p.isApiVersionParam) ||
+    (!p.optional &&
+      !hasDefaultValue(p) &&
       !(
         p.type.kind === "endpoint" &&
         p.type.templateArguments[0] &&
         hasDefaultValue(p.type.templateArguments[0])
-      )) ||
-      (options.apiVersionAsRequired && p.isApiVersionParam));
+      ));
   const isOptional = (p: SdkParameter) => p.optional || hasDefaultValue(p);
   const skipCredentials = (p: SdkParameter) => p.kind !== "credential";
   const skipMethodParam = (p: SdkParameter) => p.kind !== "method";
@@ -98,7 +99,6 @@ export function getClientParameters(
   const params = clientParams.filter((p) =>
     filters.every((filter) => !filter || filter(p))
   );
-
   return params;
 }
 

package/src/modular/helpers/operationHelpers.ts

@@ -8,6 +8,7 @@ import { NoTarget, Program } from "@typespec/compiler";
 import {
   PagingHelpers,
   PollingHelpers,
+  SerializationHelpers,
   UrlTemplateHelpers
 } from "../static-helpers-metadata.js";
 import {
@@ -472,11 +473,18 @@ export function getOperationFunction(
   };
 
   const statements: string[] = [];
-  statements.push(
-    `const result = await _${name}Send(${parameters
-      .map((p) => p.name)
-      .join(", ")});`
-  );
+
+  const parameterList = parameters.map((p) => p.name).join(", ");
+  // Special case for binary-only bodies: use helper to call streaming methods so that Core doesn't poison the response body by
+  // doing a UTF-8 decode on the raw bytes.
+  if (response?.type?.kind === "bytes" && response.type.encode === "bytes") {
+    statements.push(`const streamableMethod = _${name}Send(${parameterList});`);
+    statements.push(
+      `const result = await ${resolveReference(SerializationHelpers.getBinaryResponse)}(streamableMethod);`
+    );
+  } else {
+    statements.push(`const result = await _${name}Send(${parameterList});`);
+  }
   statements.push(`return _${name}Deserialize(result);`);
 
   return {
@@ -703,10 +711,16 @@ function getHeaderAndBodyParameters(
       ) {
         continue;
       }
-      parametersImplementation[param.kind].push({
-        paramMap: getParameterMap(dpgContext, param, optionalParamName),
-        param
-      });
+      // Check if this parameter still exists in the corresponding method params (after override)
+      if (
+        param.correspondingMethodParams &&
+        param.correspondingMethodParams.length > 0
+      ) {
+        parametersImplementation[param.kind].push({
+          paramMap: getParameterMap(dpgContext, param, optionalParamName),
+          param
+        });
+      }
     }
   }
 
@@ -1571,7 +1585,7 @@ export function getExpectedStatuses(operation: ServiceOperation): string {
   let statusCodes = operation.operation.responses.map((x) => x.statusCodes);
   // LROs may call the same path but with GET to get the operation status.
   if (isLroOnlyOperation(operation) && operation.operation.verb !== "get") {
-    statusCodes = Array.from(new Set([...statusCodes, 200, 202]));
+    statusCodes = Array.from(new Set([...statusCodes, 200, 201, 202]));
   }
 
   return `[${statusCodes.map((x) => `"${x}"`).join(", ")}]`;

package/src/modular/serialization/buildSerializerFunction.ts

@@ -473,7 +473,7 @@ function getAdditionalPropertiesStatement(
     false,
     true
   );
-  const params = [`item.${getAdditionalPropertiesName(context, type)}`];
+  const params = [`item.${getAdditionalPropertiesName(context, type)} ?? {}`];
   if (typeof deserializerFunction === "string") {
     params.push("undefined");
     params.push(deserializerFunction);

package/src/modular/static-helpers-metadata.ts

@@ -28,6 +28,11 @@ export const SerializationHelpers = {
     kind: "function",
     name: "serializeRecord",
     location: "serialization/serialize-record.ts"
+  },
+  getBinaryResponse: {
+    kind: "function",
+    name: "getBinaryResponse",
+    location: "serialization/get-binary-response.ts"
   }
 } as const;
 

package/src/modular/type-expressions/get-model-expression.ts

@@ -48,7 +48,8 @@ export function getModelExpression(
 }
 
 const externalModels: Record<string, string> = {
-  "Azure.Core.Foundations.Error": "ErrorModel"
+  "Azure.Core.Foundations.Error": "ErrorModel",
+  "Azure.Core.Foundations.ErrorResponse": "AzureCoreErrorResponse"
 };
 
 export function getExternalModel(type: SdkModelType) {

package/src/utils/emitUtil.ts

@@ -91,7 +91,6 @@ async function emitFile(
         target: NoTarget
       });
       // Continue with unformatted content rather than crashing
-      console.error(`Failed to format file: ${filePath}`, e);
     }
   }
   await host.mkdirp(dirname(filePath));