@azure-tools/typespec-ts 0.12.0-alpha.20230502.1 → 0.13.0

package/test/integration/generated/specialWords/src/specialWordsClient.ts

@@ -2,11 +2,12 @@
 // Licensed under the MIT license.
 
 import { getClient, ClientOptions } from "@azure-rest/core-client";
+import { logger } from "./logger";
 import { SpecialWordsClient } from "./clientDefinitions";
 
 /**
  * Initialize a new instance of `SpecialWordsClient`
- * @param options type: ClientOptions, the parameter for all optional parameters
+ * @param options - the parameter for all optional parameters
  */
 export default function createClient(
   options: ClientOptions = {}
@@ -23,6 +24,9 @@ export default function createClient(
     userAgentOptions: {
       userAgentPrefix,
     },
+    loggingOptions: {
+      logger: options.loggingOptions?.logger ?? logger.info,
+    },
   };
 
   const client = getClient(baseUrl, options) as SpecialWordsClient;

package/test/integration/generated/unions/src/logger.ts

@@ -0,0 +1,5 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+import { createClientLogger } from "@azure/logger";
+export const logger = createClientLogger("unions");

package/test/integration/generated/unions/src/unionsClient.ts

@@ -2,11 +2,12 @@
 // Licensed under the MIT license.
 
 import { getClient, ClientOptions } from "@azure-rest/core-client";
+import { logger } from "./logger";
 import { UnionsClient } from "./clientDefinitions";
 
 /**
  * Initialize a new instance of `UnionsClient`
- * @param options type: ClientOptions, the parameter for all optional parameters
+ * @param options - the parameter for all optional parameters
  */
 export default function createClient(
   options: ClientOptions = {}
@@ -23,6 +24,9 @@ export default function createClient(
     userAgentOptions: {
       userAgentPrefix,
     },
+    loggingOptions: {
+      logger: options.loggingOptions?.logger ?? logger.info,
+    },
   };
 
   const client = getClient(baseUrl, options) as UnionsClient;

package/test/integration/internal.spec.ts

@@ -14,27 +14,60 @@ describe("Internal Rest Client", () => {
     });
   });
 
+  it("should get internal only", async () => {
+    try {
+      const result = await client
+        .path("/azure/client-generator-core/internal/internal")
+        .get({
+          queryParameters: {
+            name: "any"
+          }
+        });
+      assert.strictEqual(result.status, "200");
+    } catch (err) {
+      assert.fail(err as string);
+    }
+  });
+
   it("should get internal", async () => {
     try {
-      const result = await client.path("/azure/client-generator-core/internal/getInternal").get({
-        queryParameters: {
-          name: "get internal"
-        }
-      });
+      const result = await client
+        .path("/azure/client-generator-core/internal/public")
+        .get({
+          queryParameters: {
+            name: "any"
+          }
+        });
+      assert.strictEqual(result.status, "200");
+    } catch (err) {
+      assert.fail(err as string);
+    }
+  });
+
+  it("should get shared public", async () => {
+    try {
+      const result = await client
+        .path("/azure/client-generator-core/internal/shared/public")
+        .get({
+          queryParameters: {
+            name: "any"
+          }
+        });
       assert.strictEqual(result.status, "200");
     } catch (err) {
       assert.fail(err as string);
     }
   });
 
-  it("should post internal", async () => {
+  it("should get shared internal", async () => {
     try {
-      const result = await client.path("/azure/client-generator-core/internal/postInternal").post({
-        body: {
-          id: 1 as any,
-          name: "post internal name"
-        }
-      });
+      const result = await client
+        .path("/azure/client-generator-core/internal/shared/internal")
+        .get({
+          queryParameters: {
+            name: "any"
+          }
+        });
       assert.strictEqual(result.status, "200");
     } catch (err) {
       assert.fail(err as string);

package/test/integration/modelPropertyType.spec.ts

@@ -71,6 +71,22 @@ const testedTypes: TypeDetail[] = [
   {
     type: "never",
     defaultValue: undefined
+  },
+  {
+    type: "unknown/string",
+    defaultValue: "hello"
+  },
+  {
+    type: "unknown/int",
+    defaultValue: 42
+  },
+  {
+    type: "unknown/dict",
+    defaultValue: { k1: "hello", k2: 42 }
+  },
+  {
+    type: "unknown/array",
+    defaultValue: ["hello", "world"]
   }
 ];
 describe("ModelsPropertyTypesClient Rest Client", () => {

package/test/integration/resiliencyDpgCustomization.spec.ts

@@ -6,48 +6,77 @@ import ServiceDrivenNewClientFactory, {
   ServiceDrivenNewClient
 } from "./generated/resiliency/srvDriven2/src/index.js";
 describe("ResiliencyDevDrivenClient Rest Client", () => {
-  let client1: ServiceDrivenOldClient;
+  let client11: ServiceDrivenOldClient;
+  let client12: ServiceDrivenOldClient;
+  let client21: ServiceDrivenNewClient;
+  let client22: ServiceDrivenNewClient;
 
   beforeEach(() => {
-    client1 = ServiceDrivenOldClientFactory("v1", {
-      allowInsecureConnection: true
+    client11 = ServiceDrivenOldClientFactory("v1", {
+      allowInsecureConnection: true,
+      apiVersion: "v1"
     });
-  });
-
-  let client2: ServiceDrivenNewClient;
-
-  beforeEach(() => {
-    client2 = ServiceDrivenNewClientFactory("v2", {
-      allowInsecureConnection: true
+    client12 = ServiceDrivenOldClientFactory("v2", {
+      allowInsecureConnection: true,
+      apiVersion: "v1"
+    });
+    client21 = ServiceDrivenNewClientFactory("v2", {
+      allowInsecureConnection: true,
+      apiVersion: "v1"
+    });
+    client22 = ServiceDrivenNewClientFactory("v2", {
+      allowInsecureConnection: true,
+      apiVersion: "v2"
     });
   });
 
+
   describe("resiliency with service driven", () => {
     it("should work with none parameter", async () => {
-      const result1 = await client1
+      const result11 = await client11
         .path("/add-optional-param/from-none")
         .head();
 
-      assert.equal(result1.status, "204");
-      const result2 = await client2.path("/add-optional-param/from-none").head({
+      assert.equal(result11.status, "204");
+      const result12 = await client12
+      .path("/add-optional-param/from-none")
+      .head();
+
+      assert.equal(result12.status, "204");
+      const result21 = await client21.path("/add-optional-param/from-none").head({
         queryParameters: {
           "new-parameter": "new"
         }
       });
 
-      assert.equal(result2.status, "204");
+      assert.equal(result21.status, "204");
+      const result22 = await client22.path("/add-optional-param/from-none").head({
+        queryParameters: {
+          "new-parameter": "new"
+        }
+      });
+
+      assert.equal(result22.status, "204");
     });
 
     it("should work with one optional parameter", async () => {
-      const result1 = await client1
+      const result11 = await client11
         .path("/add-optional-param/from-one-optional")
         .get({
           queryParameters: {
             parameter: "optional"
           }
         });
-      assert.equal(result1.status, "204");
-      const result2 = await client2
+      assert.equal(result11.status, "204");
+      const result12 = await client12
+      .path("/add-optional-param/from-one-optional")
+      .get({
+        queryParameters: {
+          parameter: "optional"
+        }
+      });
+      assert.equal(result12.status, "204");
+      const result21 = await client21
         .path("/add-optional-param/from-one-optional")
         .get({
           queryParameters: {
@@ -55,19 +84,36 @@ describe("ResiliencyDevDrivenClient Rest Client", () => {
             "new-parameter": "new"
           }
         });
-      assert.equal(result2.status, "204");
+      assert.equal(result21.status, "204");
+      const result22 = await client22
+      .path("/add-optional-param/from-one-optional")
+      .get({
+        queryParameters: {
+          parameter: "optional",
+          "new-parameter": "new"
+        }
+      });
+      assert.equal(result22.status, "204");
     });
 
     it("should work with one required parameter", async () => {
-      const result1 = await client1
+      const result11 = await client11
         .path("/add-optional-param/from-one-required")
         .get({
           queryParameters: {
             parameter: "required"
           }
         });
-      assert.equal(result1.status, "204");
-      const result2 = await client2
+      assert.equal(result11.status, "204");
+      const result12 = await client12
+      .path("/add-optional-param/from-one-required")
+      .get({
+        queryParameters: {
+          parameter: "required"
+        }
+      });
+    assert.equal(result12.status, "204");
+      const result21 = await client21
         .path("/add-optional-param/from-one-required")
         .get({
           queryParameters: {
@@ -75,12 +121,27 @@ describe("ResiliencyDevDrivenClient Rest Client", () => {
             "new-parameter": "new"
           }
         });
-      assert.equal(result2.status, "204");
+      assert.equal(result21.status, "204");
+      const result22 = await client22
+      .path("/add-optional-param/from-one-required")
+      .get({
+        queryParameters: {
+          parameter: "required",
+          "new-parameter": "new"
+        }
+      });
+    assert.equal(result22.status, "204");
     });
   });
 
   it("should work with add operation", async () => {
-    const result2 = await client2.path("/add-operation").delete()
-    assert.equal(result2.status, "204");
+    const client122 = ServiceDrivenOldClientFactory("v2", {
+      allowInsecureConnection: true,
+      apiVersion: "v2"
+    });
+    const result122 = await client122.pathUnchecked("/add-operation").delete();
+    assert.equal(result122.status, "204");
+    const result22 = await client22.path("/add-operation").delete()
+    assert.equal(result22.status, "204");
   });
 });

package/test/unit/apiVersion.spec.ts

@@ -130,12 +130,13 @@ const buildDefaultReturn = (hasDefault: boolean) => {
     : `options.apiVersion = options.apiVersion ?? "2022-05-15-preview";`;
   return `
   import { getClient, ClientOptions } from "@azure-rest/core-client";
+  import { logger } from "./logger";
   import { testClient } from "./clientDefinitions";
   
   /**
    * Initialize a new instance of \`testClient\`
-   * @param endpoint type: string, The endpoint to use.
-   * @param options type: ClientOptions, the parameter for all optional parameters
+   * @param endpoint - The endpoint to use.
+   * @param options - the parameter for all optional parameters
    */
   export default function createClient(
     endpoint: string,
@@ -154,6 +155,9 @@ const buildDefaultReturn = (hasDefault: boolean) => {
       userAgentOptions: {
         userAgentPrefix,
       },
+      loggingOptions: {
+        logger: options.loggingOptions?.logger ?? logger.info
+      },
     };
   
     const client = getClient(baseUrl, options) as testClient;
@@ -165,6 +169,7 @@ const buildDefaultReturn = (hasDefault: boolean) => {
 const buildPathReturn_WithDefault = () => {
   return `
   import { getClient, ClientOptions } from "@azure-rest/core-client";
+  import { logger } from "./logger";
   import { testClient } from "./clientDefinitions";
 
   export interface testClientOptions extends ClientOptions {
@@ -173,8 +178,8 @@ const buildPathReturn_WithDefault = () => {
   
   /**
    * Initialize a new instance of \`testClient\`
-   * @param endpoint type: string, The endpoint to use.
-   * @param options type: testClientOptions, the parameter for all optional parameters
+   * @param endpoint - The endpoint to use.
+   * @param options - the parameter for all optional parameters
    */
   export default function createClient(
     endpoint: string,
@@ -193,6 +198,9 @@ const buildPathReturn_WithDefault = () => {
       userAgentOptions: {
         userAgentPrefix,
       },
+      loggingOptions: {
+        logger: options.loggingOptions?.logger ?? logger.info
+      },
     };
   
     const client = getClient(baseUrl, options) as testClient;
@@ -204,13 +212,14 @@ const buildPathReturn_WithDefault = () => {
 const buildPathReturn_WithoutDefault = () => {
   return `
   import { getClient, ClientOptions } from "@azure-rest/core-client";
+  import { logger } from "./logger";
   import { testClient } from "./clientDefinitions";
   
   /**
    * Initialize a new instance of \`testClient\`
-   * @param endpoint type: string, The endpoint to use.
-   * @param apiVersion type: string, Api Version Possible values: 2022-05-15-preview
-   * @param options type: ClientOptions, the parameter for all optional parameters
+   * @param endpoint - The endpoint to use.
+   * @param apiVersion - Api Version Possible values: 2022-05-15-preview
+   * @param options - the parameter for all optional parameters
    */
   export default function createClient(
     endpoint: string,
@@ -229,6 +238,9 @@ const buildPathReturn_WithoutDefault = () => {
       userAgentOptions: {
         userAgentPrefix,
       },
+      loggingOptions: {
+        logger: options.loggingOptions?.logger ?? logger.info
+      },
     };
   
     const client = getClient(baseUrl, options) as testClient;

package/test/unit/clientFactoryGenerator.spec.ts

@@ -18,11 +18,12 @@ describe("Client Factory generation", () => {
         models!.content,
         `
         import { getClient, ClientOptions } from "@azure-rest/core-client";
+        import { logger } from "./logger";
         import { testClient } from "./clientDefinitions";
         
         /**
          * Initialize a new instance of \`testClient\`
-         * @param options type: ClientOptions, the parameter for all optional parameters
+         * @param options - the parameter for all optional parameters
          */
         export default function createClient(options: ClientOptions = {}): testClient {
         const baseUrl = options.baseUrl ?? \`localhost\`;
@@ -37,6 +38,9 @@ describe("Client Factory generation", () => {
             userAgentOptions: {
             userAgentPrefix,
             },
+            loggingOptions: {
+              logger: options.loggingOptions?.logger ?? logger.info
+            },
         };
         
         const client = getClient(baseUrl, options) as testClient;
@@ -65,12 +69,13 @@ describe("Client Factory generation", () => {
         models!.content,
         `
           import { getClient, ClientOptions } from "@azure-rest/core-client";
+          import { logger } from "./logger";
           import { testClient } from "./clientDefinitions";
 
           /**
            * Initialize a new instance of \`testClient\`
-           * @param endpoint type: string, The endpoint to use.
-           * @param options type: ClientOptions, the parameter for all optional parameters
+           * @param endpoint - The endpoint to use.
+           * @param options - the parameter for all optional parameters
            */
           export default function createClient(
             endpoint: string,
@@ -88,6 +93,9 @@ describe("Client Factory generation", () => {
               userAgentOptions: {
                 userAgentPrefix,
               },
+              loggingOptions: {
+                logger: options.loggingOptions?.logger ?? logger.info
+              },
             };
           
             const client = getClient(baseUrl, options) as testClient;
@@ -129,13 +137,14 @@ describe("Client Factory generation", () => {
         models!.content,
         `
             import { getClient, ClientOptions } from "@azure-rest/core-client";
+            import { logger } from "./logger";
             import { testClient } from "./clientDefinitions";
             
             /**
              * Initialize a new instance of \`testClient\`
-             * @param endpoint type: string, The endpoint to use.
-             * @param version type: "V1"|"V2", The version to use
-             * @param options type: ClientOptions, the parameter for all optional parameters
+             * @param endpoint - The endpoint to use.
+             * @param version - The version to use
+             * @param options - the parameter for all optional parameters
              */
             export default function createClient(
               endpoint: string,
@@ -154,6 +163,9 @@ describe("Client Factory generation", () => {
                 userAgentOptions: {
                   userAgentPrefix,
                 },
+                loggingOptions: {
+                  logger: options.loggingOptions?.logger ?? logger.info
+                },
               };
             
               const client = getClient(baseUrl, options) as testClient;
@@ -191,13 +203,14 @@ describe("Client Factory generation", () => {
         models!.content,
         `
             import { getClient, ClientOptions } from "@azure-rest/core-client";
+            import { logger } from "./logger";
             import { testClient } from "./clientDefinitions";
             
             /**
              * Initialize a new instance of \`testClient\`
-             * @param endpoint type: string, The endpoint to use.
-             * @param version type: string, The version to use. Possible values: v1.1
-             * @param options type: ClientOptions, the parameter for all optional parameters
+             * @param endpoint - The endpoint to use.
+             * @param version - The version to use. Possible values: v1.1
+             * @param options - the parameter for all optional parameters
              */
             export default function createClient(
               endpoint: string,
@@ -216,6 +229,9 @@ describe("Client Factory generation", () => {
                 userAgentOptions: {
                   userAgentPrefix,
                 },
+                loggingOptions: {
+                  logger: options.loggingOptions?.logger ?? logger.info
+                },
               };
             
               const client = getClient(baseUrl, options) as testClient;
@@ -238,12 +254,13 @@ describe("Client Factory generation", () => {
         models!.content,
         `
         import { getClient, ClientOptions } from "@azure-rest/core-client";
+        import { logger } from "./logger";
         import { testClient } from "./clientDefinitions";
         
         /**
          * Initialize a new instance of \`testClient\`
-         * @param endpoint type: string, The parameter endpoint
-         * @param options type: ClientOptions, the parameter for all optional parameters
+         * @param endpoint - The parameter endpoint
+         * @param options - the parameter for all optional parameters
          */
         export default function createClient(endpoint: string, options: ClientOptions = {}): testClient {
         const baseUrl = options.baseUrl ?? \`\${endpoint}\`;
@@ -258,6 +275,9 @@ describe("Client Factory generation", () => {
             userAgentOptions: {
             userAgentPrefix,
             },
+            loggingOptions: {
+              logger: options.loggingOptions?.logger ?? logger.info
+            },
         };
         
         const client = getClient(baseUrl, options) as testClient;
@@ -286,12 +306,13 @@ describe("Client Factory generation", () => {
         models!.content,
         `
         import { getClient, ClientOptions } from "@azure-rest/core-client";
+        import { logger } from "./logger";
         import { testClient } from "./clientDefinitions";
         
         /**
          * Initialize a new instance of \`testClient\`
-         * @param endpoint type: string, The parameter endpoint
-         * @param options type: ClientOptions, the parameter for all optional parameters
+         * @param endpoint - The parameter endpoint
+         * @param options - the parameter for all optional parameters
          */
         export default function createClient(endpoint: string, options: ClientOptions = {}): testClient {
         const baseUrl = options.baseUrl ?? \`\${endpoint}\`;
@@ -306,6 +327,9 @@ describe("Client Factory generation", () => {
             userAgentOptions: {
             userAgentPrefix,
             },
+            loggingOptions: {
+              logger: options.loggingOptions?.logger ?? logger.info
+            },
         };
         
         const client = getClient(baseUrl, options) as testClient;
@@ -333,14 +357,15 @@ describe("Client Factory generation", () => {
         models!.content,
         `
         import { getClient, ClientOptions } from "@azure-rest/core-client";
+        import { logger } from "./logger";
         import { TokenCredential, KeyCredential } from "@azure/core-auth";
         import { testClient } from "./clientDefinitions";
         
         /**
          * Initialize a new instance of \`testClient\`
-         * @param endpoint type: string, The parameter endpoint
-         * @param credentials type: TokenCredential|KeyCredential, uniquely identify client credential
-         * @param options type: ClientOptions, the parameter for all optional parameters
+         * @param endpoint - The parameter endpoint
+         * @param credentials - uniquely identify client credential
+         * @param options - the parameter for all optional parameters
          */
         export default function createClient(endpoint: string, credentials: TokenCredential | KeyCredential, options: ClientOptions = {}): testClient {
         const baseUrl = options.baseUrl ?? \`\${endpoint}\`;
@@ -363,6 +388,9 @@ describe("Client Factory generation", () => {
             userAgentOptions: {
             userAgentPrefix,
             },
+            loggingOptions: {
+              logger: options.loggingOptions?.logger ?? logger.info
+            },
         };
         
         const client = getClient(baseUrl, credentials, options) as testClient;