@aztec/world-state 0.0.1-commit.179ed20 → 0.0.1-commit.189eedb3

package/src/synchronizer/server_world_state_synchronizer.ts

@@ -1,10 +1,11 @@
-import { GENESIS_BLOCK_HEADER_HASH, INITIAL_L2_BLOCK_NUM, INITIAL_L2_CHECKPOINT_NUM } from '@aztec/constants';
-import { BlockNumber } from '@aztec/foundation/branded-types';
+import { INITIAL_CHECKPOINT_NUMBER } from '@aztec/constants';
+import { BlockNumber, CheckpointNumber } from '@aztec/foundation/branded-types';
 import type { Fr } from '@aztec/foundation/curves/bn254';
 import { type Logger, createLogger } from '@aztec/foundation/log';
 import { promiseWithResolvers } from '@aztec/foundation/promise';
 import { elapsed } from '@aztec/foundation/timer';
 import {
+  type BlockHash,
   GENESIS_CHECKPOINT_HEADER_HASH,
   type L2Block,
   type L2BlockId,
@@ -64,7 +65,7 @@ export class ServerWorldStateSynchronizer
     private readonly log: Logger = createLogger('world_state'),
   ) {
     this.merkleTreeCommitted = this.merkleTreeDb.getCommitted();
-    this.historyToKeep = config.worldStateBlockHistory < 1 ? undefined : config.worldStateBlockHistory;
+    this.historyToKeep = config.worldStateCheckpointHistory < 1 ? undefined : config.worldStateCheckpointHistory;
     this.log.info(
       `Created world state synchroniser with block history of ${
         this.historyToKeep === undefined ? 'infinity' : this.historyToKeep
@@ -177,13 +178,10 @@ export class ServerWorldStateSynchronizer
   /**
    * Forces an immediate sync.
    * @param targetBlockNumber - The target block number that we must sync to. Will download unproven blocks if needed to reach it.
-   * @param skipThrowIfTargetNotReached - Whether to skip throwing if the target block number is not reached.
+   * @param blockHash - If provided, verifies the block at targetBlockNumber matches this hash. On mismatch, triggers a resync (reorg detection).
    * @returns A promise that resolves with the block number the world state was synced to
    */
-  public async syncImmediate(
-    targetBlockNumber?: BlockNumber,
-    skipThrowIfTargetNotReached?: boolean,
-  ): Promise<BlockNumber> {
+  public async syncImmediate(targetBlockNumber?: BlockNumber, blockHash?: BlockHash): Promise<BlockNumber> {
     if (this.currentState !== WorldStateRunningState.RUNNING) {
       throw new Error(`World State is not running. Unable to perform sync.`);
     }
@@ -195,7 +193,19 @@ export class ServerWorldStateSynchronizer
     // If we have been given a block number to sync to and we have reached that number then return
     const currentBlockNumber = await this.getLatestBlockNumber();
     if (targetBlockNumber !== undefined && targetBlockNumber <= currentBlockNumber) {
-      return currentBlockNumber;
+      if (blockHash === undefined) {
+        return currentBlockNumber;
+      }
+
+      // If a block hash was provided, verify we're on the expected fork
+      const currentHash = await this.getL2BlockHash(targetBlockNumber);
+      if (currentHash === blockHash.toString()) {
+        return currentBlockNumber;
+      }
+      // Hash mismatch: a reorg may have occurred, fall through to trigger sync
+      this.log.debug(
+        `World state block hash mismatch at ${targetBlockNumber} (expected ${blockHash}, got ${currentHash}). Triggering resync.`,
+      );
     }
     this.log.debug(`World State at ${currentBlockNumber} told to sync to ${targetBlockNumber ?? 'latest'}`);
 
@@ -213,7 +223,7 @@ export class ServerWorldStateSynchronizer
 
     // If we have been given a block number to sync to and we have not reached that number then fail
     const updatedBlockNumber = await this.getLatestBlockNumber();
-    if (!skipThrowIfTargetNotReached && targetBlockNumber !== undefined && targetBlockNumber > updatedBlockNumber) {
+    if (targetBlockNumber !== undefined && targetBlockNumber > updatedBlockNumber) {
       throw new WorldStateSynchronizerError(
         `Unable to sync to block number ${targetBlockNumber} (last synced is ${updatedBlockNumber})`,
         {
@@ -227,6 +237,24 @@ export class ServerWorldStateSynchronizer
       );
     }
 
+    // If a block hash was provided, verify we're on the expected fork after syncing, throw otherwise
+    if (blockHash !== undefined && targetBlockNumber !== undefined) {
+      const updatedHash = await this.getL2BlockHash(targetBlockNumber);
+      if (updatedHash !== blockHash.toString()) {
+        throw new WorldStateSynchronizerError(
+          `Block hash mismatch at block ${targetBlockNumber} (expected ${blockHash} but got ${updatedHash})`,
+          {
+            cause: {
+              reason: 'block_hash_mismatch',
+              targetBlockNumber,
+              expectedHash: blockHash.toString(),
+              actualHash: updatedHash,
+            },
+          },
+        );
+      }
+    }
+
     return updatedBlockNumber;
   }
 
@@ -259,19 +287,24 @@ export class ServerWorldStateSynchronizer
     // but we use a block stream so we need to provide 'local' L2Tips.
     // We configure the block stream to ignore checkpoints and set checkpoint values to genesis here.
     const genesisCheckpointHeaderHash = GENESIS_CHECKPOINT_HEADER_HASH.toString();
+    const initialBlockHash = (await this.merkleTreeCommitted.getInitialHeader().hash()).toString();
     return {
       proposed: latestBlockId,
       checkpointed: {
-        block: { number: INITIAL_L2_BLOCK_NUM, hash: GENESIS_BLOCK_HEADER_HASH.toString() },
-        checkpoint: { number: INITIAL_L2_CHECKPOINT_NUM, hash: genesisCheckpointHeaderHash },
+        block: { number: BlockNumber.ZERO, hash: initialBlockHash },
+        checkpoint: { number: INITIAL_CHECKPOINT_NUMBER, hash: genesisCheckpointHeaderHash },
+      },
+      proposedCheckpoint: {
+        block: { number: BlockNumber.ZERO, hash: initialBlockHash },
+        checkpoint: { number: INITIAL_CHECKPOINT_NUMBER, hash: genesisCheckpointHeaderHash },
       },
       finalized: {
         block: { number: status.finalizedBlockNumber, hash: finalizedBlockHash ?? '' },
-        checkpoint: { number: INITIAL_L2_CHECKPOINT_NUM, hash: genesisCheckpointHeaderHash },
+        checkpoint: { number: INITIAL_CHECKPOINT_NUMBER, hash: genesisCheckpointHeaderHash },
       },
       proven: {
         block: { number: provenBlockNumber, hash: provenBlockHash ?? '' },
-        checkpoint: { number: INITIAL_L2_CHECKPOINT_NUM, hash: genesisCheckpointHeaderHash },
+        checkpoint: { number: INITIAL_CHECKPOINT_NUMBER, hash: genesisCheckpointHeaderHash },
       },
     };
   }
@@ -360,16 +393,56 @@ export class ServerWorldStateSynchronizer
 
   private async handleChainFinalized(blockNumber: BlockNumber) {
     this.log.verbose(`Finalized chain is now at block ${blockNumber}`);
+    // If the finalized block number is older than the oldest available block in world state,
+    // skip entirely. The finalized block number can jump backwards (e.g. when the finalization
+    // heuristic changes) and try to read block data that has already been pruned. When this
+    // happens, there is nothing useful to do — the native world state is already finalized
+    // past this point and pruning has already happened.
+    const currentSummary = await this.merkleTreeDb.getStatusSummary();
+    if (blockNumber < currentSummary.oldestHistoricalBlock || blockNumber < 1) {
+      this.log.trace(
+        `Finalized block ${blockNumber} is older than the oldest available block ${currentSummary.oldestHistoricalBlock}. Skipping.`,
+      );
+      return;
+    }
     const summary = await this.merkleTreeDb.setFinalized(blockNumber);
     if (this.historyToKeep === undefined) {
       return;
     }
-    const newHistoricBlock = summary.finalizedBlockNumber - this.historyToKeep + 1;
-    if (newHistoricBlock <= 1) {
+    const finalisedBlockData = await this.l2BlockSource.getBlockData({ number: summary.finalizedBlockNumber });
+    if (finalisedBlockData === undefined) {
+      this.log.warn(
+        `Failed to retrieve checkpointed block for finalized block number: ${summary.finalizedBlockNumber}`,
+      );
+      return;
+    }
+    // Compute the required historic checkpoint number
+    const newHistoricCheckpointNumber = finalisedBlockData.checkpointNumber - this.historyToKeep + 1;
+    if (newHistoricCheckpointNumber <= 1) {
+      return;
+    }
+    // Retrieve the historic checkpoint
+    const historicCheckpoint = await this.l2BlockSource.getCheckpoint({
+      number: CheckpointNumber(newHistoricCheckpointNumber),
+    });
+    if (!historicCheckpoint) {
+      this.log.warn(`Failed to retrieve checkpoint number ${newHistoricCheckpointNumber} from Archiver`);
       return;
     }
-    this.log.verbose(`Pruning historic blocks to ${newHistoricBlock}`);
-    const status = await this.merkleTreeDb.removeHistoricalBlocks(BlockNumber(newHistoricBlock));
+    if (historicCheckpoint.checkpoint.blocks.length === 0 || historicCheckpoint.checkpoint.blocks[0] === undefined) {
+      this.log.warn(`Retrieved checkpoint number ${newHistoricCheckpointNumber} has no blocks!`);
+      return;
+    }
+    // Find the block at the start of the checkpoint and remove blocks up to this one
+    const newHistoricBlock = historicCheckpoint.checkpoint.blocks[0];
+    if (newHistoricBlock.number <= currentSummary.oldestHistoricalBlock) {
+      this.log.debug(
+        `Historic block ${newHistoricBlock.number} is not newer than oldest available ${currentSummary.oldestHistoricalBlock}. Skipping prune.`,
+      );
+      return;
+    }
+    this.log.verbose(`Pruning historic blocks to ${newHistoricBlock.number}`);
+    const status = await this.merkleTreeDb.removeHistoricalBlocks(BlockNumber(newHistoricBlock.number));
     this.log.debug(`World state summary `, status.summary);
   }
 
@@ -380,9 +453,11 @@ export class ServerWorldStateSynchronizer
   }
 
   private async handleChainPruned(blockNumber: BlockNumber) {
-    this.log.warn(`Chain pruned to block ${blockNumber}`);
+    this.log.info(`Chain pruned to block ${blockNumber}`);
     const status = await this.merkleTreeDb.unwindBlocks(blockNumber);
-    this.provenBlockNumber = undefined;
+    if (this.provenBlockNumber !== undefined && this.provenBlockNumber > blockNumber) {
+      this.provenBlockNumber = undefined;
+    }
     this.instrumentation.updateWorldStateMetrics(status);
   }
 

package/src/testing.ts

@@ -3,22 +3,19 @@ import { Fr } from '@aztec/foundation/curves/bn254';
 import { computeFeePayerBalanceLeafSlot } from '@aztec/protocol-contracts/fee-juice';
 import type { AztecAddress } from '@aztec/stdlib/aztec-address';
 import { MerkleTreeId, PublicDataTreeLeaf } from '@aztec/stdlib/trees';
+import type { GenesisData } from '@aztec/stdlib/world-state';
 
 import { NativeWorldStateService } from './native/index.js';
 
-async function generateGenesisValues(prefilledPublicData: PublicDataTreeLeaf[]) {
-  if (!prefilledPublicData.length) {
+async function generateGenesisValues(genesis: GenesisData) {
+  if (!genesis.prefilledPublicData.length && genesis.genesisTimestamp === 0n) {
     return {
       genesisArchiveRoot: new Fr(GENESIS_ARCHIVE_ROOT),
     };
   }
 
   // Create a temporary world state to compute the genesis values.
-  const ws = await NativeWorldStateService.tmp(
-    undefined /* rollupAddress */,
-    true /* cleanupTmpDir */,
-    prefilledPublicData,
-  );
+  const ws = await NativeWorldStateService.tmp(/*cleanupTmpDir=*/ true, genesis);
   const genesisArchiveRoot = new Fr((await ws.getCommitted().getTreeInfo(MerkleTreeId.ARCHIVE)).root);
   await ws.close();
 
@@ -33,6 +30,7 @@ export async function getGenesisValues(
   initialAccounts: AztecAddress[],
   initialAccountFeeJuice = defaultInitialAccountFeeJuice,
   genesisPublicData: PublicDataTreeLeaf[] = [],
+  genesisTimestamp: bigint = 0n,
 ) {
   // Top up the accounts with fee juice.
   let prefilledPublicData = await Promise.all(
@@ -46,11 +44,12 @@ export async function getGenesisValues(
 
   prefilledPublicData.sort((a, b) => (b.slot.lt(a.slot) ? 1 : -1));
 
-  const { genesisArchiveRoot } = await generateGenesisValues(prefilledPublicData);
+  const genesis: GenesisData = { prefilledPublicData, genesisTimestamp };
+  const { genesisArchiveRoot } = await generateGenesisValues(genesis);
 
   return {
     genesisArchiveRoot,
-    prefilledPublicData,
+    genesis,
     fundingNeeded: BigInt(initialAccounts.length) * initialAccountFeeJuice.toBigInt(),
   };
 }

package/src/world-state-db/merkle_tree_db.ts

@@ -1,14 +1,12 @@
 import { MAX_NULLIFIERS_PER_TX, MAX_TOTAL_PUBLIC_DATA_UPDATE_REQUESTS_PER_TX } from '@aztec/constants';
 import type { BlockNumber } from '@aztec/foundation/branded-types';
 import type { Fr } from '@aztec/foundation/curves/bn254';
-import type { IndexedTreeSnapshot, TreeSnapshot } from '@aztec/merkle-tree';
 import type { L2Block } from '@aztec/stdlib/block';
 import type {
   ForkMerkleTreeOperations,
   MerkleTreeReadOperations,
   ReadonlyWorldStateAccess,
 } from '@aztec/stdlib/interfaces/server';
-import type { MerkleTreeId } from '@aztec/stdlib/trees';
 
 import type { WorldStateStatusFull, WorldStateStatusSummary } from '../native/message.js';
 
@@ -31,14 +29,6 @@ export const INITIAL_NULLIFIER_TREE_SIZE = 2 * MAX_NULLIFIERS_PER_TX;
 
 export const INITIAL_PUBLIC_DATA_TREE_SIZE = 2 * MAX_TOTAL_PUBLIC_DATA_UPDATE_REQUESTS_PER_TX;
 
-export type TreeSnapshots = {
-  [MerkleTreeId.NULLIFIER_TREE]: IndexedTreeSnapshot;
-  [MerkleTreeId.NOTE_HASH_TREE]: TreeSnapshot<Fr>;
-  [MerkleTreeId.PUBLIC_DATA_TREE]: IndexedTreeSnapshot;
-  [MerkleTreeId.L1_TO_L2_MESSAGE_TREE]: TreeSnapshot<Fr>;
-  [MerkleTreeId.ARCHIVE]: TreeSnapshot<Fr>;
-};
-
 export interface MerkleTreeAdminDatabase extends ForkMerkleTreeOperations, ReadonlyWorldStateAccess {
   /**
    * Handles a single L2 block (i.e. Inserts the new note hashes into the merkle tree).

package/dest/native/world_state_ops_queue.d.ts

@@ -1,19 +0,0 @@
-import { WorldStateMessageType } from './message.js';
-export declare const MUTATING_MSG_TYPES: Set<WorldStateMessageType>;
-export declare class WorldStateOpsQueue {
-    private requests;
-    private inFlightMutatingCount;
-    private inFlightCount;
-    private stopPromise?;
-    private stopResolve?;
-    private requestId;
-    private ops;
-    execute(request: () => Promise<any>, messageType: WorldStateMessageType, committedOnly: boolean): Promise<any>;
-    private executeMutating;
-    private executeNonMutatingUncommitted;
-    private executeNonMutatingCommitted;
-    private checkAndEnqueue;
-    private sendEnqueuedRequest;
-    stop(): Promise<void>;
-}
-//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoid29ybGRfc3RhdGVfb3BzX3F1ZXVlLmQudHMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyIuLi8uLi9zcmMvbmF0aXZlL3dvcmxkX3N0YXRlX29wc19xdWV1ZS50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFFQSxPQUFPLEVBQUUscUJBQXFCLEVBQUUsTUFBTSxjQUFjLENBQUM7QUF5QnJELGVBQU8sTUFBTSxrQkFBa0IsNEJBZ0I3QixDQUFDO0FBR0gscUJBQWEsa0JBQWtCO0lBQzdCLE9BQU8sQ0FBQyxRQUFRLENBQXNCO0lBQ3RDLE9BQU8sQ0FBQyxxQkFBcUIsQ0FBSztJQUNsQyxPQUFPLENBQUMsYUFBYSxDQUFLO0lBQzFCLE9BQU8sQ0FBQyxXQUFXLENBQUMsQ0FBZ0I7SUFDcEMsT0FBTyxDQUFDLFdBQVcsQ0FBQyxDQUFhO0lBQ2pDLE9BQU8sQ0FBQyxTQUFTLENBQUs7SUFDdEIsT0FBTyxDQUFDLEdBQUcsQ0FBd0M7SUFJNUMsT0FBTyxDQUFDLE9BQU8sRUFBRSxNQUFNLE9BQU8sQ0FBQyxHQUFHLENBQUMsRUFBRSxXQUFXLEVBQUUscUJBQXFCLEVBQUUsYUFBYSxFQUFFLE9BQU8sZ0JBc0JyRztJQUdELE9BQU8sQ0FBQyxlQUFlO0lBV3ZCLE9BQU8sQ0FBQyw2QkFBNkI7SUFZckMsT0FBTyxDQUFDLDJCQUEyQjtJQVVuQyxPQUFPLENBQUMsZUFBZTtJQXlDdkIsT0FBTyxDQUFDLG1CQUFtQjtJQWdCcEIsSUFBSSxrQkFnQlY7Q0FDRiJ9

package/dest/native/world_state_ops_queue.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"world_state_ops_queue.d.ts","sourceRoot":"","sources":["../../src/native/world_state_ops_queue.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,qBAAqB,EAAE,MAAM,cAAc,CAAC;AAyBrD,eAAO,MAAM,kBAAkB,4BAgB7B,CAAC;AAGH,qBAAa,kBAAkB;IAC7B,OAAO,CAAC,QAAQ,CAAsB;IACtC,OAAO,CAAC,qBAAqB,CAAK;IAClC,OAAO,CAAC,aAAa,CAAK;IAC1B,OAAO,CAAC,WAAW,CAAC,CAAgB;IACpC,OAAO,CAAC,WAAW,CAAC,CAAa;IACjC,OAAO,CAAC,SAAS,CAAK;IACtB,OAAO,CAAC,GAAG,CAAwC;IAI5C,OAAO,CAAC,OAAO,EAAE,MAAM,OAAO,CAAC,GAAG,CAAC,EAAE,WAAW,EAAE,qBAAqB,EAAE,aAAa,EAAE,OAAO,gBAsBrG;IAGD,OAAO,CAAC,eAAe;IAWvB,OAAO,CAAC,6BAA6B;IAYrC,OAAO,CAAC,2BAA2B;IAUnC,OAAO,CAAC,eAAe;IAyCvB,OAAO,CAAC,mBAAmB;IAgBpB,IAAI,kBAgBV;CACF"}

package/dest/native/world_state_ops_queue.js

@@ -1,146 +0,0 @@
-import { promiseWithResolvers } from '@aztec/foundation/promise';
-import { WorldStateMessageType } from './message.js';
-// These are the set of message types that implement mutating operations
-// Messages of these types require exclusive access to their given forks
-export const MUTATING_MSG_TYPES = new Set([
-    WorldStateMessageType.APPEND_LEAVES,
-    WorldStateMessageType.BATCH_INSERT,
-    WorldStateMessageType.SEQUENTIAL_INSERT,
-    WorldStateMessageType.UPDATE_ARCHIVE,
-    WorldStateMessageType.COMMIT,
-    WorldStateMessageType.ROLLBACK,
-    WorldStateMessageType.SYNC_BLOCK,
-    WorldStateMessageType.CREATE_FORK,
-    WorldStateMessageType.DELETE_FORK,
-    WorldStateMessageType.FINALIZE_BLOCKS,
-    WorldStateMessageType.UNWIND_BLOCKS,
-    WorldStateMessageType.REMOVE_HISTORICAL_BLOCKS,
-    WorldStateMessageType.CREATE_CHECKPOINT,
-    WorldStateMessageType.COMMIT_CHECKPOINT,
-    WorldStateMessageType.REVERT_CHECKPOINT
-]);
-// This class implements the per-fork operation queue
-export class WorldStateOpsQueue {
-    requests = [];
-    inFlightMutatingCount = 0;
-    inFlightCount = 0;
-    stopPromise;
-    stopResolve;
-    requestId = 0;
-    ops = new Map();
-    // The primary public api, this is where an operation is queued
-    // We return a promise that will ultimately be resolved/rejected with the response/error generated by the 'request' argument
-    execute(request, messageType, committedOnly) {
-        if (this.stopResolve !== undefined) {
-            throw new Error('Unable to send request to world state, queue already stopped');
-        }
-        const op = {
-            requestId: this.requestId++,
-            mutating: MUTATING_MSG_TYPES.has(messageType),
-            request,
-            promise: promiseWithResolvers()
-        };
-        this.ops.set(op.requestId, op);
-        // Perform the appropriate action based upon the queueing rules
-        if (op.mutating) {
-            this.executeMutating(op);
-        } else if (committedOnly === false) {
-            this.executeNonMutatingUncommitted(op);
-        } else {
-            this.executeNonMutatingCommitted(op);
-        }
-        return op.promise.promise;
-    }
-    // Mutating requests need exclusive access
-    executeMutating(op) {
-        // If nothing is in flight then we send the request immediately
-        // Otherwise add to the queue
-        if (this.inFlightCount === 0) {
-            this.sendEnqueuedRequest(op);
-        } else {
-            this.requests.push(op);
-        }
-    }
-    // Non mutating requests including uncommitted state
-    executeNonMutatingUncommitted(op) {
-        // If there are no mutating requests in flight and there is nothing queued
-        // then send the request immediately
-        // If a mutating request is in flight then we must wait
-        // If a mutating request is not in flight but something is queued then it must be a mutating request
-        if (this.inFlightMutatingCount == 0 && this.requests.length == 0) {
-            this.sendEnqueuedRequest(op);
-        } else {
-            this.requests.push(op);
-        }
-    }
-    executeNonMutatingCommitted(op) {
-        // This is a non-mutating request for committed data
-        // It can always be sent
-        op.request().then(op.promise.resolve, op.promise.reject).finally(()=>{
-            this.ops.delete(op.requestId);
-        });
-    }
-    checkAndEnqueue(completedOp) {
-        // As request has completed
-        // First we decrements the relevant in flight counters
-        if (completedOp.mutating) {
-            --this.inFlightMutatingCount;
-        }
-        --this.inFlightCount;
-        // If there are still requests in flight then do nothing further
-        if (this.inFlightCount != 0) {
-            return;
-        }
-        // No requests in flight, send next queued requests
-        // We loop and send:
-        // 1 mutating request if it is next in the queue
-        // As many non-mutating requests as we encounter until
-        // we exhaust the queue or we reach a mutating request
-        while(this.requests.length > 0){
-            const next = this.requests[0];
-            if (next.mutating) {
-                if (this.inFlightCount == 0) {
-                    // send the mutating request
-                    this.requests.shift();
-                    this.sendEnqueuedRequest(next);
-                }
-                break;
-            } else {
-                // not mutating, send and go round again
-                this.requests.shift();
-                this.sendEnqueuedRequest(next);
-            }
-        }
-        // If the queue is empty, there is nothing in flight and we have been told to stop, then resolve the stop promise
-        if (this.inFlightCount == 0 && this.stopResolve !== undefined) {
-            this.stopResolve();
-        }
-    }
-    sendEnqueuedRequest(op) {
-        // Here we increment the in flight counts before sending
-        ++this.inFlightCount;
-        if (op.mutating) {
-            ++this.inFlightMutatingCount;
-        }
-        // Make the request and pass the response/error through to the stored promise
-        op.request().then(op.promise.resolve, op.promise.reject).finally(()=>{
-            this.checkAndEnqueue(op);
-            this.ops.delete(op.requestId);
-        });
-    }
-    stop() {
-        // If there is already a stop promise then return it
-        if (this.stopPromise) {
-            return this.stopPromise;
-        }
-        // Otherwise create a new one and capture the resolve method
-        this.stopPromise = new Promise((resolve)=>{
-            this.stopResolve = resolve;
-        });
-        // If no outstanding requests then immediately resolve the promise
-        if (this.requests.length == 0 && this.inFlightCount == 0 && this.stopResolve !== undefined) {
-            this.stopResolve();
-        }
-        return this.stopPromise;
-    }
-}

package/src/native/world_state_ops_queue.ts

@@ -1,190 +0,0 @@
-import { promiseWithResolvers } from '@aztec/foundation/promise';
-
-import { WorldStateMessageType } from './message.js';
-
-/**
- * This is the implementation for queueing requests to the world state.
- * Requests need to be queued for the world state to ensure that writes are correctly ordered
- * and reads return the correct data.
- * Due to the nature of the NAPI we can't really do this there.
- *
- * The rules for queueing are as follows:
- *
- * 1. Reads of committed state never need to be queued. LMDB uses MVCC to ensure readers see a consistent view of the DB.
- * 2. Reads of uncommitted state can happen concurrently with other reads of uncommitted state on the same fork (or reads of committed state)
- * 3. All writes require exclusive access to their respective fork
- *
- */
-
-type WorldStateOp = {
-  requestId: number;
-  mutating: boolean;
-  request: () => Promise<any>;
-  promise: PromiseWithResolvers<any>;
-};
-
-// These are the set of message types that implement mutating operations
-// Messages of these types require exclusive access to their given forks
-export const MUTATING_MSG_TYPES = new Set([
-  WorldStateMessageType.APPEND_LEAVES,
-  WorldStateMessageType.BATCH_INSERT,
-  WorldStateMessageType.SEQUENTIAL_INSERT,
-  WorldStateMessageType.UPDATE_ARCHIVE,
-  WorldStateMessageType.COMMIT,
-  WorldStateMessageType.ROLLBACK,
-  WorldStateMessageType.SYNC_BLOCK,
-  WorldStateMessageType.CREATE_FORK,
-  WorldStateMessageType.DELETE_FORK,
-  WorldStateMessageType.FINALIZE_BLOCKS,
-  WorldStateMessageType.UNWIND_BLOCKS,
-  WorldStateMessageType.REMOVE_HISTORICAL_BLOCKS,
-  WorldStateMessageType.CREATE_CHECKPOINT,
-  WorldStateMessageType.COMMIT_CHECKPOINT,
-  WorldStateMessageType.REVERT_CHECKPOINT,
-]);
-
-// This class implements the per-fork operation queue
-export class WorldStateOpsQueue {
-  private requests: WorldStateOp[] = [];
-  private inFlightMutatingCount = 0;
-  private inFlightCount = 0;
-  private stopPromise?: Promise<void>;
-  private stopResolve?: () => void;
-  private requestId = 0;
-  private ops: Map<number, WorldStateOp> = new Map();
-
-  // The primary public api, this is where an operation is queued
-  // We return a promise that will ultimately be resolved/rejected with the response/error generated by the 'request' argument
-  public execute(request: () => Promise<any>, messageType: WorldStateMessageType, committedOnly: boolean) {
-    if (this.stopResolve !== undefined) {
-      throw new Error('Unable to send request to world state, queue already stopped');
-    }
-
-    const op: WorldStateOp = {
-      requestId: this.requestId++,
-      mutating: MUTATING_MSG_TYPES.has(messageType),
-      request,
-      promise: promiseWithResolvers(),
-    };
-    this.ops.set(op.requestId, op);
-
-    // Perform the appropriate action based upon the queueing rules
-    if (op.mutating) {
-      this.executeMutating(op);
-    } else if (committedOnly === false) {
-      this.executeNonMutatingUncommitted(op);
-    } else {
-      this.executeNonMutatingCommitted(op);
-    }
-    return op.promise.promise;
-  }
-
-  // Mutating requests need exclusive access
-  private executeMutating(op: WorldStateOp) {
-    // If nothing is in flight then we send the request immediately
-    // Otherwise add to the queue
-    if (this.inFlightCount === 0) {
-      this.sendEnqueuedRequest(op);
-    } else {
-      this.requests.push(op);
-    }
-  }
-
-  // Non mutating requests including uncommitted state
-  private executeNonMutatingUncommitted(op: WorldStateOp) {
-    // If there are no mutating requests in flight and there is nothing queued
-    // then send the request immediately
-    // If a mutating request is in flight then we must wait
-    // If a mutating request is not in flight but something is queued then it must be a mutating request
-    if (this.inFlightMutatingCount == 0 && this.requests.length == 0) {
-      this.sendEnqueuedRequest(op);
-    } else {
-      this.requests.push(op);
-    }
-  }
-
-  private executeNonMutatingCommitted(op: WorldStateOp) {
-    // This is a non-mutating request for committed data
-    // It can always be sent
-    op.request()
-      .then(op.promise.resolve, op.promise.reject)
-      .finally(() => {
-        this.ops.delete(op.requestId);
-      });
-  }
-
-  private checkAndEnqueue(completedOp: WorldStateOp) {
-    // As request has completed
-    // First we decrements the relevant in flight counters
-    if (completedOp.mutating) {
-      --this.inFlightMutatingCount;
-    }
-    --this.inFlightCount;
-
-    // If there are still requests in flight then do nothing further
-    if (this.inFlightCount != 0) {
-      return;
-    }
-
-    // No requests in flight, send next queued requests
-    // We loop and send:
-    // 1 mutating request if it is next in the queue
-    // As many non-mutating requests as we encounter until
-    // we exhaust the queue or we reach a mutating request
-    while (this.requests.length > 0) {
-      const next = this.requests[0];
-      if (next.mutating) {
-        if (this.inFlightCount == 0) {
-          // send the mutating request
-          this.requests.shift();
-          this.sendEnqueuedRequest(next);
-        }
-        // this request is mutating, we need to stop here
-        break;
-      } else {
-        // not mutating, send and go round again
-        this.requests.shift();
-        this.sendEnqueuedRequest(next);
-      }
-    }
-
-    // If the queue is empty, there is nothing in flight and we have been told to stop, then resolve the stop promise
-    if (this.inFlightCount == 0 && this.stopResolve !== undefined) {
-      this.stopResolve();
-    }
-  }
-
-  private sendEnqueuedRequest(op: WorldStateOp) {
-    // Here we increment the in flight counts before sending
-    ++this.inFlightCount;
-    if (op.mutating) {
-      ++this.inFlightMutatingCount;
-    }
-
-    // Make the request and pass the response/error through to the stored promise
-    op.request()
-      .then(op.promise.resolve, op.promise.reject)
-      .finally(() => {
-        this.checkAndEnqueue(op);
-        this.ops.delete(op.requestId);
-      });
-  }
-
-  public stop() {
-    // If there is already a stop promise then return it
-    if (this.stopPromise) {
-      return this.stopPromise;
-    }
-
-    // Otherwise create a new one and capture the resolve method
-    this.stopPromise = new Promise(resolve => {
-      this.stopResolve = resolve;
-    });
-
-    // If no outstanding requests then immediately resolve the promise
-    if (this.requests.length == 0 && this.inFlightCount == 0 && this.stopResolve !== undefined) {
-      this.stopResolve();
-    }
-    return this.stopPromise;
-  }
-}