@aztec/validator-ha-signer 0.0.1-commit.0208eb9

package/src/db/types.ts

@@ -0,0 +1,206 @@
+import type { BlockNumber, CheckpointNumber, IndexWithinCheckpoint, SlotNumber } from '@aztec/foundation/branded-types';
+import type { EthAddress } from '@aztec/foundation/eth-address';
+import type { Signature } from '@aztec/foundation/eth-signature';
+
+/**
+ * Row type from PostgreSQL query
+ */
+export interface DutyRow {
+  rollup_address: string;
+  validator_address: string;
+  slot: string;
+  block_number: string;
+  block_index_within_checkpoint: number;
+  duty_type: DutyType;
+  status: DutyStatus;
+  message_hash: string;
+  signature: string | null;
+  node_id: string;
+  lock_token: string;
+  started_at: Date;
+  completed_at: Date | null;
+  error_message: string | null;
+}
+
+/**
+ * Row type from INSERT_OR_GET_DUTY query (includes is_new flag)
+ */
+export interface InsertOrGetRow extends DutyRow {
+  is_new: boolean;
+}
+
+/**
+ * Type of validator duty being performed
+ */
+export enum DutyType {
+  BLOCK_PROPOSAL = 'BLOCK_PROPOSAL',
+  CHECKPOINT_PROPOSAL = 'CHECKPOINT_PROPOSAL',
+  ATTESTATION = 'ATTESTATION',
+  ATTESTATIONS_AND_SIGNERS = 'ATTESTATIONS_AND_SIGNERS',
+  GOVERNANCE_VOTE = 'GOVERNANCE_VOTE',
+  SLASHING_VOTE = 'SLASHING_VOTE',
+  AUTH_REQUEST = 'AUTH_REQUEST',
+  TXS = 'TXS',
+}
+
+/**
+ * Status of a duty in the database
+ */
+export enum DutyStatus {
+  SIGNING = 'signing',
+  SIGNED = 'signed',
+}
+
+/**
+ * Record of a validator duty in the database
+ */
+export interface ValidatorDutyRecord {
+  /** Ethereum address of the rollup contract */
+  rollupAddress: EthAddress;
+  /** Ethereum address of the validator */
+  validatorAddress: EthAddress;
+  /** Slot number for this duty */
+  slot: SlotNumber;
+  /** Block number for this duty */
+  blockNumber: BlockNumber;
+  /** Block index within checkpoint (0, 1, 2... for block proposals, -1 for other duty types) */
+  blockIndexWithinCheckpoint: number;
+  /** Type of duty being performed */
+  dutyType: DutyType;
+  /** Current status of the duty */
+  status: DutyStatus;
+  /** The signing root (hash) for this duty */
+  messageHash: string;
+  /** The signature (populated after successful signing) */
+  signature?: string;
+  /** Unique identifier for the node that acquired the lock */
+  nodeId: string;
+  /** Secret token for verifying ownership of the duty lock */
+  lockToken: string;
+  /** When the duty signing was started */
+  startedAt: Date;
+  /** When the duty signing was completed (success or failure) */
+  completedAt?: Date;
+  /** Error message (currently unused) */
+  errorMessage?: string;
+}
+
+/**
+ * Duty identifier for block proposals.
+ * blockIndexWithinCheckpoint is REQUIRED and must be >= 0.
+ */
+export interface BlockProposalDutyIdentifier {
+  rollupAddress: EthAddress;
+  validatorAddress: EthAddress;
+  slot: SlotNumber;
+  /** Block index within checkpoint (0, 1, 2...). Required for block proposals. */
+  blockIndexWithinCheckpoint: IndexWithinCheckpoint;
+  dutyType: DutyType.BLOCK_PROPOSAL;
+}
+
+/**
+ * Duty identifier for non-block-proposal duties.
+ * blockIndexWithinCheckpoint is not applicable (internally stored as -1).
+ */
+export interface OtherDutyIdentifier {
+  rollupAddress: EthAddress;
+  validatorAddress: EthAddress;
+  slot: SlotNumber;
+  dutyType:
+    | DutyType.CHECKPOINT_PROPOSAL
+    | DutyType.ATTESTATION
+    | DutyType.ATTESTATIONS_AND_SIGNERS
+    | DutyType.GOVERNANCE_VOTE
+    | DutyType.SLASHING_VOTE
+    | DutyType.AUTH_REQUEST
+    | DutyType.TXS;
+}
+
+/**
+ * Minimal info needed to identify a unique duty.
+ * Uses discriminated union to enforce type safety:
+ * - BLOCK_PROPOSAL duties MUST have blockIndexWithinCheckpoint >= 0
+ * - Other duty types do NOT have blockIndexWithinCheckpoint (internally -1)
+ */
+export type DutyIdentifier = BlockProposalDutyIdentifier | OtherDutyIdentifier;
+
+/**
+ * Validates and normalizes the block index for a duty.
+ * - BLOCK_PROPOSAL: validates blockIndexWithinCheckpoint is provided and >= 0
+ * - Other duty types: always returns -1
+ *
+ * @throws Error if BLOCK_PROPOSAL is missing blockIndexWithinCheckpoint or has invalid value
+ */
+export function normalizeBlockIndex(dutyType: DutyType, blockIndexWithinCheckpoint: number | undefined): number {
+  if (dutyType === DutyType.BLOCK_PROPOSAL) {
+    if (blockIndexWithinCheckpoint === undefined) {
+      throw new Error('BLOCK_PROPOSAL duties require blockIndexWithinCheckpoint to be specified');
+    }
+    if (blockIndexWithinCheckpoint < 0) {
+      throw new Error(
+        `BLOCK_PROPOSAL duties require blockIndexWithinCheckpoint >= 0, got ${blockIndexWithinCheckpoint}`,
+      );
+    }
+    return blockIndexWithinCheckpoint;
+  }
+  // For all other duty types, always use -1
+  return -1;
+}
+
+/**
+ * Gets the block index from a DutyIdentifier.
+ * - BLOCK_PROPOSAL: returns the blockIndexWithinCheckpoint
+ * - Other duty types: returns -1
+ */
+export function getBlockIndexFromDutyIdentifier(duty: DutyIdentifier): number {
+  if (duty.dutyType === DutyType.BLOCK_PROPOSAL) {
+    return duty.blockIndexWithinCheckpoint;
+  }
+  return -1;
+}
+
+/**
+ * Additional parameters for checking and recording a new duty
+ */
+interface CheckAndRecordExtra {
+  /** Block number for this duty */
+  blockNumber: BlockNumber | CheckpointNumber;
+  /** The signing root (hash) for this duty */
+  messageHash: string;
+  /** Identifier for the node that acquired the lock */
+  nodeId: string;
+}
+
+/**
+ * Parameters for checking and recording a new duty.
+ * Uses intersection with DutyIdentifier to preserve the discriminated union.
+ */
+export type CheckAndRecordParams = DutyIdentifier & CheckAndRecordExtra;
+
+/**
+ * Additional parameters for recording a successful signing
+ */
+interface RecordSuccessExtra {
+  signature: Signature;
+  nodeId: string;
+  lockToken: string;
+}
+
+/**
+ * Parameters for recording a successful signing.
+ * Uses intersection with DutyIdentifier to preserve the discriminated union.
+ */
+export type RecordSuccessParams = DutyIdentifier & RecordSuccessExtra;
+
+/**
+ * Additional parameters for deleting a duty
+ */
+interface DeleteDutyExtra {
+  lockToken: string;
+}
+
+/**
+ * Parameters for deleting a duty.
+ * Uses intersection with DutyIdentifier to preserve the discriminated union.
+ */
+export type DeleteDutyParams = DutyIdentifier & DeleteDutyExtra;

package/src/errors.ts

@@ -0,0 +1,47 @@
+/**
+ * Custom errors for the validator HA signer
+ */
+import type { SlotNumber } from '@aztec/foundation/branded-types';
+
+import type { DutyType } from './db/types.js';
+
+/**
+ * Thrown when a duty has already been signed (by any node).
+ * This is expected behavior in an HA setup - all nodes try to sign,
+ * the first one wins, and subsequent attempts get this error.
+ */
+export class DutyAlreadySignedError extends Error {
+  constructor(
+    public readonly slot: SlotNumber,
+    public readonly dutyType: DutyType,
+    public readonly blockIndexWithinCheckpoint: number,
+    public readonly signedByNode: string,
+  ) {
+    super(`Duty ${dutyType} for slot ${slot} already signed by node ${signedByNode}`);
+    this.name = 'DutyAlreadySignedError';
+  }
+}
+
+/**
+ * Thrown when attempting to sign data that conflicts with an already-signed duty.
+ * This means the same validator tried to sign DIFFERENT data for the same slot.
+ *
+ * This is expected in HA setups where nodes may build different blocks
+ * (e.g., different transaction ordering) - the protection prevents double-signing.
+ */
+export class SlashingProtectionError extends Error {
+  constructor(
+    public readonly slot: SlotNumber,
+    public readonly dutyType: DutyType,
+    public readonly blockIndexWithinCheckpoint: number,
+    public readonly existingMessageHash: string,
+    public readonly attemptedMessageHash: string,
+    public readonly signedByNode: string,
+  ) {
+    super(
+      `Slashing protection: ${dutyType} for slot ${slot} was already signed with different data. ` +
+        `Existing: ${existingMessageHash.slice(0, 10)}..., Attempted: ${attemptedMessageHash.slice(0, 10)}...`,
+    );
+    this.name = 'SlashingProtectionError';
+  }
+}

package/src/factory.ts

@@ -0,0 +1,82 @@
+/**
+ * Factory functions for creating validator HA signers
+ */
+import { Pool } from 'pg';
+
+import type { ValidatorHASignerConfig } from './config.js';
+import { PostgresSlashingProtectionDatabase } from './db/postgres.js';
+import type { CreateHASignerDeps, SlashingProtectionDatabase } from './types.js';
+import { ValidatorHASigner } from './validator_ha_signer.js';
+
+/**
+ * Create a validator HA signer with PostgreSQL backend
+ *
+ * After creating the signer, call `signer.start()` to begin background
+ * cleanup tasks. Call `signer.stop()` during graceful shutdown.
+ *
+ * Example with manual migrations (recommended for production):
+ * ```bash
+ * # Run migrations separately
+ * yarn migrate:up
+ * ```
+ *
+ * ```typescript
+ * const { signer, db } = await createHASigner({
+ *   databaseUrl: process.env.DATABASE_URL,
+ *   haSigningEnabled: true,
+ *   nodeId: 'validator-node-1',
+ *   pollingIntervalMs: 100,
+ *   signingTimeoutMs: 3000,
+ * });
+ * signer.start(); // Start background cleanup
+ *
+ * // ... use signer ...
+ *
+ * await signer.stop(); // On shutdown
+ * ```
+ *
+ * Note: Migrations must be run separately using `aztec migrate-ha-db up` before
+ * creating the signer. The factory will verify the schema is initialized via `db.initialize()`.
+ *
+ * @param config - Configuration for the HA signer
+ * @param deps - Optional dependencies (e.g., for testing)
+ * @returns An object containing the signer and database instances
+ */
+export async function createHASigner(
+  config: ValidatorHASignerConfig,
+  deps?: CreateHASignerDeps,
+): Promise<{
+  signer: ValidatorHASigner;
+  db: SlashingProtectionDatabase;
+}> {
+  const { databaseUrl, poolMaxCount, poolMinCount, poolIdleTimeoutMs, poolConnectionTimeoutMs, ...signerConfig } =
+    config;
+
+  if (!databaseUrl) {
+    throw new Error('databaseUrl is required for createHASigner');
+  }
+  // Create connection pool (or use provided pool)
+  let pool: Pool;
+  if (!deps?.pool) {
+    pool = new Pool({
+      connectionString: databaseUrl,
+      max: poolMaxCount ?? 10,
+      min: poolMinCount ?? 0,
+      idleTimeoutMillis: poolIdleTimeoutMs ?? 10_000,
+      connectionTimeoutMillis: poolConnectionTimeoutMs ?? 0,
+    });
+  } else {
+    pool = deps.pool;
+  }
+
+  // Create database instance
+  const db = new PostgresSlashingProtectionDatabase(pool);
+
+  // Verify database schema is initialized and version matches
+  await db.initialize();
+
+  // Create signer
+  const signer = new ValidatorHASigner(db, { ...signerConfig, databaseUrl });
+
+  return { signer, db };
+}

package/src/migrations.ts

@@ -0,0 +1,75 @@
+/**
+ * Programmatic migration runner
+ */
+import { createLogger } from '@aztec/foundation/log';
+
+import { readdirSync } from 'fs';
+import { runner } from 'node-pg-migrate';
+import { dirname, join } from 'path';
+import { fileURLToPath } from 'url';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = dirname(__filename);
+
+export interface RunMigrationsOptions {
+  /** Migration direction ('up' to apply, 'down' to rollback). Defaults to 'up'. */
+  direction?: 'up' | 'down';
+  /** Enable verbose output. Defaults to false. */
+  verbose?: boolean;
+}
+
+/**
+ * Run database migrations programmatically
+ *
+ * @param databaseUrl - PostgreSQL connection string
+ * @param options - Migration options (direction, verbose)
+ * @returns Array of applied migration names
+ */
+export async function runMigrations(databaseUrl: string, options: RunMigrationsOptions = {}): Promise<string[]> {
+  const direction = options.direction ?? 'up';
+  const verbose = options.verbose ?? false;
+
+  const log = createLogger('validator-ha-signer:migrations');
+
+  const migrationsDir = join(__dirname, 'db', 'migrations');
+
+  try {
+    log.info(`Running migrations ${direction}...`);
+
+    // Filter out .d.ts and .d.ts.map files - node-pg-migrate only needs .js files
+    const migrationFiles = readdirSync(migrationsDir);
+    const jsMigrationFiles = migrationFiles.filter(
+      file => file.endsWith('.js') && !file.endsWith('.d.ts') && !file.endsWith('.d.ts.map'),
+    );
+
+    if (jsMigrationFiles.length === 0) {
+      log.info('No migration files found');
+      return [];
+    }
+
+    const appliedMigrations = await runner({
+      databaseUrl,
+      dir: migrationsDir,
+      direction,
+      migrationsTable: 'pgmigrations',
+      count: direction === 'down' ? 1 : Infinity,
+      verbose,
+      log: msg => (verbose ? log.info(msg) : log.debug(msg)),
+      // Ignore TypeScript declaration files - node-pg-migrate will try to import them otherwise
+      ignorePattern: '.*\\.d\\.(ts|js)$|.*\\.d\\.ts\\.map$',
+    });
+
+    if (appliedMigrations.length === 0) {
+      log.info('No migrations to apply - schema is up to date');
+    } else {
+      log.info(`Applied ${appliedMigrations.length} migration(s)`, {
+        migrations: appliedMigrations.map(m => m.name),
+      });
+    }
+
+    return appliedMigrations.map(m => m.name);
+  } catch (error: any) {
+    log.error('Migration failed', error);
+    throw error;
+  }
+}

package/src/slashing_protection_service.ts

@@ -0,0 +1,287 @@
+/**
+ * Slashing Protection Service
+ *
+ * Provides distributed locking and slashing protection for validator duties.
+ * Uses an external database to coordinate across multiple validator nodes.
+ */
+import { type Logger, createLogger } from '@aztec/foundation/log';
+import { RunningPromise } from '@aztec/foundation/promise';
+import { sleep } from '@aztec/foundation/sleep';
+
+import {
+  type CheckAndRecordParams,
+  type DeleteDutyParams,
+  DutyStatus,
+  type RecordSuccessParams,
+  getBlockIndexFromDutyIdentifier,
+} from './db/types.js';
+import { DutyAlreadySignedError, SlashingProtectionError } from './errors.js';
+import type { SlashingProtectionDatabase, ValidatorHASignerConfig } from './types.js';
+
+/**
+ * Slashing Protection Service
+ *
+ * This service ensures that a validator only signs one block/attestation per slot,
+ * even when running multiple redundant nodes (HA setup).
+ *
+ * All nodes in the HA setup try to sign - the first one wins, others get
+ * DutyAlreadySignedError (normal) or SlashingProtectionError (if different data).
+ *
+ * Flow:
+ * 1. checkAndRecord() - Atomically try to acquire lock via tryInsertOrGetExisting
+ * 2. Caller performs the signing operation
+ * 3. recordSuccess() - Update to 'signed' status with signature
+ *    OR deleteDuty() - Delete the record to allow retry
+ */
+export class SlashingProtectionService {
+  private readonly log: Logger;
+  private readonly pollingIntervalMs: number;
+  private readonly signingTimeoutMs: number;
+  private readonly maxStuckDutiesAgeMs: number;
+
+  private cleanupRunningPromise: RunningPromise;
+  private lastOldDutiesCleanupAtMs?: number;
+
+  constructor(
+    private readonly db: SlashingProtectionDatabase,
+    private readonly config: ValidatorHASignerConfig,
+  ) {
+    this.log = createLogger('slashing-protection');
+    this.pollingIntervalMs = config.pollingIntervalMs;
+    this.signingTimeoutMs = config.signingTimeoutMs;
+    // Default to 144s (2x 72s Aztec slot duration) if not explicitly configured
+    this.maxStuckDutiesAgeMs = config.maxStuckDutiesAgeMs ?? 144_000;
+
+    this.cleanupRunningPromise = new RunningPromise(this.cleanup.bind(this), this.log, this.maxStuckDutiesAgeMs);
+  }
+
+  /**
+   * Check if a duty can be performed and acquire the lock if so.
+   *
+   * This method uses an atomic insert-or-get operation.
+   * It will:
+   * 1. Try to insert a new record with 'signing' status
+   * 2. If insert succeeds, we acquired the lock - return the lockToken
+   * 3. If a record exists, handle based on status:
+   *    - SIGNED: Throw appropriate error (already signed or slashing protection)
+   *    - SIGNING: Wait and poll until status changes, then handle result
+   *
+   * @returns The lockToken that must be used for recordSuccess/deleteDuty
+   * @throws DutyAlreadySignedError if the duty was already completed
+   * @throws SlashingProtectionError if attempting to sign different data for same slot/duty
+   */
+  async checkAndRecord(params: CheckAndRecordParams): Promise<string> {
+    const { validatorAddress, slot, dutyType, messageHash, nodeId } = params;
+    const startTime = Date.now();
+
+    this.log.debug(`Checking duty: ${dutyType} for slot ${slot}`, {
+      validatorAddress: validatorAddress.toString(),
+      nodeId,
+    });
+
+    while (true) {
+      // insert if not present, get existing if present
+      const { isNew, record } = await this.db.tryInsertOrGetExisting(params);
+
+      if (isNew) {
+        // We successfully acquired the lock
+        this.log.info(`Acquired lock for duty ${dutyType} at slot ${slot}`, {
+          validatorAddress: validatorAddress.toString(),
+          nodeId,
+        });
+        return record.lockToken;
+      }
+
+      // Record already exists - handle based on status
+      if (record.status === DutyStatus.SIGNED) {
+        // Duty was already signed - check if same or different data
+        if (record.messageHash !== messageHash) {
+          this.log.verbose(`Slashing protection triggered for duty ${dutyType} at slot ${slot}`, {
+            validatorAddress: validatorAddress.toString(),
+            existingMessageHash: record.messageHash,
+            attemptedMessageHash: messageHash,
+            existingNodeId: record.nodeId,
+            attemptingNodeId: nodeId,
+          });
+          throw new SlashingProtectionError(
+            slot,
+            dutyType,
+            record.blockIndexWithinCheckpoint,
+            record.messageHash,
+            messageHash,
+            record.nodeId,
+          );
+        }
+        throw new DutyAlreadySignedError(slot, dutyType, record.blockIndexWithinCheckpoint, record.nodeId);
+      } else if (record.status === DutyStatus.SIGNING) {
+        // Another node is currently signing - check for timeout
+        if (Date.now() - startTime > this.signingTimeoutMs) {
+          this.log.warn(`Timeout waiting for signing to complete for duty ${dutyType} at slot ${slot}`, {
+            validatorAddress: validatorAddress.toString(),
+            timeoutMs: this.signingTimeoutMs,
+            signingNodeId: record.nodeId,
+          });
+          throw new DutyAlreadySignedError(slot, dutyType, record.blockIndexWithinCheckpoint, 'unknown (timeout)');
+        }
+
+        // Wait and poll
+        this.log.debug(`Waiting for signing to complete for duty ${dutyType} at slot ${slot}`, {
+          validatorAddress: validatorAddress.toString(),
+          signingNodeId: record.nodeId,
+        });
+        await sleep(this.pollingIntervalMs);
+        // Loop continues - next iteration will check status again
+      } else {
+        throw new Error(`Unknown duty status: ${record.status}`);
+      }
+    }
+  }
+
+  /**
+   * Record a successful signing operation.
+   * Updates the duty status to 'signed' and stores the signature.
+   * Only succeeds if the lockToken matches (caller must be the one who created the duty).
+   *
+   * @returns true if the update succeeded, false if token didn't match
+   */
+  async recordSuccess(params: RecordSuccessParams): Promise<boolean> {
+    const { rollupAddress, validatorAddress, slot, dutyType, signature, nodeId, lockToken } = params;
+    const blockIndexWithinCheckpoint = getBlockIndexFromDutyIdentifier(params);
+
+    const success = await this.db.updateDutySigned(
+      rollupAddress,
+      validatorAddress,
+      slot,
+      dutyType,
+      signature.toString(),
+      lockToken,
+      blockIndexWithinCheckpoint,
+    );
+
+    if (success) {
+      this.log.info(`Recorded successful signing for duty ${dutyType} at slot ${slot}`, {
+        validatorAddress: validatorAddress.toString(),
+        nodeId,
+      });
+    } else {
+      this.log.warn(`Failed to record successful signing for duty ${dutyType} at slot ${slot}: invalid token`, {
+        validatorAddress: validatorAddress.toString(),
+        nodeId,
+      });
+    }
+
+    return success;
+  }
+
+  /**
+   * Delete a duty record after a failed signing operation.
+   * Removes the record to allow another node/attempt to retry.
+   * Only succeeds if the lockToken matches (caller must be the one who created the duty).
+   *
+   * @returns true if the delete succeeded, false if token didn't match
+   */
+  async deleteDuty(params: DeleteDutyParams): Promise<boolean> {
+    const { rollupAddress, validatorAddress, slot, dutyType, lockToken } = params;
+    const blockIndexWithinCheckpoint = getBlockIndexFromDutyIdentifier(params);
+
+    const success = await this.db.deleteDuty(
+      rollupAddress,
+      validatorAddress,
+      slot,
+      dutyType,
+      lockToken,
+      blockIndexWithinCheckpoint,
+    );
+
+    if (success) {
+      this.log.info(`Deleted duty ${dutyType} at slot ${slot} to allow retry`, {
+        validatorAddress: validatorAddress.toString(),
+      });
+    } else {
+      this.log.warn(`Failed to delete duty ${dutyType} at slot ${slot}: invalid token`, {
+        validatorAddress: validatorAddress.toString(),
+      });
+    }
+
+    return success;
+  }
+
+  /**
+   * Get the node ID for this service
+   */
+  get nodeId(): string {
+    return this.config.nodeId;
+  }
+
+  /**
+   * Start running tasks.
+   * Cleanup runs immediately on start to recover from any previous crashes.
+   */
+  /**
+   * Start the background cleanup task.
+   * Also performs one-time cleanup of duties with outdated rollup addresses.
+   */
+  async start() {
+    // One-time cleanup at startup: remove duties from previous rollup versions
+    const numOutdatedRollupDuties = await this.db.cleanupOutdatedRollupDuties(this.config.l1Contracts.rollupAddress);
+    if (numOutdatedRollupDuties > 0) {
+      this.log.info(`Cleaned up ${numOutdatedRollupDuties} duties with outdated rollup address at startup`, {
+        currentRollupAddress: this.config.l1Contracts.rollupAddress.toString(),
+      });
+    }
+
+    this.cleanupRunningPromise.start();
+    this.log.info('Slashing protection service started', { nodeId: this.config.nodeId });
+  }
+
+  /**
+   * Stop the background cleanup task.
+   */
+  async stop() {
+    await this.cleanupRunningPromise.stop();
+    this.log.info('Slashing protection service stopped', { nodeId: this.config.nodeId });
+  }
+
+  /**
+   * Close the database connection.
+   * Should be called after stop() during graceful shutdown.
+   */
+  async close() {
+    await this.db.close();
+    this.log.info('Slashing protection database connection closed');
+  }
+
+  /**
+   * Periodic cleanup of stuck duties and optionally old signed duties.
+   * Runs in the background via RunningPromise.
+   */
+  private async cleanup() {
+    // 1. Clean up stuck duties (our own node's duties that got stuck in 'signing' status)
+    const numStuckDuties = await this.db.cleanupOwnStuckDuties(this.config.nodeId, this.maxStuckDutiesAgeMs);
+    if (numStuckDuties > 0) {
+      this.log.verbose(`Cleaned up ${numStuckDuties} stuck duties`, {
+        nodeId: this.config.nodeId,
+        maxStuckDutiesAgeMs: this.maxStuckDutiesAgeMs,
+      });
+    }
+
+    // 2. Clean up old signed duties if configured
+    // we shouldn't run this as often as stuck duty cleanup.
+    if (this.config.cleanupOldDutiesAfterHours !== undefined) {
+      const maxAgeMs = this.config.cleanupOldDutiesAfterHours * 60 * 60 * 1000;
+      const nowMs = Date.now();
+      const shouldRun =
+        this.lastOldDutiesCleanupAtMs === undefined || nowMs - this.lastOldDutiesCleanupAtMs >= maxAgeMs;
+      if (shouldRun) {
+        const numOldDuties = await this.db.cleanupOldDuties(maxAgeMs);
+        this.lastOldDutiesCleanupAtMs = nowMs;
+        if (numOldDuties > 0) {
+          this.log.verbose(`Cleaned up ${numOldDuties} old signed duties`, {
+            cleanupOldDutiesAfterHours: this.config.cleanupOldDutiesAfterHours,
+            maxAgeMs,
+          });
+        }
+      }
+    }
+  }
+}