@aztec/validator-client 0.0.1-commit.e558bd1c → 0.0.1-commit.e57c76e

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (52) hide show
  1. package/README.md +52 -10
  2. package/dest/checkpoint_builder.d.ts +21 -8
  3. package/dest/checkpoint_builder.d.ts.map +1 -1
  4. package/dest/checkpoint_builder.js +124 -46
  5. package/dest/config.d.ts +1 -1
  6. package/dest/config.d.ts.map +1 -1
  7. package/dest/config.js +37 -7
  8. package/dest/duties/validation_service.d.ts +12 -13
  9. package/dest/duties/validation_service.d.ts.map +1 -1
  10. package/dest/duties/validation_service.js +33 -45
  11. package/dest/factory.d.ts +10 -4
  12. package/dest/factory.d.ts.map +1 -1
  13. package/dest/factory.js +11 -5
  14. package/dest/index.d.ts +2 -3
  15. package/dest/index.d.ts.map +1 -1
  16. package/dest/index.js +1 -2
  17. package/dest/key_store/ha_key_store.js +1 -1
  18. package/dest/metrics.d.ts +14 -2
  19. package/dest/metrics.d.ts.map +1 -1
  20. package/dest/metrics.js +24 -0
  21. package/dest/proposal_handler.d.ts +134 -0
  22. package/dest/proposal_handler.d.ts.map +1 -0
  23. package/dest/proposal_handler.js +1072 -0
  24. package/dest/validator.d.ts +53 -23
  25. package/dest/validator.d.ts.map +1 -1
  26. package/dest/validator.js +341 -231
  27. package/package.json +19 -19
  28. package/src/checkpoint_builder.ts +142 -39
  29. package/src/config.ts +37 -6
  30. package/src/duties/validation_service.ts +59 -54
  31. package/src/factory.ts +20 -3
  32. package/src/index.ts +1 -2
  33. package/src/key_store/ha_key_store.ts +1 -1
  34. package/src/metrics.ts +37 -1
  35. package/src/proposal_handler.ts +1161 -0
  36. package/src/validator.ts +460 -272
  37. package/dest/block_proposal_handler.d.ts +0 -63
  38. package/dest/block_proposal_handler.d.ts.map +0 -1
  39. package/dest/block_proposal_handler.js +0 -546
  40. package/dest/tx_validator/index.d.ts +0 -3
  41. package/dest/tx_validator/index.d.ts.map +0 -1
  42. package/dest/tx_validator/index.js +0 -2
  43. package/dest/tx_validator/nullifier_cache.d.ts +0 -14
  44. package/dest/tx_validator/nullifier_cache.d.ts.map +0 -1
  45. package/dest/tx_validator/nullifier_cache.js +0 -24
  46. package/dest/tx_validator/tx_validator_factory.d.ts +0 -19
  47. package/dest/tx_validator/tx_validator_factory.d.ts.map +0 -1
  48. package/dest/tx_validator/tx_validator_factory.js +0 -54
  49. package/src/block_proposal_handler.ts +0 -555
  50. package/src/tx_validator/index.ts +0 -2
  51. package/src/tx_validator/nullifier_cache.ts +0 -30
  52. package/src/tx_validator/tx_validator_factory.ts +0 -154
package/dest/validator.js CHANGED
@@ -1,46 +1,70 @@
1
1
  import { getBlobsPerL1Block } from '@aztec/blob-lib';
2
- import { BlockNumber } from '@aztec/foundation/branded-types';
3
- import { TimeoutError } from '@aztec/foundation/error';
2
+ import { CheckpointNumber } from '@aztec/foundation/branded-types';
3
+ import { FifoSet } from '@aztec/foundation/fifo-set';
4
4
  import { createLogger } from '@aztec/foundation/log';
5
- import { retryUntil } from '@aztec/foundation/retry';
6
5
  import { RunningPromise } from '@aztec/foundation/running-promise';
7
6
  import { sleep } from '@aztec/foundation/sleep';
8
7
  import { DateProvider } from '@aztec/foundation/timer';
9
8
  import { AuthRequest, AuthResponse, BlockProposalValidator, ReqRespSubProtocol } from '@aztec/p2p';
10
- import { OffenseType, WANT_TO_SLASH_EVENT } from '@aztec/slasher';
9
+ import { OffenseType, WANT_TO_CLEAR_SLASH_EVENT, WANT_TO_SLASH_EVENT, getOffenseTypeName } from '@aztec/slasher';
11
10
  import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
12
- import { accumulateCheckpointOutHashes } from '@aztec/stdlib/messaging';
13
11
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
14
12
  import { getTelemetryClient } from '@aztec/telemetry-client';
15
- import { createHASigner } from '@aztec/validator-ha-signer/factory';
13
+ import { createHASigner, createLocalSignerWithProtection, createSignerFromSharedDb } from '@aztec/validator-ha-signer/factory';
16
14
  import { DutyType } from '@aztec/validator-ha-signer/types';
17
15
  import { EventEmitter } from 'events';
18
- import { BlockProposalHandler } from './block_proposal_handler.js';
19
16
  import { ValidationService } from './duties/validation_service.js';
20
17
  import { HAKeyStore } from './key_store/ha_key_store.js';
21
18
  import { NodeKeystoreAdapter } from './key_store/node_keystore_adapter.js';
22
19
  import { ValidatorMetrics } from './metrics.js';
20
+ import { ProposalHandler } from './proposal_handler.js';
23
21
  // We maintain a set of proposers who have proposed invalid blocks.
24
22
  // Just cap the set to avoid unbounded growth.
25
23
  const MAX_PROPOSERS_OF_INVALID_BLOCKS = 1000;
24
+ const MAX_TRACKED_INVALID_PROPOSAL_SLOTS = 1000;
25
+ const MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS = 1000;
26
+ const MAX_TRACKED_BAD_ATTESTATIONS = 10_000;
26
27
  // What errors from the block proposal handler result in slashing
27
28
  const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
28
29
  'state_mismatch',
29
- 'failed_txs'
30
+ 'failed_txs',
31
+ 'global_variables_mismatch',
32
+ 'invalid_proposal',
33
+ 'parent_block_wrong_slot',
34
+ 'in_hash_mismatch'
30
35
  ];
36
+ const SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT = {
37
+ // enabled
38
+ ['invalid_fee_asset_price_modifier']: true,
39
+ ['checkpoint_header_mismatch']: true,
40
+ // These late mismatches should normally be caught by earlier checks, but if reached after validating the local
41
+ // checkpoint inputs, the proposer-signed payload disagrees with deterministic recomputation.
42
+ ['archive_mismatch']: true,
43
+ ['out_hash_mismatch']: true,
44
+ ['no_blocks_for_slot']: true,
45
+ ['too_many_blocks_in_checkpoint']: true,
46
+ ['checkpoint_validation_failed']: true,
47
+ ['last_block_archive_mismatch']: true,
48
+ // disabled
49
+ ['invalid_signature']: false,
50
+ ['last_block_not_found']: false,
51
+ ['block_fetch_error']: false,
52
+ ['checkpoint_already_published']: false
53
+ };
31
54
  /**
32
55
  * Validator Client
33
56
  */ export class ValidatorClient extends EventEmitter {
34
57
  keyStore;
35
58
  epochCache;
36
59
  p2pClient;
37
- blockProposalHandler;
60
+ proposalHandler;
38
61
  blockSource;
39
62
  checkpointsBuilder;
40
63
  worldState;
41
64
  l1ToL2MessageSource;
42
65
  config;
43
66
  blobClient;
67
+ slashingProtectionSigner;
44
68
  dateProvider;
45
69
  tracer;
46
70
  validationService;
@@ -48,18 +72,25 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
48
72
  log;
49
73
  // Whether it has already registered handlers on the p2p client
50
74
  hasRegisteredHandlers;
51
- // Used to check if we are sending the same proposal twice
52
- previousProposal;
75
+ /** Tracks the last block proposal we created, to detect duplicate proposal attempts. */ lastProposedBlock;
76
+ /** Tracks the last checkpoint proposal we created. */ lastProposedCheckpoint;
53
77
  lastEpochForCommitteeUpdateLoop;
54
78
  epochCacheUpdateLoop;
79
+ /** Tracks the last epoch in which each attester successfully submitted at least one attestation. */ lastAttestedEpochByAttester;
55
80
  proposersOfInvalidBlocks;
56
- constructor(keyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
57
- super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.blockProposalHandler = blockProposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.proposersOfInvalidBlocks = new Set();
81
+ slotsWithInvalidProposals;
82
+ invalidCheckpointProposalOffenseKeys;
83
+ badAttestationOffenseKeys;
84
+ slotsWithProposalEquivocation;
85
+ /** Tracks the last checkpoint proposal we attested to, to prevent equivocation. */ lastAttestedProposal;
86
+ constructor(keyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
87
+ super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.proposalHandler = proposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.slashingProtectionSigner = slashingProtectionSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.lastAttestedEpochByAttester = new Map(), this.proposersOfInvalidBlocks = FifoSet.withLimit(MAX_PROPOSERS_OF_INVALID_BLOCKS), this.slotsWithInvalidProposals = FifoSet.withLimit(MAX_TRACKED_INVALID_PROPOSAL_SLOTS), this.invalidCheckpointProposalOffenseKeys = FifoSet.withLimit(MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS), this.badAttestationOffenseKeys = FifoSet.withLimit(MAX_TRACKED_BAD_ATTESTATIONS), this.slotsWithProposalEquivocation = FifoSet.withLimit(MAX_TRACKED_INVALID_PROPOSAL_SLOTS);
58
88
  // Create child logger with fisherman prefix if in fisherman mode
59
89
  this.log = config.fishermanMode ? log.createChild('[FISHERMAN]') : log;
60
90
  this.tracer = telemetry.getTracer('Validator');
61
91
  this.metrics = new ValidatorMetrics(telemetry);
62
- this.validationService = new ValidationService(keyStore, this.log.createChild('validation-service'));
92
+ this.validationService = new ValidationService(keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
93
+ this.proposalHandler.setCheckpointProposalValidationFailureCallback((proposal, result, proposalInfo)=>this.handleInvalidCheckpointProposal(proposal, result, proposalInfo));
63
94
  // Refresh epoch cache every second to trigger alert if participation in committee changes
64
95
  this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), this.log, 1000);
65
96
  const myAddresses = this.getValidatorAddresses();
@@ -93,6 +124,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
93
124
  this.log.trace(`No committee found for slot`);
94
125
  return;
95
126
  }
127
+ this.metrics.setCurrentEpoch(epoch);
96
128
  if (epoch !== this.lastEpochForCommitteeUpdateLoop) {
97
129
  const me = this.getValidatorAddresses();
98
130
  const committeeSet = new Set(committee.map((v)=>v.toString()));
@@ -108,34 +140,65 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
108
140
  this.log.error(`Error updating epoch committee`, err);
109
141
  }
110
142
  }
111
- static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient()) {
143
+ static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, reexecutionTracker, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), slashingProtectionDb) {
112
144
  const metrics = new ValidatorMetrics(telemetry);
113
145
  const blockProposalValidator = new BlockProposalValidator(epochCache, {
114
- txsPermitted: !config.disableTransactions
146
+ txsPermitted: !config.disableTransactions,
147
+ maxTxsPerBlock: config.validateMaxTxsPerBlock,
148
+ maxBlocksPerCheckpoint: config.maxBlocksPerCheckpoint,
149
+ skipSlotValidation: config.skipProposalSlotValidation,
150
+ signatureContext: {
151
+ chainId: config.l1ChainId,
152
+ rollupAddress: config.rollupAddress
153
+ }
115
154
  });
116
- const blockProposalHandler = new BlockProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, metrics, dateProvider, telemetry);
117
- let validatorKeyStore = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
118
- if (config.haSigningEnabled) {
155
+ const proposalHandler = new ProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, blobClient, reexecutionTracker, metrics, dateProvider, telemetry, undefined);
156
+ const nodeKeystoreAdapter = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
157
+ let slashingProtectionSigner;
158
+ if (slashingProtectionDb) {
159
+ // Shared database mode: use a pre-existing database (e.g. for testing HA setups).
160
+ ({ signer: slashingProtectionSigner } = createSignerFromSharedDb(slashingProtectionDb, config, {
161
+ telemetryClient: telemetry,
162
+ dateProvider
163
+ }));
164
+ } else if (config.haSigningEnabled) {
165
+ // Multi-node HA mode: use PostgreSQL-backed distributed locking.
119
166
  // If maxStuckDutiesAgeMs is not explicitly set, compute it from Aztec slot duration
120
167
  const haConfig = {
121
168
  ...config,
122
169
  maxStuckDutiesAgeMs: config.maxStuckDutiesAgeMs ?? epochCache.getL1Constants().slotDuration * 2 * 1000
123
170
  };
124
- const { signer } = await createHASigner(haConfig);
125
- validatorKeyStore = new HAKeyStore(validatorKeyStore, signer);
171
+ ({ signer: slashingProtectionSigner } = await createHASigner(haConfig, {
172
+ telemetryClient: telemetry,
173
+ dateProvider
174
+ }));
175
+ } else {
176
+ // Single-node mode: use LMDB-backed local signing protection.
177
+ // This prevents double-signing if the node crashes and restarts mid-proposal.
178
+ ({ signer: slashingProtectionSigner } = await createLocalSignerWithProtection(config, {
179
+ telemetryClient: telemetry,
180
+ dateProvider
181
+ }));
126
182
  }
127
- const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, dateProvider, telemetry);
183
+ const validatorKeyStore = new HAKeyStore(nodeKeystoreAdapter, slashingProtectionSigner);
184
+ const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider, telemetry);
128
185
  return validator;
129
186
  }
130
187
  getValidatorAddresses() {
131
188
  return this.keyStore.getAddresses().filter((addr)=>!this.config.disabledValidators.some((disabled)=>disabled.equals(addr)));
132
189
  }
133
- getBlockProposalHandler() {
134
- return this.blockProposalHandler;
190
+ getProposalHandler() {
191
+ return this.proposalHandler;
135
192
  }
136
193
  signWithAddress(addr, msg, context) {
137
194
  return this.keyStore.signTypedDataWithAddress(addr, msg, context);
138
195
  }
196
+ getSignatureContext() {
197
+ return {
198
+ chainId: this.config.l1ChainId,
199
+ rollupAddress: this.config.rollupAddress
200
+ };
201
+ }
139
202
  getCoinbaseForAttestor(attestor) {
140
203
  return this.keyStore.getCoinbaseAddress(attestor);
141
204
  }
@@ -145,11 +208,23 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
145
208
  getConfig() {
146
209
  return this.config;
147
210
  }
211
+ hasProposalEquivocation(slotNumber) {
212
+ return this.slotsWithProposalEquivocation.has(slotNumber);
213
+ }
214
+ hasInvalidProposals(slotNumber) {
215
+ return this.slotsWithInvalidProposals.has(slotNumber);
216
+ }
148
217
  updateConfig(config) {
149
218
  this.config = {
150
219
  ...this.config,
151
220
  ...config
152
221
  };
222
+ this.proposalHandler.updateConfig(config);
223
+ }
224
+ reloadKeystore(newManager) {
225
+ const newAdapter = NodeKeystoreAdapter.fromKeyStoreManager(newManager);
226
+ this.keyStore = new HAKeyStore(newAdapter, this.slashingProtectionSigner);
227
+ this.validationService = new ValidationService(this.keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
153
228
  }
154
229
  async start() {
155
230
  if (this.epochCacheUpdateLoop.isRunning()) {
@@ -182,11 +257,18 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
182
257
  // The checkpoint is received as CheckpointProposalCore since the lastBlock is extracted
183
258
  // and processed separately via the block handler above.
184
259
  const checkpointHandler = (checkpoint, proposalSender)=>this.attestToCheckpointProposal(checkpoint, proposalSender);
185
- this.p2pClient.registerCheckpointProposalHandler(checkpointHandler);
260
+ this.p2pClient.registerValidatorCheckpointProposalHandler(checkpointHandler);
186
261
  // Duplicate proposal handler - triggers slashing for equivocation
187
262
  this.p2pClient.registerDuplicateProposalCallback((info)=>{
188
263
  this.handleDuplicateProposal(info);
189
264
  });
265
+ // Duplicate attestation handler - triggers slashing for attestation equivocation
266
+ this.p2pClient.registerDuplicateAttestationCallback((info)=>{
267
+ this.handleDuplicateAttestation(info);
268
+ });
269
+ this.p2pClient.registerCheckpointAttestationCallback((attestation)=>{
270
+ this.handleCheckpointAttestation(attestation);
271
+ });
190
272
  const myAddresses = this.getValidatorAddresses();
191
273
  this.p2pClient.registerThisValidatorAddresses(myAddresses);
192
274
  await this.p2pClient.addReqRespSubProtocol(ReqRespSubProtocol.AUTH, this.handleAuthRequest.bind(this));
@@ -207,6 +289,13 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
207
289
  this.log.warn(`Received block proposal with invalid signature for slot ${slotNumber}`);
208
290
  return false;
209
291
  }
292
+ // Log self-proposals from HA peers (same validator key on different nodes)
293
+ if (this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
294
+ this.log.verbose(`Processing block proposal from HA peer for slot ${slotNumber}`, {
295
+ proposer: proposer.toString(),
296
+ slotNumber
297
+ });
298
+ }
210
299
  // Check if we're in the committee (for metrics purposes)
211
300
  const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
212
301
  const partOfCommittee = inCommittee.length > 0;
@@ -219,14 +308,11 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
219
308
  txHashes: proposal.txHashes.map((t)=>t.toString()),
220
309
  fishermanMode: this.config.fishermanMode || false
221
310
  });
222
- // Reexecute txs if we are part of the committee, or if slashing is enabled, or if we are configured to always reexecute.
223
- // In fisherman mode, we always reexecute to validate proposals.
224
- const { validatorReexecute, slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } = this.config;
225
- const shouldReexecute = fishermanMode || slashBroadcastedInvalidBlockPenalty > 0n && validatorReexecute || partOfCommittee && validatorReexecute || alwaysReexecuteBlockProposals || this.blobClient.canUpload();
226
- const validationResult = await this.blockProposalHandler.handleBlockProposal(proposal, proposalSender, !!shouldReexecute && !escapeHatchOpen);
311
+ // Reexecute outside the escape hatch so slashing observers can detect invalid proposals even when penalties are 0.
312
+ const validationResult = await this.proposalHandler.handleBlockProposal(proposal, proposalSender, !escapeHatchOpen);
227
313
  if (!validationResult.isValid) {
228
- this.log.warn(`Block proposal validation failed: ${validationResult.reason}`, proposalInfo);
229
314
  const reason = validationResult.reason || 'unknown';
315
+ this.log.warn(`Block proposal validation failed: ${reason}`, proposalInfo);
230
316
  // Classify failure reason: bad proposal vs node issue
231
317
  const badProposalReasons = [
232
318
  'invalid_proposal',
@@ -241,10 +327,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
241
327
  // Node issues so we can't validate
242
328
  this.metrics.incFailedAttestationsNodeIssue(1, reason, partOfCommittee);
243
329
  }
244
- // Slash invalid block proposals (can happen even when not in committee)
245
- if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason) && slashBroadcastedInvalidBlockPenalty > 0n) {
246
- this.log.warn(`Slashing proposer for invalid block proposal`, proposalInfo);
330
+ if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason)) {
331
+ this.log.info(`Detected invalid block proposal offense`, {
332
+ ...proposalInfo,
333
+ amount: this.config.slashBroadcastedInvalidBlockPenalty,
334
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL)
335
+ });
247
336
  this.slashInvalidBlock(proposal);
337
+ this.markInvalidProposalSlot(proposal.slotNumber);
248
338
  }
249
339
  return false;
250
340
  }
@@ -266,45 +356,50 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
266
356
  * the lastBlock is extracted and processed separately via the block handler.
267
357
  * @returns Checkpoint attestations if valid, undefined otherwise
268
358
  */ async attestToCheckpointProposal(proposal, _proposalSender) {
269
- const slotNumber = proposal.slotNumber;
359
+ const proposalSlotNumber = proposal.slotNumber;
270
360
  const proposer = proposal.getSender();
271
361
  // If escape hatch is open for this slot's epoch, do not attest.
272
- if (await this.epochCache.isEscapeHatchOpenAtSlot(slotNumber)) {
273
- this.log.warn(`Escape hatch open for slot ${slotNumber}, skipping checkpoint attestation handling`);
362
+ if (await this.epochCache.isEscapeHatchOpenAtSlot(proposalSlotNumber)) {
363
+ this.log.warn(`Escape hatch open for slot ${proposalSlotNumber}, skipping checkpoint attestation handling`);
274
364
  return undefined;
275
365
  }
276
- // Reject proposals with invalid signatures
277
- if (!proposer) {
278
- this.log.warn(`Received checkpoint proposal with invalid signature for slot ${slotNumber}`);
366
+ // Early-out for equivocation: refuses if we've already attested to a higher slot.
367
+ if (!this.shouldAttestToSlot(proposalSlotNumber)) {
279
368
  return undefined;
280
369
  }
281
- // Check that I have any address in current committee before attesting
282
- const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
370
+ // Ignore proposals from ourselves (may happen in HA setups)
371
+ if (proposer && this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
372
+ this.log.debug(`Ignoring block proposal from self for slot ${proposalSlotNumber}`, {
373
+ proposer: proposer.toString(),
374
+ proposalSlotNumber
375
+ });
376
+ return undefined;
377
+ }
378
+ // Check that I have any address in the committee where this checkpoint will land before attesting
379
+ const inCommittee = await this.epochCache.filterInCommittee(proposalSlotNumber, this.getValidatorAddresses());
283
380
  const partOfCommittee = inCommittee.length > 0;
284
381
  const proposalInfo = {
285
- slotNumber,
382
+ proposalSlotNumber,
286
383
  archive: proposal.archive.toString(),
287
- proposer: proposer.toString(),
288
- txCount: proposal.txHashes.length
384
+ proposer: proposer?.toString()
289
385
  };
290
- this.log.info(`Received checkpoint proposal for slot ${slotNumber}`, {
386
+ this.log.info(`Received checkpoint proposal for slot ${proposalSlotNumber}`, {
291
387
  ...proposalInfo,
292
- txHashes: proposal.txHashes.map((t)=>t.toString()),
293
388
  fishermanMode: this.config.fishermanMode || false
294
389
  });
295
- // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set)
390
+ // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set).
391
+ // Uses the cached result from the all-nodes callback if available (avoids double validation).
392
+ let checkpointNumber;
296
393
  if (this.config.skipCheckpointProposalValidation) {
297
- this.log.warn(`Skipping checkpoint proposal validation for slot ${slotNumber}`, proposalInfo);
394
+ this.log.warn(`Skipping checkpoint proposal validation for slot ${proposalSlotNumber}`, proposalInfo);
395
+ checkpointNumber = CheckpointNumber(0);
298
396
  } else {
299
- const validationResult = await this.validateCheckpointProposal(proposal, proposalInfo);
397
+ const validationResult = await this.proposalHandler.handleCheckpointProposal(proposal, proposalInfo);
300
398
  if (!validationResult.isValid) {
301
399
  this.log.warn(`Checkpoint proposal validation failed: ${validationResult.reason}`, proposalInfo);
302
400
  return undefined;
303
401
  }
304
- }
305
- // Upload blobs to filestore if we can (fire and forget)
306
- if (this.blobClient.canUpload()) {
307
- void this.uploadBlobsForCheckpoint(proposal, proposalInfo);
402
+ checkpointNumber = validationResult.checkpointNumber;
308
403
  }
309
404
  // Check that I have any address in current committee before attesting
310
405
  // In fisherman mode, we still create attestations for validation even if not in committee
@@ -313,12 +408,22 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
313
408
  return undefined;
314
409
  }
315
410
  // Provided all of the above checks pass, we can attest to the proposal
316
- this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${slotNumber}`, {
411
+ this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${proposalSlotNumber}`, {
317
412
  ...proposalInfo,
318
413
  inCommittee: partOfCommittee,
319
414
  fishermanMode: this.config.fishermanMode || false
320
415
  });
321
416
  this.metrics.incSuccessfulAttestations(inCommittee.length);
417
+ // Track epoch participation per attester: count each (attester, epoch) pair at most once
418
+ const proposalEpoch = getEpochAtSlot(proposalSlotNumber, this.epochCache.getL1Constants());
419
+ for (const attester of inCommittee){
420
+ const key = attester.toString();
421
+ const lastEpoch = this.lastAttestedEpochByAttester.get(key);
422
+ if (lastEpoch === undefined || proposalEpoch > lastEpoch) {
423
+ this.lastAttestedEpochByAttester.set(key, proposalEpoch);
424
+ this.metrics.incAttestedEpochCount(attester);
425
+ }
426
+ }
322
427
  // Determine which validators should attest
323
428
  let attestors;
324
429
  if (partOfCommittee) {
@@ -335,157 +440,47 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
335
440
  }
336
441
  if (this.config.fishermanMode) {
337
442
  // bail out early and don't save attestations to the pool in fisherman mode
338
- this.log.info(`Creating checkpoint attestations for slot ${slotNumber}`, {
443
+ this.log.info(`Creating checkpoint attestations for slot ${proposalSlotNumber}`, {
339
444
  ...proposalInfo,
340
445
  attestors: attestors.map((a)=>a.toString())
341
446
  });
342
447
  return undefined;
343
448
  }
344
- return this.createCheckpointAttestationsFromProposal(proposal, attestors);
345
- }
346
- async createCheckpointAttestationsFromProposal(proposal, attestors = []) {
347
- const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors);
348
- await this.p2pClient.addOwnCheckpointAttestations(attestations);
349
- return attestations;
449
+ return await this.createCheckpointAttestationsFromProposal(proposal, attestors, checkpointNumber);
350
450
  }
351
451
  /**
352
- * Validates a checkpoint proposal by building the full checkpoint and comparing it with the proposal.
353
- * @returns Validation result with isValid flag and reason if invalid.
354
- */ async validateCheckpointProposal(proposal, proposalInfo) {
355
- const slot = proposal.slotNumber;
356
- const timeoutSeconds = 10; // TODO(palla/mbps): This should map to the timetable settings
357
- // Wait for last block to sync by archive
358
- let lastBlockHeader;
359
- try {
360
- lastBlockHeader = await retryUntil(async ()=>{
361
- await this.blockSource.syncImmediate();
362
- return this.blockSource.getBlockHeaderByArchive(proposal.archive);
363
- }, `waiting for block with archive ${proposal.archive.toString()} for slot ${slot}`, timeoutSeconds, 0.5);
364
- } catch (err) {
365
- if (err instanceof TimeoutError) {
366
- this.log.warn(`Timed out waiting for block with archive matching checkpoint proposal`, proposalInfo);
367
- return {
368
- isValid: false,
369
- reason: 'last_block_not_found'
370
- };
371
- }
372
- this.log.error(`Error fetching last block for checkpoint proposal`, err, proposalInfo);
373
- return {
374
- isValid: false,
375
- reason: 'block_fetch_error'
376
- };
377
- }
378
- if (!lastBlockHeader) {
379
- this.log.warn(`Last block not found for checkpoint proposal`, proposalInfo);
380
- return {
381
- isValid: false,
382
- reason: 'last_block_not_found'
383
- };
452
+ * Checks if we should attest to a slot based on equivocation prevention rules.
453
+ * @returns true if we should attest, false if we should skip
454
+ */ shouldAttestToSlot(slotNumber) {
455
+ // If attestToEquivocatedProposals is true, always allow
456
+ if (this.config.attestToEquivocatedProposals) {
457
+ return true;
384
458
  }
385
- // Get all full blocks for the slot and checkpoint
386
- const blocks = await this.blockSource.getBlocksForSlot(slot);
387
- if (blocks.length === 0) {
388
- this.log.warn(`No blocks found for slot ${slot}`, proposalInfo);
389
- return {
390
- isValid: false,
391
- reason: 'no_blocks_for_slot'
392
- };
393
- }
394
- this.log.debug(`Found ${blocks.length} blocks for slot ${slot}`, {
395
- ...proposalInfo,
396
- blockNumbers: blocks.map((b)=>b.number)
397
- });
398
- // Get checkpoint constants from first block
399
- const firstBlock = blocks[0];
400
- const constants = this.extractCheckpointConstants(firstBlock);
401
- const checkpointNumber = firstBlock.checkpointNumber;
402
- // Get L1-to-L2 messages for this checkpoint
403
- const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(checkpointNumber);
404
- // Compute the previous checkpoint out hashes for the epoch.
405
- // TODO: There can be a more efficient way to get the previous checkpoint out hashes without having to fetch the
406
- // actual checkpoints and the blocks/txs in them.
407
- const epoch = getEpochAtSlot(slot, this.epochCache.getL1Constants());
408
- const previousCheckpoints = (await this.blockSource.getCheckpointsForEpoch(epoch)).filter((b)=>b.number < checkpointNumber).sort((a, b)=>a.number - b.number);
409
- const previousCheckpointOutHashes = previousCheckpoints.map((c)=>c.getCheckpointOutHash());
410
- // Fork world state at the block before the first block
411
- const parentBlockNumber = BlockNumber(firstBlock.number - 1);
412
- const fork = await this.worldState.fork(parentBlockNumber);
413
- try {
414
- // Create checkpoint builder with all existing blocks
415
- const checkpointBuilder = await this.checkpointsBuilder.openCheckpoint(checkpointNumber, constants, l1ToL2Messages, previousCheckpointOutHashes, fork, blocks, this.log.getBindings());
416
- // Complete the checkpoint to get computed values
417
- const computedCheckpoint = await checkpointBuilder.completeCheckpoint();
418
- // Compare checkpoint header with proposal
419
- if (!computedCheckpoint.header.equals(proposal.checkpointHeader)) {
420
- this.log.warn(`Checkpoint header mismatch`, {
421
- ...proposalInfo,
422
- computed: computedCheckpoint.header.toInspect(),
423
- proposal: proposal.checkpointHeader.toInspect()
424
- });
425
- return {
426
- isValid: false,
427
- reason: 'checkpoint_header_mismatch'
428
- };
429
- }
430
- // Compare archive root with proposal
431
- if (!computedCheckpoint.archive.root.equals(proposal.archive)) {
432
- this.log.warn(`Archive root mismatch`, {
433
- ...proposalInfo,
434
- computed: computedCheckpoint.archive.root.toString(),
435
- proposal: proposal.archive.toString()
436
- });
437
- return {
438
- isValid: false,
439
- reason: 'archive_mismatch'
440
- };
441
- }
442
- // Check that the accumulated epoch out hash matches the value in the proposal.
443
- // The epoch out hash is the accumulated hash of all checkpoint out hashes in the epoch.
444
- const checkpointOutHash = computedCheckpoint.getCheckpointOutHash();
445
- const computedEpochOutHash = accumulateCheckpointOutHashes([
446
- ...previousCheckpointOutHashes,
447
- checkpointOutHash
448
- ]);
449
- const proposalEpochOutHash = proposal.checkpointHeader.epochOutHash;
450
- if (!computedEpochOutHash.equals(proposalEpochOutHash)) {
451
- this.log.warn(`Epoch out hash mismatch`, {
452
- proposalEpochOutHash: proposalEpochOutHash.toString(),
453
- computedEpochOutHash: computedEpochOutHash.toString(),
454
- checkpointOutHash: checkpointOutHash.toString(),
455
- previousCheckpointOutHashes: previousCheckpointOutHashes.map((h)=>h.toString()),
456
- ...proposalInfo
457
- });
458
- return {
459
- isValid: false,
460
- reason: 'out_hash_mismatch'
461
- };
462
- }
463
- this.log.verbose(`Checkpoint proposal validation successful for slot ${slot}`, proposalInfo);
464
- return {
465
- isValid: true
466
- };
467
- } finally{
468
- await fork.close();
459
+ // Check if incoming slot is strictly greater than last attested
460
+ if (this.lastAttestedProposal && slotNumber <= this.lastAttestedProposal.slotNumber) {
461
+ this.log.warn(`Refusing to process a proposal for slot ${slotNumber} given we already attested to a proposal for slot ${this.lastAttestedProposal.slotNumber}`);
462
+ return false;
469
463
  }
464
+ return true;
470
465
  }
471
- /**
472
- * Extract checkpoint global variables from a block.
473
- */ extractCheckpointConstants(block) {
474
- const gv = block.header.globalVariables;
475
- return {
476
- chainId: gv.chainId,
477
- version: gv.version,
478
- slotNumber: gv.slotNumber,
479
- coinbase: gv.coinbase,
480
- feeRecipient: gv.feeRecipient,
481
- gasFees: gv.gasFees
482
- };
466
+ async createCheckpointAttestationsFromProposal(proposal, attestors = [], checkpointNumber) {
467
+ // Equivocation check: must happen right before signing to minimize the race window
468
+ if (!this.shouldAttestToSlot(proposal.slotNumber)) {
469
+ return undefined;
470
+ }
471
+ const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors, checkpointNumber);
472
+ // Track the proposal we attested to (to prevent equivocation)
473
+ this.lastAttestedProposal = proposal;
474
+ await this.p2pClient.addOwnCheckpointAttestations(attestations);
475
+ return attestations;
483
476
  }
484
477
  /**
485
478
  * Uploads blobs for a checkpoint to the filestore (fire and forget).
486
479
  */ async uploadBlobsForCheckpoint(proposal, proposalInfo) {
487
480
  try {
488
- const lastBlockHeader = await this.blockSource.getBlockHeaderByArchive(proposal.archive);
481
+ const lastBlockHeader = (await this.blockSource.getBlockData({
482
+ archive: proposal.archive
483
+ }))?.header;
489
484
  if (!lastBlockHeader) {
490
485
  this.log.warn(`Failed to get last block header for blob upload`, proposalInfo);
491
486
  return;
@@ -496,7 +491,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
496
491
  return;
497
492
  }
498
493
  const blobFields = blocks.flatMap((b)=>b.toBlobFields());
499
- const blobs = getBlobsPerL1Block(blobFields);
494
+ const blobs = await getBlobsPerL1Block(blobFields);
500
495
  await this.blobClient.sendBlobsToFilestore(blobs);
501
496
  this.log.debug(`Uploaded ${blobs.length} blobs to filestore for checkpoint at slot ${proposal.slotNumber}`, {
502
497
  ...proposalInfo,
@@ -513,11 +508,6 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
513
508
  this.log.warn(`Cannot slash proposal with invalid signature`);
514
509
  return;
515
510
  }
516
- // Trim the set if it's too big.
517
- if (this.proposersOfInvalidBlocks.size > MAX_PROPOSERS_OF_INVALID_BLOCKS) {
518
- // remove oldest proposer. `values` is guaranteed to be in insertion order.
519
- this.proposersOfInvalidBlocks.delete(this.proposersOfInvalidBlocks.values().next().value);
520
- }
521
511
  this.proposersOfInvalidBlocks.add(proposer.toString());
522
512
  this.emit(WANT_TO_SLASH_EVENT, [
523
513
  {
@@ -528,17 +518,95 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
528
518
  }
529
519
  ]);
530
520
  }
521
+ handleInvalidCheckpointProposal(proposal, result, proposalInfo) {
522
+ if (!SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT[result.reason]) {
523
+ return;
524
+ }
525
+ this.markInvalidProposalSlot(proposal.slotNumber);
526
+ if (this.slashInvalidCheckpointProposal(proposal)) {
527
+ this.log.info(`Detected invalid checkpoint proposal offense`, {
528
+ ...proposalInfo,
529
+ reason: result.reason,
530
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
531
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL)
532
+ });
533
+ }
534
+ }
535
+ slashInvalidCheckpointProposal(proposal) {
536
+ const proposer = proposal.getSender();
537
+ if (!proposer) {
538
+ this.log.warn(`Cannot slash checkpoint proposal with invalid signature`, {
539
+ slotNumber: proposal.slotNumber,
540
+ archive: proposal.archive.toString()
541
+ });
542
+ return false;
543
+ }
544
+ const offenseType = OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL;
545
+ const offenseKey = `${proposer.toString()}:${offenseType}:${proposal.slotNumber}`;
546
+ if (!this.invalidCheckpointProposalOffenseKeys.addIfAbsent(offenseKey)) {
547
+ return false;
548
+ }
549
+ this.emit(WANT_TO_SLASH_EVENT, [
550
+ {
551
+ validator: proposer,
552
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
553
+ offenseType,
554
+ epochOrSlot: BigInt(proposal.slotNumber)
555
+ }
556
+ ]);
557
+ return true;
558
+ }
559
+ markInvalidProposalSlot(slotNumber) {
560
+ this.slotsWithInvalidProposals.add(slotNumber);
561
+ }
562
+ handleCheckpointAttestation(attestation) {
563
+ const slotNumber = attestation.slotNumber;
564
+ if (!this.slotsWithInvalidProposals.has(slotNumber) || this.slotsWithProposalEquivocation.has(slotNumber)) {
565
+ return;
566
+ }
567
+ const attester = attestation.getSender();
568
+ if (!attester) {
569
+ this.log.warn(`Cannot slash checkpoint attestation with invalid signature`, {
570
+ slotNumber,
571
+ archive: attestation.archive.toString()
572
+ });
573
+ return;
574
+ }
575
+ this.slashAttestedToInvalidCheckpointProposal(slotNumber, attester);
576
+ }
577
+ slashAttestedToInvalidCheckpointProposal(slotNumber, attester) {
578
+ const offenseKey = `${attester.toString()}:${OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL}:${slotNumber}`;
579
+ if (!this.badAttestationOffenseKeys.addIfAbsent(offenseKey)) {
580
+ return;
581
+ }
582
+ this.log.info(`Detected attestation to invalid checkpoint proposal offense`, {
583
+ attester: attester.toString(),
584
+ slotNumber,
585
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
586
+ offenseType: getOffenseTypeName(OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL)
587
+ });
588
+ this.emit(WANT_TO_SLASH_EVENT, [
589
+ {
590
+ validator: attester,
591
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
592
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
593
+ epochOrSlot: BigInt(slotNumber)
594
+ }
595
+ ]);
596
+ }
531
597
  /**
532
598
  * Handle detection of a duplicate proposal (equivocation).
533
599
  * Emits a slash event when a proposer sends multiple proposals for the same position.
534
600
  */ handleDuplicateProposal(info) {
535
601
  const { slot, proposer, type } = info;
536
- this.log.warn(`Triggering slash event for duplicate ${type} proposal from ${proposer.toString()} at slot ${slot}`, {
602
+ this.slotsWithProposalEquivocation.add(slot);
603
+ this.log.info(`Detected duplicate ${type} proposal offense from ${proposer.toString()} at slot ${slot}`, {
537
604
  proposer: proposer.toString(),
538
605
  slot,
539
- type
606
+ type,
607
+ amount: this.config.slashDuplicateProposalPenalty,
608
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_PROPOSAL)
540
609
  });
541
- // Emit slash event
542
610
  this.emit(WANT_TO_SLASH_EVENT, [
543
611
  {
544
612
  validator: proposer,
@@ -547,38 +615,88 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
547
615
  epochOrSlot: BigInt(slot)
548
616
  }
549
617
  ]);
618
+ this.emit(WANT_TO_CLEAR_SLASH_EVENT, [
619
+ {
620
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
621
+ epochOrSlot: BigInt(slot)
622
+ }
623
+ ]);
624
+ }
625
+ /**
626
+ * Handle detection of a duplicate attestation (equivocation).
627
+ * Emits a slash event when an attester signs attestations for different proposals at the same slot.
628
+ */ handleDuplicateAttestation(info) {
629
+ const { slot, attester } = info;
630
+ this.log.info(`Detected duplicate attestation offense from ${attester.toString()} at slot ${slot}`, {
631
+ attester: attester.toString(),
632
+ slot,
633
+ amount: this.config.slashDuplicateAttestationPenalty,
634
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_ATTESTATION)
635
+ });
636
+ this.emit(WANT_TO_SLASH_EVENT, [
637
+ {
638
+ validator: attester,
639
+ amount: this.config.slashDuplicateAttestationPenalty,
640
+ offenseType: OffenseType.DUPLICATE_ATTESTATION,
641
+ epochOrSlot: BigInt(slot)
642
+ }
643
+ ]);
550
644
  }
551
- async createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
552
- // TODO(palla/mbps): Prevent double proposals properly
553
- // if (this.previousProposal?.slotNumber === blockHeader.globalVariables.slotNumber) {
554
- // this.log.verbose(`Already made a proposal for the same slot, skipping proposal`);
555
- // return Promise.resolve(undefined);
556
- // }
645
+ async createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
646
+ // Validate that we're not creating a proposal for an older or equal position
647
+ if (this.lastProposedBlock) {
648
+ const lastSlot = this.lastProposedBlock.slotNumber;
649
+ const lastIndex = this.lastProposedBlock.indexWithinCheckpoint;
650
+ const newSlot = blockHeader.globalVariables.slotNumber;
651
+ if (newSlot < lastSlot || newSlot === lastSlot && indexWithinCheckpoint <= lastIndex) {
652
+ throw new Error(`Cannot create block proposal for slot ${newSlot} index ${indexWithinCheckpoint}: ` + `already proposed block for slot ${lastSlot} index ${lastIndex}`);
653
+ }
654
+ }
557
655
  this.log.info(`Assembling block proposal for block ${blockHeader.globalVariables.blockNumber} slot ${blockHeader.globalVariables.slotNumber}`);
558
- const newProposal = await this.validationService.createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
656
+ const newProposal = await this.validationService.createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
559
657
  ...options,
560
- broadcastInvalidBlockProposal: this.config.broadcastInvalidBlockProposal
658
+ broadcastInvalidBlockProposal: options.broadcastInvalidBlockProposal || this.config.broadcastInvalidBlockProposal
561
659
  });
562
- this.previousProposal = newProposal;
660
+ this.lastProposedBlock = newProposal;
563
661
  return newProposal;
564
662
  }
565
- async createCheckpointProposal(checkpointHeader, archive, lastBlockInfo, proposerAddress, options = {}) {
663
+ async createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options = {}) {
664
+ // Validate that we're not creating a proposal for an older or equal slot
665
+ if (this.lastProposedCheckpoint) {
666
+ const lastSlot = this.lastProposedCheckpoint.slotNumber;
667
+ const newSlot = checkpointHeader.slotNumber;
668
+ if (newSlot <= lastSlot) {
669
+ throw new Error(`Cannot create checkpoint proposal for slot ${newSlot}: ` + `already proposed checkpoint for slot ${lastSlot}`);
670
+ }
671
+ }
566
672
  this.log.info(`Assembling checkpoint proposal for slot ${checkpointHeader.slotNumber}`);
567
- return await this.validationService.createCheckpointProposal(checkpointHeader, archive, lastBlockInfo, proposerAddress, options);
673
+ const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options);
674
+ this.lastProposedCheckpoint = newProposal;
675
+ // Self-record this slot's outcome on the re-execution tracker. Proposers don't run their
676
+ // own proposals through `handleCheckpointProposal`, so without this call the proposer's
677
+ // sentinel would see no outcome for slots it proposed and would mis-attribute itself as
678
+ // inactive. We pass the locally-computed `archive` (not `newProposal.archive`, which may
679
+ // be intentionally corrupted under test-only flags); from the proposer's local-view
680
+ // perspective the work it just completed is valid by definition.
681
+ this.proposalHandler.recordOwnCheckpointProposalAsValid(checkpointHeader.slotNumber, archive, checkpointNumber);
682
+ return newProposal;
568
683
  }
569
684
  async broadcastBlockProposal(proposal) {
570
685
  await this.p2pClient.broadcastProposal(proposal);
571
686
  }
572
- async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber) {
573
- return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber);
687
+ async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber) {
688
+ return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber);
574
689
  }
575
- async collectOwnAttestations(proposal) {
690
+ async collectOwnAttestations(proposal, checkpointNumber) {
576
691
  const slot = proposal.slotNumber;
577
692
  const inCommittee = await this.epochCache.filterInCommittee(slot, this.getValidatorAddresses());
578
693
  this.log.debug(`Collecting ${inCommittee.length} self-attestations for slot ${slot}`, {
579
694
  inCommittee
580
695
  });
581
- const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee);
696
+ const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee, checkpointNumber);
697
+ if (!attestations) {
698
+ return [];
699
+ }
582
700
  // We broadcast our own attestations to our peers so, in case our block does not get mined on L1,
583
701
  // other nodes can see that our validators did attest to this block proposal, and do not slash us
584
702
  // due to inactivity for missed attestations.
@@ -587,7 +705,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
587
705
  });
588
706
  return attestations;
589
707
  }
590
- async collectAttestations(proposal, required, deadline) {
708
+ async collectAttestations(proposal, required, deadline, checkpointNumber) {
591
709
  // Wait and poll the p2pClient's attestation pool for this checkpoint until we have enough attestations
592
710
  const slot = proposal.slotNumber;
593
711
  this.log.debug(`Collecting ${required} attestations for slot ${slot} with deadline ${deadline.toISOString()}`);
@@ -595,28 +713,20 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
595
713
  this.log.error(`Deadline ${deadline.toISOString()} for collecting ${required} attestations for slot ${slot} is in the past`);
596
714
  throw new AttestationTimeoutError(0, required, slot);
597
715
  }
598
- await this.collectOwnAttestations(proposal);
599
- const proposalId = proposal.archive.toString();
716
+ await this.collectOwnAttestations(proposal, checkpointNumber);
717
+ const proposalPayloadHash = proposal.getPayloadHash();
600
718
  const myAddresses = this.getValidatorAddresses();
601
719
  let attestations = [];
602
720
  while(true){
603
- // Filter out attestations with a mismatching archive. This should NOT happen since we have verified
604
- // the proposer signature (ie our own) before accepting the attestation into the pool via the p2p client.
605
- const collectedAttestations = (await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalId)).filter((attestation)=>{
606
- if (!attestation.archive.equals(proposal.archive)) {
607
- this.log.warn(`Received attestation for slot ${slot} with mismatched archive from ${attestation.getSender()?.toString()}`, {
608
- attestationArchive: attestation.archive.toString(),
609
- proposalArchive: proposal.archive.toString()
610
- });
611
- return false;
612
- }
613
- return true;
614
- });
721
+ // The pool already filters by proposal payload hash; if any attestation slips through with a
722
+ // mismatched payload hash, drop it defensively. Equivocations are emitted as separate slash
723
+ // events from libp2p_service.
724
+ const collectedAttestations = await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalPayloadHash);
615
725
  // Log new attestations we collected
616
726
  const oldSenders = attestations.map((attestation)=>attestation.getSender());
617
727
  for (const collected of collectedAttestations){
618
728
  const collectedSender = collected.getSender();
619
- // Skip attestations with invalid signatures
729
+ // Skip attestations with invalid signatures. Should not happen as we don't add invalid attestations to our pool.
620
730
  if (!collectedSender) {
621
731
  this.log.warn(`Skipping attestation with invalid signature for slot ${slot}`);
622
732
  continue;