@aztec/validator-client 0.0.1-commit.c31f2472 → 0.0.1-commit.c52d6e7

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (58) hide show
  1. package/README.md +63 -18
  2. package/dest/checkpoint_builder.d.ts +36 -17
  3. package/dest/checkpoint_builder.d.ts.map +1 -1
  4. package/dest/checkpoint_builder.js +143 -42
  5. package/dest/config.d.ts +9 -3
  6. package/dest/config.d.ts.map +1 -1
  7. package/dest/config.js +45 -7
  8. package/dest/duties/validation_service.d.ts +12 -13
  9. package/dest/duties/validation_service.d.ts.map +1 -1
  10. package/dest/duties/validation_service.js +33 -45
  11. package/dest/factory.d.ts +10 -4
  12. package/dest/factory.d.ts.map +1 -1
  13. package/dest/factory.js +19 -6
  14. package/dest/index.d.ts +2 -3
  15. package/dest/index.d.ts.map +1 -1
  16. package/dest/index.js +1 -2
  17. package/dest/key_store/ha_key_store.d.ts +1 -1
  18. package/dest/key_store/ha_key_store.d.ts.map +1 -1
  19. package/dest/key_store/ha_key_store.js +3 -3
  20. package/dest/key_store/web3signer_key_store.d.ts +10 -2
  21. package/dest/key_store/web3signer_key_store.d.ts.map +1 -1
  22. package/dest/key_store/web3signer_key_store.js +32 -41
  23. package/dest/metrics.d.ts +14 -2
  24. package/dest/metrics.d.ts.map +1 -1
  25. package/dest/metrics.js +27 -1
  26. package/dest/proposal_handler.d.ts +166 -0
  27. package/dest/proposal_handler.d.ts.map +1 -0
  28. package/dest/proposal_handler.js +1303 -0
  29. package/dest/validator.d.ts +65 -24
  30. package/dest/validator.d.ts.map +1 -1
  31. package/dest/validator.js +379 -234
  32. package/package.json +19 -19
  33. package/src/checkpoint_builder.ts +168 -43
  34. package/src/config.ts +53 -9
  35. package/src/duties/validation_service.ts +59 -54
  36. package/src/factory.ts +29 -4
  37. package/src/index.ts +1 -2
  38. package/src/key_store/ha_key_store.ts +3 -3
  39. package/src/key_store/web3signer_key_store.ts +43 -59
  40. package/src/metrics.ts +39 -1
  41. package/src/proposal_handler.ts +1409 -0
  42. package/src/validator.ts +511 -277
  43. package/dest/block_proposal_handler.d.ts +0 -63
  44. package/dest/block_proposal_handler.d.ts.map +0 -1
  45. package/dest/block_proposal_handler.js +0 -546
  46. package/dest/tx_validator/index.d.ts +0 -3
  47. package/dest/tx_validator/index.d.ts.map +0 -1
  48. package/dest/tx_validator/index.js +0 -2
  49. package/dest/tx_validator/nullifier_cache.d.ts +0 -14
  50. package/dest/tx_validator/nullifier_cache.d.ts.map +0 -1
  51. package/dest/tx_validator/nullifier_cache.js +0 -24
  52. package/dest/tx_validator/tx_validator_factory.d.ts +0 -19
  53. package/dest/tx_validator/tx_validator_factory.d.ts.map +0 -1
  54. package/dest/tx_validator/tx_validator_factory.js +0 -54
  55. package/src/block_proposal_handler.ts +0 -555
  56. package/src/tx_validator/index.ts +0 -2
  57. package/src/tx_validator/nullifier_cache.ts +0 -30
  58. package/src/tx_validator/tx_validator_factory.ts +0 -154
package/dest/validator.js CHANGED
@@ -1,46 +1,44 @@
1
1
  import { getBlobsPerL1Block } from '@aztec/blob-lib';
2
- import { BlockNumber } from '@aztec/foundation/branded-types';
3
- import { TimeoutError } from '@aztec/foundation/error';
2
+ import { CheckpointNumber } from '@aztec/foundation/branded-types';
3
+ import { FifoSet } from '@aztec/foundation/fifo-set';
4
4
  import { createLogger } from '@aztec/foundation/log';
5
- import { retryUntil } from '@aztec/foundation/retry';
6
5
  import { RunningPromise } from '@aztec/foundation/running-promise';
7
6
  import { sleep } from '@aztec/foundation/sleep';
8
7
  import { DateProvider } from '@aztec/foundation/timer';
9
8
  import { AuthRequest, AuthResponse, BlockProposalValidator, ReqRespSubProtocol } from '@aztec/p2p';
10
- import { OffenseType, WANT_TO_SLASH_EVENT } from '@aztec/slasher';
9
+ import { OffenseType, WANT_TO_CLEAR_SLASH_EVENT, WANT_TO_SLASH_EVENT, getOffenseTypeName } from '@aztec/slasher';
11
10
  import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
12
- import { accumulateCheckpointOutHashes } from '@aztec/stdlib/messaging';
11
+ import { ConsensusTimetable } from '@aztec/stdlib/timetable';
13
12
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
14
13
  import { getTelemetryClient } from '@aztec/telemetry-client';
15
- import { createHASigner } from '@aztec/validator-ha-signer/factory';
14
+ import { createHASigner, createLocalSignerWithProtection, createSignerFromSharedDb } from '@aztec/validator-ha-signer/factory';
16
15
  import { DutyType } from '@aztec/validator-ha-signer/types';
17
16
  import { EventEmitter } from 'events';
18
- import { BlockProposalHandler } from './block_proposal_handler.js';
17
+ import { DEFAULT_MAX_GOSSIP_CLOCK_DISPARITY_MS } from './config.js';
19
18
  import { ValidationService } from './duties/validation_service.js';
20
19
  import { HAKeyStore } from './key_store/ha_key_store.js';
21
20
  import { NodeKeystoreAdapter } from './key_store/node_keystore_adapter.js';
22
21
  import { ValidatorMetrics } from './metrics.js';
22
+ import { ProposalHandler, SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT, SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT } from './proposal_handler.js';
23
23
  // We maintain a set of proposers who have proposed invalid blocks.
24
24
  // Just cap the set to avoid unbounded growth.
25
25
  const MAX_PROPOSERS_OF_INVALID_BLOCKS = 1000;
26
- // What errors from the block proposal handler result in slashing
27
- const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
28
- 'state_mismatch',
29
- 'failed_txs'
30
- ];
26
+ const MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS = 1000;
27
+ const MAX_TRACKED_BAD_ATTESTATIONS = 10_000;
31
28
  /**
32
29
  * Validator Client
33
30
  */ export class ValidatorClient extends EventEmitter {
34
31
  keyStore;
35
32
  epochCache;
36
33
  p2pClient;
37
- blockProposalHandler;
34
+ proposalHandler;
38
35
  blockSource;
39
36
  checkpointsBuilder;
40
37
  worldState;
41
38
  l1ToL2MessageSource;
42
39
  config;
43
40
  blobClient;
41
+ slashingProtectionSigner;
44
42
  dateProvider;
45
43
  tracer;
46
44
  validationService;
@@ -48,18 +46,24 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
48
46
  log;
49
47
  // Whether it has already registered handlers on the p2p client
50
48
  hasRegisteredHandlers;
51
- // Used to check if we are sending the same proposal twice
52
- previousProposal;
49
+ /** Tracks the last block proposal we created, to detect duplicate proposal attempts. */ lastProposedBlock;
50
+ /** Tracks the last checkpoint proposal we created. */ lastProposedCheckpoint;
53
51
  lastEpochForCommitteeUpdateLoop;
54
52
  epochCacheUpdateLoop;
53
+ /** Tracks the last epoch in which each attester successfully submitted at least one attestation. */ lastAttestedEpochByAttester;
55
54
  proposersOfInvalidBlocks;
56
- constructor(keyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
57
- super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.blockProposalHandler = blockProposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.proposersOfInvalidBlocks = new Set();
55
+ invalidCheckpointProposalOffenseKeys;
56
+ oversizedProposalOffenseKeys;
57
+ badAttestationOffenseKeys;
58
+ /** Tracks the last checkpoint proposal we attested to, to prevent equivocation. */ lastAttestedProposal;
59
+ constructor(keyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
60
+ super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.proposalHandler = proposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.slashingProtectionSigner = slashingProtectionSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.lastAttestedEpochByAttester = new Map(), this.proposersOfInvalidBlocks = FifoSet.withLimit(MAX_PROPOSERS_OF_INVALID_BLOCKS), this.invalidCheckpointProposalOffenseKeys = FifoSet.withLimit(MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS), this.oversizedProposalOffenseKeys = FifoSet.withLimit(MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS), this.badAttestationOffenseKeys = FifoSet.withLimit(MAX_TRACKED_BAD_ATTESTATIONS);
58
61
  // Create child logger with fisherman prefix if in fisherman mode
59
62
  this.log = config.fishermanMode ? log.createChild('[FISHERMAN]') : log;
60
63
  this.tracer = telemetry.getTracer('Validator');
61
64
  this.metrics = new ValidatorMetrics(telemetry);
62
- this.validationService = new ValidationService(keyStore, this.log.createChild('validation-service'));
65
+ this.validationService = new ValidationService(keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
66
+ this.proposalHandler.setCheckpointProposalValidationFailureCallback((proposal, result, proposalInfo)=>this.handleInvalidCheckpointProposal(proposal, result, proposalInfo));
63
67
  // Refresh epoch cache every second to trigger alert if participation in committee changes
64
68
  this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), this.log, 1000);
65
69
  const myAddresses = this.getValidatorAddresses();
@@ -93,6 +97,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
93
97
  this.log.trace(`No committee found for slot`);
94
98
  return;
95
99
  }
100
+ this.metrics.setCurrentEpoch(epoch);
96
101
  if (epoch !== this.lastEpochForCommitteeUpdateLoop) {
97
102
  const me = this.getValidatorAddresses();
98
103
  const committeeSet = new Set(committee.map((v)=>v.toString()));
@@ -108,34 +113,70 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
108
113
  this.log.error(`Error updating epoch committee`, err);
109
114
  }
110
115
  }
111
- static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient()) {
116
+ static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, reexecutionTracker, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), slashingProtectionDb) {
112
117
  const metrics = new ValidatorMetrics(telemetry);
113
- const blockProposalValidator = new BlockProposalValidator(epochCache, {
114
- txsPermitted: !config.disableTransactions
118
+ const consensusTimetable = new ConsensusTimetable({
119
+ l1Constants: epochCache.getL1Constants(),
120
+ blockDuration: config.blockDurationMs / 1000
115
121
  });
116
- const blockProposalHandler = new BlockProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, metrics, dateProvider, telemetry);
117
- let validatorKeyStore = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
118
- if (config.haSigningEnabled) {
122
+ const blockProposalValidator = new BlockProposalValidator(epochCache, consensusTimetable, {
123
+ txsPermitted: !config.disableTransactions,
124
+ maxTxsPerBlock: config.validateMaxTxsPerBlock,
125
+ maxBlocksPerCheckpoint: config.maxBlocksPerCheckpoint,
126
+ skipSlotValidation: config.skipProposalSlotValidation,
127
+ signatureContext: {
128
+ chainId: config.l1ChainId,
129
+ rollupAddress: config.rollupAddress
130
+ },
131
+ clockDisparityMs: config.maxGossipClockDisparityMs ?? DEFAULT_MAX_GOSSIP_CLOCK_DISPARITY_MS
132
+ });
133
+ const proposalHandler = new ProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, consensusTimetable, config, blobClient, reexecutionTracker, metrics, dateProvider, telemetry, undefined);
134
+ const nodeKeystoreAdapter = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
135
+ let slashingProtectionSigner;
136
+ if (slashingProtectionDb) {
137
+ // Shared database mode: use a pre-existing database (e.g. for testing HA setups).
138
+ ({ signer: slashingProtectionSigner } = createSignerFromSharedDb(slashingProtectionDb, config, {
139
+ telemetryClient: telemetry,
140
+ dateProvider
141
+ }));
142
+ } else if (config.haSigningEnabled) {
143
+ // Multi-node HA mode: use PostgreSQL-backed distributed locking.
119
144
  // If maxStuckDutiesAgeMs is not explicitly set, compute it from Aztec slot duration
120
145
  const haConfig = {
121
146
  ...config,
122
147
  maxStuckDutiesAgeMs: config.maxStuckDutiesAgeMs ?? epochCache.getL1Constants().slotDuration * 2 * 1000
123
148
  };
124
- const { signer } = await createHASigner(haConfig);
125
- validatorKeyStore = new HAKeyStore(validatorKeyStore, signer);
149
+ ({ signer: slashingProtectionSigner } = await createHASigner(haConfig, {
150
+ telemetryClient: telemetry,
151
+ dateProvider
152
+ }));
153
+ } else {
154
+ // Single-node mode: use LMDB-backed local signing protection.
155
+ // This prevents double-signing if the node crashes and restarts mid-proposal.
156
+ ({ signer: slashingProtectionSigner } = await createLocalSignerWithProtection(config, {
157
+ telemetryClient: telemetry,
158
+ dateProvider
159
+ }));
126
160
  }
127
- const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, dateProvider, telemetry);
161
+ const validatorKeyStore = new HAKeyStore(nodeKeystoreAdapter, slashingProtectionSigner);
162
+ const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider, telemetry);
128
163
  return validator;
129
164
  }
130
165
  getValidatorAddresses() {
131
166
  return this.keyStore.getAddresses().filter((addr)=>!this.config.disabledValidators.some((disabled)=>disabled.equals(addr)));
132
167
  }
133
- getBlockProposalHandler() {
134
- return this.blockProposalHandler;
168
+ getProposalHandler() {
169
+ return this.proposalHandler;
135
170
  }
136
171
  signWithAddress(addr, msg, context) {
137
172
  return this.keyStore.signTypedDataWithAddress(addr, msg, context);
138
173
  }
174
+ getSignatureContext() {
175
+ return {
176
+ chainId: this.config.l1ChainId,
177
+ rollupAddress: this.config.rollupAddress
178
+ };
179
+ }
139
180
  getCoinbaseForAttestor(attestor) {
140
181
  return this.keyStore.getCoinbaseAddress(attestor);
141
182
  }
@@ -145,11 +186,23 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
145
186
  getConfig() {
146
187
  return this.config;
147
188
  }
189
+ hasProposalEquivocation(slotNumber) {
190
+ return this.proposalHandler.hasProposalEquivocation(slotNumber);
191
+ }
192
+ hasInvalidProposals(slotNumber) {
193
+ return this.proposalHandler.hasInvalidProposals(slotNumber);
194
+ }
148
195
  updateConfig(config) {
149
196
  this.config = {
150
197
  ...this.config,
151
198
  ...config
152
199
  };
200
+ this.proposalHandler.updateConfig(config);
201
+ }
202
+ reloadKeystore(newManager) {
203
+ const newAdapter = NodeKeystoreAdapter.fromKeyStoreManager(newManager);
204
+ this.keyStore = new HAKeyStore(newAdapter, this.slashingProtectionSigner);
205
+ this.validationService = new ValidationService(this.keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
153
206
  }
154
207
  async start() {
155
208
  if (this.epochCacheUpdateLoop.isRunning()) {
@@ -182,7 +235,22 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
182
235
  // The checkpoint is received as CheckpointProposalCore since the lastBlock is extracted
183
236
  // and processed separately via the block handler above.
184
237
  const checkpointHandler = (checkpoint, proposalSender)=>this.attestToCheckpointProposal(checkpoint, proposalSender);
185
- this.p2pClient.registerCheckpointProposalHandler(checkpointHandler);
238
+ this.p2pClient.registerValidatorCheckpointProposalHandler(checkpointHandler);
239
+ // Duplicate proposal handler - triggers slashing for equivocation
240
+ this.p2pClient.registerDuplicateProposalCallback((info)=>{
241
+ this.handleDuplicateProposal(info);
242
+ });
243
+ // Oversized proposal handler - triggers slashing for proposals beyond the per-checkpoint block limit
244
+ this.p2pClient.registerOversizedProposalCallback((info)=>{
245
+ this.handleOversizedProposal(info);
246
+ });
247
+ // Duplicate attestation handler - triggers slashing for attestation equivocation
248
+ this.p2pClient.registerDuplicateAttestationCallback((info)=>{
249
+ this.handleDuplicateAttestation(info);
250
+ });
251
+ this.p2pClient.registerCheckpointAttestationCallback((attestation)=>{
252
+ this.handleCheckpointAttestation(attestation);
253
+ });
186
254
  const myAddresses = this.getValidatorAddresses();
187
255
  this.p2pClient.registerThisValidatorAddresses(myAddresses);
188
256
  await this.p2pClient.addReqRespSubProtocol(ReqRespSubProtocol.AUTH, this.handleAuthRequest.bind(this));
@@ -203,6 +271,13 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
203
271
  this.log.warn(`Received block proposal with invalid signature for slot ${slotNumber}`);
204
272
  return false;
205
273
  }
274
+ // Log self-proposals from HA peers (same validator key on different nodes)
275
+ if (this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
276
+ this.log.verbose(`Processing block proposal from HA peer for slot ${slotNumber}`, {
277
+ proposer: proposer.toString(),
278
+ slotNumber
279
+ });
280
+ }
206
281
  // Check if we're in the committee (for metrics purposes)
207
282
  const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
208
283
  const partOfCommittee = inCommittee.length > 0;
@@ -215,21 +290,20 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
215
290
  txHashes: proposal.txHashes.map((t)=>t.toString()),
216
291
  fishermanMode: this.config.fishermanMode || false
217
292
  });
218
- // Reexecute txs if we are part of the committee, or if slashing is enabled, or if we are configured to always reexecute.
219
- // In fisherman mode, we always reexecute to validate proposals.
220
- const { validatorReexecute, slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } = this.config;
221
- const shouldReexecute = fishermanMode || slashBroadcastedInvalidBlockPenalty > 0n && validatorReexecute || partOfCommittee && validatorReexecute || alwaysReexecuteBlockProposals || this.blobClient.canUpload();
222
- const validationResult = await this.blockProposalHandler.handleBlockProposal(proposal, proposalSender, !!shouldReexecute && !escapeHatchOpen);
293
+ // Reexecute outside the escape hatch so slashing observers can detect invalid proposals even when penalties are 0.
294
+ const validationResult = await this.proposalHandler.handleBlockProposal(proposal, proposalSender, !escapeHatchOpen);
223
295
  if (!validationResult.isValid) {
224
- this.log.warn(`Block proposal validation failed: ${validationResult.reason}`, proposalInfo);
225
296
  const reason = validationResult.reason || 'unknown';
297
+ this.log.warn(`Block proposal validation failed: ${reason}`, proposalInfo);
226
298
  // Classify failure reason: bad proposal vs node issue
227
299
  const badProposalReasons = [
228
300
  'invalid_proposal',
229
301
  'state_mismatch',
230
302
  'failed_txs',
231
303
  'in_hash_mismatch',
232
- 'parent_block_wrong_slot'
304
+ 'parent_block_wrong_slot',
305
+ 'duplicate_txs',
306
+ 'invalid_embedded_txs'
233
307
  ];
234
308
  if (badProposalReasons.includes(reason)) {
235
309
  this.metrics.incFailedAttestationsBadProposal(1, reason, partOfCommittee);
@@ -237,10 +311,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
237
311
  // Node issues so we can't validate
238
312
  this.metrics.incFailedAttestationsNodeIssue(1, reason, partOfCommittee);
239
313
  }
240
- // Slash invalid block proposals (can happen even when not in committee)
241
- if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason) && slashBroadcastedInvalidBlockPenalty > 0n) {
242
- this.log.warn(`Slashing proposer for invalid block proposal`, proposalInfo);
314
+ if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason)) {
315
+ this.log.info(`Detected invalid block proposal offense`, {
316
+ ...proposalInfo,
317
+ amount: this.config.slashBroadcastedInvalidBlockPenalty,
318
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL)
319
+ });
243
320
  this.slashInvalidBlock(proposal);
321
+ this.markInvalidProposalSlot(proposal.slotNumber);
244
322
  }
245
323
  return false;
246
324
  }
@@ -262,45 +340,50 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
262
340
  * the lastBlock is extracted and processed separately via the block handler.
263
341
  * @returns Checkpoint attestations if valid, undefined otherwise
264
342
  */ async attestToCheckpointProposal(proposal, _proposalSender) {
265
- const slotNumber = proposal.slotNumber;
343
+ const proposalSlotNumber = proposal.slotNumber;
266
344
  const proposer = proposal.getSender();
267
345
  // If escape hatch is open for this slot's epoch, do not attest.
268
- if (await this.epochCache.isEscapeHatchOpenAtSlot(slotNumber)) {
269
- this.log.warn(`Escape hatch open for slot ${slotNumber}, skipping checkpoint attestation handling`);
346
+ if (await this.epochCache.isEscapeHatchOpenAtSlot(proposalSlotNumber)) {
347
+ this.log.warn(`Escape hatch open for slot ${proposalSlotNumber}, skipping checkpoint attestation handling`);
270
348
  return undefined;
271
349
  }
272
- // Reject proposals with invalid signatures
273
- if (!proposer) {
274
- this.log.warn(`Received checkpoint proposal with invalid signature for slot ${slotNumber}`);
350
+ // Early-out for equivocation: refuses if we've already attested to a higher slot.
351
+ if (!this.shouldAttestToSlot(proposalSlotNumber)) {
275
352
  return undefined;
276
353
  }
277
- // Check that I have any address in current committee before attesting
278
- const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
354
+ // Ignore proposals from ourselves (may happen in HA setups)
355
+ if (proposer && this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
356
+ this.log.debug(`Not attesting to block proposal from self for slot ${proposalSlotNumber}`, {
357
+ proposer: proposer.toString(),
358
+ proposalSlotNumber
359
+ });
360
+ return undefined;
361
+ }
362
+ // Check that I have any address in the committee where this checkpoint will land before attesting
363
+ const inCommittee = await this.epochCache.filterInCommittee(proposalSlotNumber, this.getValidatorAddresses());
279
364
  const partOfCommittee = inCommittee.length > 0;
280
365
  const proposalInfo = {
281
- slotNumber,
366
+ proposalSlotNumber,
282
367
  archive: proposal.archive.toString(),
283
- proposer: proposer.toString(),
284
- txCount: proposal.txHashes.length
368
+ proposer: proposer?.toString()
285
369
  };
286
- this.log.info(`Received checkpoint proposal for slot ${slotNumber}`, {
370
+ this.log.info(`Received checkpoint proposal for slot ${proposalSlotNumber}`, {
287
371
  ...proposalInfo,
288
- txHashes: proposal.txHashes.map((t)=>t.toString()),
289
372
  fishermanMode: this.config.fishermanMode || false
290
373
  });
291
- // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set)
374
+ // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set).
375
+ // Uses the cached result from the all-nodes callback if available (avoids double validation).
376
+ let checkpointNumber;
292
377
  if (this.config.skipCheckpointProposalValidation) {
293
- this.log.warn(`Skipping checkpoint proposal validation for slot ${slotNumber}`, proposalInfo);
378
+ this.log.warn(`Skipping checkpoint proposal validation for slot ${proposalSlotNumber}`, proposalInfo);
379
+ checkpointNumber = CheckpointNumber(0);
294
380
  } else {
295
- const validationResult = await this.validateCheckpointProposal(proposal, proposalInfo);
381
+ const validationResult = await this.proposalHandler.handleCheckpointProposal(proposal, proposalInfo);
296
382
  if (!validationResult.isValid) {
297
383
  this.log.warn(`Checkpoint proposal validation failed: ${validationResult.reason}`, proposalInfo);
298
384
  return undefined;
299
385
  }
300
- }
301
- // Upload blobs to filestore if we can (fire and forget)
302
- if (this.blobClient.canUpload()) {
303
- void this.uploadBlobsForCheckpoint(proposal, proposalInfo);
386
+ checkpointNumber = validationResult.checkpointNumber;
304
387
  }
305
388
  // Check that I have any address in current committee before attesting
306
389
  // In fisherman mode, we still create attestations for validation even if not in committee
@@ -309,12 +392,22 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
309
392
  return undefined;
310
393
  }
311
394
  // Provided all of the above checks pass, we can attest to the proposal
312
- this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${slotNumber}`, {
395
+ this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${proposalSlotNumber}`, {
313
396
  ...proposalInfo,
314
397
  inCommittee: partOfCommittee,
315
398
  fishermanMode: this.config.fishermanMode || false
316
399
  });
317
400
  this.metrics.incSuccessfulAttestations(inCommittee.length);
401
+ // Track epoch participation per attester: count each (attester, epoch) pair at most once
402
+ const proposalEpoch = getEpochAtSlot(proposalSlotNumber, this.epochCache.getL1Constants());
403
+ for (const attester of inCommittee){
404
+ const key = attester.toString();
405
+ const lastEpoch = this.lastAttestedEpochByAttester.get(key);
406
+ if (lastEpoch === undefined || proposalEpoch > lastEpoch) {
407
+ this.lastAttestedEpochByAttester.set(key, proposalEpoch);
408
+ this.metrics.incAttestedEpochCount(attester);
409
+ }
410
+ }
318
411
  // Determine which validators should attest
319
412
  let attestors;
320
413
  if (partOfCommittee) {
@@ -331,157 +424,47 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
331
424
  }
332
425
  if (this.config.fishermanMode) {
333
426
  // bail out early and don't save attestations to the pool in fisherman mode
334
- this.log.info(`Creating checkpoint attestations for slot ${slotNumber}`, {
427
+ this.log.info(`Creating checkpoint attestations for slot ${proposalSlotNumber}`, {
335
428
  ...proposalInfo,
336
429
  attestors: attestors.map((a)=>a.toString())
337
430
  });
338
431
  return undefined;
339
432
  }
340
- return this.createCheckpointAttestationsFromProposal(proposal, attestors);
341
- }
342
- async createCheckpointAttestationsFromProposal(proposal, attestors = []) {
343
- const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors);
344
- await this.p2pClient.addCheckpointAttestations(attestations);
345
- return attestations;
433
+ return await this.createCheckpointAttestationsFromProposal(proposal, attestors, checkpointNumber);
346
434
  }
347
435
  /**
348
- * Validates a checkpoint proposal by building the full checkpoint and comparing it with the proposal.
349
- * @returns Validation result with isValid flag and reason if invalid.
350
- */ async validateCheckpointProposal(proposal, proposalInfo) {
351
- const slot = proposal.slotNumber;
352
- const timeoutSeconds = 10; // TODO(palla/mbps): This should map to the timetable settings
353
- // Wait for last block to sync by archive
354
- let lastBlockHeader;
355
- try {
356
- lastBlockHeader = await retryUntil(async ()=>{
357
- await this.blockSource.syncImmediate();
358
- return this.blockSource.getBlockHeaderByArchive(proposal.archive);
359
- }, `waiting for block with archive ${proposal.archive.toString()} for slot ${slot}`, timeoutSeconds, 0.5);
360
- } catch (err) {
361
- if (err instanceof TimeoutError) {
362
- this.log.warn(`Timed out waiting for block with archive matching checkpoint proposal`, proposalInfo);
363
- return {
364
- isValid: false,
365
- reason: 'last_block_not_found'
366
- };
367
- }
368
- this.log.error(`Error fetching last block for checkpoint proposal`, err, proposalInfo);
369
- return {
370
- isValid: false,
371
- reason: 'block_fetch_error'
372
- };
436
+ * Checks if we should attest to a slot based on equivocation prevention rules.
437
+ * @returns true if we should attest, false if we should skip
438
+ */ shouldAttestToSlot(slotNumber) {
439
+ // If attestToEquivocatedProposals is true, always allow
440
+ if (this.config.attestToEquivocatedProposals) {
441
+ return true;
373
442
  }
374
- if (!lastBlockHeader) {
375
- this.log.warn(`Last block not found for checkpoint proposal`, proposalInfo);
376
- return {
377
- isValid: false,
378
- reason: 'last_block_not_found'
379
- };
380
- }
381
- // Get all full blocks for the slot and checkpoint
382
- const blocks = await this.blockSource.getBlocksForSlot(slot);
383
- if (blocks.length === 0) {
384
- this.log.warn(`No blocks found for slot ${slot}`, proposalInfo);
385
- return {
386
- isValid: false,
387
- reason: 'no_blocks_for_slot'
388
- };
389
- }
390
- this.log.debug(`Found ${blocks.length} blocks for slot ${slot}`, {
391
- ...proposalInfo,
392
- blockNumbers: blocks.map((b)=>b.number)
393
- });
394
- // Get checkpoint constants from first block
395
- const firstBlock = blocks[0];
396
- const constants = this.extractCheckpointConstants(firstBlock);
397
- const checkpointNumber = firstBlock.checkpointNumber;
398
- // Get L1-to-L2 messages for this checkpoint
399
- const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(checkpointNumber);
400
- // Compute the previous checkpoint out hashes for the epoch.
401
- // TODO: There can be a more efficient way to get the previous checkpoint out hashes without having to fetch the
402
- // actual checkpoints and the blocks/txs in them.
403
- const epoch = getEpochAtSlot(slot, this.epochCache.getL1Constants());
404
- const previousCheckpoints = (await this.blockSource.getCheckpointsForEpoch(epoch)).filter((b)=>b.number < checkpointNumber).sort((a, b)=>a.number - b.number);
405
- const previousCheckpointOutHashes = previousCheckpoints.map((c)=>c.getCheckpointOutHash());
406
- // Fork world state at the block before the first block
407
- const parentBlockNumber = BlockNumber(firstBlock.number - 1);
408
- const fork = await this.worldState.fork(parentBlockNumber);
409
- try {
410
- // Create checkpoint builder with all existing blocks
411
- const checkpointBuilder = await this.checkpointsBuilder.openCheckpoint(checkpointNumber, constants, l1ToL2Messages, previousCheckpointOutHashes, fork, blocks, this.log.getBindings());
412
- // Complete the checkpoint to get computed values
413
- const computedCheckpoint = await checkpointBuilder.completeCheckpoint();
414
- // Compare checkpoint header with proposal
415
- if (!computedCheckpoint.header.equals(proposal.checkpointHeader)) {
416
- this.log.warn(`Checkpoint header mismatch`, {
417
- ...proposalInfo,
418
- computed: computedCheckpoint.header.toInspect(),
419
- proposal: proposal.checkpointHeader.toInspect()
420
- });
421
- return {
422
- isValid: false,
423
- reason: 'checkpoint_header_mismatch'
424
- };
425
- }
426
- // Compare archive root with proposal
427
- if (!computedCheckpoint.archive.root.equals(proposal.archive)) {
428
- this.log.warn(`Archive root mismatch`, {
429
- ...proposalInfo,
430
- computed: computedCheckpoint.archive.root.toString(),
431
- proposal: proposal.archive.toString()
432
- });
433
- return {
434
- isValid: false,
435
- reason: 'archive_mismatch'
436
- };
437
- }
438
- // Check that the accumulated epoch out hash matches the value in the proposal.
439
- // The epoch out hash is the accumulated hash of all checkpoint out hashes in the epoch.
440
- const checkpointOutHash = computedCheckpoint.getCheckpointOutHash();
441
- const computedEpochOutHash = accumulateCheckpointOutHashes([
442
- ...previousCheckpointOutHashes,
443
- checkpointOutHash
444
- ]);
445
- const proposalEpochOutHash = proposal.checkpointHeader.epochOutHash;
446
- if (!computedEpochOutHash.equals(proposalEpochOutHash)) {
447
- this.log.warn(`Epoch out hash mismatch`, {
448
- proposalEpochOutHash: proposalEpochOutHash.toString(),
449
- computedEpochOutHash: computedEpochOutHash.toString(),
450
- checkpointOutHash: checkpointOutHash.toString(),
451
- previousCheckpointOutHashes: previousCheckpointOutHashes.map((h)=>h.toString()),
452
- ...proposalInfo
453
- });
454
- return {
455
- isValid: false,
456
- reason: 'out_hash_mismatch'
457
- };
458
- }
459
- this.log.verbose(`Checkpoint proposal validation successful for slot ${slot}`, proposalInfo);
460
- return {
461
- isValid: true
462
- };
463
- } finally{
464
- await fork.close();
443
+ // Check if incoming slot is strictly greater than last attested
444
+ if (this.lastAttestedProposal && slotNumber <= this.lastAttestedProposal.slotNumber) {
445
+ this.log.warn(`Refusing to process a proposal for slot ${slotNumber} given we already attested to a proposal for slot ${this.lastAttestedProposal.slotNumber}`);
446
+ return false;
465
447
  }
448
+ return true;
466
449
  }
467
- /**
468
- * Extract checkpoint global variables from a block.
469
- */ extractCheckpointConstants(block) {
470
- const gv = block.header.globalVariables;
471
- return {
472
- chainId: gv.chainId,
473
- version: gv.version,
474
- slotNumber: gv.slotNumber,
475
- coinbase: gv.coinbase,
476
- feeRecipient: gv.feeRecipient,
477
- gasFees: gv.gasFees
478
- };
450
+ async createCheckpointAttestationsFromProposal(proposal, attestors = [], checkpointNumber) {
451
+ // Equivocation check: must happen right before signing to minimize the race window
452
+ if (!this.shouldAttestToSlot(proposal.slotNumber)) {
453
+ return undefined;
454
+ }
455
+ const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors, checkpointNumber);
456
+ // Track the proposal we attested to (to prevent equivocation)
457
+ this.lastAttestedProposal = proposal;
458
+ await this.p2pClient.addOwnCheckpointAttestations(attestations);
459
+ return attestations;
479
460
  }
480
461
  /**
481
462
  * Uploads blobs for a checkpoint to the filestore (fire and forget).
482
463
  */ async uploadBlobsForCheckpoint(proposal, proposalInfo) {
483
464
  try {
484
- const lastBlockHeader = await this.blockSource.getBlockHeaderByArchive(proposal.archive);
465
+ const lastBlockHeader = (await this.blockSource.getBlockData({
466
+ archive: proposal.archive
467
+ }))?.header;
485
468
  if (!lastBlockHeader) {
486
469
  this.log.warn(`Failed to get last block header for blob upload`, proposalInfo);
487
470
  return;
@@ -492,7 +475,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
492
475
  return;
493
476
  }
494
477
  const blobFields = blocks.flatMap((b)=>b.toBlobFields());
495
- const blobs = getBlobsPerL1Block(blobFields);
478
+ const blobs = await getBlobsPerL1Block(blobFields);
496
479
  await this.blobClient.sendBlobsToFilestore(blobs);
497
480
  this.log.debug(`Uploaded ${blobs.length} blobs to filestore for checkpoint at slot ${proposal.slotNumber}`, {
498
481
  ...proposalInfo,
@@ -509,11 +492,6 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
509
492
  this.log.warn(`Cannot slash proposal with invalid signature`);
510
493
  return;
511
494
  }
512
- // Trim the set if it's too big.
513
- if (this.proposersOfInvalidBlocks.size > MAX_PROPOSERS_OF_INVALID_BLOCKS) {
514
- // remove oldest proposer. `values` is guaranteed to be in insertion order.
515
- this.proposersOfInvalidBlocks.delete(this.proposersOfInvalidBlocks.values().next().value);
516
- }
517
495
  this.proposersOfInvalidBlocks.add(proposer.toString());
518
496
  this.emit(WANT_TO_SLASH_EVENT, [
519
497
  {
@@ -524,37 +502,212 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
524
502
  }
525
503
  ]);
526
504
  }
527
- async createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
528
- // TODO(palla/mbps): Prevent double proposals properly
529
- // if (this.previousProposal?.slotNumber === blockHeader.globalVariables.slotNumber) {
530
- // this.log.verbose(`Already made a proposal for the same slot, skipping proposal`);
531
- // return Promise.resolve(undefined);
532
- // }
505
+ handleInvalidCheckpointProposal(proposal, result, proposalInfo) {
506
+ if (!SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT[result.reason]) {
507
+ return;
508
+ }
509
+ // The slot is already marked invalid by the all-nodes checkpoint handler that invokes this callback,
510
+ // so we only emit the proposer slash event here.
511
+ if (this.slashInvalidCheckpointProposal(proposal)) {
512
+ this.log.info(`Detected invalid checkpoint proposal offense`, {
513
+ ...proposalInfo,
514
+ reason: result.reason,
515
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
516
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL)
517
+ });
518
+ }
519
+ }
520
+ slashInvalidCheckpointProposal(proposal) {
521
+ const proposer = proposal.getSender();
522
+ if (!proposer) {
523
+ this.log.warn(`Cannot slash checkpoint proposal with invalid signature`, {
524
+ slotNumber: proposal.slotNumber,
525
+ archive: proposal.archive.toString()
526
+ });
527
+ return false;
528
+ }
529
+ const offenseType = OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL;
530
+ const offenseKey = `${proposer.toString()}:${offenseType}:${proposal.slotNumber}`;
531
+ if (!this.invalidCheckpointProposalOffenseKeys.addIfAbsent(offenseKey)) {
532
+ return false;
533
+ }
534
+ this.emit(WANT_TO_SLASH_EVENT, [
535
+ {
536
+ validator: proposer,
537
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
538
+ offenseType,
539
+ epochOrSlot: BigInt(proposal.slotNumber)
540
+ }
541
+ ]);
542
+ return true;
543
+ }
544
+ markInvalidProposalSlot(slotNumber) {
545
+ this.proposalHandler.markInvalidProposalSlot(slotNumber);
546
+ }
547
+ handleCheckpointAttestation(attestation) {
548
+ const slotNumber = attestation.slotNumber;
549
+ if (!this.proposalHandler.hasInvalidProposals(slotNumber) || this.proposalHandler.hasProposalEquivocation(slotNumber)) {
550
+ return;
551
+ }
552
+ const attester = attestation.getSender();
553
+ if (!attester) {
554
+ this.log.warn(`Cannot slash checkpoint attestation with invalid signature`, {
555
+ slotNumber,
556
+ archive: attestation.archive.toString()
557
+ });
558
+ return;
559
+ }
560
+ this.slashAttestedToInvalidCheckpointProposal(slotNumber, attester);
561
+ }
562
+ slashAttestedToInvalidCheckpointProposal(slotNumber, attester) {
563
+ const offenseKey = `${attester.toString()}:${OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL}:${slotNumber}`;
564
+ if (!this.badAttestationOffenseKeys.addIfAbsent(offenseKey)) {
565
+ return;
566
+ }
567
+ this.log.info(`Detected attestation to invalid checkpoint proposal offense`, {
568
+ attester: attester.toString(),
569
+ slotNumber,
570
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
571
+ offenseType: getOffenseTypeName(OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL)
572
+ });
573
+ this.emit(WANT_TO_SLASH_EVENT, [
574
+ {
575
+ validator: attester,
576
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
577
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
578
+ epochOrSlot: BigInt(slotNumber)
579
+ }
580
+ ]);
581
+ }
582
+ /**
583
+ * Handle detection of an oversized block proposal: one whose index within its checkpoint lands at or
584
+ * beyond the consensus per-checkpoint block limit. A single signed proposal at an illegal index is
585
+ * self-contained evidence, so emit an invalid-block-proposal slash event for the proposer, deduped per
586
+ * (proposer, slot) since the p2p layer reports every oversized proposal it stores.
587
+ */ handleOversizedProposal(info) {
588
+ const { slot, proposer } = info;
589
+ const offenseType = OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL;
590
+ if (!this.oversizedProposalOffenseKeys.addIfAbsent(`${proposer.toString()}:${offenseType}:${slot}`)) {
591
+ return;
592
+ }
593
+ this.log.info(`Detected oversized block proposal offense from ${proposer.toString()} at slot ${slot}`, {
594
+ proposer: proposer.toString(),
595
+ slot,
596
+ amount: this.config.slashBroadcastedInvalidBlockPenalty,
597
+ offenseType: getOffenseTypeName(offenseType)
598
+ });
599
+ this.emit(WANT_TO_SLASH_EVENT, [
600
+ {
601
+ validator: proposer,
602
+ amount: this.config.slashBroadcastedInvalidBlockPenalty,
603
+ offenseType,
604
+ epochOrSlot: BigInt(slot)
605
+ }
606
+ ]);
607
+ }
608
+ /**
609
+ * Handle detection of a duplicate proposal (equivocation).
610
+ * Emits a slash event when a proposer sends multiple proposals for the same position.
611
+ */ handleDuplicateProposal(info) {
612
+ const { slot, proposer, type } = info;
613
+ this.proposalHandler.markProposalEquivocation(slot);
614
+ this.log.info(`Detected duplicate ${type} proposal offense from ${proposer.toString()} at slot ${slot}`, {
615
+ proposer: proposer.toString(),
616
+ slot,
617
+ type,
618
+ amount: this.config.slashDuplicateProposalPenalty,
619
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_PROPOSAL)
620
+ });
621
+ this.emit(WANT_TO_SLASH_EVENT, [
622
+ {
623
+ validator: proposer,
624
+ amount: this.config.slashDuplicateProposalPenalty,
625
+ offenseType: OffenseType.DUPLICATE_PROPOSAL,
626
+ epochOrSlot: BigInt(slot)
627
+ }
628
+ ]);
629
+ this.emit(WANT_TO_CLEAR_SLASH_EVENT, [
630
+ {
631
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
632
+ epochOrSlot: BigInt(slot)
633
+ }
634
+ ]);
635
+ }
636
+ /**
637
+ * Handle detection of a duplicate attestation (equivocation).
638
+ * Emits a slash event when an attester signs attestations for different proposals at the same slot.
639
+ */ handleDuplicateAttestation(info) {
640
+ const { slot, attester } = info;
641
+ this.log.info(`Detected duplicate attestation offense from ${attester.toString()} at slot ${slot}`, {
642
+ attester: attester.toString(),
643
+ slot,
644
+ amount: this.config.slashDuplicateAttestationPenalty,
645
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_ATTESTATION)
646
+ });
647
+ this.emit(WANT_TO_SLASH_EVENT, [
648
+ {
649
+ validator: attester,
650
+ amount: this.config.slashDuplicateAttestationPenalty,
651
+ offenseType: OffenseType.DUPLICATE_ATTESTATION,
652
+ epochOrSlot: BigInt(slot)
653
+ }
654
+ ]);
655
+ }
656
+ async createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
657
+ // Validate that we're not creating a proposal for an older or equal position
658
+ if (this.lastProposedBlock) {
659
+ const lastSlot = this.lastProposedBlock.slotNumber;
660
+ const lastIndex = this.lastProposedBlock.indexWithinCheckpoint;
661
+ const newSlot = blockHeader.globalVariables.slotNumber;
662
+ if (newSlot < lastSlot || newSlot === lastSlot && indexWithinCheckpoint <= lastIndex) {
663
+ throw new Error(`Cannot create block proposal for slot ${newSlot} index ${indexWithinCheckpoint}: ` + `already proposed block for slot ${lastSlot} index ${lastIndex}`);
664
+ }
665
+ }
533
666
  this.log.info(`Assembling block proposal for block ${blockHeader.globalVariables.blockNumber} slot ${blockHeader.globalVariables.slotNumber}`);
534
- const newProposal = await this.validationService.createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
667
+ const newProposal = await this.validationService.createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
535
668
  ...options,
536
- broadcastInvalidBlockProposal: this.config.broadcastInvalidBlockProposal
669
+ broadcastInvalidBlockProposal: options.broadcastInvalidBlockProposal || this.config.broadcastInvalidBlockProposal
537
670
  });
538
- this.previousProposal = newProposal;
671
+ this.lastProposedBlock = newProposal;
539
672
  return newProposal;
540
673
  }
541
- async createCheckpointProposal(checkpointHeader, archive, lastBlockInfo, proposerAddress, options = {}) {
674
+ async createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options = {}) {
675
+ // Validate that we're not creating a proposal for an older or equal slot
676
+ if (this.lastProposedCheckpoint) {
677
+ const lastSlot = this.lastProposedCheckpoint.slotNumber;
678
+ const newSlot = checkpointHeader.slotNumber;
679
+ if (newSlot <= lastSlot) {
680
+ throw new Error(`Cannot create checkpoint proposal for slot ${newSlot}: ` + `already proposed checkpoint for slot ${lastSlot}`);
681
+ }
682
+ }
542
683
  this.log.info(`Assembling checkpoint proposal for slot ${checkpointHeader.slotNumber}`);
543
- return await this.validationService.createCheckpointProposal(checkpointHeader, archive, lastBlockInfo, proposerAddress, options);
684
+ const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options);
685
+ this.lastProposedCheckpoint = newProposal;
686
+ // Self-record this slot's outcome on the re-execution tracker. Proposers don't run their
687
+ // own proposals through `handleCheckpointProposal`, so without this call the proposer's
688
+ // sentinel would see no outcome for slots it proposed and would mis-attribute itself as
689
+ // inactive. We pass the locally-computed `archive` (not `newProposal.archive`, which may
690
+ // be intentionally corrupted under test-only flags); from the proposer's local-view
691
+ // perspective the work it just completed is valid by definition.
692
+ this.proposalHandler.recordOwnCheckpointProposalAsValid(checkpointHeader.slotNumber, archive, checkpointNumber);
693
+ return newProposal;
544
694
  }
545
695
  async broadcastBlockProposal(proposal) {
546
696
  await this.p2pClient.broadcastProposal(proposal);
547
697
  }
548
- async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber) {
549
- return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber);
698
+ async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber) {
699
+ return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber);
550
700
  }
551
- async collectOwnAttestations(proposal) {
701
+ async collectOwnAttestations(proposal, checkpointNumber) {
552
702
  const slot = proposal.slotNumber;
553
703
  const inCommittee = await this.epochCache.filterInCommittee(slot, this.getValidatorAddresses());
554
704
  this.log.debug(`Collecting ${inCommittee.length} self-attestations for slot ${slot}`, {
555
705
  inCommittee
556
706
  });
557
- const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee);
707
+ const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee, checkpointNumber);
708
+ if (!attestations) {
709
+ return [];
710
+ }
558
711
  // We broadcast our own attestations to our peers so, in case our block does not get mined on L1,
559
712
  // other nodes can see that our validators did attest to this block proposal, and do not slash us
560
713
  // due to inactivity for missed attestations.
@@ -563,7 +716,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
563
716
  });
564
717
  return attestations;
565
718
  }
566
- async collectAttestations(proposal, required, deadline) {
719
+ async collectAttestations(proposal, required, deadline, checkpointNumber) {
567
720
  // Wait and poll the p2pClient's attestation pool for this checkpoint until we have enough attestations
568
721
  const slot = proposal.slotNumber;
569
722
  this.log.debug(`Collecting ${required} attestations for slot ${slot} with deadline ${deadline.toISOString()}`);
@@ -571,28 +724,20 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
571
724
  this.log.error(`Deadline ${deadline.toISOString()} for collecting ${required} attestations for slot ${slot} is in the past`);
572
725
  throw new AttestationTimeoutError(0, required, slot);
573
726
  }
574
- await this.collectOwnAttestations(proposal);
575
- const proposalId = proposal.archive.toString();
727
+ await this.collectOwnAttestations(proposal, checkpointNumber);
728
+ const proposalPayloadHash = proposal.getPayloadHash();
576
729
  const myAddresses = this.getValidatorAddresses();
577
730
  let attestations = [];
578
731
  while(true){
579
- // Filter out attestations with a mismatching archive. This should NOT happen since we have verified
580
- // the proposer signature (ie our own) before accepting the attestation into the pool via the p2p client.
581
- const collectedAttestations = (await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalId)).filter((attestation)=>{
582
- if (!attestation.archive.equals(proposal.archive)) {
583
- this.log.warn(`Received attestation for slot ${slot} with mismatched archive from ${attestation.getSender()?.toString()}`, {
584
- attestationArchive: attestation.archive.toString(),
585
- proposalArchive: proposal.archive.toString()
586
- });
587
- return false;
588
- }
589
- return true;
590
- });
732
+ // The pool already filters by proposal payload hash; if any attestation slips through with a
733
+ // mismatched payload hash, drop it defensively. Equivocations are emitted as separate slash
734
+ // events from libp2p_service.
735
+ const collectedAttestations = await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalPayloadHash);
591
736
  // Log new attestations we collected
592
737
  const oldSenders = attestations.map((attestation)=>attestation.getSender());
593
738
  for (const collected of collectedAttestations){
594
739
  const collectedSender = collected.getSender();
595
- // Skip attestations with invalid signatures
740
+ // Skip attestations with invalid signatures. Should not happen as we don't add invalid attestations to our pool.
596
741
  if (!collectedSender) {
597
742
  this.log.warn(`Skipping attestation with invalid signature for slot ${slot}`);
598
743
  continue;