@aztec/validator-client 0.0.1-commit.b655e406 → 0.0.1-commit.d1f2d6c

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (69) hide show
  1. package/README.md +282 -0
  2. package/dest/block_proposal_handler.d.ts +24 -12
  3. package/dest/block_proposal_handler.d.ts.map +1 -1
  4. package/dest/block_proposal_handler.js +345 -86
  5. package/dest/checkpoint_builder.d.ts +67 -0
  6. package/dest/checkpoint_builder.d.ts.map +1 -0
  7. package/dest/checkpoint_builder.js +160 -0
  8. package/dest/config.d.ts +1 -1
  9. package/dest/config.d.ts.map +1 -1
  10. package/dest/config.js +17 -7
  11. package/dest/duties/validation_service.d.ts +42 -13
  12. package/dest/duties/validation_service.d.ts.map +1 -1
  13. package/dest/duties/validation_service.js +113 -31
  14. package/dest/factory.d.ts +13 -8
  15. package/dest/factory.d.ts.map +1 -1
  16. package/dest/factory.js +2 -2
  17. package/dest/index.d.ts +3 -1
  18. package/dest/index.d.ts.map +1 -1
  19. package/dest/index.js +2 -0
  20. package/dest/key_store/ha_key_store.d.ts +99 -0
  21. package/dest/key_store/ha_key_store.d.ts.map +1 -0
  22. package/dest/key_store/ha_key_store.js +208 -0
  23. package/dest/key_store/index.d.ts +2 -1
  24. package/dest/key_store/index.d.ts.map +1 -1
  25. package/dest/key_store/index.js +1 -0
  26. package/dest/key_store/interface.d.ts +36 -6
  27. package/dest/key_store/interface.d.ts.map +1 -1
  28. package/dest/key_store/local_key_store.d.ts +10 -5
  29. package/dest/key_store/local_key_store.d.ts.map +1 -1
  30. package/dest/key_store/local_key_store.js +9 -5
  31. package/dest/key_store/node_keystore_adapter.d.ts +18 -5
  32. package/dest/key_store/node_keystore_adapter.d.ts.map +1 -1
  33. package/dest/key_store/node_keystore_adapter.js +18 -4
  34. package/dest/key_store/web3signer_key_store.d.ts +10 -11
  35. package/dest/key_store/web3signer_key_store.d.ts.map +1 -1
  36. package/dest/key_store/web3signer_key_store.js +9 -5
  37. package/dest/metrics.d.ts +1 -1
  38. package/dest/metrics.d.ts.map +1 -1
  39. package/dest/metrics.js +8 -33
  40. package/dest/tx_validator/index.d.ts +3 -0
  41. package/dest/tx_validator/index.d.ts.map +1 -0
  42. package/dest/tx_validator/index.js +2 -0
  43. package/dest/tx_validator/nullifier_cache.d.ts +14 -0
  44. package/dest/tx_validator/nullifier_cache.d.ts.map +1 -0
  45. package/dest/tx_validator/nullifier_cache.js +24 -0
  46. package/dest/tx_validator/tx_validator_factory.d.ts +18 -0
  47. package/dest/tx_validator/tx_validator_factory.d.ts.map +1 -0
  48. package/dest/tx_validator/tx_validator_factory.js +54 -0
  49. package/dest/validator.d.ts +47 -18
  50. package/dest/validator.d.ts.map +1 -1
  51. package/dest/validator.js +365 -63
  52. package/package.json +22 -14
  53. package/src/block_proposal_handler.ts +272 -61
  54. package/src/checkpoint_builder.ts +284 -0
  55. package/src/config.ts +17 -6
  56. package/src/duties/validation_service.ts +157 -38
  57. package/src/factory.ts +17 -8
  58. package/src/index.ts +2 -0
  59. package/src/key_store/ha_key_store.ts +269 -0
  60. package/src/key_store/index.ts +1 -0
  61. package/src/key_store/interface.ts +44 -5
  62. package/src/key_store/local_key_store.ts +14 -5
  63. package/src/key_store/node_keystore_adapter.ts +28 -5
  64. package/src/key_store/web3signer_key_store.ts +18 -5
  65. package/src/metrics.ts +7 -34
  66. package/src/tx_validator/index.ts +2 -0
  67. package/src/tx_validator/nullifier_cache.ts +30 -0
  68. package/src/tx_validator/tx_validator_factory.ts +135 -0
  69. package/src/validator.ts +490 -91
package/dest/validator.js CHANGED
@@ -1,14 +1,22 @@
1
+ import { getBlobsPerL1Block } from '@aztec/blob-lib';
2
+ import { BlockNumber } from '@aztec/foundation/branded-types';
3
+ import { TimeoutError } from '@aztec/foundation/error';
1
4
  import { createLogger } from '@aztec/foundation/log';
5
+ import { retryUntil } from '@aztec/foundation/retry';
2
6
  import { RunningPromise } from '@aztec/foundation/running-promise';
3
7
  import { sleep } from '@aztec/foundation/sleep';
4
8
  import { DateProvider } from '@aztec/foundation/timer';
5
9
  import { AuthRequest, AuthResponse, BlockProposalValidator, ReqRespSubProtocol } from '@aztec/p2p';
6
10
  import { OffenseType, WANT_TO_SLASH_EVENT } from '@aztec/slasher';
11
+ import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
7
12
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
8
13
  import { getTelemetryClient } from '@aztec/telemetry-client';
14
+ import { createHASigner } from '@aztec/validator-ha-signer/factory';
15
+ import { DutyType } from '@aztec/validator-ha-signer/types';
9
16
  import { EventEmitter } from 'events';
10
17
  import { BlockProposalHandler } from './block_proposal_handler.js';
11
18
  import { ValidationService } from './duties/validation_service.js';
19
+ import { HAKeyStore } from './key_store/ha_key_store.js';
12
20
  import { NodeKeystoreAdapter } from './key_store/node_keystore_adapter.js';
13
21
  import { ValidatorMetrics } from './metrics.js';
14
22
  // We maintain a set of proposers who have proposed invalid blocks.
@@ -26,12 +34,17 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
26
34
  epochCache;
27
35
  p2pClient;
28
36
  blockProposalHandler;
37
+ blockSource;
38
+ checkpointsBuilder;
39
+ worldState;
40
+ l1ToL2MessageSource;
29
41
  config;
42
+ blobClient;
30
43
  dateProvider;
31
- log;
32
44
  tracer;
33
45
  validationService;
34
46
  metrics;
47
+ log;
35
48
  // Whether it has already registered handlers on the p2p client
36
49
  hasRegisteredHandlers;
37
50
  // Used to check if we are sending the same proposal twice
@@ -39,13 +52,19 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
39
52
  lastEpochForCommitteeUpdateLoop;
40
53
  epochCacheUpdateLoop;
41
54
  proposersOfInvalidBlocks;
42
- constructor(keyStore, epochCache, p2pClient, blockProposalHandler, config, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
43
- super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.blockProposalHandler = blockProposalHandler, this.config = config, this.dateProvider = dateProvider, this.log = log, this.hasRegisteredHandlers = false, this.proposersOfInvalidBlocks = new Set();
55
+ // TODO(palla/mbps): Remove this once checkpoint validation is stable and we can validate all blocks properly.
56
+ // Tracks slots for which we have successfully validated a block proposal, so we can attest to checkpoint proposals for those slots.
57
+ // eslint-disable-next-line aztec-custom/no-non-primitive-in-collections
58
+ validatedBlockSlots;
59
+ constructor(keyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
60
+ super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.blockProposalHandler = blockProposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.proposersOfInvalidBlocks = new Set(), this.validatedBlockSlots = new Set();
61
+ // Create child logger with fisherman prefix if in fisherman mode
62
+ this.log = config.fishermanMode ? log.createChild('[FISHERMAN]') : log;
44
63
  this.tracer = telemetry.getTracer('Validator');
45
64
  this.metrics = new ValidatorMetrics(telemetry);
46
- this.validationService = new ValidationService(keyStore, log.createChild('validation-service'));
65
+ this.validationService = new ValidationService(keyStore, this.log.createChild('validation-service'));
47
66
  // Refresh epoch cache every second to trigger alert if participation in committee changes
48
- this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), log, 1000);
67
+ this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), this.log, 1000);
49
68
  const myAddresses = this.getValidatorAddresses();
50
69
  this.log.verbose(`Initialized validator with addresses: ${myAddresses.map((a)=>a.toString()).join(', ')}`);
51
70
  }
@@ -92,13 +111,23 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
92
111
  this.log.error(`Error updating epoch committee`, err);
93
112
  }
94
113
  }
95
- static new(config, blockBuilder, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, dateProvider = new DateProvider(), telemetry = getTelemetryClient()) {
114
+ static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient()) {
96
115
  const metrics = new ValidatorMetrics(telemetry);
97
116
  const blockProposalValidator = new BlockProposalValidator(epochCache, {
98
117
  txsPermitted: !config.disableTransactions
99
118
  });
100
- const blockProposalHandler = new BlockProposalHandler(blockBuilder, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, config, metrics, dateProvider, telemetry);
101
- const validator = new ValidatorClient(NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager), epochCache, p2pClient, blockProposalHandler, config, dateProvider, telemetry);
119
+ const blockProposalHandler = new BlockProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, metrics, dateProvider, telemetry);
120
+ let validatorKeyStore = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
121
+ if (config.haSigningEnabled) {
122
+ // If maxStuckDutiesAgeMs is not explicitly set, compute it from Aztec slot duration
123
+ const haConfig = {
124
+ ...config,
125
+ maxStuckDutiesAgeMs: config.maxStuckDutiesAgeMs ?? epochCache.getL1Constants().slotDuration * 2 * 1000
126
+ };
127
+ const { signer } = await createHASigner(haConfig);
128
+ validatorKeyStore = new HAKeyStore(validatorKeyStore, signer);
129
+ }
130
+ const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, dateProvider, telemetry);
102
131
  return validator;
103
132
  }
104
133
  getValidatorAddresses() {
@@ -107,12 +136,8 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
107
136
  getBlockProposalHandler() {
108
137
  return this.blockProposalHandler;
109
138
  }
110
- // Proxy method for backwards compatibility with tests
111
- reExecuteTransactions(proposal, blockNumber, txs, l1ToL2Messages) {
112
- return this.blockProposalHandler.reexecuteTransactions(proposal, blockNumber, txs, l1ToL2Messages);
113
- }
114
- signWithAddress(addr, msg) {
115
- return this.keyStore.signTypedDataWithAddress(addr, msg);
139
+ signWithAddress(addr, msg, context) {
140
+ return this.keyStore.signTypedDataWithAddress(addr, msg, context);
116
141
  }
117
142
  getCoinbaseForAttestor(attestor) {
118
143
  return this.keyStore.getCoinbaseAddress(attestor);
@@ -134,57 +159,72 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
134
159
  this.log.warn(`Validator client already started`);
135
160
  return;
136
161
  }
162
+ await this.keyStore.start();
137
163
  await this.registerHandlers();
138
164
  const myAddresses = this.getValidatorAddresses();
139
165
  const inCommittee = await this.epochCache.filterInCommittee('now', myAddresses);
166
+ this.log.info(`Started validator with addresses: ${myAddresses.map((a)=>a.toString()).join(', ')}`);
140
167
  if (inCommittee.length > 0) {
141
- this.log.info(`Started validator with addresses in current validator committee: ${inCommittee.map((a)=>a.toString()).join(', ')}`);
142
- } else {
143
- this.log.info(`Started validator with addresses: ${myAddresses.map((a)=>a.toString()).join(', ')}`);
168
+ this.log.info(`Addresses in current validator committee: ${inCommittee.map((a)=>a.toString()).join(', ')}`);
144
169
  }
145
170
  this.epochCacheUpdateLoop.start();
146
171
  return Promise.resolve();
147
172
  }
148
173
  async stop() {
149
174
  await this.epochCacheUpdateLoop.stop();
175
+ await this.keyStore.stop();
150
176
  }
151
177
  /** Register handlers on the p2p client */ async registerHandlers() {
152
178
  if (!this.hasRegisteredHandlers) {
153
179
  this.hasRegisteredHandlers = true;
154
180
  this.log.debug(`Registering validator handlers for p2p client`);
155
- const handler = (block, proposalSender)=>this.attestToProposal(block, proposalSender);
156
- this.p2pClient.registerBlockProposalHandler(handler);
181
+ // Block proposal handler - validates but does NOT attest (validators only attest to checkpoints)
182
+ const blockHandler = (block, proposalSender)=>this.validateBlockProposal(block, proposalSender);
183
+ this.p2pClient.registerBlockProposalHandler(blockHandler);
184
+ // Checkpoint proposal handler - validates and creates attestations
185
+ // The checkpoint is received as CheckpointProposalCore since the lastBlock is extracted
186
+ // and processed separately via the block handler above.
187
+ const checkpointHandler = (checkpoint, proposalSender)=>this.attestToCheckpointProposal(checkpoint, proposalSender);
188
+ this.p2pClient.registerCheckpointProposalHandler(checkpointHandler);
157
189
  const myAddresses = this.getValidatorAddresses();
158
190
  this.p2pClient.registerThisValidatorAddresses(myAddresses);
159
191
  await this.p2pClient.addReqRespSubProtocol(ReqRespSubProtocol.AUTH, this.handleAuthRequest.bind(this));
160
192
  }
161
193
  }
162
- async attestToProposal(proposal, proposalSender) {
163
- const slotNumber = proposal.slotNumber.toBigInt();
194
+ /**
195
+ * Validate a block proposal from a peer.
196
+ * Note: Validators do NOT attest to individual blocks - attestations are only for checkpoint proposals.
197
+ * @returns true if the proposal is valid, false otherwise
198
+ */ async validateBlockProposal(proposal, proposalSender) {
199
+ const slotNumber = proposal.slotNumber;
200
+ // Note: During escape hatch, we still want to "validate" proposals for observability,
201
+ // but we intentionally reject them and disable slashing invalid block and attestation flow.
202
+ const escapeHatchOpen = await this.epochCache.isEscapeHatchOpenAtSlot(slotNumber);
164
203
  const proposer = proposal.getSender();
165
204
  // Reject proposals with invalid signatures
166
205
  if (!proposer) {
167
- this.log.warn(`Received proposal with invalid signature for slot ${slotNumber}`);
168
- return undefined;
206
+ this.log.warn(`Received block proposal with invalid signature for slot ${slotNumber}`);
207
+ return false;
169
208
  }
170
- // Check that I have any address in current committee before attesting
209
+ // Check if we're in the committee (for metrics purposes)
171
210
  const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
172
211
  const partOfCommittee = inCommittee.length > 0;
173
212
  const proposalInfo = {
174
213
  ...proposal.toBlockInfo(),
175
214
  proposer: proposer.toString()
176
215
  };
177
- this.log.info(`Received proposal for slot ${slotNumber}`, {
216
+ this.log.info(`Received block proposal for slot ${slotNumber}`, {
178
217
  ...proposalInfo,
179
- txHashes: proposal.txHashes.map((t)=>t.toString())
218
+ txHashes: proposal.txHashes.map((t)=>t.toString()),
219
+ fishermanMode: this.config.fishermanMode || false
180
220
  });
181
- // Reexecute txs if we are part of the committee so we can attest, or if slashing is enabled so we can slash
182
- // invalid proposals even when not in the committee, or if we are configured to always reexecute for monitoring purposes.
183
- const { validatorReexecute, slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals } = this.config;
184
- const shouldReexecute = slashBroadcastedInvalidBlockPenalty > 0n && validatorReexecute || partOfCommittee && validatorReexecute || alwaysReexecuteBlockProposals;
185
- const validationResult = await this.blockProposalHandler.handleBlockProposal(proposal, proposalSender, !!shouldReexecute);
221
+ // Reexecute txs if we are part of the committee, or if slashing is enabled, or if we are configured to always reexecute.
222
+ // In fisherman mode, we always reexecute to validate proposals.
223
+ const { validatorReexecute, slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } = this.config;
224
+ const shouldReexecute = fishermanMode || slashBroadcastedInvalidBlockPenalty > 0n && validatorReexecute || partOfCommittee && validatorReexecute || alwaysReexecuteBlockProposals || this.blobClient.canUpload();
225
+ const validationResult = await this.blockProposalHandler.handleBlockProposal(proposal, proposalSender, !!shouldReexecute && !escapeHatchOpen);
186
226
  if (!validationResult.isValid) {
187
- this.log.warn(`Proposal validation failed: ${validationResult.reason}`, proposalInfo);
227
+ this.log.warn(`Block proposal validation failed: ${validationResult.reason}`, proposalInfo);
188
228
  const reason = validationResult.reason || 'unknown';
189
229
  // Classify failure reason: bad proposal vs node issue
190
230
  const badProposalReasons = [
@@ -197,26 +237,276 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
197
237
  if (badProposalReasons.includes(reason)) {
198
238
  this.metrics.incFailedAttestationsBadProposal(1, reason, partOfCommittee);
199
239
  } else {
200
- // Node issues so we can't attest
240
+ // Node issues so we can't validate
201
241
  this.metrics.incFailedAttestationsNodeIssue(1, reason, partOfCommittee);
202
242
  }
203
243
  // Slash invalid block proposals (can happen even when not in committee)
204
- if (validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason) && slashBroadcastedInvalidBlockPenalty > 0n) {
244
+ if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason) && slashBroadcastedInvalidBlockPenalty > 0n) {
205
245
  this.log.warn(`Slashing proposer for invalid block proposal`, proposalInfo);
206
246
  this.slashInvalidBlock(proposal);
207
247
  }
248
+ return false;
249
+ }
250
+ this.log.info(`Validated block proposal for slot ${slotNumber}`, {
251
+ ...proposalInfo,
252
+ inCommittee: partOfCommittee,
253
+ fishermanMode: this.config.fishermanMode || false,
254
+ escapeHatchOpen
255
+ });
256
+ if (escapeHatchOpen) {
257
+ this.log.warn(`Escape hatch open for slot ${slotNumber}, rejecting block proposal`, proposalInfo);
258
+ return false;
259
+ }
260
+ // TODO(palla/mbps): Remove this once checkpoint validation is stable.
261
+ // Track that we successfully validated a block for this slot, so we can attest to checkpoint proposals for it.
262
+ this.validatedBlockSlots.add(slotNumber);
263
+ return true;
264
+ }
265
+ /**
266
+ * Validate and attest to a checkpoint proposal from a peer.
267
+ * The proposal is received as CheckpointProposalCore (without lastBlock) since
268
+ * the lastBlock is extracted and processed separately via the block handler.
269
+ * @returns Checkpoint attestations if valid, undefined otherwise
270
+ */ async attestToCheckpointProposal(proposal, _proposalSender) {
271
+ const slotNumber = proposal.slotNumber;
272
+ const proposer = proposal.getSender();
273
+ // If escape hatch is open for this slot's epoch, do not attest.
274
+ if (await this.epochCache.isEscapeHatchOpenAtSlot(slotNumber)) {
275
+ this.log.warn(`Escape hatch open for slot ${slotNumber}, skipping checkpoint attestation handling`);
276
+ return undefined;
277
+ }
278
+ // Reject proposals with invalid signatures
279
+ if (!proposer) {
280
+ this.log.warn(`Received checkpoint proposal with invalid signature for slot ${slotNumber}`);
208
281
  return undefined;
209
282
  }
210
283
  // Check that I have any address in current committee before attesting
211
- if (!partOfCommittee) {
284
+ const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
285
+ const partOfCommittee = inCommittee.length > 0;
286
+ const proposalInfo = {
287
+ slotNumber,
288
+ archive: proposal.archive.toString(),
289
+ proposer: proposer.toString(),
290
+ txCount: proposal.txHashes.length
291
+ };
292
+ this.log.info(`Received checkpoint proposal for slot ${slotNumber}`, {
293
+ ...proposalInfo,
294
+ txHashes: proposal.txHashes.map((t)=>t.toString()),
295
+ fishermanMode: this.config.fishermanMode || false
296
+ });
297
+ // TODO(palla/mbps): Remove this once checkpoint validation is stable.
298
+ // Check that we have successfully validated a block for this slot before attesting to the checkpoint.
299
+ if (!this.validatedBlockSlots.has(slotNumber)) {
300
+ this.log.warn(`No validated block found for slot ${slotNumber}, refusing to attest to checkpoint`, proposalInfo);
301
+ return undefined;
302
+ }
303
+ // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set)
304
+ // TODO(palla/mbps): Change default to false once checkpoint validation is stable.
305
+ if (this.config.skipCheckpointProposalValidation !== false) {
306
+ this.log.verbose(`Skipping checkpoint proposal validation for slot ${slotNumber}`, proposalInfo);
307
+ } else {
308
+ const validationResult = await this.validateCheckpointProposal(proposal, proposalInfo);
309
+ if (!validationResult.isValid) {
310
+ this.log.warn(`Checkpoint proposal validation failed: ${validationResult.reason}`, proposalInfo);
311
+ return undefined;
312
+ }
313
+ }
314
+ // Upload blobs to filestore if we can (fire and forget)
315
+ if (this.blobClient.canUpload()) {
316
+ void this.uploadBlobsForCheckpoint(proposal, proposalInfo);
317
+ }
318
+ // Check that I have any address in current committee before attesting
319
+ // In fisherman mode, we still create attestations for validation even if not in committee
320
+ if (!partOfCommittee && !this.config.fishermanMode) {
212
321
  this.log.verbose(`No validator in the current committee, skipping attestation`, proposalInfo);
213
322
  return undefined;
214
323
  }
215
324
  // Provided all of the above checks pass, we can attest to the proposal
216
- this.log.info(`Attesting to proposal for slot ${slotNumber}`, proposalInfo);
325
+ this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${slotNumber}`, {
326
+ ...proposalInfo,
327
+ inCommittee: partOfCommittee,
328
+ fishermanMode: this.config.fishermanMode || false
329
+ });
217
330
  this.metrics.incSuccessfulAttestations(inCommittee.length);
218
- // If the above function does not throw an error, then we can attest to the proposal
219
- return this.createBlockAttestationsFromProposal(proposal, inCommittee);
331
+ // Determine which validators should attest
332
+ let attestors;
333
+ if (partOfCommittee) {
334
+ attestors = inCommittee;
335
+ } else if (this.config.fishermanMode) {
336
+ // In fisherman mode, create attestations for validation purposes even if not in committee. These won't be broadcast.
337
+ attestors = this.getValidatorAddresses();
338
+ } else {
339
+ attestors = [];
340
+ }
341
+ // Only create attestations if we have attestors
342
+ if (attestors.length === 0) {
343
+ return undefined;
344
+ }
345
+ if (this.config.fishermanMode) {
346
+ // bail out early and don't save attestations to the pool in fisherman mode
347
+ this.log.info(`Creating checkpoint attestations for slot ${slotNumber}`, {
348
+ ...proposalInfo,
349
+ attestors: attestors.map((a)=>a.toString())
350
+ });
351
+ return undefined;
352
+ }
353
+ return this.createCheckpointAttestationsFromProposal(proposal, attestors);
354
+ }
355
+ async createCheckpointAttestationsFromProposal(proposal, attestors = []) {
356
+ const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors);
357
+ await this.p2pClient.addCheckpointAttestations(attestations);
358
+ return attestations;
359
+ }
360
+ /**
361
+ * Validates a checkpoint proposal by building the full checkpoint and comparing it with the proposal.
362
+ * @returns Validation result with isValid flag and reason if invalid.
363
+ */ async validateCheckpointProposal(proposal, proposalInfo) {
364
+ const slot = proposal.slotNumber;
365
+ const timeoutSeconds = 10;
366
+ // Wait for last block to sync by archive
367
+ let lastBlockHeader;
368
+ try {
369
+ lastBlockHeader = await retryUntil(async ()=>{
370
+ await this.blockSource.syncImmediate();
371
+ return this.blockSource.getBlockHeaderByArchive(proposal.archive);
372
+ }, `waiting for block with archive ${proposal.archive.toString()} for slot ${slot}`, timeoutSeconds, 0.5);
373
+ } catch (err) {
374
+ if (err instanceof TimeoutError) {
375
+ this.log.warn(`Timed out waiting for block with archive matching checkpoint proposal`, proposalInfo);
376
+ return {
377
+ isValid: false,
378
+ reason: 'last_block_not_found'
379
+ };
380
+ }
381
+ this.log.error(`Error fetching last block for checkpoint proposal`, err, proposalInfo);
382
+ return {
383
+ isValid: false,
384
+ reason: 'block_fetch_error'
385
+ };
386
+ }
387
+ if (!lastBlockHeader) {
388
+ this.log.warn(`Last block not found for checkpoint proposal`, proposalInfo);
389
+ return {
390
+ isValid: false,
391
+ reason: 'last_block_not_found'
392
+ };
393
+ }
394
+ // Get all full blocks for the slot and checkpoint
395
+ const blocks = await this.blockSource.getBlocksForSlot(slot);
396
+ if (blocks.length === 0) {
397
+ this.log.warn(`No blocks found for slot ${slot}`, proposalInfo);
398
+ return {
399
+ isValid: false,
400
+ reason: 'no_blocks_for_slot'
401
+ };
402
+ }
403
+ this.log.debug(`Found ${blocks.length} blocks for slot ${slot}`, {
404
+ ...proposalInfo,
405
+ blockNumbers: blocks.map((b)=>b.number)
406
+ });
407
+ // Get checkpoint constants from first block
408
+ const firstBlock = blocks[0];
409
+ const constants = this.extractCheckpointConstants(firstBlock);
410
+ const checkpointNumber = firstBlock.checkpointNumber;
411
+ // Get L1-to-L2 messages for this checkpoint
412
+ const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(checkpointNumber);
413
+ // Compute the previous checkpoint out hashes for the epoch.
414
+ // TODO: There can be a more efficient way to get the previous checkpoint out hashes without having to fetch the
415
+ // actual checkpoints and the blocks/txs in them.
416
+ const epoch = getEpochAtSlot(slot, this.epochCache.getL1Constants());
417
+ const previousCheckpoints = (await this.blockSource.getCheckpointsForEpoch(epoch)).filter((b)=>b.number < checkpointNumber).sort((a, b)=>a.number - b.number);
418
+ const previousCheckpointOutHashes = previousCheckpoints.map((c)=>c.getCheckpointOutHash());
419
+ // Fork world state at the block before the first block
420
+ const parentBlockNumber = BlockNumber(firstBlock.number - 1);
421
+ const fork = await this.worldState.fork(parentBlockNumber);
422
+ try {
423
+ // Create checkpoint builder with all existing blocks
424
+ const checkpointBuilder = await this.checkpointsBuilder.openCheckpoint(checkpointNumber, constants, l1ToL2Messages, previousCheckpointOutHashes, fork, blocks);
425
+ // Complete the checkpoint to get computed values
426
+ const computedCheckpoint = await checkpointBuilder.completeCheckpoint();
427
+ // Compare checkpoint header with proposal
428
+ if (!computedCheckpoint.header.equals(proposal.checkpointHeader)) {
429
+ this.log.warn(`Checkpoint header mismatch`, {
430
+ ...proposalInfo,
431
+ computed: computedCheckpoint.header.toInspect(),
432
+ proposal: proposal.checkpointHeader.toInspect()
433
+ });
434
+ return {
435
+ isValid: false,
436
+ reason: 'checkpoint_header_mismatch'
437
+ };
438
+ }
439
+ // Compare archive root with proposal
440
+ if (!computedCheckpoint.archive.root.equals(proposal.archive)) {
441
+ this.log.warn(`Archive root mismatch`, {
442
+ ...proposalInfo,
443
+ computed: computedCheckpoint.archive.root.toString(),
444
+ proposal: proposal.archive.toString()
445
+ });
446
+ return {
447
+ isValid: false,
448
+ reason: 'archive_mismatch'
449
+ };
450
+ }
451
+ // Check that the accumulated out hash matches the value in the proposal.
452
+ const computedOutHash = computedCheckpoint.getCheckpointOutHash();
453
+ const proposalOutHash = proposal.checkpointHeader.epochOutHash;
454
+ if (!computedOutHash.equals(proposalOutHash)) {
455
+ this.log.warn(`Epoch out hash mismatch`, {
456
+ proposalOutHash: proposalOutHash.toString(),
457
+ computedOutHash: computedOutHash.toString(),
458
+ ...proposalInfo
459
+ });
460
+ return {
461
+ isValid: false,
462
+ reason: 'out_hash_mismatch'
463
+ };
464
+ }
465
+ this.log.verbose(`Checkpoint proposal validation successful for slot ${slot}`, proposalInfo);
466
+ return {
467
+ isValid: true
468
+ };
469
+ } finally{
470
+ await fork.close();
471
+ }
472
+ }
473
+ /**
474
+ * Extract checkpoint global variables from a block.
475
+ */ extractCheckpointConstants(block) {
476
+ const gv = block.header.globalVariables;
477
+ return {
478
+ chainId: gv.chainId,
479
+ version: gv.version,
480
+ slotNumber: gv.slotNumber,
481
+ coinbase: gv.coinbase,
482
+ feeRecipient: gv.feeRecipient,
483
+ gasFees: gv.gasFees
484
+ };
485
+ }
486
+ /**
487
+ * Uploads blobs for a checkpoint to the filestore (fire and forget).
488
+ */ async uploadBlobsForCheckpoint(proposal, proposalInfo) {
489
+ try {
490
+ const lastBlockHeader = await this.blockSource.getBlockHeaderByArchive(proposal.archive);
491
+ if (!lastBlockHeader) {
492
+ this.log.warn(`Failed to get last block header for blob upload`, proposalInfo);
493
+ return;
494
+ }
495
+ const blocks = await this.blockSource.getBlocksForSlot(proposal.slotNumber);
496
+ if (blocks.length === 0) {
497
+ this.log.warn(`No blocks found for blob upload`, proposalInfo);
498
+ return;
499
+ }
500
+ const blobFields = blocks.flatMap((b)=>b.toBlobFields());
501
+ const blobs = getBlobsPerL1Block(blobFields);
502
+ await this.blobClient.sendBlobsToFilestore(blobs);
503
+ this.log.debug(`Uploaded ${blobs.length} blobs to filestore for checkpoint at slot ${proposal.slotNumber}`, {
504
+ ...proposalInfo,
505
+ numBlobs: blobs.length
506
+ });
507
+ } catch (err) {
508
+ this.log.warn(`Failed to upload blobs for checkpoint: ${err}`, proposalInfo);
509
+ }
220
510
  }
221
511
  slashInvalidBlock(proposal) {
222
512
  const proposer = proposal.getSender();
@@ -236,39 +526,52 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
236
526
  validator: proposer,
237
527
  amount: this.config.slashBroadcastedInvalidBlockPenalty,
238
528
  offenseType: OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL,
239
- epochOrSlot: proposal.slotNumber.toBigInt()
529
+ epochOrSlot: BigInt(proposal.slotNumber)
240
530
  }
241
531
  ]);
242
532
  }
243
- async createBlockProposal(blockNumber, header, archive, stateReference, txs, proposerAddress, options) {
244
- if (this.previousProposal?.slotNumber.equals(header.slotNumber)) {
245
- this.log.verbose(`Already made a proposal for the same slot, skipping proposal`);
246
- return Promise.resolve(undefined);
247
- }
248
- const newProposal = await this.validationService.createBlockProposal(header, archive, stateReference, txs, proposerAddress, {
533
+ async createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options) {
534
+ // TODO(palla/mbps): Prevent double proposals properly
535
+ // if (this.previousProposal?.slotNumber === blockHeader.globalVariables.slotNumber) {
536
+ // this.log.verbose(`Already made a proposal for the same slot, skipping proposal`);
537
+ // return Promise.resolve(undefined);
538
+ // }
539
+ this.log.info(`Assembling block proposal for block ${blockHeader.globalVariables.blockNumber} slot ${blockHeader.globalVariables.slotNumber}`);
540
+ const newProposal = await this.validationService.createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
249
541
  ...options,
250
542
  broadcastInvalidBlockProposal: this.config.broadcastInvalidBlockProposal
251
543
  });
252
544
  this.previousProposal = newProposal;
253
545
  return newProposal;
254
546
  }
547
+ async createCheckpointProposal(checkpointHeader, archive, lastBlockInfo, proposerAddress, options) {
548
+ this.log.info(`Assembling checkpoint proposal for slot ${checkpointHeader.slotNumber}`);
549
+ return await this.validationService.createCheckpointProposal(checkpointHeader, archive, lastBlockInfo, proposerAddress, options);
550
+ }
255
551
  async broadcastBlockProposal(proposal) {
256
552
  await this.p2pClient.broadcastProposal(proposal);
257
553
  }
258
- async signAttestationsAndSigners(attestationsAndSigners, proposer) {
259
- return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer);
554
+ async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber) {
555
+ return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber);
260
556
  }
261
557
  async collectOwnAttestations(proposal) {
262
- const slot = proposal.payload.header.slotNumber.toBigInt();
558
+ const slot = proposal.slotNumber;
263
559
  const inCommittee = await this.epochCache.filterInCommittee(slot, this.getValidatorAddresses());
264
560
  this.log.debug(`Collecting ${inCommittee.length} self-attestations for slot ${slot}`, {
265
561
  inCommittee
266
562
  });
267
- return this.createBlockAttestationsFromProposal(proposal, inCommittee);
563
+ const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee);
564
+ // We broadcast our own attestations to our peers so, in case our block does not get mined on L1,
565
+ // other nodes can see that our validators did attest to this block proposal, and do not slash us
566
+ // due to inactivity for missed attestations.
567
+ void this.p2pClient.broadcastCheckpointAttestations(attestations).catch((err)=>{
568
+ this.log.error(`Failed to broadcast self-attestations for slot ${slot}`, err);
569
+ });
570
+ return attestations;
268
571
  }
269
572
  async collectAttestations(proposal, required, deadline) {
270
- // Wait and poll the p2pClient's attestation pool for this block until we have enough attestations
271
- const slot = proposal.payload.header.slotNumber.toBigInt();
573
+ // Wait and poll the p2pClient's attestation pool for this checkpoint until we have enough attestations
574
+ const slot = proposal.slotNumber;
272
575
  this.log.debug(`Collecting ${required} attestations for slot ${slot} with deadline ${deadline.toISOString()}`);
273
576
  if (+deadline < this.dateProvider.now()) {
274
577
  this.log.error(`Deadline ${deadline.toISOString()} for collecting ${required} attestations for slot ${slot} is in the past`);
@@ -279,13 +582,13 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
279
582
  const myAddresses = this.getValidatorAddresses();
280
583
  let attestations = [];
281
584
  while(true){
282
- // Filter out attestations with a mismatching payload. This should NOT happen since we have verified
585
+ // Filter out attestations with a mismatching archive. This should NOT happen since we have verified
283
586
  // the proposer signature (ie our own) before accepting the attestation into the pool via the p2p client.
284
- const collectedAttestations = (await this.p2pClient.getAttestationsForSlot(slot, proposalId)).filter((attestation)=>{
285
- if (!attestation.payload.equals(proposal.payload)) {
286
- this.log.warn(`Received attestation for slot ${slot} with mismatched payload from ${attestation.getSender()?.toString()}`, {
287
- attestationPayload: attestation.payload,
288
- proposalPayload: proposal.payload
587
+ const collectedAttestations = (await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalId)).filter((attestation)=>{
588
+ if (!attestation.archive.equals(proposal.archive)) {
589
+ this.log.warn(`Received attestation for slot ${slot} with mismatched archive from ${attestation.getSender()?.toString()}`, {
590
+ attestationArchive: attestation.archive.toString(),
591
+ proposalArchive: proposal.archive.toString()
289
592
  });
290
593
  return false;
291
594
  }
@@ -317,11 +620,6 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
317
620
  await sleep(this.config.attestationPollingIntervalMs);
318
621
  }
319
622
  }
320
- async createBlockAttestationsFromProposal(proposal, attestors = []) {
321
- const attestations = await this.validationService.attestToProposal(proposal, attestors);
322
- await this.p2pClient.addAttestations(attestations);
323
- return attestations;
324
- }
325
623
  async handleAuthRequest(peer, msg) {
326
624
  const authRequest = AuthRequest.fromBuffer(msg);
327
625
  const statusMessage = await this.p2pClient.handleAuthRequestFromPeer(authRequest, peer).catch((_)=>undefined);
@@ -336,7 +634,11 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
336
634
  return Buffer.alloc(0);
337
635
  }
338
636
  const payloadToSign = authRequest.getPayloadToSign();
339
- const signature = await this.keyStore.signMessageWithAddress(addressToUse, payloadToSign);
637
+ // AUTH_REQUEST doesn't require HA protection - multiple signatures are safe
638
+ const context = {
639
+ dutyType: DutyType.AUTH_REQUEST
640
+ };
641
+ const signature = await this.keyStore.signMessageWithAddress(addressToUse, payloadToSign, context);
340
642
  const authResponse = new AuthResponse(statusMessage, signature);
341
643
  return authResponse.toBuffer();
342
644
  }