@aztec/validator-client 0.0.1-commit.b33fc05d0 → 0.0.1-commit.b3d3157a

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/src/validator.ts CHANGED
@@ -1,39 +1,37 @@
1
1
  import type { BlobClientInterface } from '@aztec/blob-client/client';
2
2
  import { type Blob, getBlobsPerL1Block } from '@aztec/blob-lib';
3
3
  import type { EpochCache } from '@aztec/epoch-cache';
4
- import { validateFeeAssetPriceModifier } from '@aztec/ethereum/contracts';
5
- import {
6
- BlockNumber,
7
- CheckpointNumber,
8
- EpochNumber,
9
- IndexWithinCheckpoint,
10
- SlotNumber,
11
- } from '@aztec/foundation/branded-types';
4
+ import { CheckpointNumber, EpochNumber, IndexWithinCheckpoint, SlotNumber } from '@aztec/foundation/branded-types';
12
5
  import { Fr } from '@aztec/foundation/curves/bn254';
13
- import { TimeoutError } from '@aztec/foundation/error';
14
6
  import type { EthAddress } from '@aztec/foundation/eth-address';
15
7
  import type { Signature } from '@aztec/foundation/eth-signature';
8
+ import { FifoSet } from '@aztec/foundation/fifo-set';
16
9
  import { type LogData, type Logger, createLogger } from '@aztec/foundation/log';
17
- import { retryUntil } from '@aztec/foundation/retry';
18
10
  import { RunningPromise } from '@aztec/foundation/running-promise';
19
11
  import { sleep } from '@aztec/foundation/sleep';
20
12
  import { DateProvider } from '@aztec/foundation/timer';
21
13
  import type { KeystoreManager } from '@aztec/node-keystore';
22
14
  import type { DuplicateAttestationInfo, DuplicateProposalInfo, P2P, PeerId } from '@aztec/p2p';
23
15
  import { AuthRequest, AuthResponse, BlockProposalValidator, ReqRespSubProtocol } from '@aztec/p2p';
24
- import { OffenseType, WANT_TO_SLASH_EVENT, type Watcher, type WatcherEmitter } from '@aztec/slasher';
16
+ import {
17
+ OffenseType,
18
+ WANT_TO_CLEAR_SLASH_EVENT,
19
+ WANT_TO_SLASH_EVENT,
20
+ type Watcher,
21
+ type WatcherEmitter,
22
+ getOffenseTypeName,
23
+ } from '@aztec/slasher';
25
24
  import type { AztecAddress } from '@aztec/stdlib/aztec-address';
26
- import type { CommitteeAttestationsAndSigners, L2Block, L2BlockSink, L2BlockSource } from '@aztec/stdlib/block';
27
- import { validateCheckpoint } from '@aztec/stdlib/checkpoint';
28
- import { getEpochAtSlot, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
25
+ import type { CommitteeAttestationsAndSigners, L2BlockSink, L2BlockSource } from '@aztec/stdlib/block';
26
+ import type { CheckpointReexecutionTracker } from '@aztec/stdlib/checkpoint';
27
+ import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
29
28
  import type {
30
- CreateCheckpointProposalLastBlockData,
31
29
  ITxProvider,
32
30
  Validator,
33
31
  ValidatorClientFullConfig,
34
32
  WorldStateSynchronizer,
35
33
  } from '@aztec/stdlib/interfaces/server';
36
- import { type L1ToL2MessageSource, accumulateCheckpointOutHashes } from '@aztec/stdlib/messaging';
34
+ import type { L1ToL2MessageSource } from '@aztec/stdlib/messaging';
37
35
  import {
38
36
  type BlockProposal,
39
37
  type BlockProposalOptions,
@@ -41,36 +39,73 @@ import {
41
39
  CheckpointProposal,
42
40
  type CheckpointProposalCore,
43
41
  type CheckpointProposalOptions,
42
+ type CoordinationSignatureContext,
44
43
  } from '@aztec/stdlib/p2p';
45
44
  import type { CheckpointHeader } from '@aztec/stdlib/rollup';
46
- import type { BlockHeader, CheckpointGlobalVariables, Tx } from '@aztec/stdlib/tx';
45
+ import type { BlockHeader, Tx } from '@aztec/stdlib/tx';
47
46
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
48
47
  import { type TelemetryClient, type Tracer, getTelemetryClient } from '@aztec/telemetry-client';
49
- import { createHASigner, createLocalSignerWithProtection } from '@aztec/validator-ha-signer/factory';
50
- import { DutyType, type SigningContext } from '@aztec/validator-ha-signer/types';
48
+ import {
49
+ createHASigner,
50
+ createLocalSignerWithProtection,
51
+ createSignerFromSharedDb,
52
+ } from '@aztec/validator-ha-signer/factory';
53
+ import { DutyType, type SigningContext, type SlashingProtectionDatabase } from '@aztec/validator-ha-signer/types';
51
54
  import type { ValidatorHASigner } from '@aztec/validator-ha-signer/validator-ha-signer';
52
55
 
53
56
  import { EventEmitter } from 'events';
54
57
  import type { TypedDataDefinition } from 'viem';
55
58
 
56
- import { BlockProposalHandler, type BlockProposalValidationFailureReason } from './block_proposal_handler.js';
57
59
  import type { FullNodeCheckpointsBuilder } from './checkpoint_builder.js';
58
60
  import { ValidationService } from './duties/validation_service.js';
59
61
  import { HAKeyStore } from './key_store/ha_key_store.js';
60
62
  import type { ExtendedValidatorKeyStore } from './key_store/interface.js';
61
63
  import { NodeKeystoreAdapter } from './key_store/node_keystore_adapter.js';
62
64
  import { ValidatorMetrics } from './metrics.js';
65
+ import {
66
+ type BlockProposalValidationFailureReason,
67
+ type CheckpointProposalValidationFailureReason,
68
+ type CheckpointProposalValidationFailureResult,
69
+ ProposalHandler,
70
+ } from './proposal_handler.js';
63
71
 
64
72
  // We maintain a set of proposers who have proposed invalid blocks.
65
73
  // Just cap the set to avoid unbounded growth.
66
74
  const MAX_PROPOSERS_OF_INVALID_BLOCKS = 1000;
75
+ const MAX_TRACKED_INVALID_PROPOSAL_SLOTS = 1000;
76
+ const MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS = 1000;
77
+ const MAX_TRACKED_BAD_ATTESTATIONS = 10_000;
67
78
 
68
79
  // What errors from the block proposal handler result in slashing
69
80
  const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT: BlockProposalValidationFailureReason[] = [
70
81
  'state_mismatch',
71
82
  'failed_txs',
83
+ 'global_variables_mismatch',
84
+ 'invalid_proposal',
85
+ 'parent_block_wrong_slot',
86
+ 'in_hash_mismatch',
72
87
  ];
73
88
 
89
+ const SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT: Record<CheckpointProposalValidationFailureReason, boolean> = {
90
+ // enabled
91
+ ['invalid_fee_asset_price_modifier']: true,
92
+ ['checkpoint_header_mismatch']: true,
93
+ // These late mismatches should normally be caught by earlier checks, but if reached after validating the local
94
+ // checkpoint inputs, the proposer-signed payload disagrees with deterministic recomputation.
95
+ ['archive_mismatch']: true,
96
+ ['out_hash_mismatch']: true,
97
+ ['no_blocks_for_slot']: true,
98
+ ['too_many_blocks_in_checkpoint']: true,
99
+ ['checkpoint_validation_failed']: true,
100
+ ['last_block_archive_mismatch']: true,
101
+
102
+ // disabled
103
+ ['invalid_signature']: false,
104
+ ['last_block_not_found']: false,
105
+ ['block_fetch_error']: false,
106
+ ['checkpoint_already_published']: false,
107
+ };
108
+
74
109
  /**
75
110
  * Validator Client
76
111
  */
@@ -93,7 +128,11 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
93
128
  /** Tracks the last epoch in which each attester successfully submitted at least one attestation. */
94
129
  private lastAttestedEpochByAttester: Map<string, EpochNumber> = new Map();
95
130
 
96
- private proposersOfInvalidBlocks: Set<string> = new Set();
131
+ private proposersOfInvalidBlocks = FifoSet.withLimit<string>(MAX_PROPOSERS_OF_INVALID_BLOCKS);
132
+ private slotsWithInvalidProposals = FifoSet.withLimit<SlotNumber>(MAX_TRACKED_INVALID_PROPOSAL_SLOTS);
133
+ private invalidCheckpointProposalOffenseKeys = FifoSet.withLimit<string>(MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS);
134
+ private badAttestationOffenseKeys = FifoSet.withLimit<string>(MAX_TRACKED_BAD_ATTESTATIONS);
135
+ private slotsWithProposalEquivocation = FifoSet.withLimit<SlotNumber>(MAX_TRACKED_INVALID_PROPOSAL_SLOTS);
97
136
 
98
137
  /** Tracks the last checkpoint proposal we attested to, to prevent equivocation. */
99
138
  private lastAttestedProposal?: CheckpointProposalCore;
@@ -102,7 +141,7 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
102
141
  private keyStore: ExtendedValidatorKeyStore,
103
142
  private epochCache: EpochCache,
104
143
  private p2pClient: P2P,
105
- private blockProposalHandler: BlockProposalHandler,
144
+ private proposalHandler: ProposalHandler,
106
145
  private blockSource: L2BlockSource,
107
146
  private checkpointsBuilder: FullNodeCheckpointsBuilder,
108
147
  private worldState: WorldStateSynchronizer,
@@ -122,11 +161,17 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
122
161
  this.tracer = telemetry.getTracer('Validator');
123
162
  this.metrics = new ValidatorMetrics(telemetry);
124
163
 
125
- this.validationService = new ValidationService(keyStore, this.log.createChild('validation-service'));
164
+ this.validationService = new ValidationService(
165
+ keyStore,
166
+ this.getSignatureContext(),
167
+ this.log.createChild('validation-service'),
168
+ );
169
+ this.proposalHandler.setCheckpointProposalValidationFailureCallback((proposal, result, proposalInfo) =>
170
+ this.handleInvalidCheckpointProposal(proposal, result, proposalInfo),
171
+ );
126
172
 
127
173
  // Refresh epoch cache every second to trigger alert if participation in committee changes
128
174
  this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), this.log, 1000);
129
-
130
175
  const myAddresses = this.getValidatorAddresses();
131
176
  this.log.verbose(`Initialized validator with addresses: ${myAddresses.map(a => a.toString()).join(', ')}`);
132
177
  }
@@ -195,15 +240,23 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
195
240
  txProvider: ITxProvider,
196
241
  keyStoreManager: KeystoreManager,
197
242
  blobClient: BlobClientInterface,
243
+ reexecutionTracker: CheckpointReexecutionTracker,
198
244
  dateProvider: DateProvider = new DateProvider(),
199
245
  telemetry: TelemetryClient = getTelemetryClient(),
246
+ slashingProtectionDb?: SlashingProtectionDatabase,
200
247
  ) {
201
248
  const metrics = new ValidatorMetrics(telemetry);
202
249
  const blockProposalValidator = new BlockProposalValidator(epochCache, {
203
250
  txsPermitted: !config.disableTransactions,
204
251
  maxTxsPerBlock: config.validateMaxTxsPerBlock,
252
+ maxBlocksPerCheckpoint: config.maxBlocksPerCheckpoint,
253
+ skipSlotValidation: config.skipProposalSlotValidation,
254
+ signatureContext: {
255
+ chainId: config.l1ChainId,
256
+ rollupAddress: config.rollupAddress,
257
+ },
205
258
  });
206
- const blockProposalHandler = new BlockProposalHandler(
259
+ const proposalHandler = new ProposalHandler(
207
260
  checkpointsBuilder,
208
261
  worldState,
209
262
  blockSource,
@@ -212,14 +265,23 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
212
265
  blockProposalValidator,
213
266
  epochCache,
214
267
  config,
268
+ blobClient,
269
+ reexecutionTracker,
215
270
  metrics,
216
271
  dateProvider,
217
272
  telemetry,
273
+ undefined,
218
274
  );
219
275
 
220
276
  const nodeKeystoreAdapter = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
221
277
  let slashingProtectionSigner: ValidatorHASigner;
222
- if (config.haSigningEnabled) {
278
+ if (slashingProtectionDb) {
279
+ // Shared database mode: use a pre-existing database (e.g. for testing HA setups).
280
+ ({ signer: slashingProtectionSigner } = createSignerFromSharedDb(slashingProtectionDb, config, {
281
+ telemetryClient: telemetry,
282
+ dateProvider,
283
+ }));
284
+ } else if (config.haSigningEnabled) {
223
285
  // Multi-node HA mode: use PostgreSQL-backed distributed locking.
224
286
  // If maxStuckDutiesAgeMs is not explicitly set, compute it from Aztec slot duration
225
287
  const haConfig = {
@@ -244,7 +306,7 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
244
306
  validatorKeyStore,
245
307
  epochCache,
246
308
  p2pClient,
247
- blockProposalHandler,
309
+ proposalHandler,
248
310
  blockSource,
249
311
  checkpointsBuilder,
250
312
  worldState,
@@ -265,14 +327,21 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
265
327
  .filter(addr => !this.config.disabledValidators.some(disabled => disabled.equals(addr)));
266
328
  }
267
329
 
268
- public getBlockProposalHandler() {
269
- return this.blockProposalHandler;
330
+ public getProposalHandler() {
331
+ return this.proposalHandler;
270
332
  }
271
333
 
272
334
  public signWithAddress(addr: EthAddress, msg: TypedDataDefinition, context: SigningContext) {
273
335
  return this.keyStore.signTypedDataWithAddress(addr, msg, context);
274
336
  }
275
337
 
338
+ private getSignatureContext(): CoordinationSignatureContext {
339
+ return {
340
+ chainId: this.config.l1ChainId,
341
+ rollupAddress: this.config.rollupAddress,
342
+ };
343
+ }
344
+
276
345
  public getCoinbaseForAttestor(attestor: EthAddress): EthAddress {
277
346
  return this.keyStore.getCoinbaseAddress(attestor);
278
347
  }
@@ -285,14 +354,27 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
285
354
  return this.config;
286
355
  }
287
356
 
357
+ public hasProposalEquivocation(slotNumber: SlotNumber): boolean {
358
+ return this.slotsWithProposalEquivocation.has(slotNumber);
359
+ }
360
+
361
+ public hasInvalidProposals(slotNumber: SlotNumber): boolean {
362
+ return this.slotsWithInvalidProposals.has(slotNumber);
363
+ }
364
+
288
365
  public updateConfig(config: Partial<ValidatorClientFullConfig>) {
289
366
  this.config = { ...this.config, ...config };
367
+ this.proposalHandler.updateConfig(config);
290
368
  }
291
369
 
292
370
  public reloadKeystore(newManager: KeystoreManager): void {
293
371
  const newAdapter = NodeKeystoreAdapter.fromKeyStoreManager(newManager);
294
372
  this.keyStore = new HAKeyStore(newAdapter, this.slashingProtectionSigner);
295
- this.validationService = new ValidationService(this.keyStore, this.log.createChild('validation-service'));
373
+ this.validationService = new ValidationService(
374
+ this.keyStore,
375
+ this.getSignatureContext(),
376
+ this.log.createChild('validation-service'),
377
+ );
296
378
  }
297
379
 
298
380
  public async start() {
@@ -339,7 +421,7 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
339
421
  checkpoint: CheckpointProposalCore,
340
422
  proposalSender: PeerId,
341
423
  ): Promise<CheckpointAttestation[] | undefined> => this.attestToCheckpointProposal(checkpoint, proposalSender);
342
- this.p2pClient.registerCheckpointProposalHandler(checkpointHandler);
424
+ this.p2pClient.registerValidatorCheckpointProposalHandler(checkpointHandler);
343
425
 
344
426
  // Duplicate proposal handler - triggers slashing for equivocation
345
427
  this.p2pClient.registerDuplicateProposalCallback((info: DuplicateProposalInfo) => {
@@ -351,6 +433,10 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
351
433
  this.handleDuplicateAttestation(info);
352
434
  });
353
435
 
436
+ this.p2pClient.registerCheckpointAttestationCallback((attestation: CheckpointAttestation) => {
437
+ this.handleCheckpointAttestation(attestation);
438
+ });
439
+
354
440
  const myAddresses = this.getValidatorAddresses();
355
441
  this.p2pClient.registerThisValidatorAddresses(myAddresses);
356
442
 
@@ -378,13 +464,12 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
378
464
  return false;
379
465
  }
380
466
 
381
- // Ignore proposals from ourselves (may happen in HA setups)
467
+ // Log self-proposals from HA peers (same validator key on different nodes)
382
468
  if (this.getValidatorAddresses().some(addr => addr.equals(proposer))) {
383
- this.log.debug(`Ignoring block proposal from self for slot ${slotNumber}`, {
469
+ this.log.verbose(`Processing block proposal from HA peer for slot ${slotNumber}`, {
384
470
  proposer: proposer.toString(),
385
471
  slotNumber,
386
472
  });
387
- return false;
388
473
  }
389
474
 
390
475
  // Check if we're in the committee (for metrics purposes)
@@ -398,22 +483,8 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
398
483
  fishermanMode: this.config.fishermanMode || false,
399
484
  });
400
485
 
401
- // Reexecute txs if we are part of the committee, or if slashing is enabled, or if we are configured to always reexecute.
402
- // In fisherman mode, we always reexecute to validate proposals.
403
- const { validatorReexecute, slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } =
404
- this.config;
405
- const shouldReexecute =
406
- fishermanMode ||
407
- (slashBroadcastedInvalidBlockPenalty > 0n && validatorReexecute) ||
408
- (partOfCommittee && validatorReexecute) ||
409
- alwaysReexecuteBlockProposals ||
410
- this.blobClient.canUpload();
411
-
412
- const validationResult = await this.blockProposalHandler.handleBlockProposal(
413
- proposal,
414
- proposalSender,
415
- !!shouldReexecute && !escapeHatchOpen,
416
- );
486
+ // Reexecute outside the escape hatch so slashing observers can detect invalid proposals even when penalties are 0.
487
+ const validationResult = await this.proposalHandler.handleBlockProposal(proposal, proposalSender, !escapeHatchOpen);
417
488
 
418
489
  if (!validationResult.isValid) {
419
490
  const reason = validationResult.reason || 'unknown';
@@ -436,15 +507,18 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
436
507
  this.metrics.incFailedAttestationsNodeIssue(1, reason, partOfCommittee);
437
508
  }
438
509
 
439
- // Slash invalid block proposals (can happen even when not in committee)
440
510
  if (
441
511
  !escapeHatchOpen &&
442
512
  validationResult.reason &&
443
- SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason) &&
444
- slashBroadcastedInvalidBlockPenalty > 0n
513
+ SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason)
445
514
  ) {
446
- this.log.warn(`Slashing proposer for invalid block proposal`, proposalInfo);
515
+ this.log.info(`Detected invalid block proposal offense`, {
516
+ ...proposalInfo,
517
+ amount: this.config.slashBroadcastedInvalidBlockPenalty,
518
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL),
519
+ });
447
520
  this.slashInvalidBlock(proposal);
521
+ this.markInvalidProposalSlot(proposal.slotNumber);
448
522
  }
449
523
  return false;
450
524
  }
@@ -474,66 +548,56 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
474
548
  proposal: CheckpointProposalCore,
475
549
  _proposalSender: PeerId,
476
550
  ): Promise<CheckpointAttestation[] | undefined> {
477
- const slotNumber = proposal.slotNumber;
551
+ const proposalSlotNumber = proposal.slotNumber;
478
552
  const proposer = proposal.getSender();
479
553
 
480
554
  // If escape hatch is open for this slot's epoch, do not attest.
481
- if (await this.epochCache.isEscapeHatchOpenAtSlot(slotNumber)) {
482
- this.log.warn(`Escape hatch open for slot ${slotNumber}, skipping checkpoint attestation handling`);
555
+ if (await this.epochCache.isEscapeHatchOpenAtSlot(proposalSlotNumber)) {
556
+ this.log.warn(`Escape hatch open for slot ${proposalSlotNumber}, skipping checkpoint attestation handling`);
483
557
  return undefined;
484
558
  }
485
559
 
486
- // Reject proposals with invalid signatures
487
- if (!proposer) {
488
- this.log.warn(`Received checkpoint proposal with invalid signature for slot ${slotNumber}`);
560
+ // Early-out for equivocation: refuses if we've already attested to a higher slot.
561
+ if (!this.shouldAttestToSlot(proposalSlotNumber)) {
489
562
  return undefined;
490
563
  }
491
564
 
492
565
  // Ignore proposals from ourselves (may happen in HA setups)
493
- if (this.getValidatorAddresses().some(addr => addr.equals(proposer))) {
494
- this.log.debug(`Ignoring block proposal from self for slot ${slotNumber}`, {
566
+ if (proposer && this.getValidatorAddresses().some(addr => addr.equals(proposer))) {
567
+ this.log.debug(`Ignoring block proposal from self for slot ${proposalSlotNumber}`, {
495
568
  proposer: proposer.toString(),
496
- slotNumber,
569
+ proposalSlotNumber,
497
570
  });
498
571
  return undefined;
499
572
  }
500
573
 
501
- // Validate fee asset price modifier is within allowed range
502
- if (!validateFeeAssetPriceModifier(proposal.feeAssetPriceModifier)) {
503
- this.log.warn(
504
- `Received checkpoint proposal with invalid feeAssetPriceModifier ${proposal.feeAssetPriceModifier} for slot ${slotNumber}`,
505
- );
506
- return undefined;
507
- }
508
-
509
- // Check that I have any address in current committee before attesting
510
- const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
574
+ // Check that I have any address in the committee where this checkpoint will land before attesting
575
+ const inCommittee = await this.epochCache.filterInCommittee(proposalSlotNumber, this.getValidatorAddresses());
511
576
  const partOfCommittee = inCommittee.length > 0;
512
577
 
513
578
  const proposalInfo = {
514
- slotNumber,
579
+ proposalSlotNumber,
515
580
  archive: proposal.archive.toString(),
516
- proposer: proposer.toString(),
581
+ proposer: proposer?.toString(),
517
582
  };
518
- this.log.info(`Received checkpoint proposal for slot ${slotNumber}`, {
583
+ this.log.info(`Received checkpoint proposal for slot ${proposalSlotNumber}`, {
519
584
  ...proposalInfo,
520
585
  fishermanMode: this.config.fishermanMode || false,
521
586
  });
522
587
 
523
- // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set)
588
+ // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set).
589
+ // Uses the cached result from the all-nodes callback if available (avoids double validation).
590
+ let checkpointNumber: CheckpointNumber;
524
591
  if (this.config.skipCheckpointProposalValidation) {
525
- this.log.warn(`Skipping checkpoint proposal validation for slot ${slotNumber}`, proposalInfo);
592
+ this.log.warn(`Skipping checkpoint proposal validation for slot ${proposalSlotNumber}`, proposalInfo);
593
+ checkpointNumber = CheckpointNumber(0);
526
594
  } else {
527
- const validationResult = await this.validateCheckpointProposal(proposal, proposalInfo);
595
+ const validationResult = await this.proposalHandler.handleCheckpointProposal(proposal, proposalInfo);
528
596
  if (!validationResult.isValid) {
529
597
  this.log.warn(`Checkpoint proposal validation failed: ${validationResult.reason}`, proposalInfo);
530
598
  return undefined;
531
599
  }
532
- }
533
-
534
- // Upload blobs to filestore if we can (fire and forget)
535
- if (this.blobClient.canUpload()) {
536
- void this.uploadBlobsForCheckpoint(proposal, proposalInfo);
600
+ checkpointNumber = validationResult.checkpointNumber;
537
601
  }
538
602
 
539
603
  // Check that I have any address in current committee before attesting
@@ -544,16 +608,19 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
544
608
  }
545
609
 
546
610
  // Provided all of the above checks pass, we can attest to the proposal
547
- this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${slotNumber}`, {
548
- ...proposalInfo,
549
- inCommittee: partOfCommittee,
550
- fishermanMode: this.config.fishermanMode || false,
551
- });
611
+ this.log.info(
612
+ `${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${proposalSlotNumber}`,
613
+ {
614
+ ...proposalInfo,
615
+ inCommittee: partOfCommittee,
616
+ fishermanMode: this.config.fishermanMode || false,
617
+ },
618
+ );
552
619
 
553
620
  this.metrics.incSuccessfulAttestations(inCommittee.length);
554
621
 
555
622
  // Track epoch participation per attester: count each (attester, epoch) pair at most once
556
- const proposalEpoch = getEpochAtSlot(slotNumber, this.epochCache.getL1Constants());
623
+ const proposalEpoch = getEpochAtSlot(proposalSlotNumber, this.epochCache.getL1Constants());
557
624
  for (const attester of inCommittee) {
558
625
  const key = attester.toString();
559
626
  const lastEpoch = this.lastAttestedEpochByAttester.get(key);
@@ -581,14 +648,14 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
581
648
 
582
649
  if (this.config.fishermanMode) {
583
650
  // bail out early and don't save attestations to the pool in fisherman mode
584
- this.log.info(`Creating checkpoint attestations for slot ${slotNumber}`, {
651
+ this.log.info(`Creating checkpoint attestations for slot ${proposalSlotNumber}`, {
585
652
  ...proposalInfo,
586
653
  attestors: attestors.map(a => a.toString()),
587
654
  });
588
655
  return undefined;
589
656
  }
590
657
 
591
- return await this.createCheckpointAttestationsFromProposal(proposal, attestors);
658
+ return await this.createCheckpointAttestationsFromProposal(proposal, attestors, checkpointNumber);
592
659
  }
593
660
 
594
661
  /**
@@ -615,13 +682,14 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
615
682
  private async createCheckpointAttestationsFromProposal(
616
683
  proposal: CheckpointProposalCore,
617
684
  attestors: EthAddress[] = [],
685
+ checkpointNumber: CheckpointNumber,
618
686
  ): Promise<CheckpointAttestation[] | undefined> {
619
687
  // Equivocation check: must happen right before signing to minimize the race window
620
688
  if (!this.shouldAttestToSlot(proposal.slotNumber)) {
621
689
  return undefined;
622
690
  }
623
691
 
624
- const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors);
692
+ const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors, checkpointNumber);
625
693
 
626
694
  // Track the proposal we attested to (to prevent equivocation)
627
695
  this.lastAttestedProposal = proposal;
@@ -630,178 +698,12 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
630
698
  return attestations;
631
699
  }
632
700
 
633
- /**
634
- * Validates a checkpoint proposal by building the full checkpoint and comparing it with the proposal.
635
- * @returns Validation result with isValid flag and reason if invalid.
636
- */
637
- private async validateCheckpointProposal(
638
- proposal: CheckpointProposalCore,
639
- proposalInfo: LogData,
640
- ): Promise<{ isValid: true } | { isValid: false; reason: string }> {
641
- const slot = proposal.slotNumber;
642
-
643
- // Timeout block syncing at the start of the next slot
644
- const config = this.checkpointsBuilder.getConfig();
645
- const nextSlotTimestampSeconds = Number(getTimestampForSlot(SlotNumber(slot + 1), config));
646
- const timeoutSeconds = Math.max(1, nextSlotTimestampSeconds - Math.floor(this.dateProvider.now() / 1000));
647
-
648
- // Wait for last block to sync by archive
649
- let lastBlockHeader: BlockHeader | undefined;
650
- try {
651
- lastBlockHeader = await retryUntil(
652
- async () => {
653
- await this.blockSource.syncImmediate();
654
- return this.blockSource.getBlockHeaderByArchive(proposal.archive);
655
- },
656
- `waiting for block with archive ${proposal.archive.toString()} for slot ${slot}`,
657
- timeoutSeconds,
658
- 0.5,
659
- );
660
- } catch (err) {
661
- if (err instanceof TimeoutError) {
662
- this.log.warn(`Timed out waiting for block with archive matching checkpoint proposal`, proposalInfo);
663
- return { isValid: false, reason: 'last_block_not_found' };
664
- }
665
- this.log.error(`Error fetching last block for checkpoint proposal`, err, proposalInfo);
666
- return { isValid: false, reason: 'block_fetch_error' };
667
- }
668
-
669
- if (!lastBlockHeader) {
670
- this.log.warn(`Last block not found for checkpoint proposal`, proposalInfo);
671
- return { isValid: false, reason: 'last_block_not_found' };
672
- }
673
-
674
- // Get all full blocks for the slot and checkpoint
675
- const blocks = await this.blockSource.getBlocksForSlot(slot);
676
- if (blocks.length === 0) {
677
- this.log.warn(`No blocks found for slot ${slot}`, proposalInfo);
678
- return { isValid: false, reason: 'no_blocks_for_slot' };
679
- }
680
-
681
- // Ensure the last block for this slot matches the archive in the checkpoint proposal
682
- if (!blocks.at(-1)?.archive.root.equals(proposal.archive)) {
683
- this.log.warn(`Last block archive mismatch for checkpoint proposal`, proposalInfo);
684
- return { isValid: false, reason: 'last_block_archive_mismatch' };
685
- }
686
-
687
- this.log.debug(`Found ${blocks.length} blocks for slot ${slot}`, {
688
- ...proposalInfo,
689
- blockNumbers: blocks.map(b => b.number),
690
- });
691
-
692
- // Get checkpoint constants from first block
693
- const firstBlock = blocks[0];
694
- const constants = this.extractCheckpointConstants(firstBlock);
695
- const checkpointNumber = firstBlock.checkpointNumber;
696
-
697
- // Get L1-to-L2 messages for this checkpoint
698
- const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(checkpointNumber);
699
-
700
- // Collect the out hashes of all the checkpoints before this one in the same epoch
701
- const epoch = getEpochAtSlot(slot, this.epochCache.getL1Constants());
702
- const previousCheckpointOutHashes = (await this.blockSource.getCheckpointsDataForEpoch(epoch))
703
- .filter(c => c.checkpointNumber < checkpointNumber)
704
- .map(c => c.checkpointOutHash);
705
-
706
- // Fork world state at the block before the first block
707
- const parentBlockNumber = BlockNumber(firstBlock.number - 1);
708
- const fork = await this.worldState.fork(parentBlockNumber);
709
-
710
- try {
711
- // Create checkpoint builder with all existing blocks
712
- const checkpointBuilder = await this.checkpointsBuilder.openCheckpoint(
713
- checkpointNumber,
714
- constants,
715
- proposal.feeAssetPriceModifier,
716
- l1ToL2Messages,
717
- previousCheckpointOutHashes,
718
- fork,
719
- blocks,
720
- this.log.getBindings(),
721
- );
722
-
723
- // Complete the checkpoint to get computed values
724
- const computedCheckpoint = await checkpointBuilder.completeCheckpoint();
725
-
726
- // Compare checkpoint header with proposal
727
- if (!computedCheckpoint.header.equals(proposal.checkpointHeader)) {
728
- this.log.warn(`Checkpoint header mismatch`, {
729
- ...proposalInfo,
730
- computed: computedCheckpoint.header.toInspect(),
731
- proposal: proposal.checkpointHeader.toInspect(),
732
- });
733
- return { isValid: false, reason: 'checkpoint_header_mismatch' };
734
- }
735
-
736
- // Compare archive root with proposal
737
- if (!computedCheckpoint.archive.root.equals(proposal.archive)) {
738
- this.log.warn(`Archive root mismatch`, {
739
- ...proposalInfo,
740
- computed: computedCheckpoint.archive.root.toString(),
741
- proposal: proposal.archive.toString(),
742
- });
743
- return { isValid: false, reason: 'archive_mismatch' };
744
- }
745
-
746
- // Check that the accumulated epoch out hash matches the value in the proposal.
747
- // The epoch out hash is the accumulated hash of all checkpoint out hashes in the epoch.
748
- const checkpointOutHash = computedCheckpoint.getCheckpointOutHash();
749
- const computedEpochOutHash = accumulateCheckpointOutHashes([...previousCheckpointOutHashes, checkpointOutHash]);
750
- const proposalEpochOutHash = proposal.checkpointHeader.epochOutHash;
751
- if (!computedEpochOutHash.equals(proposalEpochOutHash)) {
752
- this.log.warn(`Epoch out hash mismatch`, {
753
- proposalEpochOutHash: proposalEpochOutHash.toString(),
754
- computedEpochOutHash: computedEpochOutHash.toString(),
755
- checkpointOutHash: checkpointOutHash.toString(),
756
- previousCheckpointOutHashes: previousCheckpointOutHashes.map(h => h.toString()),
757
- ...proposalInfo,
758
- });
759
- return { isValid: false, reason: 'out_hash_mismatch' };
760
- }
761
-
762
- // Final round of validations on the checkpoint, just in case.
763
- try {
764
- validateCheckpoint(computedCheckpoint, {
765
- rollupManaLimit: this.checkpointsBuilder.getConfig().rollupManaLimit,
766
- maxDABlockGas: this.config.validateMaxDABlockGas,
767
- maxL2BlockGas: this.config.validateMaxL2BlockGas,
768
- maxTxsPerBlock: this.config.validateMaxTxsPerBlock,
769
- maxTxsPerCheckpoint: this.config.validateMaxTxsPerCheckpoint,
770
- });
771
- } catch (err) {
772
- this.log.warn(`Checkpoint validation failed: ${err}`, proposalInfo);
773
- return { isValid: false, reason: 'checkpoint_validation_failed' };
774
- }
775
-
776
- this.log.verbose(`Checkpoint proposal validation successful for slot ${slot}`, proposalInfo);
777
- return { isValid: true };
778
- } finally {
779
- await fork.close();
780
- }
781
- }
782
-
783
- /**
784
- * Extract checkpoint global variables from a block.
785
- */
786
- private extractCheckpointConstants(block: L2Block): CheckpointGlobalVariables {
787
- const gv = block.header.globalVariables;
788
- return {
789
- chainId: gv.chainId,
790
- version: gv.version,
791
- slotNumber: gv.slotNumber,
792
- timestamp: gv.timestamp,
793
- coinbase: gv.coinbase,
794
- feeRecipient: gv.feeRecipient,
795
- gasFees: gv.gasFees,
796
- };
797
- }
798
-
799
701
  /**
800
702
  * Uploads blobs for a checkpoint to the filestore (fire and forget).
801
703
  */
802
704
  protected async uploadBlobsForCheckpoint(proposal: CheckpointProposalCore, proposalInfo: LogData): Promise<void> {
803
705
  try {
804
- const lastBlockHeader = await this.blockSource.getBlockHeaderByArchive(proposal.archive);
706
+ const lastBlockHeader = (await this.blockSource.getBlockData({ archive: proposal.archive }))?.header;
805
707
  if (!lastBlockHeader) {
806
708
  this.log.warn(`Failed to get last block header for blob upload`, proposalInfo);
807
709
  return;
@@ -834,12 +736,6 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
834
736
  return;
835
737
  }
836
738
 
837
- // Trim the set if it's too big.
838
- if (this.proposersOfInvalidBlocks.size > MAX_PROPOSERS_OF_INVALID_BLOCKS) {
839
- // remove oldest proposer. `values` is guaranteed to be in insertion order.
840
- this.proposersOfInvalidBlocks.delete(this.proposersOfInvalidBlocks.values().next().value!);
841
- }
842
-
843
739
  this.proposersOfInvalidBlocks.add(proposer.toString());
844
740
 
845
741
  this.emit(WANT_TO_SLASH_EVENT, [
@@ -852,20 +748,115 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
852
748
  ]);
853
749
  }
854
750
 
751
+ private handleInvalidCheckpointProposal(
752
+ proposal: CheckpointProposalCore,
753
+ result: CheckpointProposalValidationFailureResult,
754
+ proposalInfo: LogData,
755
+ ): void {
756
+ if (!SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT[result.reason]) {
757
+ return;
758
+ }
759
+
760
+ this.markInvalidProposalSlot(proposal.slotNumber);
761
+
762
+ if (this.slashInvalidCheckpointProposal(proposal)) {
763
+ this.log.info(`Detected invalid checkpoint proposal offense`, {
764
+ ...proposalInfo,
765
+ reason: result.reason,
766
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
767
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL),
768
+ });
769
+ }
770
+ }
771
+
772
+ private slashInvalidCheckpointProposal(proposal: CheckpointProposalCore): boolean {
773
+ const proposer = proposal.getSender();
774
+ if (!proposer) {
775
+ this.log.warn(`Cannot slash checkpoint proposal with invalid signature`, {
776
+ slotNumber: proposal.slotNumber,
777
+ archive: proposal.archive.toString(),
778
+ });
779
+ return false;
780
+ }
781
+
782
+ const offenseType = OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL;
783
+ const offenseKey = `${proposer.toString()}:${offenseType}:${proposal.slotNumber}`;
784
+ if (!this.invalidCheckpointProposalOffenseKeys.addIfAbsent(offenseKey)) {
785
+ return false;
786
+ }
787
+
788
+ this.emit(WANT_TO_SLASH_EVENT, [
789
+ {
790
+ validator: proposer,
791
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
792
+ offenseType,
793
+ epochOrSlot: BigInt(proposal.slotNumber),
794
+ },
795
+ ]);
796
+ return true;
797
+ }
798
+
799
+ private markInvalidProposalSlot(slotNumber: SlotNumber): void {
800
+ this.slotsWithInvalidProposals.add(slotNumber);
801
+ }
802
+
803
+ private handleCheckpointAttestation(attestation: CheckpointAttestation): void {
804
+ const slotNumber = attestation.slotNumber;
805
+ if (!this.slotsWithInvalidProposals.has(slotNumber) || this.slotsWithProposalEquivocation.has(slotNumber)) {
806
+ return;
807
+ }
808
+
809
+ const attester = attestation.getSender();
810
+ if (!attester) {
811
+ this.log.warn(`Cannot slash checkpoint attestation with invalid signature`, {
812
+ slotNumber,
813
+ archive: attestation.archive.toString(),
814
+ });
815
+ return;
816
+ }
817
+
818
+ this.slashAttestedToInvalidCheckpointProposal(slotNumber, attester);
819
+ }
820
+
821
+ private slashAttestedToInvalidCheckpointProposal(slotNumber: SlotNumber, attester: EthAddress): void {
822
+ const offenseKey = `${attester.toString()}:${OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL}:${slotNumber}`;
823
+ if (!this.badAttestationOffenseKeys.addIfAbsent(offenseKey)) {
824
+ return;
825
+ }
826
+
827
+ this.log.info(`Detected attestation to invalid checkpoint proposal offense`, {
828
+ attester: attester.toString(),
829
+ slotNumber,
830
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
831
+ offenseType: getOffenseTypeName(OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL),
832
+ });
833
+
834
+ this.emit(WANT_TO_SLASH_EVENT, [
835
+ {
836
+ validator: attester,
837
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
838
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
839
+ epochOrSlot: BigInt(slotNumber),
840
+ },
841
+ ]);
842
+ }
843
+
855
844
  /**
856
845
  * Handle detection of a duplicate proposal (equivocation).
857
846
  * Emits a slash event when a proposer sends multiple proposals for the same position.
858
847
  */
859
848
  private handleDuplicateProposal(info: DuplicateProposalInfo): void {
860
849
  const { slot, proposer, type } = info;
850
+ this.slotsWithProposalEquivocation.add(slot);
861
851
 
862
- this.log.warn(`Triggering slash event for duplicate ${type} proposal from ${proposer.toString()} at slot ${slot}`, {
852
+ this.log.info(`Detected duplicate ${type} proposal offense from ${proposer.toString()} at slot ${slot}`, {
863
853
  proposer: proposer.toString(),
864
854
  slot,
865
855
  type,
856
+ amount: this.config.slashDuplicateProposalPenalty,
857
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_PROPOSAL),
866
858
  });
867
859
 
868
- // Emit slash event
869
860
  this.emit(WANT_TO_SLASH_EVENT, [
870
861
  {
871
862
  validator: proposer,
@@ -874,6 +865,13 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
874
865
  epochOrSlot: BigInt(slot),
875
866
  },
876
867
  ]);
868
+
869
+ this.emit(WANT_TO_CLEAR_SLASH_EVENT, [
870
+ {
871
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
872
+ epochOrSlot: BigInt(slot),
873
+ },
874
+ ]);
877
875
  }
878
876
 
879
877
  /**
@@ -883,9 +881,11 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
883
881
  private handleDuplicateAttestation(info: DuplicateAttestationInfo): void {
884
882
  const { slot, attester } = info;
885
883
 
886
- this.log.warn(`Triggering slash event for duplicate attestation from ${attester.toString()} at slot ${slot}`, {
884
+ this.log.info(`Detected duplicate attestation offense from ${attester.toString()} at slot ${slot}`, {
887
885
  attester: attester.toString(),
888
886
  slot,
887
+ amount: this.config.slashDuplicateAttestationPenalty,
888
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_ATTESTATION),
889
889
  });
890
890
 
891
891
  this.emit(WANT_TO_SLASH_EVENT, [
@@ -900,6 +900,7 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
900
900
 
901
901
  async createBlockProposal(
902
902
  blockHeader: BlockHeader,
903
+ checkpointNumber: CheckpointNumber,
903
904
  indexWithinCheckpoint: IndexWithinCheckpoint,
904
905
  inHash: Fr,
905
906
  archive: Fr,
@@ -926,6 +927,7 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
926
927
  );
927
928
  const newProposal = await this.validationService.createBlockProposal(
928
929
  blockHeader,
930
+ checkpointNumber,
929
931
  indexWithinCheckpoint,
930
932
  inHash,
931
933
  archive,
@@ -933,7 +935,8 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
933
935
  proposerAddress,
934
936
  {
935
937
  ...options,
936
- broadcastInvalidBlockProposal: this.config.broadcastInvalidBlockProposal,
938
+ broadcastInvalidBlockProposal:
939
+ options.broadcastInvalidBlockProposal || this.config.broadcastInvalidBlockProposal,
937
940
  },
938
941
  );
939
942
  this.lastProposedBlock = newProposal;
@@ -943,8 +946,9 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
943
946
  async createCheckpointProposal(
944
947
  checkpointHeader: CheckpointHeader,
945
948
  archive: Fr,
949
+ checkpointNumber: CheckpointNumber,
946
950
  feeAssetPriceModifier: bigint,
947
- lastBlockInfo: CreateCheckpointProposalLastBlockData | undefined,
951
+ lastBlockProposal: BlockProposal | undefined,
948
952
  proposerAddress: EthAddress | undefined,
949
953
  options: CheckpointProposalOptions = {},
950
954
  ): Promise<CheckpointProposal> {
@@ -965,12 +969,20 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
965
969
  const newProposal = await this.validationService.createCheckpointProposal(
966
970
  checkpointHeader,
967
971
  archive,
972
+ checkpointNumber,
968
973
  feeAssetPriceModifier,
969
- lastBlockInfo,
974
+ lastBlockProposal,
970
975
  proposerAddress,
971
976
  options,
972
977
  );
973
978
  this.lastProposedCheckpoint = newProposal;
979
+ // Self-record this slot's outcome on the re-execution tracker. Proposers don't run their
980
+ // own proposals through `handleCheckpointProposal`, so without this call the proposer's
981
+ // sentinel would see no outcome for slots it proposed and would mis-attribute itself as
982
+ // inactive. We pass the locally-computed `archive` (not `newProposal.archive`, which may
983
+ // be intentionally corrupted under test-only flags); from the proposer's local-view
984
+ // perspective the work it just completed is valid by definition.
985
+ this.proposalHandler.recordOwnCheckpointProposalAsValid(checkpointHeader.slotNumber, archive, checkpointNumber);
974
986
  return newProposal;
975
987
  }
976
988
 
@@ -982,16 +994,24 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
982
994
  attestationsAndSigners: CommitteeAttestationsAndSigners,
983
995
  proposer: EthAddress,
984
996
  slot: SlotNumber,
985
- blockNumber: BlockNumber | CheckpointNumber,
997
+ checkpointNumber: CheckpointNumber,
986
998
  ): Promise<Signature> {
987
- return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber);
999
+ return await this.validationService.signAttestationsAndSigners(
1000
+ attestationsAndSigners,
1001
+ proposer,
1002
+ slot,
1003
+ checkpointNumber,
1004
+ );
988
1005
  }
989
1006
 
990
- async collectOwnAttestations(proposal: CheckpointProposal): Promise<CheckpointAttestation[]> {
1007
+ async collectOwnAttestations(
1008
+ proposal: CheckpointProposal,
1009
+ checkpointNumber: CheckpointNumber,
1010
+ ): Promise<CheckpointAttestation[]> {
991
1011
  const slot = proposal.slotNumber;
992
1012
  const inCommittee = await this.epochCache.filterInCommittee(slot, this.getValidatorAddresses());
993
1013
  this.log.debug(`Collecting ${inCommittee.length} self-attestations for slot ${slot}`, { inCommittee });
994
- const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee);
1014
+ const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee, checkpointNumber);
995
1015
 
996
1016
  if (!attestations) {
997
1017
  return [];
@@ -1010,6 +1030,7 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
1010
1030
  proposal: CheckpointProposal,
1011
1031
  required: number,
1012
1032
  deadline: Date,
1033
+ checkpointNumber: CheckpointNumber,
1013
1034
  ): Promise<CheckpointAttestation[]> {
1014
1035
  // Wait and poll the p2pClient's attestation pool for this checkpoint until we have enough attestations
1015
1036
  const slot = proposal.slotNumber;
@@ -1022,33 +1043,23 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
1022
1043
  throw new AttestationTimeoutError(0, required, slot);
1023
1044
  }
1024
1045
 
1025
- await this.collectOwnAttestations(proposal);
1046
+ await this.collectOwnAttestations(proposal, checkpointNumber);
1026
1047
 
1027
- const proposalId = proposal.archive.toString();
1048
+ const proposalPayloadHash = proposal.getPayloadHash();
1028
1049
  const myAddresses = this.getValidatorAddresses();
1029
1050
 
1030
1051
  let attestations: CheckpointAttestation[] = [];
1031
1052
  while (true) {
1032
- // Filter out attestations with a mismatching archive. This should NOT happen since we have verified
1033
- // the proposer signature (ie our own) before accepting the attestation into the pool via the p2p client.
1034
- const collectedAttestations = (await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalId)).filter(
1035
- attestation => {
1036
- if (!attestation.archive.equals(proposal.archive)) {
1037
- this.log.warn(
1038
- `Received attestation for slot ${slot} with mismatched archive from ${attestation.getSender()?.toString()}`,
1039
- { attestationArchive: attestation.archive.toString(), proposalArchive: proposal.archive.toString() },
1040
- );
1041
- return false;
1042
- }
1043
- return true;
1044
- },
1045
- );
1053
+ // The pool already filters by proposal payload hash; if any attestation slips through with a
1054
+ // mismatched payload hash, drop it defensively. Equivocations are emitted as separate slash
1055
+ // events from libp2p_service.
1056
+ const collectedAttestations = await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalPayloadHash);
1046
1057
 
1047
1058
  // Log new attestations we collected
1048
1059
  const oldSenders = attestations.map(attestation => attestation.getSender());
1049
1060
  for (const collected of collectedAttestations) {
1050
1061
  const collectedSender = collected.getSender();
1051
- // Skip attestations with invalid signatures
1062
+ // Skip attestations with invalid signatures. Should not happen as we don't add invalid attestations to our pool.
1052
1063
  if (!collectedSender) {
1053
1064
  this.log.warn(`Skipping attestation with invalid signature for slot ${slot}`);
1054
1065
  continue;