@aztec/validator-client 0.0.1-commit.9d2bcf6d → 0.0.1-commit.9d619b6c6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (52) hide show
  1. package/README.md +60 -18
  2. package/dest/checkpoint_builder.d.ts +21 -8
  3. package/dest/checkpoint_builder.d.ts.map +1 -1
  4. package/dest/checkpoint_builder.js +124 -46
  5. package/dest/config.d.ts +1 -1
  6. package/dest/config.d.ts.map +1 -1
  7. package/dest/config.js +26 -6
  8. package/dest/duties/validation_service.d.ts +7 -9
  9. package/dest/duties/validation_service.d.ts.map +1 -1
  10. package/dest/duties/validation_service.js +15 -33
  11. package/dest/factory.d.ts +7 -4
  12. package/dest/factory.d.ts.map +1 -1
  13. package/dest/factory.js +6 -5
  14. package/dest/index.d.ts +2 -3
  15. package/dest/index.d.ts.map +1 -1
  16. package/dest/index.js +1 -2
  17. package/dest/key_store/ha_key_store.js +1 -1
  18. package/dest/metrics.d.ts +14 -2
  19. package/dest/metrics.d.ts.map +1 -1
  20. package/dest/metrics.js +24 -0
  21. package/dest/proposal_handler.d.ts +108 -0
  22. package/dest/proposal_handler.d.ts.map +1 -0
  23. package/dest/proposal_handler.js +974 -0
  24. package/dest/validator.d.ts +45 -23
  25. package/dest/validator.d.ts.map +1 -1
  26. package/dest/validator.js +193 -199
  27. package/package.json +19 -19
  28. package/src/checkpoint_builder.ts +142 -39
  29. package/src/config.ts +26 -6
  30. package/src/duties/validation_service.ts +25 -37
  31. package/src/factory.ts +10 -3
  32. package/src/index.ts +1 -2
  33. package/src/key_store/ha_key_store.ts +1 -1
  34. package/src/metrics.ts +37 -1
  35. package/src/proposal_handler.ts +1042 -0
  36. package/src/validator.ts +269 -227
  37. package/dest/block_proposal_handler.d.ts +0 -63
  38. package/dest/block_proposal_handler.d.ts.map +0 -1
  39. package/dest/block_proposal_handler.js +0 -546
  40. package/dest/tx_validator/index.d.ts +0 -3
  41. package/dest/tx_validator/index.d.ts.map +0 -1
  42. package/dest/tx_validator/index.js +0 -2
  43. package/dest/tx_validator/nullifier_cache.d.ts +0 -14
  44. package/dest/tx_validator/nullifier_cache.d.ts.map +0 -1
  45. package/dest/tx_validator/nullifier_cache.js +0 -24
  46. package/dest/tx_validator/tx_validator_factory.d.ts +0 -19
  47. package/dest/tx_validator/tx_validator_factory.d.ts.map +0 -1
  48. package/dest/tx_validator/tx_validator_factory.js +0 -54
  49. package/src/block_proposal_handler.ts +0 -555
  50. package/src/tx_validator/index.ts +0 -2
  51. package/src/tx_validator/nullifier_cache.ts +0 -30
  52. package/src/tx_validator/tx_validator_factory.ts +0 -154
package/dest/validator.js CHANGED
@@ -1,25 +1,22 @@
1
1
  import { getBlobsPerL1Block } from '@aztec/blob-lib';
2
- import { BlockNumber } from '@aztec/foundation/branded-types';
3
- import { TimeoutError } from '@aztec/foundation/error';
2
+ import { CheckpointNumber } from '@aztec/foundation/branded-types';
4
3
  import { createLogger } from '@aztec/foundation/log';
5
- import { retryUntil } from '@aztec/foundation/retry';
6
4
  import { RunningPromise } from '@aztec/foundation/running-promise';
7
5
  import { sleep } from '@aztec/foundation/sleep';
8
6
  import { DateProvider } from '@aztec/foundation/timer';
9
7
  import { AuthRequest, AuthResponse, BlockProposalValidator, ReqRespSubProtocol } from '@aztec/p2p';
10
8
  import { OffenseType, WANT_TO_SLASH_EVENT } from '@aztec/slasher';
11
9
  import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
12
- import { accumulateCheckpointOutHashes } from '@aztec/stdlib/messaging';
13
10
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
14
11
  import { getTelemetryClient } from '@aztec/telemetry-client';
15
- import { createHASigner } from '@aztec/validator-ha-signer/factory';
12
+ import { createHASigner, createLocalSignerWithProtection, createSignerFromSharedDb } from '@aztec/validator-ha-signer/factory';
16
13
  import { DutyType } from '@aztec/validator-ha-signer/types';
17
14
  import { EventEmitter } from 'events';
18
- import { BlockProposalHandler } from './block_proposal_handler.js';
19
15
  import { ValidationService } from './duties/validation_service.js';
20
16
  import { HAKeyStore } from './key_store/ha_key_store.js';
21
17
  import { NodeKeystoreAdapter } from './key_store/node_keystore_adapter.js';
22
18
  import { ValidatorMetrics } from './metrics.js';
19
+ import { ProposalHandler } from './proposal_handler.js';
23
20
  // We maintain a set of proposers who have proposed invalid blocks.
24
21
  // Just cap the set to avoid unbounded growth.
25
22
  const MAX_PROPOSERS_OF_INVALID_BLOCKS = 1000;
@@ -34,13 +31,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
34
31
  keyStore;
35
32
  epochCache;
36
33
  p2pClient;
37
- blockProposalHandler;
34
+ proposalHandler;
38
35
  blockSource;
39
36
  checkpointsBuilder;
40
37
  worldState;
41
38
  l1ToL2MessageSource;
42
39
  config;
43
40
  blobClient;
41
+ slashingProtectionSigner;
44
42
  dateProvider;
45
43
  tracer;
46
44
  validationService;
@@ -48,13 +46,15 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
48
46
  log;
49
47
  // Whether it has already registered handlers on the p2p client
50
48
  hasRegisteredHandlers;
51
- // Used to check if we are sending the same proposal twice
52
- previousProposal;
49
+ /** Tracks the last block proposal we created, to detect duplicate proposal attempts. */ lastProposedBlock;
50
+ /** Tracks the last checkpoint proposal we created. */ lastProposedCheckpoint;
53
51
  lastEpochForCommitteeUpdateLoop;
54
52
  epochCacheUpdateLoop;
53
+ /** Tracks the last epoch in which each attester successfully submitted at least one attestation. */ lastAttestedEpochByAttester;
55
54
  proposersOfInvalidBlocks;
56
- constructor(keyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
57
- super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.blockProposalHandler = blockProposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.proposersOfInvalidBlocks = new Set();
55
+ /** Tracks the last checkpoint proposal we attested to, to prevent equivocation. */ lastAttestedProposal;
56
+ constructor(keyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
57
+ super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.proposalHandler = proposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.slashingProtectionSigner = slashingProtectionSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.lastAttestedEpochByAttester = new Map(), this.proposersOfInvalidBlocks = new Set();
58
58
  // Create child logger with fisherman prefix if in fisherman mode
59
59
  this.log = config.fishermanMode ? log.createChild('[FISHERMAN]') : log;
60
60
  this.tracer = telemetry.getTracer('Validator');
@@ -93,6 +93,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
93
93
  this.log.trace(`No committee found for slot`);
94
94
  return;
95
95
  }
96
+ this.metrics.setCurrentEpoch(epoch);
96
97
  if (epoch !== this.lastEpochForCommitteeUpdateLoop) {
97
98
  const me = this.getValidatorAddresses();
98
99
  const committeeSet = new Set(committee.map((v)=>v.toString()));
@@ -108,30 +109,49 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
108
109
  this.log.error(`Error updating epoch committee`, err);
109
110
  }
110
111
  }
111
- static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient()) {
112
+ static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), slashingProtectionDb) {
112
113
  const metrics = new ValidatorMetrics(telemetry);
113
114
  const blockProposalValidator = new BlockProposalValidator(epochCache, {
114
- txsPermitted: !config.disableTransactions
115
+ txsPermitted: !config.disableTransactions,
116
+ maxTxsPerBlock: config.validateMaxTxsPerBlock
115
117
  });
116
- const blockProposalHandler = new BlockProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, metrics, dateProvider, telemetry);
117
- let validatorKeyStore = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
118
- if (config.haSigningEnabled) {
118
+ const proposalHandler = new ProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, blobClient, metrics, dateProvider, telemetry, undefined);
119
+ const nodeKeystoreAdapter = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
120
+ let slashingProtectionSigner;
121
+ if (slashingProtectionDb) {
122
+ // Shared database mode: use a pre-existing database (e.g. for testing HA setups).
123
+ ({ signer: slashingProtectionSigner } = createSignerFromSharedDb(slashingProtectionDb, config, {
124
+ telemetryClient: telemetry,
125
+ dateProvider
126
+ }));
127
+ } else if (config.haSigningEnabled) {
128
+ // Multi-node HA mode: use PostgreSQL-backed distributed locking.
119
129
  // If maxStuckDutiesAgeMs is not explicitly set, compute it from Aztec slot duration
120
130
  const haConfig = {
121
131
  ...config,
122
132
  maxStuckDutiesAgeMs: config.maxStuckDutiesAgeMs ?? epochCache.getL1Constants().slotDuration * 2 * 1000
123
133
  };
124
- const { signer } = await createHASigner(haConfig);
125
- validatorKeyStore = new HAKeyStore(validatorKeyStore, signer);
134
+ ({ signer: slashingProtectionSigner } = await createHASigner(haConfig, {
135
+ telemetryClient: telemetry,
136
+ dateProvider
137
+ }));
138
+ } else {
139
+ // Single-node mode: use LMDB-backed local signing protection.
140
+ // This prevents double-signing if the node crashes and restarts mid-proposal.
141
+ ({ signer: slashingProtectionSigner } = await createLocalSignerWithProtection(config, {
142
+ telemetryClient: telemetry,
143
+ dateProvider
144
+ }));
126
145
  }
127
- const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, blockProposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, dateProvider, telemetry);
146
+ const validatorKeyStore = new HAKeyStore(nodeKeystoreAdapter, slashingProtectionSigner);
147
+ const validator = new ValidatorClient(validatorKeyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider, telemetry);
128
148
  return validator;
129
149
  }
130
150
  getValidatorAddresses() {
131
151
  return this.keyStore.getAddresses().filter((addr)=>!this.config.disabledValidators.some((disabled)=>disabled.equals(addr)));
132
152
  }
133
- getBlockProposalHandler() {
134
- return this.blockProposalHandler;
153
+ getProposalHandler() {
154
+ return this.proposalHandler;
135
155
  }
136
156
  signWithAddress(addr, msg, context) {
137
157
  return this.keyStore.signTypedDataWithAddress(addr, msg, context);
@@ -151,6 +171,11 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
151
171
  ...config
152
172
  };
153
173
  }
174
+ reloadKeystore(newManager) {
175
+ const newAdapter = NodeKeystoreAdapter.fromKeyStoreManager(newManager);
176
+ this.keyStore = new HAKeyStore(newAdapter, this.slashingProtectionSigner);
177
+ this.validationService = new ValidationService(this.keyStore, this.log.createChild('validation-service'));
178
+ }
154
179
  async start() {
155
180
  if (this.epochCacheUpdateLoop.isRunning()) {
156
181
  this.log.warn(`Validator client already started`);
@@ -182,7 +207,15 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
182
207
  // The checkpoint is received as CheckpointProposalCore since the lastBlock is extracted
183
208
  // and processed separately via the block handler above.
184
209
  const checkpointHandler = (checkpoint, proposalSender)=>this.attestToCheckpointProposal(checkpoint, proposalSender);
185
- this.p2pClient.registerCheckpointProposalHandler(checkpointHandler);
210
+ this.p2pClient.registerValidatorCheckpointProposalHandler(checkpointHandler);
211
+ // Duplicate proposal handler - triggers slashing for equivocation
212
+ this.p2pClient.registerDuplicateProposalCallback((info)=>{
213
+ this.handleDuplicateProposal(info);
214
+ });
215
+ // Duplicate attestation handler - triggers slashing for attestation equivocation
216
+ this.p2pClient.registerDuplicateAttestationCallback((info)=>{
217
+ this.handleDuplicateAttestation(info);
218
+ });
186
219
  const myAddresses = this.getValidatorAddresses();
187
220
  this.p2pClient.registerThisValidatorAddresses(myAddresses);
188
221
  await this.p2pClient.addReqRespSubProtocol(ReqRespSubProtocol.AUTH, this.handleAuthRequest.bind(this));
@@ -203,6 +236,13 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
203
236
  this.log.warn(`Received block proposal with invalid signature for slot ${slotNumber}`);
204
237
  return false;
205
238
  }
239
+ // Log self-proposals from HA peers (same validator key on different nodes)
240
+ if (this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
241
+ this.log.verbose(`Processing block proposal from HA peer for slot ${slotNumber}`, {
242
+ proposer: proposer.toString(),
243
+ slotNumber
244
+ });
245
+ }
206
246
  // Check if we're in the committee (for metrics purposes)
207
247
  const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
208
248
  const partOfCommittee = inCommittee.length > 0;
@@ -217,12 +257,12 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
217
257
  });
218
258
  // Reexecute txs if we are part of the committee, or if slashing is enabled, or if we are configured to always reexecute.
219
259
  // In fisherman mode, we always reexecute to validate proposals.
220
- const { validatorReexecute, slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } = this.config;
221
- const shouldReexecute = fishermanMode || slashBroadcastedInvalidBlockPenalty > 0n && validatorReexecute || partOfCommittee && validatorReexecute || alwaysReexecuteBlockProposals || this.blobClient.canUpload();
222
- const validationResult = await this.blockProposalHandler.handleBlockProposal(proposal, proposalSender, !!shouldReexecute && !escapeHatchOpen);
260
+ const { slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } = this.config;
261
+ const shouldReexecute = fishermanMode || slashBroadcastedInvalidBlockPenalty > 0n || partOfCommittee || alwaysReexecuteBlockProposals || this.blobClient.canUpload();
262
+ const validationResult = await this.proposalHandler.handleBlockProposal(proposal, proposalSender, !!shouldReexecute && !escapeHatchOpen);
223
263
  if (!validationResult.isValid) {
224
- this.log.warn(`Block proposal validation failed: ${validationResult.reason}`, proposalInfo);
225
264
  const reason = validationResult.reason || 'unknown';
265
+ this.log.warn(`Block proposal validation failed: ${reason}`, proposalInfo);
226
266
  // Classify failure reason: bad proposal vs node issue
227
267
  const badProposalReasons = [
228
268
  'invalid_proposal',
@@ -262,45 +302,46 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
262
302
  * the lastBlock is extracted and processed separately via the block handler.
263
303
  * @returns Checkpoint attestations if valid, undefined otherwise
264
304
  */ async attestToCheckpointProposal(proposal, _proposalSender) {
265
- const slotNumber = proposal.slotNumber;
305
+ const proposalSlotNumber = proposal.slotNumber;
266
306
  const proposer = proposal.getSender();
267
307
  // If escape hatch is open for this slot's epoch, do not attest.
268
- if (await this.epochCache.isEscapeHatchOpenAtSlot(slotNumber)) {
269
- this.log.warn(`Escape hatch open for slot ${slotNumber}, skipping checkpoint attestation handling`);
308
+ if (await this.epochCache.isEscapeHatchOpenAtSlot(proposalSlotNumber)) {
309
+ this.log.warn(`Escape hatch open for slot ${proposalSlotNumber}, skipping checkpoint attestation handling`);
270
310
  return undefined;
271
311
  }
272
- // Reject proposals with invalid signatures
273
- if (!proposer) {
274
- this.log.warn(`Received checkpoint proposal with invalid signature for slot ${slotNumber}`);
312
+ // Ignore proposals from ourselves (may happen in HA setups)
313
+ if (proposer && this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
314
+ this.log.debug(`Ignoring block proposal from self for slot ${proposalSlotNumber}`, {
315
+ proposer: proposer.toString(),
316
+ proposalSlotNumber
317
+ });
275
318
  return undefined;
276
319
  }
277
- // Check that I have any address in current committee before attesting
278
- const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
320
+ // Check that I have any address in the committee where this checkpoint will land before attesting
321
+ const inCommittee = await this.epochCache.filterInCommittee(proposalSlotNumber, this.getValidatorAddresses());
279
322
  const partOfCommittee = inCommittee.length > 0;
280
323
  const proposalInfo = {
281
- slotNumber,
324
+ proposalSlotNumber,
282
325
  archive: proposal.archive.toString(),
283
- proposer: proposer.toString(),
284
- txCount: proposal.txHashes.length
326
+ proposer: proposer?.toString()
285
327
  };
286
- this.log.info(`Received checkpoint proposal for slot ${slotNumber}`, {
328
+ this.log.info(`Received checkpoint proposal for slot ${proposalSlotNumber}`, {
287
329
  ...proposalInfo,
288
- txHashes: proposal.txHashes.map((t)=>t.toString()),
289
330
  fishermanMode: this.config.fishermanMode || false
290
331
  });
291
- // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set)
332
+ // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set).
333
+ // Uses the cached result from the all-nodes callback if available (avoids double validation).
334
+ let checkpointNumber;
292
335
  if (this.config.skipCheckpointProposalValidation) {
293
- this.log.warn(`Skipping checkpoint proposal validation for slot ${slotNumber}`, proposalInfo);
336
+ this.log.warn(`Skipping checkpoint proposal validation for slot ${proposalSlotNumber}`, proposalInfo);
337
+ checkpointNumber = CheckpointNumber(0);
294
338
  } else {
295
- const validationResult = await this.validateCheckpointProposal(proposal, proposalInfo);
339
+ const validationResult = await this.proposalHandler.handleCheckpointProposal(proposal, proposalInfo);
296
340
  if (!validationResult.isValid) {
297
341
  this.log.warn(`Checkpoint proposal validation failed: ${validationResult.reason}`, proposalInfo);
298
342
  return undefined;
299
343
  }
300
- }
301
- // Upload blobs to filestore if we can (fire and forget)
302
- if (this.blobClient.canUpload()) {
303
- void this.uploadBlobsForCheckpoint(proposal, proposalInfo);
344
+ checkpointNumber = validationResult.checkpointNumber;
304
345
  }
305
346
  // Check that I have any address in current committee before attesting
306
347
  // In fisherman mode, we still create attestations for validation even if not in committee
@@ -309,12 +350,22 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
309
350
  return undefined;
310
351
  }
311
352
  // Provided all of the above checks pass, we can attest to the proposal
312
- this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${slotNumber}`, {
353
+ this.log.info(`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${proposalSlotNumber}`, {
313
354
  ...proposalInfo,
314
355
  inCommittee: partOfCommittee,
315
356
  fishermanMode: this.config.fishermanMode || false
316
357
  });
317
358
  this.metrics.incSuccessfulAttestations(inCommittee.length);
359
+ // Track epoch participation per attester: count each (attester, epoch) pair at most once
360
+ const proposalEpoch = getEpochAtSlot(proposalSlotNumber, this.epochCache.getL1Constants());
361
+ for (const attester of inCommittee){
362
+ const key = attester.toString();
363
+ const lastEpoch = this.lastAttestedEpochByAttester.get(key);
364
+ if (lastEpoch === undefined || proposalEpoch > lastEpoch) {
365
+ this.lastAttestedEpochByAttester.set(key, proposalEpoch);
366
+ this.metrics.incAttestedEpochCount(attester);
367
+ }
368
+ }
318
369
  // Determine which validators should attest
319
370
  let attestors;
320
371
  if (partOfCommittee) {
@@ -331,151 +382,39 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
331
382
  }
332
383
  if (this.config.fishermanMode) {
333
384
  // bail out early and don't save attestations to the pool in fisherman mode
334
- this.log.info(`Creating checkpoint attestations for slot ${slotNumber}`, {
385
+ this.log.info(`Creating checkpoint attestations for slot ${proposalSlotNumber}`, {
335
386
  ...proposalInfo,
336
387
  attestors: attestors.map((a)=>a.toString())
337
388
  });
338
389
  return undefined;
339
390
  }
340
- return this.createCheckpointAttestationsFromProposal(proposal, attestors);
341
- }
342
- async createCheckpointAttestationsFromProposal(proposal, attestors = []) {
343
- const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors);
344
- await this.p2pClient.addCheckpointAttestations(attestations);
345
- return attestations;
391
+ return await this.createCheckpointAttestationsFromProposal(proposal, attestors, checkpointNumber);
346
392
  }
347
393
  /**
348
- * Validates a checkpoint proposal by building the full checkpoint and comparing it with the proposal.
349
- * @returns Validation result with isValid flag and reason if invalid.
350
- */ async validateCheckpointProposal(proposal, proposalInfo) {
351
- const slot = proposal.slotNumber;
352
- const timeoutSeconds = 10; // TODO(palla/mbps): This should map to the timetable settings
353
- // Wait for last block to sync by archive
354
- let lastBlockHeader;
355
- try {
356
- lastBlockHeader = await retryUntil(async ()=>{
357
- await this.blockSource.syncImmediate();
358
- return this.blockSource.getBlockHeaderByArchive(proposal.archive);
359
- }, `waiting for block with archive ${proposal.archive.toString()} for slot ${slot}`, timeoutSeconds, 0.5);
360
- } catch (err) {
361
- if (err instanceof TimeoutError) {
362
- this.log.warn(`Timed out waiting for block with archive matching checkpoint proposal`, proposalInfo);
363
- return {
364
- isValid: false,
365
- reason: 'last_block_not_found'
366
- };
367
- }
368
- this.log.error(`Error fetching last block for checkpoint proposal`, err, proposalInfo);
369
- return {
370
- isValid: false,
371
- reason: 'block_fetch_error'
372
- };
394
+ * Checks if we should attest to a slot based on equivocation prevention rules.
395
+ * @returns true if we should attest, false if we should skip
396
+ */ shouldAttestToSlot(slotNumber) {
397
+ // If attestToEquivocatedProposals is true, always allow
398
+ if (this.config.attestToEquivocatedProposals) {
399
+ return true;
373
400
  }
374
- if (!lastBlockHeader) {
375
- this.log.warn(`Last block not found for checkpoint proposal`, proposalInfo);
376
- return {
377
- isValid: false,
378
- reason: 'last_block_not_found'
379
- };
380
- }
381
- // Get all full blocks for the slot and checkpoint
382
- const blocks = await this.blockSource.getBlocksForSlot(slot);
383
- if (blocks.length === 0) {
384
- this.log.warn(`No blocks found for slot ${slot}`, proposalInfo);
385
- return {
386
- isValid: false,
387
- reason: 'no_blocks_for_slot'
388
- };
389
- }
390
- this.log.debug(`Found ${blocks.length} blocks for slot ${slot}`, {
391
- ...proposalInfo,
392
- blockNumbers: blocks.map((b)=>b.number)
393
- });
394
- // Get checkpoint constants from first block
395
- const firstBlock = blocks[0];
396
- const constants = this.extractCheckpointConstants(firstBlock);
397
- const checkpointNumber = firstBlock.checkpointNumber;
398
- // Get L1-to-L2 messages for this checkpoint
399
- const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(checkpointNumber);
400
- // Compute the previous checkpoint out hashes for the epoch.
401
- // TODO: There can be a more efficient way to get the previous checkpoint out hashes without having to fetch the
402
- // actual checkpoints and the blocks/txs in them.
403
- const epoch = getEpochAtSlot(slot, this.epochCache.getL1Constants());
404
- const previousCheckpoints = (await this.blockSource.getCheckpointsForEpoch(epoch)).filter((b)=>b.number < checkpointNumber).sort((a, b)=>a.number - b.number);
405
- const previousCheckpointOutHashes = previousCheckpoints.map((c)=>c.getCheckpointOutHash());
406
- // Fork world state at the block before the first block
407
- const parentBlockNumber = BlockNumber(firstBlock.number - 1);
408
- const fork = await this.worldState.fork(parentBlockNumber);
409
- try {
410
- // Create checkpoint builder with all existing blocks
411
- const checkpointBuilder = await this.checkpointsBuilder.openCheckpoint(checkpointNumber, constants, l1ToL2Messages, previousCheckpointOutHashes, fork, blocks, this.log.getBindings());
412
- // Complete the checkpoint to get computed values
413
- const computedCheckpoint = await checkpointBuilder.completeCheckpoint();
414
- // Compare checkpoint header with proposal
415
- if (!computedCheckpoint.header.equals(proposal.checkpointHeader)) {
416
- this.log.warn(`Checkpoint header mismatch`, {
417
- ...proposalInfo,
418
- computed: computedCheckpoint.header.toInspect(),
419
- proposal: proposal.checkpointHeader.toInspect()
420
- });
421
- return {
422
- isValid: false,
423
- reason: 'checkpoint_header_mismatch'
424
- };
425
- }
426
- // Compare archive root with proposal
427
- if (!computedCheckpoint.archive.root.equals(proposal.archive)) {
428
- this.log.warn(`Archive root mismatch`, {
429
- ...proposalInfo,
430
- computed: computedCheckpoint.archive.root.toString(),
431
- proposal: proposal.archive.toString()
432
- });
433
- return {
434
- isValid: false,
435
- reason: 'archive_mismatch'
436
- };
437
- }
438
- // Check that the accumulated epoch out hash matches the value in the proposal.
439
- // The epoch out hash is the accumulated hash of all checkpoint out hashes in the epoch.
440
- const checkpointOutHash = computedCheckpoint.getCheckpointOutHash();
441
- const computedEpochOutHash = accumulateCheckpointOutHashes([
442
- ...previousCheckpointOutHashes,
443
- checkpointOutHash
444
- ]);
445
- const proposalEpochOutHash = proposal.checkpointHeader.epochOutHash;
446
- if (!computedEpochOutHash.equals(proposalEpochOutHash)) {
447
- this.log.warn(`Epoch out hash mismatch`, {
448
- proposalEpochOutHash: proposalEpochOutHash.toString(),
449
- computedEpochOutHash: computedEpochOutHash.toString(),
450
- checkpointOutHash: checkpointOutHash.toString(),
451
- previousCheckpointOutHashes: previousCheckpointOutHashes.map((h)=>h.toString()),
452
- ...proposalInfo
453
- });
454
- return {
455
- isValid: false,
456
- reason: 'out_hash_mismatch'
457
- };
458
- }
459
- this.log.verbose(`Checkpoint proposal validation successful for slot ${slot}`, proposalInfo);
460
- return {
461
- isValid: true
462
- };
463
- } finally{
464
- await fork.close();
401
+ // Check if incoming slot is strictly greater than last attested
402
+ if (this.lastAttestedProposal && slotNumber <= this.lastAttestedProposal.slotNumber) {
403
+ this.log.warn(`Refusing to process a proposal for slot ${slotNumber} given we already attested to a proposal for slot ${this.lastAttestedProposal.slotNumber}`);
404
+ return false;
465
405
  }
406
+ return true;
466
407
  }
467
- /**
468
- * Extract checkpoint global variables from a block.
469
- */ extractCheckpointConstants(block) {
470
- const gv = block.header.globalVariables;
471
- return {
472
- chainId: gv.chainId,
473
- version: gv.version,
474
- slotNumber: gv.slotNumber,
475
- coinbase: gv.coinbase,
476
- feeRecipient: gv.feeRecipient,
477
- gasFees: gv.gasFees
478
- };
408
+ async createCheckpointAttestationsFromProposal(proposal, attestors = [], checkpointNumber) {
409
+ // Equivocation check: must happen right before signing to minimize the race window
410
+ if (!this.shouldAttestToSlot(proposal.slotNumber)) {
411
+ return undefined;
412
+ }
413
+ const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors, checkpointNumber);
414
+ // Track the proposal we attested to (to prevent equivocation)
415
+ this.lastAttestedProposal = proposal;
416
+ await this.p2pClient.addOwnCheckpointAttestations(attestations);
417
+ return attestations;
479
418
  }
480
419
  /**
481
420
  * Uploads blobs for a checkpoint to the filestore (fire and forget).
@@ -492,7 +431,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
492
431
  return;
493
432
  }
494
433
  const blobFields = blocks.flatMap((b)=>b.toBlobFields());
495
- const blobs = getBlobsPerL1Block(blobFields);
434
+ const blobs = await getBlobsPerL1Block(blobFields);
496
435
  await this.blobClient.sendBlobsToFilestore(blobs);
497
436
  this.log.debug(`Uploaded ${blobs.length} blobs to filestore for checkpoint at slot ${proposal.slotNumber}`, {
498
437
  ...proposalInfo,
@@ -524,37 +463,92 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
524
463
  }
525
464
  ]);
526
465
  }
527
- async createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
528
- // TODO(palla/mbps): Prevent double proposals properly
529
- // if (this.previousProposal?.slotNumber === blockHeader.globalVariables.slotNumber) {
530
- // this.log.verbose(`Already made a proposal for the same slot, skipping proposal`);
531
- // return Promise.resolve(undefined);
532
- // }
466
+ /**
467
+ * Handle detection of a duplicate proposal (equivocation).
468
+ * Emits a slash event when a proposer sends multiple proposals for the same position.
469
+ */ handleDuplicateProposal(info) {
470
+ const { slot, proposer, type } = info;
471
+ this.log.warn(`Triggering slash event for duplicate ${type} proposal from ${proposer.toString()} at slot ${slot}`, {
472
+ proposer: proposer.toString(),
473
+ slot,
474
+ type
475
+ });
476
+ // Emit slash event
477
+ this.emit(WANT_TO_SLASH_EVENT, [
478
+ {
479
+ validator: proposer,
480
+ amount: this.config.slashDuplicateProposalPenalty,
481
+ offenseType: OffenseType.DUPLICATE_PROPOSAL,
482
+ epochOrSlot: BigInt(slot)
483
+ }
484
+ ]);
485
+ }
486
+ /**
487
+ * Handle detection of a duplicate attestation (equivocation).
488
+ * Emits a slash event when an attester signs attestations for different proposals at the same slot.
489
+ */ handleDuplicateAttestation(info) {
490
+ const { slot, attester } = info;
491
+ this.log.warn(`Triggering slash event for duplicate attestation from ${attester.toString()} at slot ${slot}`, {
492
+ attester: attester.toString(),
493
+ slot
494
+ });
495
+ this.emit(WANT_TO_SLASH_EVENT, [
496
+ {
497
+ validator: attester,
498
+ amount: this.config.slashDuplicateAttestationPenalty,
499
+ offenseType: OffenseType.DUPLICATE_ATTESTATION,
500
+ epochOrSlot: BigInt(slot)
501
+ }
502
+ ]);
503
+ }
504
+ async createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
505
+ // Validate that we're not creating a proposal for an older or equal position
506
+ if (this.lastProposedBlock) {
507
+ const lastSlot = this.lastProposedBlock.slotNumber;
508
+ const lastIndex = this.lastProposedBlock.indexWithinCheckpoint;
509
+ const newSlot = blockHeader.globalVariables.slotNumber;
510
+ if (newSlot < lastSlot || newSlot === lastSlot && indexWithinCheckpoint <= lastIndex) {
511
+ throw new Error(`Cannot create block proposal for slot ${newSlot} index ${indexWithinCheckpoint}: ` + `already proposed block for slot ${lastSlot} index ${lastIndex}`);
512
+ }
513
+ }
533
514
  this.log.info(`Assembling block proposal for block ${blockHeader.globalVariables.blockNumber} slot ${blockHeader.globalVariables.slotNumber}`);
534
- const newProposal = await this.validationService.createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
515
+ const newProposal = await this.validationService.createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
535
516
  ...options,
536
517
  broadcastInvalidBlockProposal: this.config.broadcastInvalidBlockProposal
537
518
  });
538
- this.previousProposal = newProposal;
519
+ this.lastProposedBlock = newProposal;
539
520
  return newProposal;
540
521
  }
541
- async createCheckpointProposal(checkpointHeader, archive, lastBlockInfo, proposerAddress, options = {}) {
522
+ async createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options = {}) {
523
+ // Validate that we're not creating a proposal for an older or equal slot
524
+ if (this.lastProposedCheckpoint) {
525
+ const lastSlot = this.lastProposedCheckpoint.slotNumber;
526
+ const newSlot = checkpointHeader.slotNumber;
527
+ if (newSlot <= lastSlot) {
528
+ throw new Error(`Cannot create checkpoint proposal for slot ${newSlot}: ` + `already proposed checkpoint for slot ${lastSlot}`);
529
+ }
530
+ }
542
531
  this.log.info(`Assembling checkpoint proposal for slot ${checkpointHeader.slotNumber}`);
543
- return await this.validationService.createCheckpointProposal(checkpointHeader, archive, lastBlockInfo, proposerAddress, options);
532
+ const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options);
533
+ this.lastProposedCheckpoint = newProposal;
534
+ return newProposal;
544
535
  }
545
536
  async broadcastBlockProposal(proposal) {
546
537
  await this.p2pClient.broadcastProposal(proposal);
547
538
  }
548
- async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber) {
549
- return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber);
539
+ async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber) {
540
+ return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber);
550
541
  }
551
- async collectOwnAttestations(proposal) {
542
+ async collectOwnAttestations(proposal, checkpointNumber) {
552
543
  const slot = proposal.slotNumber;
553
544
  const inCommittee = await this.epochCache.filterInCommittee(slot, this.getValidatorAddresses());
554
545
  this.log.debug(`Collecting ${inCommittee.length} self-attestations for slot ${slot}`, {
555
546
  inCommittee
556
547
  });
557
- const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee);
548
+ const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee, checkpointNumber);
549
+ if (!attestations) {
550
+ return [];
551
+ }
558
552
  // We broadcast our own attestations to our peers so, in case our block does not get mined on L1,
559
553
  // other nodes can see that our validators did attest to this block proposal, and do not slash us
560
554
  // due to inactivity for missed attestations.
@@ -563,7 +557,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
563
557
  });
564
558
  return attestations;
565
559
  }
566
- async collectAttestations(proposal, required, deadline) {
560
+ async collectAttestations(proposal, required, deadline, checkpointNumber) {
567
561
  // Wait and poll the p2pClient's attestation pool for this checkpoint until we have enough attestations
568
562
  const slot = proposal.slotNumber;
569
563
  this.log.debug(`Collecting ${required} attestations for slot ${slot} with deadline ${deadline.toISOString()}`);
@@ -571,7 +565,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
571
565
  this.log.error(`Deadline ${deadline.toISOString()} for collecting ${required} attestations for slot ${slot} is in the past`);
572
566
  throw new AttestationTimeoutError(0, required, slot);
573
567
  }
574
- await this.collectOwnAttestations(proposal);
568
+ await this.collectOwnAttestations(proposal, checkpointNumber);
575
569
  const proposalId = proposal.archive.toString();
576
570
  const myAddresses = this.getValidatorAddresses();
577
571
  let attestations = [];